July 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Furquan Shaikh (Code Review) July 28, 2017

July 28, 2017

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST WLAN_PE_RST control was moved from EC to SoC, it connected to GPP_B8. Configure GPP_B8 to drive low. TEST=Wifi card is detected and connect to an AP. Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Reviewed-on: https://review.coreboot.org/20804 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/soraka/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index c576155..f0fb34a 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -78,8 +78,8 @@ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* B7 : SRCCLKREQ2# ==> NC */ PAD_CFG_NC(GPP_B7), - /* B8 : SRCCLKREQ3# ==> NC */ - PAD_CFG_NC(GPP_B8), + /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ + PAD_CFG_GPO(GPP_B8, 0, DEEP), /* B9 : SRCCLKREQ4# ==> NC */ PAD_CFG_NC(GPP_B9), /* B10 : SRCCLKREQ5# ==> NC */ -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Furquan Shaikh (Code Review) July 28, 2017

July 28, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 2: Submitting this early since it is blocking build. -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 06:44:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Furquan Shaikh (Code Review) July 28, 2017

July 28, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/gpio.c: https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants… PS2, Line 82: 0 > It looks like this should be 1. WLAN_PE_RST_L is active low and so this sho My bad! Looked at the schematics again and this is correct. -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 06:28:08 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/google/poppy: Decrease link-frequencies for OV13858 and OV5670
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20787 ) Change subject: mainboard/google/poppy: Decrease link-frequencies for OV13858 and OV5670 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57958/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13401/ : SUCCESS -- To view, visit https://review.coreboot.org/20787 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78fb2d3527f66b5147123a9c8fc4cb95650f86b6 Gerrit-Change-Number: 20787 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 06:11:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Furquan Shaikh (Code Review) July 28, 2017

July 28, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 2: -Code-Review (1 comment) Pushing this early since it is blocking build. https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/gpio.c: https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants… PS2, Line 82: 0 It looks like this should be 1. WLAN_PE_RST_L is active low and so this should be set to 1 to take the device out of reset. -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 06:03:12 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/lenovo: add Lenovo ThinkPad X131e (Intel)
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20694 ) Change subject: mb/lenovo: add Lenovo ThinkPad X131e (Intel) ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57957/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13400/ : SUCCESS -- To view, visit https://review.coreboot.org/20694 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8de3a9308997e2d57aee869023ee9a43a2db872 Gerrit-Change-Number: 20694 Gerrit-PatchSet: 5 Gerrit-Owner: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 05:38:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57956/ : SUCCESS -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 05:01:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Furquan Shaikh (Code Review) July 28, 2017

July 28, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 04:57:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20804 ) Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57955/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13399/ : SUCCESS -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 04:56:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Rizwan Qureshi (Code Review) July 28, 2017

July 28, 2017

Hello Naresh Solanki, Nicolas Boichat, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20804 to look at the new patch set (#2). Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST WLAN_PE_RST control was moved from EC to SoC, it connected to GPP_B8. Configure GPP_B8 to drive low. TEST=Wifi card is detected and connect to an AP. Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/20804/2 -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com>

1 0