coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: rockchip/rk3399: fix rk_mipi_dsi_phy_init err
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19903 ) Change subject: rockchip/rk3399: fix rk_mipi_dsi_phy_init err ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10085/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54358/ : SUCCESS -- To view, visit https://review.coreboot.org/19903 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie260975ad6ed26c37aa8bb65dfcef4db2407a2da Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: nickey.yang(a)rock-chips.com Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip/rk3399: Add MIPI driver
by Anonymous Coward (Code Review) 25 May '17

25 May '17

nickey.yang(a)rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 ) Change subject: rockchip/rk3399: Add MIPI driver ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/#/c/19477/11/src/soc/rockchip/rk3399/mipi.c File src/soc/rockchip/rk3399/mipi.c: PS11, Line 98: ret > Coverity identified that this value is returned uninitialized. Would you mi Hi sorry for late reply. see https://review.coreboot.org/#/c/19903/ -- To view, visit https://review.coreboot.org/19477 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: nickey.yang(a)rock-chips.com Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org> Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nickey.yang(a)rock-chips.com Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: rockchip/rk3399: fix rk_mipi_dsi_phy_init err
by Anonymous Coward (Code Review) 25 May '17

25 May '17

nickey.yang(a)rock-chips.com has uploaded a new change for review. ( https://review.coreboot.org/19903 ) Change subject: rockchip/rk3399: fix rk_mipi_dsi_phy_init err ...................................................................... rockchip/rk3399: fix rk_mipi_dsi_phy_init err This patch fix rk_mipi_dsi_phy_init error return. Change-Id: Ie260975ad6ed26c37aa8bb65dfcef4db2407a2da Signed-off-by: Nickey Yang <nickey.yang(a)rock-chips.com> --- M src/soc/rockchip/rk3399/mipi.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19903/1 diff --git a/src/soc/rockchip/rk3399/mipi.c b/src/soc/rockchip/rk3399/mipi.c index 5c8f4c2..9491b91 100644 --- a/src/soc/rockchip/rk3399/mipi.c +++ b/src/soc/rockchip/rk3399/mipi.c @@ -95,7 +95,7 @@ static int rk_mipi_dsi_phy_init(struct rk_mipi_dsi *dsi) { - int ret, testdin, vco; + int testdin, vco; int lane_mbps = div_round_up(dsi->lane_bps, USECS_PER_SEC); vco = (lane_mbps < 200) ? 0 : (lane_mbps + 100) / 200; @@ -156,7 +156,7 @@ write32(&mipi_regs->dsi_phy_rstz, PHY_ENFORCEPLL | PHY_ENABLECLK | PHY_UNRSTZ | PHY_UNSHUTDOWNZ); - return ret; + return 0; } static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) @@ -421,7 +421,8 @@ rk_mipi_dsi_dphy_timing_config(&rk_mipi); rk_mipi_dsi_dphy_interface_config(&rk_mipi); rk_mipi_dsi_clear_err(&rk_mipi); - rk_mipi_dsi_phy_init(&rk_mipi); + if (rk_mipi_dsi_phy_init(&rk_mipi) < 0) + return; rk_mipi_dsi_wait_for_two_frames(&rk_mipi, edid); rk_mipi_dsi_set_mode(&rk_mipi, MIPI_DSI_CMD_MODE); -- To view, visit https://review.coreboot.org/19903 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie260975ad6ed26c37aa8bb65dfcef4db2407a2da Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: nickey.yang(a)rock-chips.com

1 0

Change in coreboot[master]: cbfscomptool: fix display of time_t
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19902 ) Change subject: cbfscomptool: fix display of time_t ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54357/ : SUCCESS -- To view, visit https://review.coreboot.org/19902 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mike Frysinger <vapier(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cbfscomptool: fix display of time_t
by Patrick Georgi (Code Review) 25 May '17

25 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19902 ) Change subject: cbfscomptool: fix display of time_t ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19902 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mike Frysinger <vapier(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cbfscomptool: fix display of time_t
by Mike Frysinger (Code Review) 25 May '17

25 May '17

Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19902 to look at the new patch set (#2). Change subject: cbfscomptool: fix display of time_t ...................................................................... cbfscomptool: fix display of time_t Not all systems have sizeof(time_t) == sizeof(long), so cast the delta here to a long to match the %ld format. Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Signed-off-by: Mike Frysinger <vapier(a)chromium.org> --- M util/cbfstool/cbfscomptool.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/19902/2 -- To view, visit https://review.coreboot.org/19902 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mike Frysinger <vapier(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cbfscomptool: fix display of time_t
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19902 ) Change subject: cbfscomptool: fix display of time_t ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/54356/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/10084/ : SUCCESS -- To view, visit https://review.coreboot.org/19902 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mike Frysinger <vapier(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: cbfscomptool: fix display of time_t
by Mike Frysinger (Code Review) 25 May '17

25 May '17

Hello Patrick Georgi, I'd like you to do a code review. Please visit https://review.coreboot.org/19902 to review the following change. Change subject: cbfscomptool: fix display of time_t ...................................................................... cbfscomptool: fix display of time_t Not all systems have sizeof(time_t) == sizeof(long), so cast the delta here to a long to match the %ld format. Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e --- M util/cbfstool/cbfscomptool.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/19902/1 diff --git a/util/cbfstool/cbfscomptool.c b/util/cbfstool/cbfscomptool.c index 3430809..1021bc8 100644 --- a/util/cbfstool/cbfscomptool.c +++ b/util/cbfstool/cbfscomptool.c @@ -81,7 +81,7 @@ clock_gettime(CLOCK_MONOTONIC, &t_e); printf("compressing %d bytes to %d took %ld seconds\n", bufsize, outsize, - t_e.tv_sec - t_s.tv_sec); + (long)(t_e.tv_sec - t_s.tv_sec)); } free(data); free(compressed_data); -- To view, visit https://review.coreboot.org/19902 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If235577fc35454ddb15043c5a543f614b6f16a9e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mike Frysinger <vapier(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: google/gru: enable the pull high for touchpad
by Caesar Wang (Code Review) 25 May '17

25 May '17

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 ) Change subject: google/gru: enable the pull high for touchpad ...................................................................... Patch Set 2: (1 comment) > (1 comment) > > ``` > WARNING: please, no spaces at the start of a line > #11: FILE: src/mainboard/google/gru/romstage.c:72: > + gpio_output(GPIO(3, B, 4), 1); /* Pull high for TP */$ > > total: 0 errors, 1 warnings, 19 lines checked > + true > ``` Sorry, done. https://review.coreboot.org/#/c/19863/1//COMMIT_MSG Commit Message: PS1, Line 19: firmware > Please mention the firmware versions. Done. I'm no sure what's finial version in the end. (just supply the firmware for tests) I *think* this patch is independent, that's no depend on the Elan firmware. -- To view, visit https://review.coreboot.org/19863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/gru: enable the pull high for touchpad
by build bot (Jenkins) (Code Review) 25 May '17

25 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19863 ) Change subject: google/gru: enable the pull high for touchpad ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10083/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54355/ : SUCCESS -- To view, visit https://review.coreboot.org/19863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017