coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: sb/intel/common/firmware: Keep CHECK_ME disabled by default
by Nicola Corna (Code Review) 05 May '17

05 May '17

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/19257 ) Change subject: sb/intel/common/firmware: Keep CHECK_ME disabled by default ...................................................................... Patch Set 2: Can you pull the latest changes from me_cleaner (https://github.com/corna/me_cleaner) and see if they fix your error? -- To view, visit https://review.coreboot.org/19257 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3186498c8da307b686c06c3828e24acbc7f2d17 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set FADT legacy and 8042 supported
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19165 ) Change subject: google/kahlee: Set FADT legacy and 8042 supported ...................................................................... Patch Set 17: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53290/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9108/ : SUCCESS -- To view, visit https://review.coreboot.org/19165 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae048a5aeaa5f497687a8a0b152a29c5cd552e28 Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Update for single DIMM
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19162 ) Change subject: google/kahlee: Update for single DIMM ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53288/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9106/ : SUCCESS -- To view, visit https://review.coreboot.org/19162 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0cc25e4b9ff39105cc70e5c548261958d53eb8 Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS and ChromeEC
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19164 ) Change subject: google/kahlee: Add ChromeOS and ChromeEC ...................................................................... Patch Set 17: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53289/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9107/ : SUCCESS -- To view, visit https://review.coreboot.org/19164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Start Kahlee mainboard
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19161 ) Change subject: google/kahlee: Start Kahlee mainboard ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53286/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9104/ : SUCCESS -- To view, visit https://review.coreboot.org/19161 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcfe100a5e303ccf89f973d9740075bd40ff3f18 Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: rk3399: enable DPLL SSC for DDR EMI test on bob
by Julius Werner (Code Review) 05 May '17

05 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19557 ) Change subject: rockchip: rk3399: enable DPLL SSC for DDR EMI test on bob ...................................................................... Patch Set 3: (6 comments) https://review.coreboot.org/#/c/19557/3/src/soc/rockchip/rk3399/Kconfig File src/soc/rockchip/rk3399/Kconfig: Line 28: bool I think it might make sense to make this user configurable, so let's add an option text here (e.g. bool "Spread-spectrum DDR clock"). Also, please add a 'help' section with a more detailed description of what this does and why it might be useful. Line 29: default y if BOARD_GOOGLE_BOB No board references in this file, please. Instead just have 'default n' here and put 'select RK3399_SPREAD_SPECTRUM_DDR if BOARD_GOOGLE_BOB' into gru/Kconfig:BOARD_SPECIFIC_OPTIONS. Also, since Paul already found this CL you should probably make a separate patch for the gru/Kconfig part, or he's going to ask you to do it later anyway. ;) https://review.coreboot.org/#/c/19557/3/src/soc/rockchip/rk3399/clock.c File src/soc/rockchip/rk3399/clock.c: Line 344: #if (IS_ENABLED(CONFIG_RK3399_SPREAD_SPECTRUM_DDR)) This function doesn't need to be guarded. The compiler will eliminate it automatically if it can. Line 375: * SSMOD SPREADAMP value 8 appears to mitigate EMI on boards tested. nit: Can you say how many Hz of spread "8" will do exactly? (Or if it's dependent on frequency express it in percentage or some-such.) Line 632: /* configure DPLL SSC */ nit: slightly pointless comment, the function name already tells you this much Line 633: rkclk_set_dpllssc(&dpll_cfg); Please use a C if, not the preprocessor. -- To view, visit https://review.coreboot.org/19557 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75461d4235bcf55324e6664a1220754e770b4786 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/kahlee: Update GPIO table
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19163 ) Change subject: google/kahlee: Update GPIO table ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53287/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9105/ : SUCCESS -- To view, visit https://review.coreboot.org/19163 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I654a8ea844dbfe71ac0d143bf29b62bba21047a5 Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi: Re-factor spi_crop_chunk
by coreboot org (Code Review) 05 May '17

05 May '17

coreboot org has posted comments on this change. ( https://review.coreboot.org/19386 ) Change subject: drivers/spi: Re-factor spi_crop_chunk ...................................................................... Patch Set 7: Verified+1 Gigabyte GA-G41M-ES2L: Target OFFLINE. Test ABORTED. Asus P5GC-MX: Boot and extended test successful. -- To view, visit https://review.coreboot.org/19386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c199413f879c664682088e93bfa3f91c6a46e5 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/cpu/pi: Add basic configuration for Vboot
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19158 ) Change subject: amd/cpu/pi: Add basic configuration for Vboot ...................................................................... Patch Set 15: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53285/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9103/ : SUCCESS -- To view, visit https://review.coreboot.org/19158 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9690e03e546ab821eb822da6a7c8672ed659a66 Gerrit-PatchSet: 15 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi: Add verstage support
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18439 ) Change subject: amd/pi: Add verstage support ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53284/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9102/ : SUCCESS -- To view, visit https://review.coreboot.org/18439 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie43d87908c2d83b42b95b306419156e85993f7bd Gerrit-PatchSet: 21 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017