build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19523 )
Change subject: mb/lenovo/s230u: fix sata port map for the msata port
......................................................................
Patch Set 6:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/53314/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/9126/ : SUCCESS
--
To view, visit https://review.coreboot.org/19523
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19576 )
Change subject: soc/intel/apollolake: Add marco to define IOSTERM for GPIO config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19576/1/src/soc/intel/apollolake/include/so…
File src/soc/intel/apollolake/include/soc/gpio.h:
Line 76: PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)
> Can you please just call this one from PAD_CFG_NF_IOSSTATE and PAD_CFG_NF_I
Is new patch set will be expected to call the macro?
--
To view, visit https://review.coreboot.org/19576
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178f6d3055d4620cb3c895245c40f324383873ad
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com>
Gerrit-Reviewer: Freddy Paul <freddy.paul(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes