coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 13: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53329/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/9141/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by Arthur Heymans (Code Review) 05 May '17

05 May '17

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19258 to look at the new patch set (#13). Change subject: sb/intel/*: Use common SMBus functions ...................................................................... sb/intel/*: Use common SMBus functions All Intel southbridges implement the same SMBus functions. This patch replaces all these similar and mostly identical implementations with a common file. This also makes i2c block read available to all those southbridges. If the northbridge has to read a lot of SPD bytes sequentially, using this function can reduce the time being spent to read SPD five-fold. Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/sandybridge/raminit.c M src/southbridge/intel/bd82x6x/Kconfig M src/southbridge/intel/bd82x6x/early_smbus.c M src/southbridge/intel/bd82x6x/pch.h M src/southbridge/intel/bd82x6x/smbus.c D src/southbridge/intel/bd82x6x/smbus.h M src/southbridge/intel/common/Kconfig M src/southbridge/intel/common/Makefile.inc R src/southbridge/intel/common/smbus.c A src/southbridge/intel/common/smbus.h M src/southbridge/intel/fsp_bd82x6x/Kconfig M src/southbridge/intel/fsp_bd82x6x/pch.h M src/southbridge/intel/fsp_i89xx/Kconfig M src/southbridge/intel/fsp_i89xx/early_smbus.c M src/southbridge/intel/fsp_i89xx/pch.h D src/southbridge/intel/fsp_i89xx/smbus.h M src/southbridge/intel/fsp_rangeley/Kconfig M src/southbridge/intel/fsp_rangeley/early_smbus.c M src/southbridge/intel/fsp_rangeley/smbus.c D src/southbridge/intel/fsp_rangeley/smbus.h M src/southbridge/intel/fsp_rangeley/soc.h M src/southbridge/intel/i3100/Kconfig M src/southbridge/intel/i3100/early_smbus.c M src/southbridge/intel/i3100/smbus.c D src/southbridge/intel/i3100/smbus.h M src/southbridge/intel/i82371eb/Kconfig M src/southbridge/intel/i82371eb/early_smbus.c M src/southbridge/intel/i82371eb/smbus.c D src/southbridge/intel/i82371eb/smbus.h M src/southbridge/intel/i82801ax/Kconfig M src/southbridge/intel/i82801ax/early_smbus.c M src/southbridge/intel/i82801ax/i82801ax.h M src/southbridge/intel/i82801ax/smbus.c D src/southbridge/intel/i82801ax/smbus.h M src/southbridge/intel/i82801bx/Kconfig M src/southbridge/intel/i82801bx/early_smbus.c M src/southbridge/intel/i82801bx/i82801bx.h M src/southbridge/intel/i82801bx/smbus.c D src/southbridge/intel/i82801bx/smbus.h M src/southbridge/intel/i82801dx/Kconfig M src/southbridge/intel/i82801dx/early_smbus.c M src/southbridge/intel/i82801dx/i82801dx.h D src/southbridge/intel/i82801dx/smbus.c M src/southbridge/intel/i82801ex/Kconfig M src/southbridge/intel/i82801ex/early_smbus.c M src/southbridge/intel/i82801ex/smbus.c D src/southbridge/intel/i82801ex/smbus.h M src/southbridge/intel/i82801gx/Kconfig M src/southbridge/intel/i82801gx/early_smbus.c M src/southbridge/intel/i82801gx/i82801gx.h M src/southbridge/intel/i82801gx/smbus.c D src/southbridge/intel/i82801gx/smbus.h M src/southbridge/intel/i82801ix/Kconfig M src/southbridge/intel/i82801ix/early_smbus.c M src/southbridge/intel/i82801ix/i82801ix.h M src/southbridge/intel/i82801ix/smbus.c D src/southbridge/intel/i82801ix/smbus.h M src/southbridge/intel/ibexpeak/Kconfig M src/southbridge/intel/ibexpeak/early_smbus.c M src/southbridge/intel/ibexpeak/pch.h M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/early_smbus.c M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/smbus.c D src/southbridge/intel/lynxpoint/smbus.h 66 files changed, 237 insertions(+), 1,934 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19258/13 -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 12: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53328/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/9140/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by Arthur Heymans (Code Review) 05 May '17

05 May '17

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19258 to look at the new patch set (#12). Change subject: sb/intel/*: Use common SMBus functions ...................................................................... sb/intel/*: Use common SMBus functions All Intel southbridges implement the same SMBus functions. This patch replaces all these similar and mostly identical implementations with a common file. This also makes i2c block read available to all those southbridges. If the northbridge has to read a lot of SPD bytes sequentially, using this function can reduce the time being spent to read SPD five-fold. Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/sandybridge/raminit.c M src/southbridge/intel/bd82x6x/Kconfig M src/southbridge/intel/bd82x6x/early_smbus.c M src/southbridge/intel/bd82x6x/smbus.c D src/southbridge/intel/bd82x6x/smbus.h M src/southbridge/intel/common/Kconfig M src/southbridge/intel/common/Makefile.inc R src/southbridge/intel/common/smbus.c A src/southbridge/intel/common/smbus.h M src/southbridge/intel/fsp_bd82x6x/Kconfig M src/southbridge/intel/fsp_i89xx/Kconfig M src/southbridge/intel/fsp_i89xx/early_smbus.c D src/southbridge/intel/fsp_i89xx/smbus.h M src/southbridge/intel/fsp_rangeley/Kconfig M src/southbridge/intel/fsp_rangeley/early_smbus.c M src/southbridge/intel/fsp_rangeley/smbus.c D src/southbridge/intel/fsp_rangeley/smbus.h M src/southbridge/intel/i3100/Kconfig M src/southbridge/intel/i3100/early_smbus.c M src/southbridge/intel/i3100/smbus.c D src/southbridge/intel/i3100/smbus.h M src/southbridge/intel/i82371eb/Kconfig M src/southbridge/intel/i82371eb/early_smbus.c M src/southbridge/intel/i82371eb/smbus.c D src/southbridge/intel/i82371eb/smbus.h M src/southbridge/intel/i82801ax/Kconfig M src/southbridge/intel/i82801ax/early_smbus.c M src/southbridge/intel/i82801ax/smbus.c D src/southbridge/intel/i82801ax/smbus.h M src/southbridge/intel/i82801bx/Kconfig M src/southbridge/intel/i82801bx/early_smbus.c M src/southbridge/intel/i82801bx/smbus.c D src/southbridge/intel/i82801bx/smbus.h M src/southbridge/intel/i82801dx/Kconfig M src/southbridge/intel/i82801dx/early_smbus.c M src/southbridge/intel/i82801dx/i82801dx.h D src/southbridge/intel/i82801dx/smbus.c M src/southbridge/intel/i82801ex/Kconfig M src/southbridge/intel/i82801ex/early_smbus.c M src/southbridge/intel/i82801ex/smbus.c D src/southbridge/intel/i82801ex/smbus.h M src/southbridge/intel/i82801gx/Kconfig M src/southbridge/intel/i82801gx/early_smbus.c M src/southbridge/intel/i82801gx/smbus.c D src/southbridge/intel/i82801gx/smbus.h M src/southbridge/intel/i82801ix/Kconfig M src/southbridge/intel/i82801ix/early_smbus.c M src/southbridge/intel/i82801ix/smbus.c D src/southbridge/intel/i82801ix/smbus.h M src/southbridge/intel/ibexpeak/Kconfig M src/southbridge/intel/ibexpeak/early_smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/early_smbus.c M src/southbridge/intel/lynxpoint/smbus.c D src/southbridge/intel/lynxpoint/smbus.h 56 files changed, 237 insertions(+), 1,760 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19258/12 -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53327/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/9139/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by Arthur Heymans (Code Review) 05 May '17

05 May '17

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19258 to look at the new patch set (#11). Change subject: sb/intel/*: Use common SMBus functions ...................................................................... sb/intel/*: Use common SMBus functions All Intel southbridges implement the same SMBus functions. This patch replaces all these similar and mostly identical implementations with a common file. This also makes i2c block read available to all those southbridges. If the northbridge has to read a lot of SPD bytes sequentially, using this function can reduce the time being spent to read SPD five-fold. Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/sandybridge/raminit.c M src/southbridge/intel/bd82x6x/Kconfig M src/southbridge/intel/bd82x6x/early_smbus.c M src/southbridge/intel/bd82x6x/smbus.c D src/southbridge/intel/bd82x6x/smbus.h M src/southbridge/intel/common/Kconfig M src/southbridge/intel/common/Makefile.inc R src/southbridge/intel/common/smbus.c A src/southbridge/intel/common/smbus.h M src/southbridge/intel/fsp_bd82x6x/Kconfig M src/southbridge/intel/fsp_i89xx/Kconfig M src/southbridge/intel/fsp_i89xx/early_smbus.c D src/southbridge/intel/fsp_i89xx/smbus.h M src/southbridge/intel/fsp_rangeley/Kconfig M src/southbridge/intel/fsp_rangeley/early_smbus.c M src/southbridge/intel/fsp_rangeley/smbus.c D src/southbridge/intel/fsp_rangeley/smbus.h M src/southbridge/intel/i3100/Kconfig M src/southbridge/intel/i3100/early_smbus.c M src/southbridge/intel/i3100/smbus.c D src/southbridge/intel/i3100/smbus.h M src/southbridge/intel/i82371eb/Kconfig M src/southbridge/intel/i82371eb/early_smbus.c M src/southbridge/intel/i82371eb/smbus.c D src/southbridge/intel/i82371eb/smbus.h M src/southbridge/intel/i82801ax/Kconfig M src/southbridge/intel/i82801ax/early_smbus.c M src/southbridge/intel/i82801ax/smbus.c D src/southbridge/intel/i82801ax/smbus.h M src/southbridge/intel/i82801bx/Kconfig M src/southbridge/intel/i82801bx/early_smbus.c M src/southbridge/intel/i82801bx/smbus.c D src/southbridge/intel/i82801bx/smbus.h M src/southbridge/intel/i82801dx/Kconfig M src/southbridge/intel/i82801dx/early_smbus.c M src/southbridge/intel/i82801dx/i82801dx.h D src/southbridge/intel/i82801dx/smbus.c M src/southbridge/intel/i82801ex/Kconfig M src/southbridge/intel/i82801ex/early_smbus.c M src/southbridge/intel/i82801ex/smbus.c D src/southbridge/intel/i82801ex/smbus.h M src/southbridge/intel/i82801gx/Kconfig M src/southbridge/intel/i82801gx/early_smbus.c M src/southbridge/intel/i82801gx/smbus.c D src/southbridge/intel/i82801gx/smbus.h M src/southbridge/intel/i82801ix/Kconfig M src/southbridge/intel/i82801ix/early_smbus.c M src/southbridge/intel/i82801ix/smbus.c D src/southbridge/intel/i82801ix/smbus.h M src/southbridge/intel/ibexpeak/Kconfig M src/southbridge/intel/ibexpeak/early_smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/early_smbus.c M src/southbridge/intel/lynxpoint/smbus.c D src/southbridge/intel/lynxpoint/smbus.h 56 files changed, 237 insertions(+), 1,760 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19258/11 -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: Use common/blocks/uart code
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19492 ) Change subject: soc/intel/skylake: Use common/blocks/uart code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53326/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9138/ : SUCCESS -- To view, visit https://review.coreboot.org/19492 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53ed687dc49524e001889f091825b2cc530546a3 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common/block/uart code
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19491 ) Change subject: soc/intel/apollolake: Use common/block/uart code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53325/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9137/ : SUCCESS -- To view, visit https://review.coreboot.org/19491 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add PCI configuration code for UART
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19490 ) Change subject: soc/intel/common: Add PCI configuration code for UART ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53324/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9136/ : SUCCESS -- To view, visit https://review.coreboot.org/19490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibce5623ffb879f2427b759106d1f350601837e4b Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use intel/common/block/smbus code
by Aamir Bohra (Code Review) 05 May '17

05 May '17

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19373 ) Change subject: soc/intel/skylake: Use intel/common/block/smbus code ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19373/3/src/soc/intel/skylake/include/soc/s… File src/soc/intel/skylake/include/soc/smbus.h: PS3, Line 28: SMBUS_ > We should fix the name in pm.h to be prefixed better to avoid the collision Done.Revised macro name.Removed TCO_EN under pm.h,wasn't being used. -- To view, visit https://review.coreboot.org/19373 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017