coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: ec/lenovo/h8: Build h8 in romstage
by Patrick Rudolph (Code Review) 18 May '17

18 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19740 to look at the new patch set (#2). Change subject: ec/lenovo/h8: Build h8 in romstage ...................................................................... ec/lenovo/h8: Build h8 in romstage Guard ramstage methods to allow building in romstage. Build h8.c in romstage, too. Change-Id: I76dcf1fd54386562b63695003cee2956b42557c5 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/h8/h8.c 2 files changed, 21 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/19740/2 -- To view, visit https://review.coreboot.org/19740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76dcf1fd54386562b63695003cee2956b42557c5 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ec/lenovo/h8: Add panic method
by Patrick Rudolph (Code Review) 18 May '17

18 May '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19695 to look at the new patch set (#5). Change subject: ec/lenovo/h8: Add panic method ...................................................................... ec/lenovo/h8: Add panic method Flash all LEDs and play beep code 10. To be used for critical events like death. Add two additional LED IDs. Tested on Lenovo T500. Tested on Lenovo X200. Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org --- M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/h8.h 2 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/19695/5 -- To view, visit https://review.coreboot.org/19695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: console: Panic on death
by Patrick Rudolph (Code Review) 18 May '17

18 May '17

Hello Paul Menzel, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19696 to look at the new patch set (#5). Change subject: console: Panic on death ...................................................................... console: Panic on death Call weak method die_callback to signal critical failure. Tested on Lenovo T500. Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/console/die.c M src/include/console/console.h 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/19696/5 -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Kconfig: Move CONFIG_VIDEO_MB
by build bot (Jenkins) (Code Review) 18 May '17

18 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19748 ) Change subject: Kconfig: Move CONFIG_VIDEO_MB ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9674/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53937/ : SUCCESS -- To view, visit https://review.coreboot.org/19748 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd03f48bed881a5846b1bb3bf29254450d6cff3b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Build h8 in romstage
by Patrick Rudolph (Code Review) 18 May '17

18 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19740 ) Change subject: ec/lenovo/h8: Build h8 in romstage ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19740/1//COMMIT_MSG Commit Message: Line 9: Guard ramstage methods. > Why? what is the problem if you don't guard? It does not compile in romstage. -- To view, visit https://review.coreboot.org/19740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76dcf1fd54386562b63695003cee2956b42557c5 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/via/k8t890: Clean up CONFIG_VGA usage
by build bot (Jenkins) (Code Review) 18 May '17

18 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19744 ) Change subject: sb/via/k8t890: Clean up CONFIG_VGA usage ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53933/ : SUCCESS -- To view, visit https://review.coreboot.org/19744 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96ad8002845082816153ca5762543768998a5619 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Fix SPD for micron MT52L256M64D2PP-107
by Furquan Shaikh (Code Review) 18 May '17

18 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19749 ) Change subject: mainboard/google/poppy: Fix SPD for micron MT52L256M64D2PP-107 ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19749/2//COMMIT_MSG Commit Message: Line 9: Fix SPD as per the vendor-provided data. > What is fixed? Some of the bytes provided by the vendor earlier were updated and so the CRC was fixed to match new bytes. -- To view, visit https://review.coreboot.org/19749 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib87c316479f4a05e64ca4acb540d7aacfa7338e9 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: rockchip/rk3399: soc: resize reserve memory
by build bot (Jenkins) (Code Review) 18 May '17

18 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19431 ) Change subject: rockchip/rk3399: soc: resize reserve memory ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9671/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53931/ : SUCCESS -- To view, visit https://review.coreboot.org/19431 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ab39598f3f7cb96feb0c574e230e7fcb53a1a4 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: 3rdparty/arm-trusted-firmware: Update to upstream master
by Patrick Georgi (Code Review) 18 May '17

18 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/18954 ) Change subject: 3rdparty/arm-trusted-firmware: Update to upstream master ...................................................................... Patch Set 3: So I changed the ATF build to not break on unused functions since upstream doesn't seem to care. any objections? We could make them care and then reset our exception, if we want. -- To view, visit https://review.coreboot.org/18954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf5bede79126bcbb62243808a2624d9517015920 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: 3rdparty/arm-trusted-firmware: Update to upstream master
by build bot (Jenkins) (Code Review) 18 May '17

18 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18954 ) Change subject: 3rdparty/arm-trusted-firmware: Update to upstream master ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9670/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53930/ : SUCCESS -- To view, visit https://review.coreboot.org/18954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf5bede79126bcbb62243808a2624d9517015920 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017