coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: mainboard/google/kahlee: Prepare for variants
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22185 ) Change subject: mainboard/google/kahlee: Prepare for variants ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62862/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/17842/ : SUCCESS -- To view, visit https://review.coreboot.org/22185 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1beb45f571f2547f3b5b0d7ec78923d0cec761 Gerrit-Change-Number: 22185 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:51:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Prepare for variants
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22185 ) Change subject: mainboard/google/kahlee: Prepare for variants ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62861/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/17841/ : SUCCESS -- To view, visit https://review.coreboot.org/22185 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1beb45f571f2547f3b5b0d7ec78923d0cec761 Gerrit-Change-Number: 22185 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:34:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: enable 8254 Clock Gating on poppy for XTAL shutdown
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22299 ) Change subject: mb/google/poppy: enable 8254 Clock Gating on poppy for XTAL shutdown ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/62860/ : SUCCESS -- To view, visit https://review.coreboot.org/22299 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581ae4ac88ef4b02ae46454700edc2a5dab3b502 Gerrit-Change-Number: 22299 Gerrit-PatchSet: 3 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:24:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: enable CGE for 8254 PIT for XTAL shutdown
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22236 ) Change subject: soc/intel/skylake: enable CGE for 8254 PIT for XTAL shutdown ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17840/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62859/ : SUCCESS -- To view, visit https://review.coreboot.org/22236 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87fb6fa86f10be6e3c888dd3590d0e77a2b886e8 Gerrit-Change-Number: 22236 Gerrit-PatchSet: 4 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:17:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Fix SPD code
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22300 ) Change subject: soc/amd/stoneyridge: Fix SPD code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17839/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62858/ : SUCCESS -- To view, visit https://review.coreboot.org/22300 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia11c5994c41849ba01ecae3cee6fa97c527134d0 Gerrit-Change-Number: 22300 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:09:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Fix SPD code
by Richard Spiegel (Code Review) 02 Nov '17

02 Nov '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22300 Change subject: soc/amd/stoneyridge: Fix SPD code ...................................................................... soc/amd/stoneyridge: Fix SPD code SPD address should be uint8_t. Remove unused smbus_readSpd prototype from dimmSpd.h. BUG=b:62200225 Change-Id: Ia11c5994c41849ba01ecae3cee6fa97c527134d0 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/dimmSpd.h M src/soc/amd/stoneyridge/dimmSpd.c M src/soc/amd/stoneyridge/smbus_spd.c 3 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/22300/1 diff --git a/src/soc/amd/common/dimmSpd.h b/src/soc/amd/common/dimmSpd.h index cdcdb73..2206b0c 100644 --- a/src/soc/amd/common/dimmSpd.h +++ b/src/soc/amd/common/dimmSpd.h @@ -20,7 +20,6 @@ AmdMemoryReadSPD(IN UINT32 Func, IN UINTN Data, IN OUT AGESA_READ_SPD_PARAMS *SpdData); -int sb_readSpd(int spdAddress, char *buf, size_t len); -int smbus_readSpd(int spdAddress, char *buf, size_t len); +int sb_readSpd(uint8_t spdAddress, char *buf, size_t len); #endif diff --git a/src/soc/amd/stoneyridge/dimmSpd.c b/src/soc/amd/stoneyridge/dimmSpd.c index ace22bb..a821036 100644 --- a/src/soc/amd/stoneyridge/dimmSpd.c +++ b/src/soc/amd/stoneyridge/dimmSpd.c @@ -27,7 +27,7 @@ AGESA_STATUS AmdMemoryReadSPD(UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PARAMS *info) { - int spdAddress; + uint8_t spdAddress; DEVTREE_CONST struct device *dev = dev_find_slot(0, PCI_DEVFN(0x18, 2)); DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info; diff --git a/src/soc/amd/stoneyridge/smbus_spd.c b/src/soc/amd/stoneyridge/smbus_spd.c index 4e3e293..a8a5b37 100644 --- a/src/soc/amd/stoneyridge/smbus_spd.c +++ b/src/soc/amd/stoneyridge/smbus_spd.c @@ -33,10 +33,10 @@ * sending offset for every byte. * Reads 128 bytes in 7-8 ms at 400 KHz. */ -static int readspd(uint16_t iobase, int SmbusSlaveAddress, +static int readspd(uint16_t iobase, uint8_t SmbusSlaveAddress, char *buffer, size_t count) { - u8 dev_addr; + uint8_t dev_addr; size_t index; int error; char *pbuf = buffer; @@ -93,7 +93,7 @@ outb(SMBSLV_STAT_CLEAR, ioBase + SMBSLVSTAT); } -int sb_readSpd(int spdAddress, char *buf, size_t len) +int sb_readSpd(uint8_t spdAddress, char *buf, size_t len) { uint16_t ioBase = SMB_BASE_ADDR; setupFch(ioBase); -- To view, visit https://review.coreboot.org/22300 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia11c5994c41849ba01ecae3cee6fa97c527134d0 Gerrit-Change-Number: 22300 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22299 ) Change subject: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17838/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62857/ : SUCCESS -- To view, visit https://review.coreboot.org/22299 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581ae4ac88ef4b02ae46454700edc2a5dab3b502 Gerrit-Change-Number: 22299 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:00:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22240 ) Change subject: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17836/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62855/ : SUCCESS -- To view, visit https://review.coreboot.org/22240 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa37f97b5395c637fde293f48cf4589e1fe8f3fa Gerrit-Change-Number: 22240 Gerrit-PatchSet: 5 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.corp-partner.google.com> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 20:00:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown
by Roy Mingi Park (Code Review) 02 Nov '17

02 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22299 to look at the new patch set (#2). Change subject: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown ...................................................................... mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown 8254 Static Clock Gating should be enabled on poppy board for XTAL OSC shutdown which has a power impact. BUG=b:36630881 BRANCH=master TEST=Build for poppy board with the clock_gate_8254 policy in devicetree set to 1. iotools mmio_read32 0xfdc43300 should return 0x1f Change-Id: I581ae4ac88ef4b02ae46454700edc2a5dab3b502 Signed-off-by: Roy Mingi Park <roy.mingi.park(a)intel.com> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/22299/2 -- To view, visit https://review.coreboot.org/22299 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I581ae4ac88ef4b02ae46454700edc2a5dab3b502 Gerrit-Change-Number: 22299 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown
by build bot (Jenkins) (Code Review) 02 Nov '17

02 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22299 ) Change subject: mb/google/poppy: enable 8254 Static Clock Gating for XTAL shutdown ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62856/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/17837/ : SUCCESS -- To view, visit https://review.coreboot.org/22299 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581ae4ac88ef4b02ae46454700edc2a5dab3b502 Gerrit-Change-Number: 22299 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 19:51:49 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017