Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16679
-gerrit
commit 983ebc7b78301bd75bb73ecbb5e82ec485eb0a59
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 13:59:38 2016 +0200
buildgcc: Fix GNU getopt usage
Looks like this never worked correctly: There are three argument formats
to GNU getopt and none of them matches what we fed it. The missing
double dash before the `set` arguments proves that we always called it
with parameters that `getopt` did NOT parse.
Change-Id: Ib8343976ef31774b18567a9fc9745a9f58dd287a
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 9eb72f9..81632df 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -690,8 +690,8 @@ getopt - > /dev/null 2>/dev/null || gcc -o getopt getopt.c
getoptbrand="$(getopt -V | sed -e '1!d' -e 's,^\(......\).*,\1,')"
if [ "${getoptbrand}" = "getopt" ]; then
# Detected GNU getopt that supports long options.
- args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported: Vhcd:bp:l:P:j:D:tSys: -- "$@")
- eval set "$args"
+ args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported: -o Vhcd:bp:l:P:j:D:tSys: -- "$@")
+ eval set -- "$args"
else
# Detected non-GNU getopt
args=$(getopt Vhcd:bp:l:P:j:D:tSys: $*)
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16676
-gerrit
commit 5e2ea3b60e277a780b96fa9cf5f316317fab14d7
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 13:01:57 2016 +0200
[RFC] buildgcc: Don't try to build gnat with a different version
Change-Id: I64a33d2cc4793e54a50fa439a4461c40d424b569
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 8a0127e..3783234 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -225,6 +225,25 @@ hostcc_version() {
printf "%d.%d" "$(hostcc_major)" "$(hostcc_minor)"
}
+hostcc_has_gnat1() {
+ [ -x "$(${CC} -print-prog-name=gnat1)" ]
+}
+
+ada_requested() {
+ echo "${LANGUAGES}" | grep -q '\(^\|,\)ada\(,\|$\)'
+}
+
+check_gnat() {
+ if hostcc_has_gnat1; then
+ if [ "$(hostcc_version)" != "$(buildcc_version)" -a "${BOOTSTRAP}" != "1" ]; then
+ printf "\n${RED}ERROR:${red} Building the Ada compiler (gnat $(buildcc_version)) "
+ printf "with a different host compiler\n version ($(hostcc_version)) "
+ printf "requires bootstrapping (-b).${NC}\n\n"
+ HALT_FOR_TOOLS=1
+ fi
+ fi
+}
+
check_cc() {
if is_package_enabled "GCC"; then
if [ "$(hostcc_major)" != "$(buildcc_major)" -a "${BOOTSTRAP}" != "1" ]; then
@@ -232,6 +251,9 @@ check_cc() {
printf "version ($(hostcc_version)).\n"
printf " Bootstrapping (-b) is recommended.${NC}\n\n"
fi
+ if ada_requested; then
+ check_gnat
+ fi
fi
}
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16675
-gerrit
commit 8c433f2f6e08f590a9ce5729e8c5f8eafa44f059
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 12:59:53 2016 +0200
buildgcc: Warn when building GCC with a different major version
GCC build instruction recommend to bootstrap a native compiler first.
Not sure, when that is really necessary. A major version change seems
reasonable.
Change-Id: I80a9ec25739b7d33a1d1c7b4b2140d19d89a99ae
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index c66bfe6..8a0127e 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -225,6 +225,16 @@ hostcc_version() {
printf "%d.%d" "$(hostcc_major)" "$(hostcc_minor)"
}
+check_cc() {
+ if is_package_enabled "GCC"; then
+ if [ "$(hostcc_major)" != "$(buildcc_major)" -a "${BOOTSTRAP}" != "1" ]; then
+ printf "\n${red}warning: Building GCC $(buildcc_version) with a different major "
+ printf "version ($(hostcc_version)).\n"
+ printf " Bootstrapping (-b) is recommended.${NC}\n\n"
+ fi
+ fi
+}
+
check_sum() {
test -z "$CHECKSUM" || \
test "$(cat sum/$1.cksum 2>/dev/null | sed -e 's@.*\([0-9a-f]\{40,\}\).*@\1@')" = \
@@ -829,6 +839,9 @@ searchtool bzip2 "bzip2," > /dev/null
check_for_library "-lz" "zlib (zlib1g-dev or zlib-devel)"
+CC=cc
+check_cc
+
if [ "$HALT_FOR_TOOLS" -ne 0 ]; then
exit 1
fi
@@ -841,7 +854,6 @@ fi
# Set up host compiler and flags needed for various OSes
-CC=cc
if is_package_enabled "GCC"; then
if [ $UNAME = "Darwin" ]; then
#GCC_OPTIONS="$GCC_OPTIONS --enable-threads=posix"
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16501
-gerrit
commit eed94a88a0dad568fbb60b20033b8364ee450cfd
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Mon Sep 5 12:07:57 2016 +0200
gigabyte/ga-g41m-es2l: add VESA mode to Kconfig
This patch adds MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG to the
gigabyte/ga-g41m-es2l Kconfig to allow selecting between textmode and
vesamode in menuconfig.
Change-Id: I84b61118fa0419d49d2498b66029711cdce97576
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/mainboard/gigabyte/ga-g41m-es2l/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig b/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
index 6452f4d..281d498 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
@@ -26,6 +26,7 @@ config BOARD_SPECIFIC_OPTIONS
select BOARD_ROMSIZE_KB_1024
select INTEL_EDID
select MAINBOARD_HAS_NATIVE_VGA_INIT
+ select MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG
select PCIEXP_ASPM
select PCIEXP_CLK_PM
select PCIEXP_L1_SUB_STATE