the following patch was just integrated into master:
commit 2051448359e3e7cbccf63f1817fa14468dcd50c8
Author: Elyes HAOUAS <ehaouas(a)noos.fr>
Date: Sat Sep 17 20:43:41 2016 +0200
northbridge/intel/fsp_sandybridge: Add space around operators
Change-Id: I1b5cdfaf39be639a7ef71e66e91284fa186fbb86
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/16630
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See https://review.coreboot.org/16630 for details.
-gerrit
the following patch was just integrated into master:
commit 9a9c8dba8ddd549d0d6dd23d3a194ffcf427afad
Author: Elyes HAOUAS <ehaouas(a)noos.fr>
Date: Sat Sep 17 20:40:04 2016 +0200
northbridge/intel/gm45: Add space around operators
Change-Id: I3781c36a3f354bfd54d20488b95d4f2307c3bce2
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/16629
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See https://review.coreboot.org/16629 for details.
-gerrit
the following patch was just integrated into master:
commit c021ffee45f7b19b3a8e6c426e0d14a4609bf593
Author: Elyes HAOUAS <ehaouas(a)noos.fr>
Date: Sun Sep 18 19:18:56 2016 +0200
southbridge/amd: Add space around operators
Change-Id: I949ff7de072e5e0753d9c8ff0bf98abfca25798b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/16637
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See https://review.coreboot.org/16637 for details.
-gerrit
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16681
-gerrit
commit 8a28352e1bff621adb474052b7b7383999393426
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 14:16:43 2016 +0200
buildgcc: Show excessive arguments and bail out
Also remove a dead line that checks for unknown options: We already let
`getopt` check that.
Change-Id: I0e829b266e192757d6e455ee4cc608315bb4b7be
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index b4409d4..eca9439 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -725,11 +725,16 @@ while true ; do
-n|--nocolor) shift; \
unset red RED green GREEN blue BLUE cyan CYAN NC;;
--) shift; break;;
- -*) printf "Invalid option\n\n"; myhelp; exit 1;;
*) break;;
esac
done
+if [ $# -gt 0 ]; then
+ printf "Excessive arguments: $*\n"
+ myhelp
+ exit 1
+fi
+
if [ -n "$PRINTSTABLE" ]; then
print_stable
exit 0
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16679
-gerrit
commit 2d2e06f561feac9e6daa5a0ea621f7a233bf1c38
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 13:59:38 2016 +0200
buildgcc: Fix GNU getopt usage
Looks like this never worked correctly: There are three argument formats
to GNU getopt and none of them matches what we fed it. The missing
double dash before the `set` arguments proves that we always called it
with parameters that `getopt` did NOT parse.
Change-Id: Ib8343976ef31774b18567a9fc9745a9f58dd287a
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index c3c8d47..623724e 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -690,8 +690,8 @@ getopt - > /dev/null 2>/dev/null || gcc -o getopt getopt.c
getoptbrand="$(getopt -V | sed -e '1!d' -e 's,^\(......\).*,\1,')"
if [ "${getoptbrand}" = "getopt" ]; then
# Detected GNU getopt that supports long options.
- args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported:,urls,nocolor Vhcd:bp:l:P:j:D:tSys:un -- "$@")
- eval set "$args"
+ args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported:,urls,nocolor -o Vhcd:bp:l:P:j:D:tSys:un -- "$@")
+ eval set -- "$args"
else
# Detected non-GNU getopt
args=$(getopt Vhcd:bp:l:P:j:D:tSys:un $*)
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16681
-gerrit
commit 789fd0e360472e15875f2c6d61ebd7d665c4d975
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Sep 20 14:16:43 2016 +0200
buildgcc: Show excessive arguments and bail out
Also remove a dead line that checks for unknown options: We already let
`getopt` check that.
Change-Id: I0e829b266e192757d6e455ee4cc608315bb4b7be
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
util/crossgcc/buildgcc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 618aff3..2d71fe7 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -725,11 +725,16 @@ while true ; do
--nocolor) shift; \
unset red RED green GREEN blue BLUE cyan CYAN NC;;
--) shift; break;;
- -*) printf "Invalid option\n\n"; myhelp; exit 1;;
*) break;;
esac
done
+if [ $# -gt 0 ]; then
+ printf "Excessive arguments: $*\n"
+ myhelp
+ exit 1
+fi
+
if [ -n "$PRINTSTABLE" ]; then
print_stable
exit 0