David Imhoff (dimhoff_devel(a)xs4all.nl) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10167
-gerrit
commit 69019e86d6fc9adbd5588dd3213df922bc8fa501
Author: David Imhoff <dimhoff_devel(a)xs4all.nl>
Date: Sun May 10 17:10:05 2015 +0200
intel/fsp_baytrail: Fix SD card when eMMC in disabled
Always tell the FSP to initialise one of the eMMC controllers. This is a
work around to make the SD card reader work. I haven't got a clue why
this is needed.
TEST=Intel/MinnowMax
Change-Id: Ic51dca8e54eb34bf6dbf9967e7cb86d635cf8751
Signed-off-by: David Imhoff <dimhoff_devel(a)xs4all.nl>
---
src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
index adfee6f..86e4b3e 100644
--- a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
+++ b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
@@ -114,7 +114,9 @@ static void ConfigureDefaultUpdData(FSP_INFO_HEADER *FspInfo, UPD_DATA_REGION *U
UPD_DEFAULT_CHECK(TxeUmaEnable);
if (config->PcdeMMCBootMode == EMMC_FOLLOWS_DEVICETREE)
- UpdData->PcdeMMCBootMode = 0;
+ /* Hack: always tell FSP to initialize one of the eMMC
+ * controllers else SD card doesn't work */
+ UpdData->PcdeMMCBootMode = EMMC_AUTO - EMMC_DISABLED;
else if ((config->PcdeMMCBootMode != EMMC_USE_DEFAULT))
UpdData->PcdeMMCBootMode = config->PcdeMMCBootMode - EMMC_DISABLED;
David Imhoff (dimhoff_devel(a)xs4all.nl) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10165
-gerrit
commit 3f90e9d0d589348f01b6654f924f6bead89cffff
Author: David Imhoff <dimhoff_devel(a)xs4all.nl>
Date: Sun May 10 15:19:04 2015 +0200
intel/fsp_baytrail: Fix assignment of PcdeMMCBootMode
Before the PcdeMMCBootMode in the Updatable Product Date was always
assigned and didn't take into account the + 1 increment for the default
define.
Now if the configuration indicates that the device tree should be
followed PcdeMMCBootMode is initially disabled. Else if configuration
isn't the default, assign the value with the + 1 increment substracted.
TEST=Intel/MinnowMax
Change-Id: I6755eb585d1afe3a15f83347fba834766eb44ad2
Signed-off-by: David Imhoff <dimhoff_devel(a)xs4all.nl>
---
src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
index 1a3eda4..f7ca991 100644
--- a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
+++ b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
@@ -113,9 +113,10 @@ static void ConfigureDefaultUpdData(FSP_INFO_HEADER *FspInfo, UPD_DATA_REGION *U
UPD_DEFAULT_CHECK(IgdRenderStandby);
UPD_DEFAULT_CHECK(TxeUmaEnable);
- if ((config->PcdeMMCBootMode != EMMC_USE_DEFAULT) ||
- (config->PcdeMMCBootMode != EMMC_FOLLOWS_DEVICETREE))
- UpdData->PcdeMMCBootMode = config->PcdeMMCBootMode;
+ if (config->PcdeMMCBootMode == EMMC_FOLLOWS_DEVICETREE)
+ UpdData->PcdeMMCBootMode = 0;
+ else if ((config->PcdeMMCBootMode != EMMC_USE_DEFAULT))
+ UpdData->PcdeMMCBootMode = config->PcdeMMCBootMode - EMMC_DISABLED;
UpdData->PcdMrcInitTsegSize = smm_region_size() >> 20;
the following patch was just integrated into master:
commit c7a8c3835d095405cf875d6952e348c023c7c5a0
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat May 9 08:36:28 2015 +0200
cbfstool: fix 32bit host issue
Change-Id: Iaec748b4bdbb5da287520fbbd7c3794bf664eff6
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-on: http://review.coreboot.org/10161
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Sol Boucher <solb(a)chromium.org>
See http://review.coreboot.org/10161 for details.
-gerrit