coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch merged into coreboot/master: x86emu: Remove XFree86 CVS tags
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit a40f64f7fb522550892a492031cf1b1784afc8d7 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 15:32:17 2015 -0800 x86emu: Remove XFree86 CVS tags They're not supported by git. Change-Id: I8157cdc0f5f4072af588772680741b72d21a9223 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/12494 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12494 for details. -gerrit

1 0

Patch merged into coreboot/master: x86emu: Undefine _NO_INLINE
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit d89736072fbf8802a613f37b7e7da366fdc49de8 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 15:02:21 2015 -0800 x86emu: Undefine _NO_INLINE Never defined by the server. Change-Id: If22727cf3953c2931d107146fb99b5997f8a13d5 Original-Reviewed-by: Eric Anholt <eric(a)anholt.net> Original-Signed-off-by: Adam Jackson <ajax(a)redhat.com> Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/12493 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12493 for details. -gerrit

1 0

Patch merged into coreboot/master: x86emu: Fix some set-but-not-used warnings.
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit 92a97f459f4bfd784b9accfe042ef8df71e13313 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Nov 19 14:45:39 2015 -0800 x86emu: Fix some set-but-not-used warnings. Change-Id: Ide861733d721a21b77862076bf7ad70c7ee6a472 Original-Reviewed-by: Adam Jackson <ajax(a)redhat.com> Original-Signed-off-by: Eric Anholt <eric(a)anholt.net> Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/12492 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/12492 for details. -gerrit

1 0

Patch set updated for coreboot: cbfstool: autocreate trampoline
by Stefan Reinauer 20 Nov '15

20 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12505 -gerrit commit 108fb39303536b9a89f3984be99c128da718bb7e Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Nov 20 17:58:59 2015 +0100 cbfstool: autocreate trampoline Change-Id: I9b7877c58d90f9fb21d16e0061a31e19fffa2470 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/cbfstool/linux_trampoline.S | 147 +++++++++++++++++++++++++++++++++ util/cbfstool/linux_trampoline.c | 172 +++------------------------------------ util/cbfstool/trampoline.sh | 12 +++ 3 files changed, 171 insertions(+), 160 deletions(-) diff --git a/util/cbfstool/linux_trampoline.S b/util/cbfstool/linux_trampoline.S new file mode 100644 index 0000000..1905498 --- /dev/null +++ b/util/cbfstool/linux_trampoline.S @@ -0,0 +1,147 @@ +/* + * linux_trampoline + * + * Copyright (C) 2013 Patrick Georgi <patrick(a)georgi-clan.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* NOTE: THIS CODE MUST REMAIN POSITION INDEPENDENT + * IT SHOULDN'T USE THE STACK + * AND IN GENERAL EXPECT NOTHING BUT RAM TO WORK + */ +.code32 +.data + +#include "linux_trampoline.h" +#define HEADER_SIG 0x4f49424c // LBIO little endian +#define CB_TAG_FORWARD 0x11 +#define CB_TAG_MEMORY 0x1 +#define CB_TAG_FRAMEBUFFER 0x12 + +#define E820_NR_OFFSET 0x1e8 +#define LINUX_ENTRY_OFFSET 0x214 +#define E820_OFFSET 0x2d0 + +.trampoline_start: + +cld +xor %edx, %edx +mov $0, %ecx + +.headerSearch: +mov $0x10000, %ebx +add %ecx, %ebx +mov (%ecx), %eax +cmp $HEADER_SIG, %eax +je .headerSearchDone // found the header +add $16, %ecx +cmp %ecx, %ebx +jne .headerSearch + +.headerSearchDone: +cmp %ecx, %ebx // reached the end == not found anything? +je 2f // give up + +// we assume the checksum is okay, no test +mov 4(%ecx), %ebx +add %ecx, %ebx // ebx = cb_header + header_bytes +mov 20(%ecx), %ecx // ecx = table_entries + +.tableScan: +cmp $CB_TAG_FORWARD, (%ebx) +jne .testMemory + +/* forward tag: assume 32bit pointer */ +mov 8(%ebx), %ecx +jmp .headerSearch + +.testMemory: +cmp $CB_TAG_MEMORY, (%ebx) +jne .testFramebuffer + +/* memory tag: copy e820 map and entry count. also determine alt_mem_k */ +mov 4(%ebx), %eax +sub $8, %eax +shr $2, %eax /* eax = number of dwords of e820 data */ +cmp $(32 * 5), %eax /* linux wants at most 32 entries of 5 dwords */ +jng 1f +mov $(32 * 5), %eax /* only copy 32 entries */ +1: +mov %eax, %esi +mov $5, %edi +div %edi +mov %eax, (LINUX_PARAM_LOC + E820_NR_OFFSET) +mov %esi, %eax +xchg %eax, %ecx +lea 8(%ebx), %esi /* e820 data source */ +mov $(LINUX_PARAM_LOC + E820_OFFSET), %edi +rep movsl +xchg %eax, %ecx +jmp .endScan + +.testFramebuffer: +cmp $CB_TAG_FRAMEBUFFER, (%ebx) +jne .endScan +/* TODO: handle framebuffer tag */ + +.endScan: +add 4(%ebx), %ebx +dec %ecx +jnz .tableScan + +/* Setup basic code and data segment selectors for Linux +** +** Flat code segment descriptor: +** selector: 0x10 +** base : 0x00000000 +** limit : 0xFFFFFFFF +** type : code, execute, read +** +** Flat data segment descriptor: +** selector: 0x18 +** base : 0x00000000 +** limit : 0xFFFFFFFF +** type : data, read/write +** +** Use TRAMPOLINE_ENTRY_LOC as a scratchpad. +*/ +mov $TRAMPOLINE_ENTRY_LOC, %eax +sgdt (%eax) +mov 2(%eax), %ebx +movl $0x0000ffff, 16(%ebx) +movl $0x00cf9b00, 20(%ebx) +movl $0x0000ffff, 24(%ebx) +movl $0x00cf9300, 28(%ebx) + +/* finally: jump to kernel */ +mov $LINUX_PARAM_LOC, %esi +jmp *(LINUX_PARAM_LOC + LINUX_ENTRY_OFFSET) + + +2: +hlt +jmp 2b + +.trampoline_end: + +.global trampoline_start, trampoline_size +trampoline_start: +.long .trampoline_start +trampoline_size: +.long .trampoline_end - .trampoline_start + +/* The code above is hand-crafted to fit various contraints. + * To simplify porting, the below matches the above. + * When changing any code in here, compile the above as a .S + * file, objcopy it to binary and paste the result below (minus + * the last 8 bytes which are trampoline_start and trampoline_size). + */ + diff --git a/util/cbfstool/linux_trampoline.c b/util/cbfstool/linux_trampoline.c index aacf411..8b5cfad 100644 --- a/util/cbfstool/linux_trampoline.c +++ b/util/cbfstool/linux_trampoline.c @@ -1,164 +1,16 @@ -/* - * linux_trampoline - * - * Copyright (C) 2013 Patrick Georgi <patrick(a)georgi-clan.de> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#if 0 -/* NOTE: THIS CODE MUST REMAIN POSITION INDEPENDENT - * IT SHOULDN'T USE THE STACK - * AND IN GENERAL EXPECT NOTHING BUT RAM TO WORK - */ -.code32 -.data - -#include "linux_trampoline.h" -#define HEADER_SIG 0x4f49424c // LBIO little endian -#define CB_TAG_FORWARD 0x11 -#define CB_TAG_MEMORY 0x1 -#define CB_TAG_FRAMEBUFFER 0x12 - -#define E820_NR_OFFSET 0x1e8 -#define LINUX_ENTRY_OFFSET 0x214 -#define E820_OFFSET 0x2d0 - -.trampoline_start: - -cld -xor %edx, %edx -mov $0, %ecx - -.headerSearch: -mov $0x10000, %ebx -add %ecx, %ebx -mov (%ecx), %eax -cmp $HEADER_SIG, %eax -je .headerSearchDone // found the header -add $16, %ecx -cmp %ecx, %ebx -jne .headerSearch - -.headerSearchDone: -cmp %ecx, %ebx // reached the end == not found anything? -je 2f // give up - -// we assume the checksum is okay, no test -mov 4(%ecx), %ebx -add %ecx, %ebx // ebx = cb_header + header_bytes -mov 20(%ecx), %ecx // ecx = table_entries - -.tableScan: -cmp $CB_TAG_FORWARD, (%ebx) -jne .testMemory - -/* forward tag: assume 32bit pointer */ -mov 8(%ebx), %ecx -jmp .headerSearch - -.testMemory: -cmp $CB_TAG_MEMORY, (%ebx) -jne .testFramebuffer - -/* memory tag: copy e820 map and entry count. also determine alt_mem_k */ -mov 4(%ebx), %eax -sub $8, %eax -shr $2, %eax /* eax = number of dwords of e820 data */ -cmp $(32 * 5), %eax /* linux wants at most 32 entries of 5 dwords */ -jng 1f -mov $(32 * 5), %eax /* only copy 32 entries */ -1: -mov %eax, %esi -mov $5, %edi -div %edi -mov %eax, (LINUX_PARAM_LOC + E820_NR_OFFSET) -mov %esi, %eax -xchg %eax, %ecx -lea 8(%ebx), %esi /* e820 data source */ -mov $(LINUX_PARAM_LOC + E820_OFFSET), %edi -rep movsl -xchg %eax, %ecx -jmp .endScan - -.testFramebuffer: -cmp $CB_TAG_FRAMEBUFFER, (%ebx) -jne .endScan -/* TODO: handle framebuffer tag */ - -.endScan: -add 4(%ebx), %ebx -dec %ecx -jnz .tableScan - -/* Setup basic code and data segment selectors for Linux -** -** Flat code segment descriptor: -** selector: 0x10 -** base : 0x00000000 -** limit : 0xFFFFFFFF -** type : code, execute, read -** -** Flat data segment descriptor: -** selector: 0x18 -** base : 0x00000000 -** limit : 0xFFFFFFFF -** type : data, read/write -** -** Use TRAMPOLINE_ENTRY_LOC as a scratchpad. -*/ -mov $TRAMPOLINE_ENTRY_LOC, %eax -sgdt (%eax) -mov 2(%eax), %ebx -movl $0x0000ffff, 16(%ebx) -movl $0x00cf9b00, 20(%ebx) -movl $0x0000ffff, 24(%ebx) -movl $0x00cf9300, 28(%ebx) - -/* finally: jump to kernel */ -mov $LINUX_PARAM_LOC, %esi -jmp *(LINUX_PARAM_LOC + LINUX_ENTRY_OFFSET) - - -2: -hlt -jmp 2b - -.trampoline_end: - -.global trampoline_start, trampoline_size -trampoline_start: -.long .trampoline_start -trampoline_size: -.long .trampoline_end - .trampoline_start -#endif - -/* The code above is hand-crafted to fit various contraints. - * To simplify porting, the below matches the above. - * When changing any code in here, compile the above as a .S - * file, objcopy it to binary and paste the result below (minus - * the last 8 bytes which are trampoline_start and trampoline_size). - */ const unsigned char trampoline[] = { -0xfc, 0x31, 0xd2, 0xb9, 0x00, 0x00, 0x00, 0x00, 0xbb, 0x00, 0x00, 0x01, 0x00, 0x01, 0xcb, 0x8b, -0x01, 0x3d, 0x4c, 0x42, 0x49, 0x4f, 0x74, 0x07, 0x83, 0xc1, 0x10, 0x39, 0xcb, 0x75, 0xe9, 0x39, -0xcb, 0x0f, 0x84, 0x85, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, -0x3b, 0x11, 0x75, 0x05, 0x8b, 0x4b, 0x08, 0xeb, 0xcf, 0x83, 0x3b, 0x01, 0x75, 0x33, 0x8b, 0x43, -0x04, 0x83, 0xe8, 0x08, 0xc1, 0xe8, 0x02, 0x3d, 0xa0, 0x00, 0x00, 0x00, 0x7e, 0x05, 0xb8, 0xa0, -0x00, 0x00, 0x00, 0x89, 0xc6, 0xbf, 0x05, 0x00, 0x00, 0x00, 0xf7, 0xf7, 0xa3, 0xe8, 0x01, 0x09, -0x00, 0x89, 0xf0, 0x91, 0x8d, 0x73, 0x08, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0xf3, 0xa5, 0x91, 0xeb, -0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x75, 0xb3, 0xb8, 0x00, 0x00, 0x04, -0x00, 0x0f, 0x01, 0x00, 0x8b, 0x58, 0x02, 0xc7, 0x43, 0x10, 0xff, 0xff, 0x00, 0x00, 0xc7, 0x43, -0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x43, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, 0x43, 0x1c, 0x00, -0x93, 0xcf, 0x00, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, -0xfd + 0xfc, 0x31, 0xd2, 0xb9, 0x00, 0x00, 0x00, 0x00, 0xbb, 0x00, 0x00, 0x01, 0x00, 0x01, 0xcb, 0x8b, + 0x01, 0x3d, 0x4c, 0x42, 0x49, 0x4f, 0x74, 0x07, 0x83, 0xc1, 0x10, 0x39, 0xcb, 0x75, 0xe9, 0x39, + 0xcb, 0x0f, 0x84, 0x87, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, + 0x3b, 0x11, 0x75, 0x05, 0x8b, 0x4b, 0x08, 0xeb, 0xcf, 0x83, 0x3b, 0x01, 0x75, 0x33, 0x8b, 0x43, + 0x04, 0x83, 0xe8, 0x08, 0xc1, 0xe8, 0x02, 0x3d, 0xa0, 0x00, 0x00, 0x00, 0x7e, 0x05, 0xb8, 0xa0, + 0x00, 0x00, 0x00, 0x89, 0xc6, 0xbf, 0x05, 0x00, 0x00, 0x00, 0xf7, 0xf7, 0xa3, 0xe8, 0x01, 0x09, + 0x00, 0x89, 0xf0, 0x91, 0x8d, 0x73, 0x08, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0xf3, 0xa5, 0x91, 0xeb, + 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x75, 0xb3, 0xb8, 0x00, 0x00, 0x04, + 0x00, 0x0f, 0x01, 0x00, 0x8b, 0x58, 0x02, 0xc7, 0x43, 0x10, 0xff, 0xff, 0x00, 0x00, 0xc7, 0x43, + 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x43, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, 0x43, 0x1c, 0x00, + 0x93, 0xcf, 0x00, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, + 0xfd }; const void * const trampoline_start = &trampoline; diff --git a/util/cbfstool/trampoline.sh b/util/cbfstool/trampoline.sh new file mode 100644 index 0000000..864be8f --- /dev/null +++ b/util/cbfstool/trampoline.sh @@ -0,0 +1,12 @@ +#!/bin/sh + +gcc -o linux_trampoline linux_trampoline.S -ffreestanding -nostdlib -nostdinc -Wl,--defsym=_start=0 +objcopy -Obinary -j .data linux_trampoline lt +dd if=lt of=trampoline bs=$(( $( stat -c %s lt ) - 8 )) count=1 +xxd -c 16 -i trampoline > trampoline.c +( cat trampoline.c + echo "const void * const trampoline_start = &trampoline;" + echo "const unsigned long trampoline_size = sizeof trampoline;" +) | sed 's,unsigned int.*$,,' | sed 's,unsigned char,const unsigned char,g' > linux_trampoline.c +rm lt trampoline trampoline.c linux_trampoline +

1 0

Patch set updated for coreboot: build system: Make sure that build.h is generated before use
by Stefan Reinauer 20 Nov '15

20 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12361 -gerrit commit 817635c731fb74fcde486a40c6b8dba8b4b97e1d Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Nov 8 15:20:32 2015 +0100 build system: Make sure that build.h is generated before use With an order-only dependency make sure enforce generation of build.h early enough that the race condition on highly parallel builds doesn't happen anymore. Change-Id: I6eb83543ec4a995b3b3662f606fc43796ae68f7b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile.inc | 2 ++ src/arch/x86/Makefile.inc | 1 - src/lib/Makefile.inc | 6 ------ 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 65aa71c..12f1cae 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -301,6 +301,8 @@ $(obj)/build.h: .xcompile util/genbuild_h/genbuild_h.sh > $(obj)/build.ht mv $(obj)/build.ht $(obj)/build.h +%.o: | $(obj)/build.h + build-dirs: mkdir -p $(objcbfs) $(objgenerated) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 03dba34..21fa07d 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -81,7 +81,6 @@ endif # the right order. Make sure the auto generated bootblock.inc is a proper # dependency. Make the same true for the linker sript. bootblock-y += id.S -$(obj)/arch/x86/id.bootblock.o: $(obj)/build.h bootblock-y += bootblock.S bootblock-y += walkcbfs.S diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 59b1317..f9a2792 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -172,12 +172,6 @@ ramstage-y += version.c smm-y += version.c verstage-y += version.c -$(obj)/lib/version.bootblock.o : $(obj)/build.h -$(obj)/lib/version.romstage.o : $(obj)/build.h -$(obj)/lib/version.ramstage.o : $(obj)/build.h -$(obj)/lib/version.smm.o : $(obj)/build.h -$(obj)/lib/version.verstage.o : $(obj)/build.h - romstage-y += bootmode.c ramstage-y += bootmode.c

1 0

Patch merged into coreboot/master: nb/amd/amdfam10: Add HyperTransport probe filter support
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit 0f1553b89a226d368f2accd443911a443b8d3a75 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sun Aug 2 21:06:39 2015 -0500 nb/amd/amdfam10: Add HyperTransport probe filter support All modern Opteron processors support the HT probe filter, which helps to increase coherent fabric performance by reducing the number of HT transactions per cache probe. AMD recommends that the probe filter be enabled on all systems with more than two nodes, and it does not hurt to enable it on systems with 2 nodes. Change-Id: I00a27a828260be8685ae622cfa5a4995add95a8e Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12021 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/12021 for details. -gerrit

1 0

Patch set updated for coreboot: lib/timestamp.c: only log "Timestamp table full" once
by Ben Gardner 20 Nov '15

20 Nov '15

Ben Gardner (gardner.ben(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12506 -gerrit commit cb3d8c24a4d2d19dd99aa879187283196cf58ff9 Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Fri Nov 20 13:25:25 2015 -0600 lib/timestamp.c: only log "Timestamp table full" once If the timestamp table gets corrupted (separate issue), the timestamp_sync_cache_to_cbmem() function may add a large number of bogus timestamp entries. This causes a flood of "ERROR: Timestamp table full". With logs going to a serial console, this renders the system essentially unbootable. There really isn't a need to log that more than once, so log it when the last slot in the timestamp table is filled. Change-Id: I05d131183afceca31f4dac91c5edc95cfb1e443f Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> --- src/lib/timestamp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index e07fd4b..03d9b8a 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -152,14 +152,15 @@ static void timestamp_add_table_entry(struct timestamp_table *ts_table, { struct timestamp_entry *tse; - if (ts_table->num_entries == ts_table->max_entries) { - printk(BIOS_ERR, "ERROR: Timestamp table full\n"); + if (ts_table->num_entries >= ts_table->max_entries) return; - } tse = &ts_table->entries[ts_table->num_entries++]; tse->entry_id = id; tse->entry_stamp = ts_time - ts_table->base_time; + + if (ts_table->num_entries == ts_table->max_entries) + printk(BIOS_ERR, "ERROR: Timestamp table full\n"); } void timestamp_add(enum timestamp_id id, uint64_t ts_time)

1 0

Patch merged into coreboot/master: intel/skylake: Fix flash_controller.c compilation
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit 5ff2502151d55349cd8d9c565d3bf5b14f91afa5 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Nov 18 15:31:15 2015 -0800 intel/skylake: Fix flash_controller.c compilation Since this code is not currently being built by coreboot, it failed compilation. Change-Id: Ib8a0e1ebc76b7dca3dd785b09398b73abad46366 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/12466 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/12466 for details. -gerrit

1 0

Patch merged into coreboot/master: rules.h: Add ENV_STRING and use it in console_init()
by gerrit＠coreboot.org 20 Nov '15

20 Nov '15

the following patch was just integrated into master: commit aa5f5b153f10e7cb49641bedafe9990774d75119 Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Thu Nov 19 10:48:47 2015 -0600 rules.h: Add ENV_STRING and use it in console_init() Move the #ifdef chain to set the stage name to rules.h. Change-Id: I577ddf2de4ef249a1a4ce627bb55608731a9f5ed Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> Reviewed-on: http://review.coreboot.org/12479 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/12479 for details. -gerrit

1 0

Patch set updated for coreboot: northbridge/amd/amdfam10: Fix poor performance on Family 15h CPUs
by Timothy Pearson 20 Nov '15

20 Nov '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12031 -gerrit commit 2288bf84f435a1092190c2fd2ac7343db31c6952 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Aug 7 19:06:09 2015 -0500 northbridge/amd/amdfam10: Fix poor performance on Family 15h CPUs Change-Id: I193749bc767b7c1139de7cd67622a7b03298009b Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/northbridge/amd/amdfam10/nb_control.c | 4 ++-- src/northbridge/amd/amdfam10/northbridge.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/northbridge/amd/amdfam10/nb_control.c b/src/northbridge/amd/amdfam10/nb_control.c index f95b6f8..8e8dd57 100644 --- a/src/northbridge/amd/amdfam10/nb_control.c +++ b/src/northbridge/amd/amdfam10/nb_control.c @@ -60,10 +60,10 @@ static void nb_control_init(struct device *dev) pci_write_config32(dev, 0xe0, dword); /* Configure northbridge P-states */ - dword = pci_read_config32(dev, 0xe0); + dword = pci_read_config32(dev, 0x170); dword &= ~(0x7 << 9); /* NbPstateThreshold = compute_unit_count */ dword |= (compute_unit_count & 0x7) << 9; - pci_write_config32(dev, 0xe0, dword); + pci_write_config32(dev, 0x170, dword); printk(BIOS_DEBUG, "done.\n"); } diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 2684d89..4826a36 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -1755,6 +1755,8 @@ static void detect_and_enable_probe_filter(device_t dev) disable_cache(); wbinvd(); + + /* Enable probe filter */ for (i = 0; i < sysconf.nodes; i++) { device_t f3x_dev = dev_find_slot(0, PCI_DEVFN(0x18 + i, 3)); @@ -1771,6 +1773,25 @@ static void detect_and_enable_probe_filter(device_t dev) do { } while (!(pci_read_config32(f3x_dev, 0x1d4) & (0x1 << 19))); } + + if (is_fam15h()) { + printk(BIOS_DEBUG, "Enabling ATM mode\n"); + + /* Enable ATM mode */ + for (i = 0; i < sysconf.nodes; i++) { + device_t f0x_dev = dev_find_slot(0, PCI_DEVFN(0x18 + i, 0)); + device_t f3x_dev = dev_find_slot(0, PCI_DEVFN(0x18 + i, 3)); + + dword = pci_read_config32(f0x_dev, 0x68); + dword |= (0x1 << 12); /* ATMModeEn = 1 */ + pci_write_config32(f0x_dev, 0x68, dword); + + dword = pci_read_config32(f3x_dev, 0x1b8); + dword |= (0x1 << 27); /* L3ATMModeEn = 1 */ + pci_write_config32(f3x_dev, 0x1b8, dword); + } + } + enable_cache(); /* Reenable L3 and DRAM scrubbers */

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015