coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch merged into coreboot/master: iwave/IWRainBowG6: Fix IASL warning and remark
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit d26c9d603e25b8ae10ed7f7ce36f2661241cde06 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 11:21:25 2015 -0700 iwave/IWRainBowG6: Fix IASL warning and remark - Add an empty Operating Region for the empty _REG method - Serialize _CRS Method - Remove Kconfig default disabling IASL warnings as errors Fixes IASL Warning: dsdt.aml 1362: Method (_REG, 2) Warning 3079 - ^ _REG has no corresponding Operation Region Fixes IASL remark: dsdt.aml 1353: Method (_CRS, 0) Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) Change-Id: Iff01613a6e3238469c1fcb8d74f5e98d18420aaf Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12515 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12515 for details. -gerrit

1 0

Patch merged into coreboot/master: intel/soc/baytrail: Move MCRS ResourceTemplate out of _CRS method
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit 6149233cce1b220f3b78a301cf26660925eb3c48 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 10:38:10 2015 -0700 intel/soc/baytrail: Move MCRS ResourceTemplate out of _CRS method Fixes these remarks: Object is not referenced (Name is within method [_CRS]) The ACPI compiler is trying to be helpful in letting us know that we're not using various fields in the MCRS ResourceTemplate when we define it inside of the _CRS method. Since we're not intending to use those objects in the method, it shouldn't be an issue, but the warning is annoying and can mask real issues. Moving the creation of the MCRS object to outside of the CRS method and referencing it from there solves this problem. Change-Id: I54ab3ad9ed148fdd24e8615d83bc8ae668d1dbff Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12514 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12514 for details. -gerrit

1 0

Patch merged into coreboot/master: .gitignore: add output files for various make targets
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit 69759401db27add72bd76251e9365d6fa1fa4172 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 08:41:57 2015 -0700 .gitignore: add output files for various make targets - Ignore output files for the new utilities amdfwtool and intelvbttool - Ignore xml files for 'make what-jenkins-does' - Ignore build files from libpayload's 'make install' Change-Id: Ie4f1c9bf7dc597f7600c8bda0c6fad5f40acf7f8 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12512 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12512 for details. -gerrit

1 0

Patch merged into coreboot/master: Makefiles: Add / Update help for makefile targets
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit 76f14b2b60e02211c5513d83e970d94869cf058c Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 18 13:09:23 2015 -0700 Makefiles: Add / Update help for makefile targets Currently running 'make help' just gives help for the kconfig targets. This adds help for common coreboot and toolchain targets. It stops printing some of the less common kconfig targets, but still leaves them in the makefile as documentation. Change-Id: I2a00fcbc06f05dc4029a91f3dff830c19e4d1329 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12458 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12458 for details. -gerrit

1 0

Patch merged into coreboot/master: ec/lenovo/h8: Fix IASL warnings
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit 21dbc2fc3c2febe0e6ac3760f4c8a63c2aeedd06 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 12:23:19 2015 -0700 ec/lenovo/h8: Fix IASL warnings If any path in a method returns a value, IASL expects that all paths within that method will return a value. Presumably the MKHP method wouldn't get called unless there were a pending event, but if no event is found, return a zero. Fixes IASL warning: dsdt.aml 1785: Method (MHKP, 0, NotSerialized) Warning 3115 - ^ Not all control paths return a value (MHKP) This was the only IASL warning in most lenovo mainboards. Change-Id: Id93dcc4a74bd4c18b78f1dde821e7ba0f3444da3 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12517 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12517 for details. -gerrit

1 0

Patch set updated for coreboot: sconfig: pass in devicetree filename
by Martin Roth 24 Nov '15

24 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12529 -gerrit commit cd962d8a4cf8b19c6b401b22c3b1ceaf6e07f53f Author: Martin Roth <martinroth(a)google.com> Date: Tue Nov 24 12:34:16 2015 -0700 sconfig: pass in devicetree filename Instead of forcing the hardcoded 'devicetree.cb' filename under the mainboard directory, this allows mainboards to select a filename for the devicetree file. This allows mainboard variants that need to use different devicetree files to live in the same directory. Change-Id: I761e676ba5d5f70d1fb86656b528f63db169fcef Signed-off-by: Martin Roth <martinroth(a)google.com> --- Makefile.inc | 4 ++-- src/Kconfig | 8 ++++++++ util/sconfig/main.c | 32 +++++++++++++++++++++----------- 3 files changed, 31 insertions(+), 13 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 53b658b..4e9f9a9 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -369,10 +369,10 @@ $(BIMGTOOL): $(top)/util/bimgtool/bimgtool.c ####################################################################### # needed objects that every mainboard uses # Creation of these is architecture and mainboard independent -$(obj)/mainboard/$(MAINBOARDDIR)/static.c: $(src)/mainboard/$(MAINBOARDDIR)/devicetree.cb $(objutil)/sconfig/sconfig +$(obj)/mainboard/$(MAINBOARDDIR)/static.c: $(src)/mainboard/$(MAINBOARDDIR)/$(call strip_quotes, $(CONFIG_DEVICETREE)) $(objutil)/sconfig/sconfig @printf " SCONFIG $(subst $(src)/,,$(<))\n" mkdir -p $(obj)/mainboard/$(MAINBOARDDIR) - $(objutil)/sconfig/sconfig $(MAINBOARDDIR) $(obj)/mainboard/$(MAINBOARDDIR) + $(objutil)/sconfig/sconfig $(MAINBOARDDIR) $(obj)/mainboard/$(MAINBOARDDIR) $(call strip_quotes, $(CONFIG_DEVICETREE)) ramstage-y+=$(obj)/mainboard/$(MAINBOARDDIR)/static.c romstage-y+=$(obj)/mainboard/$(MAINBOARDDIR)/static.c diff --git a/src/Kconfig b/src/Kconfig index 8439a00..471d305 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -323,6 +323,14 @@ config BOARD_ID_STRING This string is placed in the 'board_id' CBFS file for indicating board type. +config DEVICETREE + string + default "devicetree.cb" + help + This symbol is for mainboards to select a different file name for + their devicetree.cb file. This allows board variants that need + different devicetree files to be in the same directory. + config RAM_CODE_SUPPORT bool default n diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 27027f5..755bfe7 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -547,7 +547,7 @@ static void inherit_subsystem_ids(FILE *file, struct device *dev) static void usage(void) { - printf("usage: sconfig vendor/mainboard outputdir [-{s|b|k} outputfile]\n"); + printf("usage: sconfig vendor/mainboard outputdir devicetree [-{s|b|k} outputfile]\n"); printf("\t-s file\tcreate ramstage static device map\n"); printf("\t-b file\tcreate bootblock init_mainboard()\n"); printf("\t-k file\tcreate Kconfig devicetree section\n"); @@ -555,27 +555,37 @@ static void usage(void) exit (1); } +#define VENDOR_MAINBOARD_ARG 1 +#define OUTPUTDIR_ARG 2 +#define DEVICEFILE_ARG 3 +#define OUTPUTTYPE_ARG 4 +#define OUTPUTFILE_ARG 5 + +#define MIN_ARGS 4 +#define MAX_ARGS 6 int main(int argc, char** argv) { - if (argc != 3 && argc != 5) + if (argc != MIN_ARGS && argc != MAX_ARGS) usage(); - char *mainboard=argv[1]; - char *outputdir=argv[2]; - char *devtree=malloc(strlen(mainboard)+30); - sprintf(devtree, "src/mainboard/%s/devicetree.cb", mainboard); + char *mainboard=argv[VENDOR_MAINBOARD_ARG]; + char *outputdir=argv[OUTPUTDIR_ARG]; + char *devfile=argv[DEVICEFILE_ARG]; + char *devtree=malloc(strlen(mainboard)+strlen(devfile)+30); + sprintf(devtree, "src/mainboard/%s/%s", mainboard, devfile); char *outputc; - if (argc == 3) { + if (argc == MIN_ARGS) { scan_mode = STATIC_MODE; outputc=malloc(strlen(outputdir)+20); sprintf(outputc, "%s/static.c", outputdir); - } else if (argc == 5) { - if ((argv[3][0] != '-') || (argv[3][2] == 0)) { + } else if (argc == MAX_ARGS) { + if ((argv[OUTPUTTYPE_ARG][0] != '-') || + (argv[OUTPUTTYPE_ARG][2] == 0)) { usage(); } - switch (argv[3][1]) { + switch (argv[OUTPUTTYPE_ARG][1]) { case 's': scan_mode = STATIC_MODE; break; @@ -589,7 +599,7 @@ int main(int argc, char** argv) { usage(); break; } - char *outputfile=argv[4]; + char *outputfile=argv[OUTPUTFILE_ARG]; outputc=malloc(strlen(outputdir)+strlen(outputfile)+2); sprintf(outputc, "%s/%s", outputdir, outputfile);

1 0

Patch merged into coreboot/master: superio/smsc/mec1308: Fix IASL warnings
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit 56033a9f2d6ceed6ad27450d866be46eb49abf8b Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 14:34:51 2015 -0700 superio/smsc/mec1308: Fix IASL warnings The SIO device needs to provide an _ADR object with the IO address as well as the address in the OperationRegion. ACPI provides two different Resource Descriptor Macros to describe the I/O areas required for a device. The FixedIO macro is only valid for 10-bit IO addresses. Use the IO macro instead. Thank you to recent IASL that allows for addition in the ASL file. :) Fixes these warnings: dsdt.aml 2276: Device (SIO) { Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) dsdt.aml 2390: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) dsdt.aml 2394: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) Lumpy now compiles its ASL tables with no warnings. Re-enable Warnings as errors. Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12520 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/12520 for details. -gerrit

1 0

Patch set updated for coreboot: superio/smsc/mec1308: Fix IASL warnings
by Martin Roth 24 Nov '15

24 Nov '15

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12520 -gerrit commit 243e3e0f3c04489f026c722c5b1bc900bb955bb6 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 14:34:51 2015 -0700 superio/smsc/mec1308: Fix IASL warnings The SIO device needs to provide an _ADR object with the IO address as well as the address in the OperationRegion. ACPI provides two different Resource Descriptor Macros to describe the I/O areas required for a device. The FixedIO macro is only valid for 10-bit IO addresses. Use the IO macro instead. Thank you to recent IASL that allows for addition in the ASL file. :) Fixes these warnings: dsdt.aml 2276: Device (SIO) { Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) dsdt.aml 2390: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) dsdt.aml 2394: FixedIO (0xa00, 0x34) Warning 3060 - ^ Maximum 10-bit ISA address (0x3FF) Lumpy now compiles its ASL tables with no warnings. Re-enable Warnings as errors. Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/samsung/lumpy/Kconfig | 4 ---- src/superio/smsc/mec1308/acpi/superio.asl | 5 +++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 1660c27..ac19be5 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -64,8 +64,4 @@ config EARLY_PCI_MMIO_BASE endif -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_SAMSUNG_LUMPY diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index 7251259..6794448 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -16,6 +16,7 @@ // Scope is \_SB.PCI0.LPCB Device (SIO) { + Name (_ADR, 0x2E) OperationRegion (SIOA, SystemIO, 0x2E, 0x02) Field (SIOA, ByteAcc, NoLock, Preserve) { @@ -245,12 +246,12 @@ Device (SIO) { Name (_CRS, ResourceTemplate() { - FixedIO (SIO_SMBX_IO0, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) }) Name (_PRS, ResourceTemplate() { - FixedIO (SIO_SMBX_IO0, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) }) } #endif

1 0

Patch merged into coreboot/master: FSP 1.0: Fix CAR issues - broken timestamps and console
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit e597e63e49da740516732a2c8453bafdb7ac4fcd Author: Ben Gardner <gardner.ben(a)gmail.com> Date: Mon Nov 23 20:47:59 2015 -0600 FSP 1.0: Fix CAR issues - broken timestamps and console FSP 1.0 has a fixed-size temporary cache size and address and the entire cache is migrated in the FSP FspInitEntry() function. Previous code expected the symbol _car_data_start to be the same as CONFIG_DCACHE_RAM_BASE and _car_data_end to be the same as _preram_cbmem_console. FSP 1.0 is the only one that migrates _preram_cbmem_console. Others leave that where it is and extract the early console data in cbmemc_reinit(). Special handling is needed to handle that. Commit dd6fa93d broke both assumptions and so broke the timestamp table and console. The fix is to use CONFIG_DCACHE_RAM_BASE when calculating the offset and to use _preram_cbmem_console instead of _car_data_end for the console check. Change-Id: I6db109269b3537f7cb1300357c483ff2a745ffa7 Signed-off-by: Ben Gardner <gardner.ben(a)gmail.com> Reviewed-on: http://review.coreboot.org/12511 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> See http://review.coreboot.org/12511 for details. -gerrit

1 0

Patch merged into coreboot/master: intel/d945gclf: Fix IASL warning and remark
by gerrit＠coreboot.org 24 Nov '15

24 Nov '15

the following patch was just integrated into master: commit b9434aa853d75d38a5e051ca9a516621e9ca3605 Author: Martin Roth <martinroth(a)google.com> Date: Mon Nov 23 16:34:10 2015 -0700 intel/d945gclf: Fix IASL warning and remark - Add an empty Operating Region for the empty _REG method - Serialize _CRS Method - Remove Kconfig default disabling IASL warnings as errors dsdt.aml 1445: Method (_CRS, 0) Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) dsdt.aml 1454: Method (_REG, 2) Warning 3079 - ^ _REG has no corresponding Operation Region Change-Id: I2b64609c929af62c2b699762206e5baf58fbdb8b Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/12523 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/12523 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015