coreboot-gerrit October 2015

coreboot-gerrit@coreboot.org

1 participants
3945 discussions

Patch merged into coreboot/master: libpayload: Fix possible NULL deref in cbfs_get_file_content()
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit ac1f4b86f4a82f00c07aa21707703c5c70d9c604 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Oct 2 19:38:24 2015 +0200 libpayload: Fix possible NULL deref in cbfs_get_file_content() Change-Id: I2e10ccac3248717d90838ca721cc691de792b507 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/11780 Tested-by: build bot (Jenkins) Reviewed-by: Daisuke Nojiri <dnojiri(a)chromium.org> See http://review.coreboot.org/11780 for details. -gerrit

1 0

New patch to review for coreboot: libpayload: Fix possible NULL deref in cbfs_get_file_content()
by Nico Huber 02 Oct '15

02 Oct '15

Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11780 -gerrit commit 8f2f9feea98d61f2df2bddf0a2ebcbef72346df2 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Oct 2 19:38:24 2015 +0200 libpayload: Fix possible NULL deref in cbfs_get_file_content() Change-Id: I2e10ccac3248717d90838ca721cc691de792b507 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/libcbfs/cbfs_core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c index 4c898c6..369d946 100644 --- a/payloads/libpayload/libcbfs/cbfs_core.c +++ b/payloads/libpayload/libcbfs/cbfs_core.c @@ -207,14 +207,12 @@ void *cbfs_get_file_content(struct cbfs_media *media, const char *name, return NULL; } - if (sz) - *sz = ntohl(file->len); - void *file_content = (void *)CBFS_SUBHEADER(file); struct cbfs_file_attribute *attr = cbfs_file_find_attr(file, CBFS_FILE_ATTR_TAG_COMPRESSION); + size_t final_size = ntohl(file->len); int compression_algo = CBFS_COMPRESS_NONE; if (attr) { struct cbfs_file_attr_compression *comp = @@ -222,16 +220,19 @@ void *cbfs_get_file_content(struct cbfs_media *media, const char *name, compression_algo = ntohl(comp->compression); DEBUG("File '%s' is compressed (alg=%d)\n", name, compression_algo); - *sz = ntohl(comp->decompressed_size); + final_size = ntohl(comp->decompressed_size); } - void *dst = malloc(*sz); + void *dst = malloc(final_size); if (dst == NULL) goto err; - if (!cbfs_decompress(compression_algo, file_content, dst, *sz)) + if (!cbfs_decompress(compression_algo, file_content, dst, final_size)) goto err; + if (sz) + *sz = final_size; + media->unmap(media, file); return dst;

1 0

Patch merged into coreboot/master: cbfstool: relocate FSP blobs on cbfstool add
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 8a414a0943931bcedcfcbc5159d9a4b7e52a432f Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 17:02:45 2015 -0500 cbfstool: relocate FSP blobs on cbfstool add When adding an FSP blob relocate it to its final destination. This allows FSP to not be hard coded in the cbfs. In order for the include paths to work correctly w/ the edk 2 headers we need to supply a neutered ProcessorBind.h to match up with the tool environment such that one can get the UEFI Platform Initialization type definitions. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built glados and booted. Also added FSP with -b and manually adjusted location in fsp cache-as-ram. Booted as well. Change-Id: I830d93578fdf745a51195109cf18d94a83ee8cd3 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11778 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11778 for details. -gerrit

1 0

Patch merged into coreboot/master: vboot: provide CHIPSET_PROVIDES_VERSTAGE_MAIN_SYMBOL option
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 3c96e808f0bbe2957fc26bdc5e04900a8c5af58c Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 16:27:55 2015 -0500 vboot: provide CHIPSET_PROVIDES_VERSTAGE_MAIN_SYMBOL option Certain chipsets provide their own main symbol for verstage. Therefore, it's necessary to know this so that those chipsets can leverage the common verstage flow. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built nyan using this option. Change-Id: If80784aa47b27f0ad286babcf0f42ce198b929e9 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11777 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11777 for details. -gerrit

1 0

Patch merged into coreboot/master: tegra124: use the common verstage flow
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 5a4f289c42d1fb04e6e1f3973ed1f635b9f5dfb1 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 16:24:28 2015 -0500 tegra124: use the common verstage flow Though the tegra124 SoC makes their faster cpus come up in verstage it can still use the common flow. Therefore, use the common verstage API for performing thenecessary steps to initialize the caches on the faster cores. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built nyan. Change-Id: I93023ec92a9de111db688742b057b5c64143f0b3 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11776 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11776 for details. -gerrit

1 0

Patch merged into coreboot/master: broadcom/cygnus: remove verstage.c
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 4d7759691889daeb93d19ab4c905ed81632f14a7 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 16:23:16 2015 -0500 broadcom/cygnus: remove verstage.c The file was not referenced or used. Kill it. BUG=chrome-os-partner:44827 BRANCH=None TEST=None Change-Id: I30285d523ef3ca4dd3ce38b53aeb42862d929c90 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11775 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11775 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: provide printk() to cbfstool code
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit d38e3de68c1e32d86337622b3f3d4559aa04eb33 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 14:25:19 2015 -0500 cbfstool: provide printk() to cbfstool code For shared compilation units between coreboot proper and cbfstool that means one needs to provide printk logging. Therefore, provide printk() at <console/console.h> to mimic coreboot's environment. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built cbfstool with code that includes and uses <console/console.h>. Change-Id: I8e54d403526a397e4fd117738a367a0a7bb71637 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11774 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11774 for details. -gerrit

1 0

Patch merged into coreboot/master: commonlib/helpers.h: handle interaction with other environments
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 7ffcc0be63bc8f253c9d4d971ef75be19038963e Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Oct 1 14:20:57 2015 -0500 commonlib/helpers.h: handle interaction with other environments There are compiler settings and interactions with other header files that should be handled. First use __typeof__ instead of typeof because 'std' modes don't accept typeof. The __typeof__ variant works equally well on clang. The other change is to guard the helper macros so as not to trigger redefinition errors. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built cbfstool including commonlib/helpers.h Change-Id: I58890477cb17df14a9fa8b7af752a7c70769cf36 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11773 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11773 for details. -gerrit

1 0

Patch merged into coreboot/master: fsp1_1: move relocation algorithm to commonlib
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 04ebf598de6d8b8152c99ebe181de084e0b5b242 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Sep 30 17:49:04 2015 -0500 fsp1_1: move relocation algorithm to commonlib In order to support FSP 1.1 relocation within cbfstool the relocation code needs to be moved into commonlib. To that end, move it. The FSP 1.1 relocation code binds to edk2 UEFI 2.4 types unconditionally which is separate from the FSP's version binding. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built and booted glados. Change-Id: Ib2627d02af99092875ff885f7cb048f70ea73856 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11772 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11772 for details. -gerrit

1 0

Patch merged into coreboot/master: fsp1_1: use commonlib/endian.h routines
by gerrit＠coreboot.org 02 Oct '15

02 Oct '15

the following patch was just integrated into master: commit 923b4d5c581e7f4499e957fc1f042ee776c365a1 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Sep 30 16:48:26 2015 -0500 fsp1_1: use commonlib/endian.h routines Now that the commonlib/endian.h routines have landed utilize those in the FSP relocation code. BUG=chrome-os-partner:44827 BRANCH=None TEST=Built and booted glados. Change-Id: If431d64fd2843bea864d971ca1ea06b07c0d6435 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/11771 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11771 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2015