Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5646
-gerrit
commit 747ba177f382f625f3d0834537ffd971bcbf7b29
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat May 3 16:21:34 2014 +0200
lib/hexdump: Use `size_t` for length parameter of `hexdump32()`
In the signature of the function `hexdump32()` it does not make sense to
represent a length, assumed to be positive, as a signed integer.
With this change, it is no longer necessary to cast a pointer to
unsigned long when passing it to `hexdump32()`.
The same change for the function `hexdump()` was done in commit
3dd0e72d [1].
lib/hexdump: Take const void * and size_t as arguments
[1] http://review.coreboot.org/4575
Change-Id: Id97f5daff95f94e862ee8b5be896a6629b125a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/include/lib.h | 2 +-
src/lib/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/lib.h b/src/include/lib.h
index c272eb5..8f02004 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -52,6 +52,6 @@ extern unsigned char _estack[];
/* Defined in src/lib/hexdump.c */
void hexdump(const void *memory, size_t length);
-void hexdump32(char LEVEL, const void *d, int len);
+void hexdump32(char LEVEL, const void *d, size_t len);
#endif /* __LIB_H__ */
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 44a5aa4..a15c5cd 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -62,7 +62,7 @@ void hexdump(const void *memory, size_t length)
}
}
-void hexdump32(char LEVEL, const void *d, int len)
+void hexdump32(char LEVEL, const void *d, size_t len)
{
int count = 0;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5646
-gerrit
commit 121b9b3b27f8ebc5081dabe1ee287fb593cf90fb
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat May 3 16:21:34 2014 +0200
lib/hexdump: Use `size_t` for length argument of `hexdump32()`
In the signature of the function `hexdump32()` It does not make sense
to represent a length, assumed to be positive, as a signed integer.
With this change, it is no longer necessary to cast a pointer to
unsigned long when passing it to hexdump.
The same change for the function `hexdump()` was done in commit
3dd0e72d [1].
lib/hexdump: Take const void * and size_t as arguments
[1] http://review.coreboot.org/4575
Change-Id: Id97f5daff95f94e862ee8b5be896a6629b125a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/include/lib.h | 2 +-
src/lib/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/lib.h b/src/include/lib.h
index c272eb5..8f02004 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -52,6 +52,6 @@ extern unsigned char _estack[];
/* Defined in src/lib/hexdump.c */
void hexdump(const void *memory, size_t length);
-void hexdump32(char LEVEL, const void *d, int len);
+void hexdump32(char LEVEL, const void *d, size_t len);
#endif /* __LIB_H__ */
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 44a5aa4..a15c5cd 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -62,7 +62,7 @@ void hexdump(const void *memory, size_t length)
}
}
-void hexdump32(char LEVEL, const void *d, int len)
+void hexdump32(char LEVEL, const void *d, size_t len)
{
int count = 0;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5646
-gerrit
commit d17b62997ec19b299fb7c50c4f4cefea794b4936
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat May 3 16:21:34 2014 +0200
lib/hexdump: Use `size_t` for length argument of `hexdump32()`
In the signature of the function `hexdump32()` It does not make sense
to represent a length, assumed to be positive, as a signed integer.
With this change, it is no longer necessary to cast a pointer to
unsigned long when passing it to hexdump.
The same change for the function `hexdump()` was done in commit
3dd0e72d [1].
lib/hexdump: Take const void * and size_t as arguments
[1] http://review.coreboot.org/4575
Change-Id: Id97f5daff95f94e862ee8b5be896a6629b125a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/include/lib.h | 2 +-
src/lib/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/lib.h b/src/include/lib.h
index c272eb5..8f02004 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -52,6 +52,6 @@ extern unsigned char _estack[];
/* Defined in src/lib/hexdump.c */
void hexdump(const void *memory, size_t length);
-void hexdump32(char LEVEL, const void *d, int len);
+void hexdump32(char LEVEL, const void *d, size_t len);
#endif /* __LIB_H__ */
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 2624333..b007e82 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -62,7 +62,7 @@ void hexdump(const void *memory, size_t length)
}
}
-void hexdump32(char LEVEL, const void *d, int len)
+void hexdump32(char LEVEL, const void *d, size_t len)
{
int count = 0;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5646
-gerrit
commit 03f9ce3c98e5ec70299f8cac743ea6c5d7e2dfb4
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat May 3 16:21:34 2014 +0200
lib/hexdump: Use `size_t` for length argument of `hexdump32()`
In the signature of the function `hexdump32()` It does not make sense
to represent a length, assumed to be positive, as a signed integer.
With this change, it is no longer necessary to cast a pointer to
unsigned long when passing it to hexdump.
The same change for the function `hexdump()` was done in commit
3dd0e72d [1].
lib/hexdump: Take const void * and size_t as arguments
[1] http://review.coreboot.org/4575
Change-Id: Id97f5daff95f94e862ee8b5be896a6629b125a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/include/lib.h | 2 +-
src/lib/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/lib.h b/src/include/lib.h
index c272eb5..8f02004 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -52,6 +52,6 @@ extern unsigned char _estack[];
/* Defined in src/lib/hexdump.c */
void hexdump(const void *memory, size_t length);
-void hexdump32(char LEVEL, const void *d, int len);
+void hexdump32(char LEVEL, const void *d, size_t len);
#endif /* __LIB_H__ */
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 2624333..b007e82 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -62,7 +62,7 @@ void hexdump(const void *memory, size_t length)
}
}
-void hexdump32(char LEVEL, const void *d, int len)
+void hexdump32(char LEVEL, const void *d, size_t len)
{
int count = 0;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5397
-gerrit
commit 2be355b8cb5979ccc6228588cd0d641bc6813818
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Mar 22 23:22:29 2014 +0100
asrock/e350m1/mainboard.c: Power unused GPP PCIe clock pins off
According to the SB800 Register Reference Guide [1] the clock pins are
powered on (0xFF) by default. On the ASRock E350M1 not all GPP PCIe
devices are used, so power their clock pins off as there is no point in
leaving them enabled and it might even save a little bit of power.
The same is done for the board AMD Persimmon in commit 73be43a1 [2].
Persimmon: Disable the unused GPP PCIe clocks
Note that the board AMD Persimmon has a normal PCI slot, where the
ASRock E350M1 has a PCIe 2.0 x16 slot, usable for example for an
external graphics cards.
Felix Held measured directly on the board, that the Ethernet chip uses
GPP_CLK1 and the PCIe slot uses GPP_GFX_SLT.
[1] AMD SB800-Series Southbridges Register Reference Guide
Publication: #45482
Revision: 3.04
[2] http://review.coreboot.org/1876
Change-Id: Ibd839bb469f06cbbb8a50d6a0bc58ad967a1a5e1
Fix-proposed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/mainboard/asrock/e350m1/mainboard.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index a98a179..5d770a1 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -25,6 +25,8 @@
#include <cpu/amd/mtrr.h>
#include <device/pci_def.h>
#include <southbridge/amd/cimx/cimx_util.h>
+#include <agesawrapper.h>
+#include "SBPLATFORM.h"
//#define SMBUS_IO_BASE 0x6000
void set_pcie_reset(void);
@@ -54,6 +56,15 @@ static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ /* enable GPP CLK1 (Ethernet) and SLT_GFX_CLK (PCIe slot) (interleaved) */
+ /* disable GPP CLK0 and CLK2 thru GPP CLK8 */
+ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+ *(misc_mem_clk_cntrl + 0) = 0xF0;
+ *(misc_mem_clk_cntrl + 1) = 0x00;
+ *(misc_mem_clk_cntrl + 2) = 0x00;
+ *(misc_mem_clk_cntrl + 3) = 0x00;
+ *(misc_mem_clk_cntrl + 4) = 0xF0;
+
/*
* Initialize ASF registers to an arbitrary address because someone
* long ago set things up this way inside the SPD read code. The