Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7598
-gerrit
commit 9a39bcf2464e79665e90999853bc7f16f8274a94
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sat Nov 29 00:03:03 2014 +1100
ec: Use DEVICE_NOOP macro formalism over static stub func
The in source comment:
/* This function avoids an error on serial console. */
refers to the resource allocator needing to find a non-NULL
function pointer else complaints of "... missing read_resources"
will be spewed.
Unfortunately/fortunately (depending on the time of day) compiler
optimisers have gotten a bit better at optimising away no-op functions
leading to the very message these stubs attempted to avoid. By using
the DEVICE_NOOP formalism that is static inlined 'suggests' (not enforces)
to the compiler to keep these symbols around.
Change-Id: I182019627b6954a4020f9f70e9c829ce3135f63c
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/ec/compal/ene932/ec.c | 16 ++--------------
src/ec/quanta/ene_kb3940q/ec.c | 16 ++--------------
src/ec/quanta/it8518/ec.c | 16 ++--------------
3 files changed, 6 insertions(+), 42 deletions(-)
diff --git a/src/ec/compal/ene932/ec.c b/src/ec/compal/ene932/ec.c
index 4bf6727..91c979e 100644
--- a/src/ec/compal/ene932/ec.c
+++ b/src/ec/compal/ene932/ec.c
@@ -142,22 +142,10 @@ static void ene932_init(struct device *dev)
}
-
-static void ene932_read_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
-
-static void ene932_enable_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
static struct device_operations ops = {
.init = ene932_init,
- .read_resources = ene932_read_resources,
- .enable_resources = ene932_enable_resources
+ .read_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
};
static struct pnp_info pnp_dev_info[] = {
diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c
index dcd9c4a..d7539fc 100644
--- a/src/ec/quanta/ene_kb3940q/ec.c
+++ b/src/ec/quanta/ene_kb3940q/ec.c
@@ -152,22 +152,10 @@ static void ene_kb3940q_init(struct device *dev)
ene_kb3940q_log_events();
}
-
-static void ene_kb3940q_read_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
-
-static void ene_kb3940q_enable_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
static struct device_operations ops = {
.init = ene_kb3940q_init,
- .read_resources = ene_kb3940q_read_resources,
- .enable_resources = ene_kb3940q_enable_resources
+ .read_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
};
static struct pnp_info pnp_dev_info[] = {
diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c
index cd976e6..5ce5c6c 100644
--- a/src/ec/quanta/it8518/ec.c
+++ b/src/ec/quanta/it8518/ec.c
@@ -165,22 +165,10 @@ static void it8518_init(struct device *dev)
pc_keyboard_init();
}
-
-static void it8518_read_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
-
-static void it8518_enable_resources(struct device *dev)
-{
- /* This function avoids an error on serial console. */
-}
-
static struct device_operations ops = {
.init = it8518_init,
- .read_resources = it8518_read_resources,
- .enable_resources = it8518_enable_resources
+ .read_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
};
static struct pnp_info pnp_dev_info[] = {
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7595
-gerrit
commit 9b301e21b2551a8a359f0b09fce956298d77acf8
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Nov 27 13:37:37 2014 +0100
3rdparty: Update to latest commit in blobs repository
Update to commit 9f68e20e (AMD KaveriPI: Add PI header files to support
binary AGESA release), which is the latest commit in the blobs
repository.
Change-Id: I3d643f7565700272c22b59ed764c3269801f4413
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
3rdparty | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/3rdparty b/3rdparty
index 27bdb5e..9f68e20 160000
--- a/3rdparty
+++ b/3rdparty
@@ -1 +1 @@
-Subproject commit 27bdb5e8a61274e3a59a13dd13dd8b4b649de68c
+Subproject commit 9f68e20e5ef4b6681fb18bdb4022471bc6810788
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7593
-gerrit
commit daa64ad12b1f337b30b8e37f235336e1752b9470
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Fri Nov 28 20:36:36 2014 +1100
mainboard/lenovo/g505s/devicetree.cb: Disable pci 14.4 bridge
14.4 does not seem to be writed on the board even though it is
enabled in the vendor BIOS. Disable as it seems to help with S3
working for some reason. It is also a bad idea to drive unconnected
pins.
Change-Id: Ibd95e3fb4bed6a9ff7d98e76c07139c81b4e4df5
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/mainboard/lenovo/g505s/devicetree.cb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb
index 4dc4a14..cc0bedc 100644
--- a/src/mainboard/lenovo/g505s/devicetree.cb
+++ b/src/mainboard/lenovo/g505s/devicetree.cb
@@ -64,7 +64,7 @@ chip northbridge/amd/agesa/family15rl/root_complex
device pnp ff.1 on end # dummy address
end
end
- device pci 14.4 on end # FCH PCI Bridge [1022:780f]
+ device pci 14.4 off end # FCH PCI Bridge [1022:780f] (disabled for S3 to work)
device pci 14.5 off end # USB 2
device pci 14.6 off end # Gec
device pci 14.7 off end # SD