October 2014 - coreboot-gerrit

New patch to review for coreboot: 17809b3 drivers/net/ne2k.c: Collect headers and defines to top of file
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7292 -gerrit commit 17809b3190ab3c40bb7b2b0b7d5ebdaedbafc931 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 12:37:49 2014 +1100 drivers/net/ne2k.c: Collect headers and defines to top of file Change-Id: I2ffb0dd9fe400132f6d430f115f962b5f8578efa Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/net/ne2k.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index b678d79..ac5230a 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -34,15 +34,25 @@ SMC8416 PIO support added by Andrew Bettison (andrewb(a)zip.com.au) on 4/3/02 #define ETH_DATA_ALIGN 2 /* Amount needed to align the data after an ethernet header */ #define ETH_MAX_MTU (ETH_FRAME_LEN-ETH_HLEN) -#include "ns8390.h" -#include <ip_checksum.h> -#include <console/ne2k.h> -#include <arch/io.h> - #define MEM_SIZE MEM_32768 #define TX_START 64 #define RX_START (64 + D8390_TXBUF_SIZE) +#include <arch/io.h> +#include <console/console.h> +#include <console/ne2k.h> +#include <delay.h> +#include <device/device.h> +#include <device/pci.h> +#include <device/pci_ids.h> +#include <device/pci_ops.h> +#include <stdlib.h> +#include <string.h> +#include <ip_checksum.h> + +#include "ns8390.h" + + static unsigned int get_count(unsigned int eth_nic_base) { unsigned int ret; @@ -415,17 +425,6 @@ int ne2k_init(unsigned int eth_nic_base) { #else -#include <delay.h> -#include <stdlib.h> -#include <string.h> -#include <arch/io.h> - -#include <console/console.h> -#include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> -#include <device/pci_ops.h> - static void read_resources(struct device *dev) { struct resource *res; @@ -455,4 +454,4 @@ static const struct pci_driver ne2k_driver __pci_driver = { .device = 0x8029, }; -#endif +#endif /* __PRE_RAM__ */

1 0

Patch set updated for coreboot: 59749f1 include/device/device.h: Provide DEVICE_NOOP macro shim
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7283 -gerrit commit 59749f113b65a98d2d50a5ade0538ff960eacae2 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:31:44 2014 +1100 include/device/device.h: Provide DEVICE_NOOP macro shim Rather than everyone writing their own adhoc device operation NOP shim, we provide some formalism. We later make use of this to reduce the loc count down trivially. Change-Id: I2d04bfb50e76f367a0ee258dab97d7caa12ec99e Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/include/device/device.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/include/device/device.h b/src/include/device/device.h index 3810716..c67205c 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -66,6 +66,12 @@ struct device_operations { const struct pnp_mode_ops *ops_pnp_mode; }; +/** + * Standard device operations function pointers shims. + */ +static inline void device_noop(struct device *dev) {} +#define DEVICE_NOOP device_noop + #endif /* ! __SIMPLE_DEVICE__ */

1 0

Patch set updated for coreboot: e78c1cc {cpu, soc}: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7285 -gerrit commit e78c1cc01694491b35335e33fda53c845c983093 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:03:16 2014 +1100 {cpu,soc}: Use DEVICE_NOOP macro over dummy symbol Change-Id: Iaf2b2873bd1c52d7f936bd9b483e194a0872a626 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/cpu/allwinner/a10/cpu.c | 8 ++------ src/cpu/amd/sc520/sc520.c | 13 +++---------- src/soc/intel/baytrail/chip.c | 8 +++----- src/soc/intel/broadwell/chip.c | 8 +++----- src/soc/intel/fsp_baytrail/chip.c | 8 +++----- src/soc/nvidia/tegra124/soc.c | 8 ++------ src/soc/samsung/exynos5250/cpu.c | 8 ++------ src/soc/samsung/exynos5420/cpu.c | 8 ++------ 8 files changed, 20 insertions(+), 49 deletions(-) diff --git a/src/cpu/allwinner/a10/cpu.c b/src/cpu/allwinner/a10/cpu.c index fac5730..3159f20 100644 --- a/src/cpu/allwinner/a10/cpu.c +++ b/src/cpu/allwinner/a10/cpu.c @@ -25,13 +25,9 @@ static void cpu_init(struct device *dev) /* TODO: Check if anything else needs to be explicitly initialized */ } -static void cpu_noop(struct device *dev) -{ -} - static struct device_operations cpu_ops = { - .read_resources = cpu_noop, - .set_resources = cpu_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = cpu_enable_resources, .init = cpu_init, .scan_bus = NULL, diff --git a/src/cpu/amd/sc520/sc520.c b/src/cpu/amd/sc520/sc520.c index 808c33c..0521544 100644 --- a/src/cpu/amd/sc520/sc520.c +++ b/src/cpu/amd/sc520/sc520.c @@ -44,9 +44,6 @@ static void sc520_enable_resources(struct device *dev) { pci_write_config8(dev, PCI_COMMAND, command); command = pci_read_config8(dev, PCI_COMMAND); printk(BIOS_SPEW, "========>%s, command 0x%x\n", __func__, command); -/* - */ - } static void sc520_read_resources(device_t dev) @@ -170,14 +167,10 @@ static void cpu_bus_init(device_t dev) printk(BIOS_SPEW, "cpu_bus_init\n"); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/soc/intel/baytrail/chip.c b/src/soc/intel/baytrail/chip.c index ce9eb49..7a5b9c2 100644 --- a/src/soc/intel/baytrail/chip.c +++ b/src/soc/intel/baytrail/chip.c @@ -40,12 +40,10 @@ static struct device_operations pci_domain_ops = { .ops_pci_bus = pci_bus_default_ops, }; -static void cpu_bus_noop(device_t dev) { } - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = baytrail_init_cpus, .scan_bus = NULL, }; diff --git a/src/soc/intel/broadwell/chip.c b/src/soc/intel/broadwell/chip.c index 94f7893..2a12820 100644 --- a/src/soc/intel/broadwell/chip.c +++ b/src/soc/intel/broadwell/chip.c @@ -36,12 +36,10 @@ static struct device_operations pci_domain_ops = { .ops_pci_bus = &pci_ops_mmconf, }; -static void cpu_bus_noop(device_t dev) { } - static struct device_operations cpu_bus_ops = { - .read_resources = &cpu_bus_noop, - .set_resources = &cpu_bus_noop, - .enable_resources = &cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = &broadwell_init_cpus, }; diff --git a/src/soc/intel/fsp_baytrail/chip.c b/src/soc/intel/fsp_baytrail/chip.c index 839e8dc..732d1dc 100644 --- a/src/soc/intel/fsp_baytrail/chip.c +++ b/src/soc/intel/fsp_baytrail/chip.c @@ -50,12 +50,10 @@ static struct device_operations pci_domain_ops = { .ops_pci_bus = pci_bus_default_ops, }; -static void cpu_bus_noop(device_t dev) { } - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = baytrail_init_cpus, .scan_bus = NULL, }; diff --git a/src/soc/nvidia/tegra124/soc.c b/src/soc/nvidia/tegra124/soc.c index 11a52c4..8ad1aa9 100644 --- a/src/soc/nvidia/tegra124/soc.c +++ b/src/soc/nvidia/tegra124/soc.c @@ -45,13 +45,9 @@ static void soc_init(device_t dev) printk(BIOS_INFO, "CPU: Tegra124\n"); } -static void soc_noop(device_t dev) -{ -} - static struct device_operations soc_ops = { - .read_resources = soc_noop, - .set_resources = soc_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = soc_enable, .init = soc_init, .scan_bus = 0, diff --git a/src/soc/samsung/exynos5250/cpu.c b/src/soc/samsung/exynos5250/cpu.c index b8b88d7..60fa55a 100644 --- a/src/soc/samsung/exynos5250/cpu.c +++ b/src/soc/samsung/exynos5250/cpu.c @@ -129,13 +129,9 @@ static void cpu_init(device_t dev) cpu_id, get_arm_clk() / (1024*1024)); } -static void cpu_noop(device_t dev) -{ -} - static struct device_operations cpu_ops = { - .read_resources = cpu_noop, - .set_resources = cpu_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = cpu_enable, .init = cpu_init, .scan_bus = 0, diff --git a/src/soc/samsung/exynos5420/cpu.c b/src/soc/samsung/exynos5420/cpu.c index 506b676..c904636 100644 --- a/src/soc/samsung/exynos5420/cpu.c +++ b/src/soc/samsung/exynos5420/cpu.c @@ -160,13 +160,9 @@ static void cpu_init(device_t dev) cpu_id, get_arm_clk() / 1000000); } -static void cpu_noop(device_t dev) -{ -} - static struct device_operations cpu_ops = { - .read_resources = cpu_noop, - .set_resources = cpu_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = cpu_enable, .init = cpu_init, .scan_bus = 0,

1 0

Patch set updated for coreboot: e725ec9 drivers: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7284 -gerrit commit e725ec9de7d42d0c9e8fd590e3396e3fdf32d4b7 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 07:55:45 2014 +1100 drivers: Use DEVICE_NOOP macro over dummy symbol Change-Id: I931bd9c89bce6ac8f8e9e482a7876e2004abfb38 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/i2c/adm1026/adm1026.c | 10 +++------- src/drivers/i2c/adm1027/adm1027.c | 10 +++------- src/drivers/i2c/adt7463/adt7463.c | 10 +++------- src/drivers/i2c/at24rf08c/at24rf08c.c | 10 +++------- src/drivers/i2c/i2cmux/i2cmux.c | 12 ++++-------- src/drivers/i2c/i2cmux2/i2cmux2.c | 12 ++++-------- src/drivers/i2c/lm63/lm63.c | 10 +++------- src/drivers/i2c/rtd2132/rtd2132.c | 10 +++------- src/drivers/i2c/w83793/w83793.c | 10 +++------- src/drivers/i2c/w83795/w83795.c | 10 +++------- src/drivers/ics/954309/ics954309.c | 10 +++------- 11 files changed, 35 insertions(+), 79 deletions(-) diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c index e8baea1..592916a 100644 --- a/src/drivers/i2c/adm1026/adm1026.c +++ b/src/drivers/i2c/adm1026/adm1026.c @@ -44,14 +44,10 @@ static void adm1026_init(struct device *dev) } } -static void adm1026_noop(struct device *dummy) -{ -} - static struct device_operations adm1026_operations = { - .read_resources = adm1026_noop, - .set_resources = adm1026_noop, - .enable_resources = adm1026_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adm1026_init, }; diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c index 9841c81..4e67e4d 100644 --- a/src/drivers/i2c/adm1027/adm1027.c +++ b/src/drivers/i2c/adm1027/adm1027.c @@ -50,14 +50,10 @@ static void adm1027_init(struct device *dev) } } -static void adm1027_noop(struct device *dummy) -{ -} - static struct device_operations adm1027_operations = { - .read_resources = adm1027_noop, - .set_resources = adm1027_noop, - .enable_resources = adm1027_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adm1027_init, }; diff --git a/src/drivers/i2c/adt7463/adt7463.c b/src/drivers/i2c/adt7463/adt7463.c index dd6d837..2fb42a9 100644 --- a/src/drivers/i2c/adt7463/adt7463.c +++ b/src/drivers/i2c/adt7463/adt7463.c @@ -85,14 +85,10 @@ static void adt7463_init(struct device *adt7463) printk(BIOS_DEBUG, "ADT7463 properly initialized\n"); } -static void adt7463_noop(struct device *dummy) -{ -} - static struct device_operations adt7463_operations = { - .read_resources = adt7463_noop, - .set_resources = adt7463_noop, - .enable_resources = adt7463_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adt7463_init, }; diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index a03564f..a9b821a 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -52,14 +52,10 @@ static void at24rf08c_init(struct device *dev) printk (BIOS_DEBUG, "init EEPROM done\n"); } -static void at24rf08c_noop(struct device *dummy) -{ -} - static struct device_operations at24rf08c_operations = { - .read_resources = at24rf08c_noop, - .set_resources = at24rf08c_noop, - .enable_resources = at24rf08c_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = at24rf08c_init, }; diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c index d8ad40b..1091653 100644 --- a/src/drivers/i2c/i2cmux/i2cmux.c +++ b/src/drivers/i2c/i2cmux/i2cmux.c @@ -16,15 +16,11 @@ static void i2cmux_set_link(struct device *dev, unsigned int link) } } -static void i2cmux_noop(struct device *dummy) -{ -} - static struct device_operations i2cmux_operations = { - .read_resources = i2cmux_noop, - .set_resources = i2cmux_noop, - .enable_resources = i2cmux_noop, - .init = i2cmux_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = DEVICE_NOOP, .scan_bus = scan_static_bus, .set_link = i2cmux_set_link, }; diff --git a/src/drivers/i2c/i2cmux2/i2cmux2.c b/src/drivers/i2c/i2cmux2/i2cmux2.c index 6b05508..fe48e76 100644 --- a/src/drivers/i2c/i2cmux2/i2cmux2.c +++ b/src/drivers/i2c/i2cmux2/i2cmux2.c @@ -15,15 +15,11 @@ static void i2cmux2_set_link(struct device *dev, unsigned int link) } } -static void i2cmux2_noop(struct device *dummy) -{ -} - static struct device_operations i2cmux2_operations = { - .read_resources = i2cmux2_noop, - .set_resources = i2cmux2_noop, - .enable_resources = i2cmux2_noop, - .init = i2cmux2_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = DEVICE_NOOP, .scan_bus = scan_static_bus, .set_link = i2cmux2_set_link, }; diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c index b64751e..3ce5fd8 100644 --- a/src/drivers/i2c/lm63/lm63.c +++ b/src/drivers/i2c/lm63/lm63.c @@ -21,14 +21,10 @@ static void lm63_init(struct device *dev) } } -static void lm63_noop(struct device *dummy) -{ -} - static struct device_operations lm63_operations = { - .read_resources = lm63_noop, - .set_resources = lm63_noop, - .enable_resources = lm63_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = lm63_init, }; diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c index 4dbfb41..7bb2146 100644 --- a/src/drivers/i2c/rtd2132/rtd2132.c +++ b/src/drivers/i2c/rtd2132/rtd2132.c @@ -241,14 +241,10 @@ static void rtd2132_init(struct device *dev) } } -static void rtd2132_noop(struct device *dummy) -{ -} - static struct device_operations rtd2132_operations = { - .read_resources = rtd2132_noop, - .set_resources = rtd2132_noop, - .enable_resources = rtd2132_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = rtd2132_init, }; diff --git a/src/drivers/i2c/w83793/w83793.c b/src/drivers/i2c/w83793/w83793.c index 732fdb4..4b947d7 100644 --- a/src/drivers/i2c/w83793/w83793.c +++ b/src/drivers/i2c/w83793/w83793.c @@ -220,14 +220,10 @@ static void w83793_init(struct device *dev) } -static void w83793_noop(struct device *dummy) -{ -} - static struct device_operations w83793_operations = { - .read_resources = w83793_noop, - .set_resources = w83793_noop, - .enable_resources = w83793_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = w83793_init, }; diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c index 5559666..569fe5a 100644 --- a/src/drivers/i2c/w83795/w83795.c +++ b/src/drivers/i2c/w83795/w83795.c @@ -239,14 +239,10 @@ static void w83795_hwm_init(struct device *dev) printk(BIOS_ERR, "Neither AMD nor INTEL CPU detected\n"); } -static void w83795_noop(struct device *dummy) -{ -} - static struct device_operations w83795_operations = { - .read_resources = w83795_noop, - .set_resources = w83795_noop, - .enable_resources = w83795_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = w83795_hwm_init, }; diff --git a/src/drivers/ics/954309/ics954309.c b/src/drivers/ics/954309/ics954309.c index 0aa15c0..fda37af 100644 --- a/src/drivers/ics/954309/ics954309.c +++ b/src/drivers/ics/954309/ics954309.c @@ -55,14 +55,10 @@ static void ics954309_init(struct device *dev) smbus_block_write(dev, 0, 12, initdata); } -static void ics954309_noop(struct device *dummy) -{ -} - static struct device_operations ics954309_operations = { - .read_resources = ics954309_noop, - .set_resources = ics954309_noop, - .enable_resources = ics954309_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = ics954309_init, };

1 0

Patch set updated for coreboot: 43172cb northbridge/intel: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7287 -gerrit commit 43172cb0c49e349d58650f03c3ca600dc2d275f3 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:12:34 2014 +1100 northbridge/intel: Use DEVICE_NOOP macro over dummy symbol Change-Id: I9aeed70f72d4df260312df6e53379f1741415b65 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/intel/e7501/northbridge.c | 10 +++------- src/northbridge/intel/e7505/northbridge.c | 10 +++------- src/northbridge/intel/e7520/northbridge.c | 10 +++------- src/northbridge/intel/e7525/northbridge.c | 10 +++------- src/northbridge/intel/fsp_rangeley/northbridge.c | 11 +++-------- src/northbridge/intel/fsp_sandybridge/northbridge.c | 11 +++-------- src/northbridge/intel/gm45/northbridge.c | 10 +++------- src/northbridge/intel/haswell/northbridge.c | 10 +++------- src/northbridge/intel/i3100/northbridge.c | 10 +++------- src/northbridge/intel/i440bx/northbridge.c | 10 +++------- src/northbridge/intel/i440lx/northbridge.c | 10 +++------- src/northbridge/intel/i5000/northbridge.c | 9 +++------ src/northbridge/intel/i82810/northbridge.c | 10 +++------- src/northbridge/intel/i82830/northbridge.c | 10 +++------- src/northbridge/intel/i855/northbridge.c | 10 +++------- src/northbridge/intel/i945/northbridge.c | 10 +++------- src/northbridge/intel/nehalem/northbridge.c | 10 +++------- src/northbridge/intel/sandybridge/northbridge.c | 10 +++------- src/northbridge/intel/sch/northbridge.c | 10 +++------- 19 files changed, 57 insertions(+), 134 deletions(-) diff --git a/src/northbridge/intel/e7501/northbridge.c b/src/northbridge/intel/e7501/northbridge.c index 2efa787..64bf840 100644 --- a/src/northbridge/intel/e7501/northbridge.c +++ b/src/northbridge/intel/e7501/northbridge.c @@ -115,14 +115,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/e7505/northbridge.c b/src/northbridge/intel/e7505/northbridge.c index 54c700b..08cd023 100644 --- a/src/northbridge/intel/e7505/northbridge.c +++ b/src/northbridge/intel/e7505/northbridge.c @@ -122,14 +122,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/e7520/northbridge.c b/src/northbridge/intel/e7520/northbridge.c index c632b2d..6e0379e 100644 --- a/src/northbridge/intel/e7520/northbridge.c +++ b/src/northbridge/intel/e7520/northbridge.c @@ -175,14 +175,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/e7525/northbridge.c b/src/northbridge/intel/e7525/northbridge.c index 7625596..68fdc74 100644 --- a/src/northbridge/intel/e7525/northbridge.c +++ b/src/northbridge/intel/e7525/northbridge.c @@ -174,14 +174,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c index 98c0b9c..07ce21f 100644 --- a/src/northbridge/intel/fsp_rangeley/northbridge.c +++ b/src/northbridge/intel/fsp_rangeley/northbridge.c @@ -263,15 +263,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } - -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c index a164536..da27b25 100644 --- a/src/northbridge/intel/fsp_sandybridge/northbridge.c +++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c @@ -380,15 +380,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } - -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c index e93d036..716ee62 100644 --- a/src/northbridge/intel/gm45/northbridge.c +++ b/src/northbridge/intel/gm45/northbridge.c @@ -212,14 +212,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index 1b4658a..4909824 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -485,14 +485,10 @@ static void cpu_bus_init(device_t dev) bsp_init_and_start_aps(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i3100/northbridge.c b/src/northbridge/intel/i3100/northbridge.c index 589c9c5..2cf5ae1 100644 --- a/src/northbridge/intel/i3100/northbridge.c +++ b/src/northbridge/intel/i3100/northbridge.c @@ -224,14 +224,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i440bx/northbridge.c b/src/northbridge/intel/i440bx/northbridge.c index 1e6b58e..12ff37b 100644 --- a/src/northbridge/intel/i440bx/northbridge.c +++ b/src/northbridge/intel/i440bx/northbridge.c @@ -86,14 +86,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i440lx/northbridge.c b/src/northbridge/intel/i440lx/northbridge.c index ca4ec6e..60e62c1 100644 --- a/src/northbridge/intel/i440lx/northbridge.c +++ b/src/northbridge/intel/i440lx/northbridge.c @@ -112,14 +112,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i5000/northbridge.c b/src/northbridge/intel/i5000/northbridge.c index c28b0c1..a9b3560 100644 --- a/src/northbridge/intel/i5000/northbridge.c +++ b/src/northbridge/intel/i5000/northbridge.c @@ -144,13 +144,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i82810/northbridge.c b/src/northbridge/intel/i82810/northbridge.c index 9d10f1d..ce0dc20 100644 --- a/src/northbridge/intel/i82810/northbridge.c +++ b/src/northbridge/intel/i82810/northbridge.c @@ -141,14 +141,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i82830/northbridge.c b/src/northbridge/intel/i82830/northbridge.c index c78bdf1..4898aaf 100644 --- a/src/northbridge/intel/i82830/northbridge.c +++ b/src/northbridge/intel/i82830/northbridge.c @@ -108,14 +108,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i855/northbridge.c b/src/northbridge/intel/i855/northbridge.c index 5c0379c..fce7d57 100644 --- a/src/northbridge/intel/i855/northbridge.c +++ b/src/northbridge/intel/i855/northbridge.c @@ -124,14 +124,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c index 815d4bf..91c5c82 100644 --- a/src/northbridge/intel/i945/northbridge.c +++ b/src/northbridge/intel/i945/northbridge.c @@ -279,14 +279,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index a31e85c..11d335a 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -329,14 +329,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 7494612..55395ea 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -476,14 +476,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/intel/sch/northbridge.c b/src/northbridge/intel/sch/northbridge.c index 1f327c6..c552879 100644 --- a/src/northbridge/intel/sch/northbridge.c +++ b/src/northbridge/intel/sch/northbridge.c @@ -297,14 +297,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, };

1 0

Patch set updated for coreboot: 93438c7 mainboard: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7286 -gerrit commit 93438c76fb689ad851b9affc51de5e18173ae490 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:04:30 2014 +1100 mainboard: Use DEVICE_NOOP macro over dummy symbol Change-Id: I37c302c7a17645f55d568c1a5f7bb791319ddbb4 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/emulation/qemu-i440fx/northbridge.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 0f8c0c2..2714052 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -262,14 +262,10 @@ static unsigned int cpu_bus_scan(device_t bus, unsigned int max) return max_cpus; } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, };

1 0

Patch set updated for coreboot: a000235 northbridge/via: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7289 -gerrit commit a000235d4eb34ebf850703fae83713b9776ac248 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:26:21 2014 +1100 northbridge/via: Use DEVICE_NOOP macro over dummy symbol Change-Id: Ib9d0fae363c5c1fbed3a63cb8aa86716cf1f9ee1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/via/cn400/agp.c | 2 +- src/northbridge/via/cn400/cn400.h | 7 ------- src/northbridge/via/cn400/northbridge.c | 18 +++++++----------- src/northbridge/via/cn400/vlink.c | 18 +++++++++--------- src/northbridge/via/cn700/agp.c | 4 ++-- src/northbridge/via/cn700/cn700.h | 7 ------- src/northbridge/via/cn700/northbridge.c | 12 ++++-------- src/northbridge/via/cx700/agp.c | 6 +----- src/northbridge/via/cx700/northbridge.c | 10 +++------- src/northbridge/via/vt8601/northbridge.c | 10 +++------- src/northbridge/via/vt8623/northbridge.c | 10 +++------- src/northbridge/via/vx800/northbridge.c | 12 ++++-------- src/northbridge/via/vx800/vx800.h | 7 ------- src/northbridge/via/vx900/northbridge.c | 10 +++------- 14 files changed, 40 insertions(+), 93 deletions(-) diff --git a/src/northbridge/via/cn400/agp.c b/src/northbridge/via/cn400/agp.c index ce814c5..ece71e0 100644 --- a/src/northbridge/via/cn400/agp.c +++ b/src/northbridge/via/cn400/agp.c @@ -128,7 +128,7 @@ static void agp_init(device_t dev) } static const struct device_operations agp_operations = { - .read_resources = cn400_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = agp_init, diff --git a/src/northbridge/via/cn400/cn400.h b/src/northbridge/via/cn400/cn400.h index 2df30a6..4921bef 100644 --- a/src/northbridge/via/cn400/cn400.h +++ b/src/northbridge/via/cn400/cn400.h @@ -18,13 +18,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef __PRE_RAM__ -// HACK -static inline void cn400_noop(device_t dev) -{ -} -#endif - #define DEBUG_CN400 /* VGA stuff */ diff --git a/src/northbridge/via/cn400/northbridge.c b/src/northbridge/via/cn400/northbridge.c index 149eab3..b797179 100644 --- a/src/northbridge/via/cn400/northbridge.c +++ b/src/northbridge/via/cn400/northbridge.c @@ -127,10 +127,10 @@ static void memctrl_init(device_t dev) } static const struct device_operations memctrl_operations = { - .read_resources = cn400_noop, - .set_resources = cn400_noop, - .enable_resources = cn400_noop, - .init = memctrl_init, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = memctrl_init, .ops_pci = 0, }; @@ -241,14 +241,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/cn400/vlink.c b/src/northbridge/via/cn400/vlink.c index c98982e..2319e75 100644 --- a/src/northbridge/via/cn400/vlink.c +++ b/src/northbridge/via/cn400/vlink.c @@ -158,9 +158,9 @@ static void c3_host_init(device_t dev) } static const struct device_operations c3_host_operations = { - .read_resources = cn400_noop, - .set_resources = cn400_noop, - .enable_resources = cn400_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = c3_host_init, .ops_pci = 0, }; @@ -195,9 +195,9 @@ static void c3_err_init(device_t dev) } static const struct device_operations c3_err_operations = { - .read_resources = cn400_noop, - .set_resources = cn400_noop, - .enable_resources = cn400_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = c3_err_init, .ops_pci = 0, }; @@ -231,9 +231,9 @@ static void cn400_pm_init(device_t dev) } static const struct device_operations cn400_pm_operations = { - .read_resources = cn400_noop, - .set_resources = cn400_noop, - .enable_resources = cn400_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cn400_pm_init, .ops_pci = 0, }; diff --git a/src/northbridge/via/cn700/agp.c b/src/northbridge/via/cn700/agp.c index e5a0fd0..fce61b4 100644 --- a/src/northbridge/via/cn700/agp.c +++ b/src/northbridge/via/cn700/agp.c @@ -104,7 +104,7 @@ static void agp_init(device_t dev) } static const struct device_operations agp_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = agp_init, @@ -157,7 +157,7 @@ static void agp_bridge_init(device_t dev) } static const struct device_operations agp_bridge_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_bus_enable_resources, .init = agp_bridge_init, diff --git a/src/northbridge/via/cn700/cn700.h b/src/northbridge/via/cn700/cn700.h index ff1d4b3..3cbc3dd 100644 --- a/src/northbridge/via/cn700/cn700.h +++ b/src/northbridge/via/cn700/cn700.h @@ -18,13 +18,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#if !defined (__PRE_RAM__) -// HACK -static inline void cn700_noop(device_t dev) -{ -} -#endif - /* VGA stuff */ #define SR_INDEX 0x3c4 #define SR_DATA 0x3c5 diff --git a/src/northbridge/via/cn700/northbridge.c b/src/northbridge/via/cn700/northbridge.c index a326baf..506bdd1 100644 --- a/src/northbridge/via/cn700/northbridge.c +++ b/src/northbridge/via/cn700/northbridge.c @@ -87,7 +87,7 @@ static void memctrl_init(device_t dev) } static const struct device_operations memctrl_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .init = memctrl_init, }; @@ -161,14 +161,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/cx700/agp.c b/src/northbridge/via/cx700/agp.c index f80d7d1..06475cc 100644 --- a/src/northbridge/via/cx700/agp.c +++ b/src/northbridge/via/cx700/agp.c @@ -72,12 +72,8 @@ static void agp_bridge_init(device_t dev) pci_write_config8(dev, 0x44, 0x34); } -static void cx700_noop(device_t dev) -{ -} - static struct device_operations agp_bridge_operations = { - .read_resources = cx700_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_bus_enable_resources, .init = agp_bridge_init, diff --git a/src/northbridge/via/cx700/northbridge.c b/src/northbridge/via/cx700/northbridge.c index e3314ff..cc9dabd 100644 --- a/src/northbridge/via/cx700/northbridge.c +++ b/src/northbridge/via/cx700/northbridge.c @@ -117,14 +117,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/vt8601/northbridge.c b/src/northbridge/via/vt8601/northbridge.c index bed434d..1887491 100644 --- a/src/northbridge/via/vt8601/northbridge.c +++ b/src/northbridge/via/vt8601/northbridge.c @@ -107,14 +107,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/vt8623/northbridge.c b/src/northbridge/via/vt8623/northbridge.c index 6e0f4ea..546db4c 100644 --- a/src/northbridge/via/vt8623/northbridge.c +++ b/src/northbridge/via/vt8623/northbridge.c @@ -167,14 +167,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/vx800/northbridge.c b/src/northbridge/via/vx800/northbridge.c index 214ca8b..fad0c2f 100644 --- a/src/northbridge/via/vx800/northbridge.c +++ b/src/northbridge/via/vx800/northbridge.c @@ -61,7 +61,7 @@ static void memctrl_init(device_t dev) } static const struct device_operations memctrl_operations = { - .read_resources = vx800_noop, + .read_resources = DEVICE_NOOP, .init = memctrl_init, }; @@ -150,14 +150,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/via/vx800/vx800.h b/src/northbridge/via/vx800/vx800.h index adfe272..ae944ef 100644 --- a/src/northbridge/via/vx800/vx800.h +++ b/src/northbridge/via/vx800/vx800.h @@ -20,13 +20,6 @@ #ifndef VX800_H #define VX800_H 1 -#ifndef __PRE_RAM__ -#include <device/device.h> -static inline void vx800_noop(device_t dev) -{ -} -#endif - #ifdef __PRE_RAM__ /* vx800_early_smbus.c */ struct mem_controller; diff --git a/src/northbridge/via/vx900/northbridge.c b/src/northbridge/via/vx900/northbridge.c index 53cada3..f9c225d 100644 --- a/src/northbridge/via/vx900/northbridge.c +++ b/src/northbridge/via/vx900/northbridge.c @@ -322,14 +322,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, };

1 0

Patch set updated for coreboot: 5ec4ce1 northbridge/amd: Use DEVICE_NOOP macro over dummy symbol
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7288 -gerrit commit 5ec4ce17839291ba758fc0aaf064f4e47b43011d Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:17:23 2014 +1100 northbridge/amd: Use DEVICE_NOOP macro over dummy symbol Change-Id: I3fdd2a9f981592112998d74ce4cfe4850d8fab31 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/amd/agesa/00730F01/northbridge.c | 6 +----- src/northbridge/amd/agesa/family10/northbridge.c | 6 +----- src/northbridge/amd/agesa/family15/northbridge.c | 6 +----- src/northbridge/amd/agesa/family15tn/northbridge.c | 6 +----- src/northbridge/amd/agesa/family16kb/northbridge.c | 6 +----- src/northbridge/amd/amdfam10/northbridge.c | 6 +----- src/northbridge/amd/amdk8/northbridge.c | 10 +++------- src/northbridge/amd/gx1/northbridge.c | 10 +++------- src/northbridge/amd/gx2/northbridge.c | 10 +++------- src/northbridge/amd/lx/northbridge.c | 10 +++------- 10 files changed, 18 insertions(+), 58 deletions(-) diff --git a/src/northbridge/amd/agesa/00730F01/northbridge.c b/src/northbridge/amd/agesa/00730F01/northbridge.c index 2689569..03433af 100644 --- a/src/northbridge/amd/agesa/00730F01/northbridge.c +++ b/src/northbridge/amd/agesa/00730F01/northbridge.c @@ -1081,10 +1081,6 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { #if CONFIG_MMCONF_SUPPORT @@ -1108,7 +1104,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c index d3d6479..b1f0890 100644 --- a/src/northbridge/amd/agesa/family10/northbridge.c +++ b/src/northbridge/amd/agesa/family10/northbridge.c @@ -1376,10 +1376,6 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { #if CONFIG_MMCONF_SUPPORT @@ -1403,7 +1399,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c index 34d7ea3..ce9785e 100644 --- a/src/northbridge/amd/agesa/family15/northbridge.c +++ b/src/northbridge/amd/agesa/family15/northbridge.c @@ -1092,10 +1092,6 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { } @@ -1107,7 +1103,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 3e2c635..d77897d 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -1054,10 +1054,6 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { } @@ -1069,7 +1065,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 5572282..d47a00d 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -1060,10 +1060,6 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { #if CONFIG_MMCONF_SUPPORT @@ -1087,7 +1083,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 529dc0a..76ffc5d 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -1411,10 +1411,6 @@ static void cpu_bus_init(device_t dev) #endif } -static void cpu_bus_noop(device_t dev) -{ -} - static void cpu_bus_read_resources(device_t dev) { } @@ -1431,7 +1427,7 @@ static void cpu_bus_set_resources(device_t dev) static struct device_operations cpu_bus_ops = { .read_resources = cpu_bus_read_resources, .set_resources = cpu_bus_set_resources, - .enable_resources = cpu_bus_noop, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c index 7d12dbd..a91a499 100644 --- a/src/northbridge/amd/amdk8/northbridge.c +++ b/src/northbridge/amd/amdk8/northbridge.c @@ -1350,14 +1350,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, }; diff --git a/src/northbridge/amd/gx1/northbridge.c b/src/northbridge/amd/gx1/northbridge.c index c8f7f94..bcb6e56 100644 --- a/src/northbridge/amd/gx1/northbridge.c +++ b/src/northbridge/amd/gx1/northbridge.c @@ -132,14 +132,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/amd/gx2/northbridge.c b/src/northbridge/amd/gx2/northbridge.c index e2f4d11..a48226d 100644 --- a/src/northbridge/amd/gx2/northbridge.c +++ b/src/northbridge/amd/gx2/northbridge.c @@ -325,14 +325,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; diff --git a/src/northbridge/amd/lx/northbridge.c b/src/northbridge/amd/lx/northbridge.c index df69b51..4e84025 100644 --- a/src/northbridge/amd/lx/northbridge.c +++ b/src/northbridge/amd/lx/northbridge.c @@ -429,14 +429,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, };

1 0

Patch set updated for coreboot: 1b1dfa2 TEST
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7291 -gerrit commit 1b1dfa2ad8fafefea73c1511720c7b6b94cd20be Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 10:55:07 2014 +1100 TEST Change-Id: I24c051f0096a7b7e6ead97e1a1fd56b14ef65a53 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/include/device/device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/device/device.h b/src/include/device/device.h index c67205c..db97d03 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -133,7 +133,7 @@ struct device { struct device_operations *ops; #ifndef __PRE_RAM__ struct chip_operations *chip_ops; - const char *name; +// const char *name; #endif ROMSTAGE_CONST void *chip_info; };

1 0

Patch set updated for coreboot: e956068 unnecessary addr '&' operator usage on func ptr's in struct initiator
by Edward O'Callaghan Oct. 31, 2014

Oct. 31, 2014

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7290 -gerrit commit e9560680cc5cd207289692076eda8a92db811839 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Oct 31 08:54:41 2014 +1100 unnecessary addr '&' operator usage on func ptr's in struct initiator Change-Id: I63a7bed5efade37dd7076dbfc9c85d420cf6c92b Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/via/cx700/lpc.c | 4 ++-- src/soc/intel/broadwell/systemagent.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/northbridge/via/cx700/lpc.c b/src/northbridge/via/cx700/lpc.c index da3e2ce..45a09cb 100644 --- a/src/northbridge/via/cx700/lpc.c +++ b/src/northbridge/via/cx700/lpc.c @@ -296,12 +296,12 @@ static struct device_operations cx700_lpc_ops = { .read_resources = cx700_read_resources, .set_resources = cx700_set_resources, .enable_resources = cx700_enable_resources, - .init = &cx700_lpc_init, + .init = cx700_lpc_init, .scan_bus = scan_static_bus, }; static const struct pci_driver lpc_driver __pci_driver = { - .ops = &cx700_lpc_ops, + .ops = cx700_lpc_ops, .vendor = PCI_VENDOR_ID_VIA, .device = 0x8324, }; diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/systemagent.c index 787a62b..2b3ce41 100644 --- a/src/soc/intel/broadwell/systemagent.c +++ b/src/soc/intel/broadwell/systemagent.c @@ -433,12 +433,12 @@ static void systemagent_enable(device_t dev) } static struct device_operations systemagent_ops = { - .read_resources = &systemagent_read_resources, - .set_resources = &pci_dev_set_resources, - .enable_resources = &pci_dev_enable_resources, - .init = &systemagent_init, - .enable = &systemagent_enable, - .ops_pci = &broadwell_pci_ops, + .read_resources = systemagent_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = systemagent_init, + .enable = systemagent_enable, + .ops_pci = broadwell_pci_ops, }; static const unsigned short systemagent_ids[] = {

1 0