Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3593
-gerrit
commit 834c531a1d2ab60739890b7f9b3e961fdab2d194
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Jul 2 16:39:28 2013 +0200
lint: Use temporary build directory
`util/lint/lint-stable-002-build-dir-handling` always overwrites your
current `config.h` and `auto.conf` when the pre-commit hook is run. It
can be very confusing when your configuration is suddenly broken. So fix
it by not using the default build directory.
Change-Id: If2bbc97ac2f12a8203a3769d813386a023f93dd6
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/lint/lint-stable-002-build-dir-handling | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling
index 2dad8a6..1880d30 100755
--- a/util/lint/lint-stable-002-build-dir-handling
+++ b/util/lint/lint-stable-002-build-dir-handling
@@ -53,9 +53,13 @@ if [ "$MAKE" = "" ]; then
fi
# prepare a config to use
+TMPOBJ=`mktemp .tmpobj.XXXXXX`
+rm $TMPOBJ
+TMPOBJ=${TMPOBJ}
+mkdir -p ${TMPOBJ}
TMPCONFIG=`mktemp .tmpconfig.XXXXXX`
rm -f $TMPCONFIG
-$MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
+$MAKE obj=$TMPOBJ DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
# look up parent directory
CURRENTDIR=`pwd -P`
@@ -66,5 +70,5 @@ compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/o
compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
-rm -f $TMPCONFIG
+rm -rf $TMPCONFIG $TMPOBJ
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3593
-gerrit
commit bceed598d5a45c852d861595694751b3a5aca63a
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue Jul 2 16:39:28 2013 +0200
lint: Use temporary build directory
`util/lint/lint-stable-002-build-dir-handling` always overwrites your
current `config.h` and `auto.conf` when the pre-commit hook is run. It
can be very confusing when your configuration is suddenly broken. So fix
it by not using the default build directory.
Change-Id: If2bbc97ac2f12a8203a3769d813386a023f93dd6
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/lint/lint-stable-002-build-dir-handling | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling
index 2dad8a6..0eef041 100755
--- a/util/lint/lint-stable-002-build-dir-handling
+++ b/util/lint/lint-stable-002-build-dir-handling
@@ -53,9 +53,11 @@ if [ "$MAKE" = "" ]; then
fi
# prepare a config to use
+TMPOBJ=`mktemp .tmpobj.XXXXXX`.dir
+mkdir -p ${TMPOBJ}
TMPCONFIG=`mktemp .tmpconfig.XXXXXX`
rm -f $TMPCONFIG
-$MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
+$MAKE obj=$TMPOBJ DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
# look up parent directory
CURRENTDIR=`pwd -P`
@@ -66,5 +68,5 @@ compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/o
compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
-rm -f $TMPCONFIG
+rm -rf $TMPCONFIG $TMPOBJ
Allen Martin (amartin(a)nvidia.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3949
-gerrit
commit e056b95c105d768d306c8de412924d20c630f7d9
Author: Allen Martin <amartin(a)nvidia.com>
Date: Thu Sep 26 11:13:01 2013 -0700
exynos5420: Fix build warning
Fix "set but not used" variable warning with gcc 4.7.3
Change-Id: Ia27291ecb4f993c4ba6f29b134167dc23a449bf5
Signed-off-by: Allen Martin <amartin(a)nvidia.com>
---
src/cpu/samsung/exynos5420/cpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/cpu/samsung/exynos5420/cpu.c b/src/cpu/samsung/exynos5420/cpu.c
index d204556..744f7ae 100644
--- a/src/cpu/samsung/exynos5420/cpu.c
+++ b/src/cpu/samsung/exynos5420/cpu.c
@@ -64,7 +64,6 @@ static void set_cpu_id(void)
*/
static void exynos_displayport_init(device_t dev)
{
- int ret;
struct cpu_samsung_exynos5420_config *conf = dev->chip_info;
/* put these on the stack. If, at some point, we want to move
* this code to a pre-ram stage, it will be much easier.
@@ -117,7 +116,7 @@ static void exynos_displayport_init(device_t dev)
mmio_resource(dev, 1, lcdbase/KiB, (fb_size + KiB - 1)/KiB);
printk(BIOS_DEBUG,
"Initializing Exynos VGA, base %p\n", (void *)lcdbase);
- ret = lcd_ctrl_init(fb_size, &panel, (void *)lcdbase);
+ lcd_ctrl_init(fb_size, &panel, (void *)lcdbase);
}
static void cpu_enable(device_t dev)
the following patch was just integrated into master:
commit a1179cafdb87e3dfd6df142b128331b02feaa5b2
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Tue Sep 17 00:12:05 2013 +0300
usbdebug AMD: Add choice of EHCI controller
Chipsets sb700 and sb800/hudson have more than one USB EHCI controller,
implement the selection logic using already existing Kconfig option.
Change-Id: I9e0df1669d73863c95c36a3a7fee40d58f6f097e
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-on: http://review.coreboot.org/3928
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See http://review.coreboot.org/3928 for details.
-gerrit
Gabe Black (gabeblack(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3943
-gerrit
commit 0b40228ad01b5c94f7e757dcc90a612c7cabb0a9
Author: Gabe Black <gabeblack(a)chromium.org>
Date: Tue Sep 24 01:40:07 2013 -0700
beaglebone: Add code to set the value of the LEDs.
The LEDs on the beaglebone are connected to GPIOs called USR0-USR3. This
change adds some functions to make it easy to set their value and clear what
the calling code is trying to do.
Change-Id: I0bb83bbc2e195ce1a0104afcd120089efaa22916
Signed-off-by: Gabe Black <gabeblack(a)chromium.org>
---
src/mainboard/ti/beaglebone/Makefile.inc | 2 ++
src/mainboard/ti/beaglebone/leds.c | 47 ++++++++++++++++++++++++++++++++
src/mainboard/ti/beaglebone/leds.h | 34 +++++++++++++++++++++++
3 files changed, 83 insertions(+)
diff --git a/src/mainboard/ti/beaglebone/Makefile.inc b/src/mainboard/ti/beaglebone/Makefile.inc
index c76cb37..fc4051c 100644
--- a/src/mainboard/ti/beaglebone/Makefile.inc
+++ b/src/mainboard/ti/beaglebone/Makefile.inc
@@ -17,6 +17,8 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
##
+bootblock-y += leds.c
+
romstage-y += romstage.c
#ramstage-y += ramstage.c
diff --git a/src/mainboard/ti/beaglebone/leds.c b/src/mainboard/ti/beaglebone/leds.c
new file mode 100644
index 0000000..6c8705a
--- /dev/null
+++ b/src/mainboard/ti/beaglebone/leds.c
@@ -0,0 +1,47 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <assert.h>
+#include <console/console.h>
+#include <cpu/ti/am335x/gpio.h>
+#include <stdlib.h>
+
+#include "leds.h"
+
+static const int led_gpios[BEAGLEBONE_LED_COUNT] = {
+ [BEAGLEBONE_LED_USR0] = AM335X_GPIO_BITS_PER_BANK + 21,
+ [BEAGLEBONE_LED_USR1] = AM335X_GPIO_BITS_PER_BANK + 22,
+ [BEAGLEBONE_LED_USR2] = AM335X_GPIO_BITS_PER_BANK + 23,
+ [BEAGLEBONE_LED_USR3] = AM335X_GPIO_BITS_PER_BANK + 24
+};
+
+void beaglebone_leds_init(void)
+{
+ int i;
+ for (i = 0; i < ARRAY_SIZE(led_gpios); i++)
+ gpio_direction_output(led_gpios[i], 0);
+}
+
+void beaglebone_leds_set(enum beaglebone_led led, int on)
+{
+ int res;
+ ASSERT(led < ARRAY_SIZE(led_gpios) && led_gpios[led]);
+ res = gpio_set_value(led_gpios[led], on);
+ ASSERT(res != -1);
+}
diff --git a/src/mainboard/ti/beaglebone/leds.h b/src/mainboard/ti/beaglebone/leds.h
new file mode 100644
index 0000000..1e4ba60
--- /dev/null
+++ b/src/mainboard/ti/beaglebone/leds.h
@@ -0,0 +1,34 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __MAINBOARD_TI_BEAGLEBONE_LEDS_H__
+#define __MAINBOARD_TI_BEAGLEBONE_LEDS_H__
+
+enum beaglebone_led {
+ BEAGLEBONE_LED_USR0,
+ BEAGLEBONE_LED_USR1,
+ BEAGLEBONE_LED_USR2,
+ BEAGLEBONE_LED_USR3,
+ BEAGLEBONE_LED_COUNT
+};
+
+void beaglebone_leds_init(void);
+void beaglebone_leds_set(enum beaglebone_led led, int on);
+
+#endif /* __MAINBOARD_TI_BEAGLEBONE_LEDS_H__ */