June 2024 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Hsuan-ting Chen (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Jakub Czapiga. Hsuan-ting Chen has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email ) Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 10:03:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: ichspi: Add support for Panther Lake
by Hsuan-ting Chen (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Hsuan Ting Chen, Subrata Banik. Hsuan-ting Chen has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email ) Change subject: ichspi: Add support for Panther Lake ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99cd8eb7cbb11381f8e8455b06cf90b9db77d8f0 Gerrit-Change-Number: 83144 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 10:02:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Nicholas Chin. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 6: (2 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/986e4c31_e185e639?us… : PS5, Line 290: int index = 0; > I just noticed this when testing your patch. […] When the clock is set error, index=1, set default 30MHz clock. https://review.coreboot.org/c/flashrom/+/82776/comment/7e87825b_f26dae2e?us… : PS5, Line 370: msg_pinfo("CH347 SPI clock set to %s.\n", spispeeds[index].name); > If the spispeed parameter is invalid, `index` is 8 here, so this prints out `CH347 SPI clock set to […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 6 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 12:05:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in flashrom[main]: flashchips: Set default wp test status for chips with custom config
by Anastasia Klimchuk (Code Review) 25 Jun '24

25 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83132?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Set default wp test status for chips with custom config ...................................................................... flashchips: Set default wp test status for chips with custom config Without this, default value is the first in enum, which is OK. While in reality, for the chips in the patch block-protection is not available, so should be NA. wp test status support was introduced later than the others, so old chips don't have this field initialised. Change-Id: I6ed8e04cd215865dc6a7d9415634dedbe3014ab5 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83132 Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Sergii Dmytruk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 1dba182..6977a26 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2648,7 +2648,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD}, + .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD, .wp = NA}, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = @@ -3717,7 +3717,7 @@ .total_size = 64, .page_size = 0, /* unused */ .feature_bits = 0, - .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD}, + .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD, .wp = NA}, .probe = PROBE_JEDEC, /* FIXME! */ .probe_timing = TIMING_ZERO, .block_erasers = @@ -9072,7 +9072,7 @@ .model_id = MACRONIX_MX23L12854, .total_size = 16384, .page_size = 256, - .tested = {.probe = NT, .read = NT, .erase = NA, .write = NA}, + .tested = {.probe = NT, .read = NT, .erase = NA, .write = NA, .wp = NA}, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .write = 0, /* MX23L12854 is a mask ROM, so it is read-only */ @@ -9088,7 +9088,7 @@ .model_id = MACRONIX_MX23L1654, .total_size = 2048, .page_size = 256, - .tested = {.probe = NT, .read = NT, .erase = NA, .write = NA}, + .tested = {.probe = NT, .read = NT, .erase = NA, .write = NA, .wp = NA}, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .write = 0, /* MX23L1654 is a mask ROM, so it is read-only */ @@ -9104,7 +9104,7 @@ .model_id = MACRONIX_MX23L3254, .total_size = 4096, .page_size = 256, - .tested = {.probe = OK, .read = OK, .erase = NA, .write = NA}, + .tested = {.probe = OK, .read = OK, .erase = NA, .write = NA, .wp = NA}, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .write = 0, /* MX23L3254 is a mask ROM, so it is read-only */ @@ -9120,7 +9120,7 @@ .model_id = MACRONIX_MX23L6454, .total_size = 8192, .page_size = 256, - .tested = {.probe = OK, .read = OK, .erase = NA, .write = NA}, + .tested = {.probe = OK, .read = OK, .erase = NA, .write = NA, .wp = NA}, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .write = 0, /* MX23L6454 is a mask ROM, so it is read-only */ -- To view, visit https://review.coreboot.org/c/flashrom/+/83132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6ed8e04cd215865dc6a7d9415634dedbe3014ab5 Gerrit-Change-Number: 83132 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: print.c: Print B (block-protect) test status of the chips
by Anastasia Klimchuk (Code Review) 25 Jun '24

25 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83131?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: print.c: Print B (block-protect) test status of the chips ...................................................................... print.c: Print B (block-protect) test status of the chips This also expands the column for test status by 1 more char, since now maximum status is longer, PREWB vs PREW. print.c runs when command line option `flashrom -L` is invoked. Change-Id: If697fe3ba93dbe34bb8f7a9a4b1686fdb8b3ee58 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83131 Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M print.c 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Sergii Dmytruk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/print.c b/print.c index 015f4a8..892471d 100644 --- a/print.c +++ b/print.c @@ -122,7 +122,7 @@ for (i = strlen("Device"); i < maxchiplen; i++) msg_ginfo(" "); - msg_ginfo("Test"); + msg_ginfo("Test "); for (i = 0; i < border; i++) msg_ginfo(" "); msg_ginfo("Known"); @@ -140,7 +140,7 @@ for (i = 0; i < maxvendorlen + maxchiplen; i++) msg_ginfo(" "); - msg_ginfo("OK "); + msg_ginfo("OK "); for (i = 0; i < border; i++) msg_ginfo(" "); msg_ginfo("Broken"); @@ -151,7 +151,7 @@ msg_ginfo(" "); msg_gdbg("range [V]"); msg_ginfo("\n\n"); - msg_ginfo("(P = PROBE, R = READ, E = ERASE, W = WRITE, - = N/A)\n\n"); + msg_ginfo("(P = PROBE, R = READ, E = ERASE, W = WRITE, B = block-protect, - = N/A)\n\n"); for (chip = flashchips; chip->name != NULL; chip++) { /* Don't print generic entries. */ @@ -242,6 +242,12 @@ msg_ginfo("-"); else msg_ginfo(" "); + if (chip->tested.wp == OK) + msg_ginfo("B"); + else if (chip->tested.wp == NA) + msg_ginfo("-"); + else + msg_ginfo(" "); for (i = 0; i < border; i++) msg_ginfo(" "); @@ -261,6 +267,10 @@ msg_ginfo("W"); else msg_ginfo(" "); + if (chip->tested.wp == BAD) + msg_ginfo("B"); + else + msg_ginfo(" "); for (i = 0; i < border + 1; i++) msg_ginfo(" "); -- To view, visit https://review.coreboot.org/c/flashrom/+/83131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If697fe3ba93dbe34bb8f7a9a4b1686fdb8b3ee58 Gerrit-Change-Number: 83131 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB256E chip model
by Anastasia Klimchuk (Code Review) 25 Jun '24

25 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83140?usp=email ) Change subject: flashchips: add GD25LB256E chip model ...................................................................... flashchips: add GD25LB256E chip model adding GD25LB256E to the model GD25LR256E which share the same feature. The datasheet link https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Tested read, write, erase, --wp-enable, --wp-disable, --wp-list and --wp-range Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Signed-off-by: Victor Lim <vlim(a)gigadevice.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83140 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 10071fd..1dba182 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6899,14 +6899,14 @@ { .vendor = "GigaDevice", - .name = "GD25LR256E", + .name = "GD25LB256E/GD25LR256E", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25LR256E, .total_size = 32768, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_4BA, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/83140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Gerrit-Change-Number: 83140 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
by Anastasia Klimchuk (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/83182/comment/3e1eaaaf_3f312088?us… : PS2, Line 21935: .voltage = {2700, 3600}, I wanted to ask, why you set minimum voltage as 2.7 , I saw in datasheet it says `Full voltage range: 2.3-3.6V` ? Is there a reason you set 2.7 and not 2.3 ? -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 06:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU80B
by Anastasia Klimchuk (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU80B ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5 Gerrit-Change-Number: 83180 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 05:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
by Ssunk (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I added comments to your other patch CB:83180 , comments about indentation and commit message apply […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 05:06:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU80B
by Ssunk (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU80B ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: > Hi Kan, you uploaded new patchset and seems like all comments are resolved, but you haven't marked t […] Got it. Commit Message: https://review.coreboot.org/c/flashrom/+/83180/comment/7d35598d_bb078cef?us… : PS1, Line 6: : Add Support for XMC XM25QU80B > Prefix with `flashchips: ` so that it's easier to go through the list of commits. […] Done https://review.coreboot.org/c/flashrom/+/83180/comment/774b7c3d_37c9feda?us… : PS1, Line 11: > For adding chip model support, we add in commit message testing info: which programmer you were usin […] Done File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/83180/comment/4588b0ff_03095d61?us… : PS1, Line 856: #define XMC_XM25QU80B 0x5014 > Let's move the line up, put it on #850, after XMC_XM25QU64C. […] Done https://review.coreboot.org/c/flashrom/+/83180/comment/5c0fc149_5a69fd5e?us… : PS1, Line 856: 0x5014 > The ID needs to be aligned with the others (see like other IDs all aligned in a column), so you need […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5 Gerrit-Change-Number: 83180 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 05:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2024