June 2024 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: util/ich_descriptors_tool: Add Panther Lake SoC to supported chipsets
by Anastasia Klimchuk (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Hsuan Ting Chen, Sam McNally, Subrata Banik. Anastasia Klimchuk has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83149?usp=email ) Change subject: util/ich_descriptors_tool: Add Panther Lake SoC to supported chipsets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83149?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I17d616d346daca15b43eb294401ac0c672b64c4a Gerrit-Change-Number: 83149 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 13:22:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: ichspi: Add support for Panther Lake
by Anastasia Klimchuk (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally, Subrata Banik. Anastasia Klimchuk has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email ) Change subject: ichspi: Add support for Panther Lake ...................................................................... Patch Set 3: (4 comments) Patchset: PS3: I think I asked everything I wanted. Hsuan-ting, Sam, do you have other comments, what do you think? Commit Message: https://review.coreboot.org/c/flashrom/+/83144/comment/8b507edc_9465a3ba?us… : PS2, Line 9: Panther Lake > Acknowledged Newbie question, how do I find the doc? :) I tried go to intel.com and search for doc number, no luck. I also tried to search by "panther lake". File include/programmer.h: https://review.coreboot.org/c/flashrom/+/83144/comment/21c19563_3744ae18?us… : PS1, Line 364: /* All chipsets after METEOR_LAKE should support checking BIOS_BM to get read/write access to of FREG0~15 */ > > I think what Hsuan-ting meant to say (but correct me if I am wrong), is that we have 100 places in […] Ah, I was thinking about consistent order more from readability point of view, not from execution of code point of view. In any case, it won't be for this commit. Hsuan-ting, since you started the thread, are you alright with the resolution? File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83144/comment/0bb9b5a1_e0e9a8df?us… : PS2, Line 251: else if (strcmp(csn, "panther") == 0) : cs = CHIPSET_PANTHER_LAKE; > > I think the ich_descriptor_tool is run separately from flashrom. […] Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/83144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99cd8eb7cbb11381f8e8455b06cf90b9db77d8f0 Gerrit-Change-Number: 83144 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 13:19:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Jakub Czapiga (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen, Peter Marheine. Jakub Czapiga has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email ) Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/83133/comment/551be1af_560b648d?us… : PS1, Line 9: Recently Android Bionic LibC got sys/io.h. > The links are non-public, I can't open them from this account. Sorry, I didn't notice corp proxy in the link. Here are publicly available patches: - [glibc-syscall.h move](https://android-review.googlesource.com/c/platform/bionic/+/221800) - [sys/io.h](https://android-review.googlesource.com/c/platform/bionic/+/31352… > Android is not mentioned anywhere. It is truly undocumented feature, so I think it's fine to update it. I'll add this to my list once flashrom is fully accepted as Android external tool (It shouldn't take long) :) > I was thinking to put that "minimum version number" in some doc, but there is no such doc. C23 has __has_include, but I doubt flashrom will switch to C23 soon to incorporate this. I'll look for ways to check Android version in C #if, so we can cover all major cases with sys/io.h https://review.coreboot.org/c/flashrom/+/83133/comment/292dc7a5_73fee255?us… : PS1, Line 12: > Could you please add testing info to commit message? […] I added testing description. I cannot provide links right now, as flashrom didn't pass Android review yet and thus its mirror is not available in AOSP yet, but I can assure you it works on the latest branch. -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 09:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Jakub Czapiga (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga, Peter Marheine. Hello Anastasia Klimchuk, Hsuan-ting Chen, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83133?usp=email to look at the new patch set (#2). Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... hwaccess_x86_io: Fix Android compilation with bionic libc Recently Android Bionic LibC got sys/io.h. Use this header to access ioperm(). Use Assembly for I/O, as Bionic does not have inb(), outb(), etc. Tested on Android 14 by adding flashrom and pciutils as external repositories, adding Android.bp blueprints (Android specialized build system - Soong), building, running and accessing (read, erase, write) SPI flash on x86 device. Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M hwaccess_x86_io.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/83133/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Anastasia Klimchuk (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email ) Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Peter, I did review from my side, but I also really interested of what you think. Thank you! Commit Message: https://review.coreboot.org/c/flashrom/+/83133/comment/93a8dbba_b8832b77?us… : PS1, Line 9: Recently Android Bionic LibC got sys/io.h. > With the current code flashrom on Android will work only on super-old builds because glibc-syscalls. […] The links are non-public, I can't open them from this account. We are public open source project, so the links should be available to everyone. Telling you so that you know for future :) To check, you can open link in incognito mode, if it works than all good. I still appreciate you giving more details! even though I can't see them now. For this question, actually I checked our documentation, and drumroll, Android is not mentioned anywhere. It is truly undocumented feature, so I think it's fine to update it. I was thinking to put that "minimum version number" in some doc, but there is no such doc. File hwaccess_x86_io.c: https://review.coreboot.org/c/flashrom/+/83133/comment/ffd962ef_eab8b0ee?us… : PS1, Line 60: #if defined(__ANDROID__) > For Android you can only build with Android.mk or Android.bp (Soong BluePrint). […] Thank you for explanation, appreciate it. I had no idea of this. It seems to be no changes needed for makefile and meson so far. However, your explanation about building can go to the commit message as a testing info (see my other comment). -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 08:48:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Add current numbers of supported devices to the intro page
by Anastasia Klimchuk (Code Review) 23 Jun '24

23 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83130?usp=email ) Change subject: doc: Add current numbers of supported devices to the intro page ...................................................................... doc: Add current numbers of supported devices to the intro page Current numbers are taken from the output of `flashrom -L` command. Intro page still has a room for improvement, but as a first step the numbers need to be updated. In future, maybe there is a way to update the numbers less manually. Change-Id: I7531521955dcf01348ed2ba9c54316b32b9cd925 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83130 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/intro.rst 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/intro.rst b/doc/intro.rst index b1fe99a..b9a2c97 100644 --- a/doc/intro.rst +++ b/doc/intro.rst @@ -2,20 +2,30 @@ chips. It is designed to flash BIOS/EFI/coreboot/firmware/optionROM images on mainboards, network/graphics/storage controller cards, and various other programmer devices. -* Supports more than 476 flash chips, 291 chipsets, 500 mainboards, 79 PCI devices, - 17 USB devices and various parallel/serial port-based programmers. +* Supports more than 627 flash chips, 407 chipsets, 539 mainboards, 94 PCI devices, + 30 USB devices and various parallel/serial port-based programmers. + For more information, see the pages under :doc:`/supported_hw/index`. + * Supports parallel, LPC, FWH and SPI flash interfaces and various chip packages (DIP32, PLCC32, DIP8, SO8/SOIC8, TSOP32, TSOP40, TSOP48, BGA and more). + * No physical access needed, root access is sufficient (not needed for some programmers). + * No bootable floppy disk, bootable CD-ROM or other media needed. + * No keyboard or monitor needed. Simply reflash remotely via SSH. + * No instant reboot needed. Reflash your chip in a running system, verify it, be happy. The new firmware will be present next time you boot. + * Crossflashing and hotflashing is possible as long as the flash chips are electrically and logically compatible (same protocol). Great for recovery. + * Scriptability. Reflash a whole pool of identical machines at the same time from the command line. It is recommended to check flashrom output and error codes. + * Speed. flashrom is often much faster than most vendor flash tools. + * Portability. Supports DOS, Linux, FreeBSD (including Debian/kFreeBSD), NetBSD, OpenBSD, DragonFlyBSD, anything Solaris-like, Mac OS X, and other Unix-like OSes as well as GNU Hurd. Partial Windows support is available (no internal programmer support at the moment, hence -- To view, visit https://review.coreboot.org/c/flashrom/+/83130?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7531521955dcf01348ed2ba9c54316b32b9cd925 Gerrit-Change-Number: 83130 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: print.c: Print total numbers of supported USB and PCI devices
by Anastasia Klimchuk (Code Review) 23 Jun '24

23 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83129?usp=email ) Change subject: print.c: Print total numbers of supported USB and PCI devices ...................................................................... print.c: Print total numbers of supported USB and PCI devices This adds two lines at the very end of the section with supported deviced per programmer. At the moment of this patch, numbers are: Supported USB devices, total 30 Supported PCI devices, total 94 All other sections print total numbers, this was only one missing. Change-Id: Ie011db3985172d05f5160d1cb1cc39a4422a5750 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83129 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M print.c 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified diff --git a/print.c b/print.c index 0caa0da..015f4a8 100644 --- a/print.c +++ b/print.c @@ -444,7 +444,8 @@ } #endif -static void print_supported_devs(const struct programmer_entry *const prog, const char *const type) +static void print_supported_devs(const struct programmer_entry *const prog, const char *const type, + int* num_devs) { const struct dev_entry *const devs = prog->devs.dev; msg_ginfo("\nSupported %s devices for the %s programmer:\n", type, prog->name); @@ -480,12 +481,17 @@ msg_pinfo(" %04x:%04x %s\n", devs[i].vendor_id, devs[i].device_id, test_state_to_text(devs[i].status)); + if (devs[i].status == OK || devs[i].status == NT || devs[i].status == DEP) + *num_devs += 1; } } int print_supported(void) { unsigned int i; + int num_pci_devs = 0; + int num_usb_devs = 0; + if (print_supported_chips()) return 1; @@ -504,10 +510,10 @@ const struct programmer_entry *const prog = programmer_table[i]; switch (prog->type) { case USB: - print_supported_devs(prog, "USB"); + print_supported_devs(prog, "USB", &num_usb_devs); break; case PCI: - print_supported_devs(prog, "PCI"); + print_supported_devs(prog, "PCI", &num_pci_devs); break; case OTHER: if (prog->devs.note != NULL) { @@ -521,6 +527,10 @@ break; } } + + msg_ginfo("\nSupported USB devices, total %d\nSupported PCI devices, total %d\n", + num_usb_devs, num_pci_devs); + return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/83129?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie011db3985172d05f5160d1cb1cc39a4422a5750 Gerrit-Change-Number: 83129 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QU16C
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/83183?usp=email ) Change subject: Add Support for XMC XM25QU16C ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/83183?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I54902969482e8b9c93664ae3ce3080af6a1fbe4b Gerrit-Change-Number: 83183 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QU16C
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Ssunk, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83183?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Add Support for XMC XM25QU16C ...................................................................... Add Support for XMC XM25QU16C Add initial support for the SPI flash chip XM25QU16C Datasheet link: https://www.xmcwh.com/uploads/804/XM25QU16C_%20Ver1.8.pdf Change-Id: I54902969482e8b9c93664ae3ce3080af6a1fbe4b Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/83183/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83183?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I54902969482e8b9c93664ae3ce3080af6a1fbe4b Gerrit-Change-Number: 83183 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QU16C
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83183?usp=email ) Change subject: Add Support for XMC XM25QU16C ...................................................................... Add Support for XMC XM25QU16C Add initial support for the SPI flash chip XM25QU16C Datasheet link: https://www.xmcwh.com/uploads/804/XM25QU16C_%20Ver1.8.pdf Change-Id: I54902969482e8b9c93664ae3ce3080af6a1fbe4b Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/83183/1 diff --git a/flashchips.c b/flashchips.c index b667b46..b78e3e8 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21937,6 +21937,44 @@ { .vendor = "XMC", + .name = "XM25QU16C", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QU16C, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index b59e759..5f29a0e 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -854,6 +854,7 @@ #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 #define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ +#define XMC_XM25QU16C 0x5015 #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83183?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I54902969482e8b9c93664ae3ce3080af6a1fbe4b Gerrit-Change-Number: 83183 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2024