June 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Nicholas Chin. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 5: (7 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/b1fbdcb0_836c1656?us… : PS4, Line 56: speed > I think `divisor` might be a better term here, as the values passed to the CH347 divide the referenc […] Very reasonable,done. https://review.coreboot.org/c/flashrom/+/82776/comment/039973d3_fa9ec61b?us… : PS4, Line 72: 0x0 > There isn't really a need to write the speeds in hexadecimal, so just drop the `0x` prefix Done https://review.coreboot.org/c/flashrom/+/82776/comment/f767300f_0f78cde1?us… : PS4, Line 287: defaulet > default Done https://review.coreboot.org/c/flashrom/+/82776/comment/65686b90_e5a75695?us… : PS4, Line 287: 0x0 > Just use decimal […] For practicality, it has been modified to default to 30MHz,done. https://review.coreboot.org/c/flashrom/+/82776/comment/49ddda37_f716cfe9?us… : PS4, Line 365: M > I would use MHz for more clarity instead of just M Done https://review.coreboot.org/c/flashrom/+/82776/comment/bea8dc71_66d9b594?us… : PS4, Line 365: defaul > default Done https://review.coreboot.org/c/flashrom/+/82776/comment/f8cc7857_69d06fba?us… : PS4, Line 365: (60M clock spi) > I don't think the parenthesis really add any value here; I would just drop them. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 5 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 01:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in flashrom[main]: ich_descriptor: Fix chipset_names index for Intel Meteor Lake
by Anastasia Klimchuk (Code Review) 24 Jun '24

24 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83143?usp=email ) Change subject: ich_descriptor: Fix chipset_names index for Intel Meteor Lake ...................................................................... ich_descriptor: Fix chipset_names index for Intel Meteor Lake commit hash 85b977151b8f57 (ichspi.c: Add support for region 9 and beyond in Meteor Lake) moved the Intel Meteor Lake macro in programmer.h, causing flashrom to display an incorrect chipset name for Meteor Lake platforms. This patch updates the corresponding chipset_names index to resolve this issue. TEST=Verified correct chipset name in flashrom output for Meteor Lake chipset (google/rex0 board). Change-Id: Ic09cf0474c980369bcbf90924d45f697bc1b0a0d Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83143 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Sam McNally <sammc(a)google.com> Reviewed-by: Hsuan-ting Chen <roccochen(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M ich_descriptors.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Hsuan-ting Chen: Looks good to me, approved Sam McNally: Looks good to me, but someone else must approve build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/ich_descriptors.c b/ich_descriptors.c index b11a78d..6de4316 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -121,7 +121,8 @@ "9 series Wildcat Point", "9 series Wildcat Point LP", "100 series Sunrise Point", "C620 series Lewisburg", "C740 series Emmitsburg", "300 series Cannon Point", "400 series Comet Point", "500 series Tiger Point", "600 series Alder Point", - "Meteor Lake", "Apollo Lake", "Gemini Lake", "Jasper Lake", "Elkhart Lake", + "Apollo Lake", "Gemini Lake", "Jasper Lake", "Elkhart Lake", + "Meteor Lake", }; if (cs < CHIPSET_ICH8 || cs - CHIPSET_ICH8 + 1 >= ARRAY_SIZE(chipset_names)) cs = 0; -- To view, visit https://review.coreboot.org/c/flashrom/+/83143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic09cf0474c980369bcbf90924d45f697bc1b0a0d Gerrit-Change-Number: 83143 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: ich_descriptor: Fix chipset_names index for Intel Meteor Lake
by Anastasia Klimchuk (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Hsuan Ting Chen, Subrata Banik. Anastasia Klimchuk has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83143?usp=email ) Change subject: ich_descriptor: Fix chipset_names index for Intel Meteor Lake ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > > > Thank you for catching this! […] Oh sorry, I only read this message now! You have two questions here. #1 The rules for merging patches we have documented here: https://flashrom.org/dev_guide/development_guide.html#merging-patches In this case, what applies is p.6, the normal process is 3days between full approval and merging. 24h, that could be some coreboot rules maybe? Not sure, but in any case, we have our process documented. I can understand you might be worried the patch may be approved and then forgotten, but such things are no longer happening nowadays. I have setup such that I can easily check which patches are ready for merging, and other people probably have their own setups too. For me, it's one of the best things, to merge someone's work into the tree. I like our contributors and value the contributions <3 #2 If you have been serious about submit right, this is great to know! It would be fantastic to have you, with your knowledge and experience, to be one of the maintainers and take on some duties to care of flashrom. Our submit and approval rights are, in fact, duties, which is also documented, here: https://flashrom.org/about_flashrom/team.html Tell me if you are interested! The first step would be for you to take some area of flashrom to maintain, and subscribe yourself into MAINTAINERS file. Meanwhile, this patch is indeed ready, I will merge it now. -- To view, visit https://review.coreboot.org/c/flashrom/+/83143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic09cf0474c980369bcbf90924d45f697bc1b0a0d Gerrit-Change-Number: 83143 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 01:38:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QH16C/XM25QH16D
by Anastasia Klimchuk (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I added comments to your other patch CB:83180 , comments about indentation and commit message apply here as well. Could you please fix the same things here too. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 00:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QU80B
by Anastasia Klimchuk (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email ) Change subject: Add Support for XMC XM25QU80B ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/83180/comment/c8ca6629_3bf54fbe?us… : PS1, Line 6: : Add Support for XMC XM25QU80B Prefix with `flashchips: ` so that it's easier to go through the list of commits. So your commit title will be: > flashchips: Add Support for XMC XM25QU80B https://review.coreboot.org/c/flashrom/+/83180/comment/8a8fb6a4_40f3bf91?us… : PS1, Line 11: For adding chip model support, we add in commit message testing info: which programmer you were using, operations that you run (most likely would be read/write/erase, but list the operation that you tested). File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/83180/comment/74fd1d0b_cdfce26e?us… : PS1, Line 856: #define XMC_XM25QU80B 0x5014 Let's move the line up, put it on #850, after XMC_XM25QU64C. Otherwise it seems a bit out of order here. https://review.coreboot.org/c/flashrom/+/83180/comment/0d4b0f48_6a60f43f?us… : PS1, Line 856: 0x5014 The ID needs to be aligned with the others (see like other IDs all aligned in a column), so you need two tabs between macro name and ID. -- To view, visit https://review.coreboot.org/c/flashrom/+/83180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5 Gerrit-Change-Number: 83180 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 00:53:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Anastasia Klimchuk (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga. Anastasia Klimchuk has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email ) Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 00:10:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: hwaccess_x86_io: Fix Android compilation with bionic libc
by Peter Marheine (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen, Jakub Czapiga. Peter Marheine has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email ) Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > Peter, I did review from my side, but I also really interested of what you think. […] This seems uncontroversial, since the extent to which we currently support android is only in helping android users avoid needing to patch the source when using their own build system. -- To view, visit https://review.coreboot.org/c/flashrom/+/83133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id80b83c2718679c925ed6ddfe33cbe837eea0429 Gerrit-Change-Number: 83133 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 23:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: ZhiYuanNJ. Nicholas Chin has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 4: (8 comments) Patchset: PS4: Sorry for not reviewing this earlier; I was busy with other things and missed this patch. File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/8a5c9cb7_6dc6e609?us… : PS4, Line 56: speed I think `divisor` might be a better term here, as the values passed to the CH347 divide the reference clock by 2^divisor_value. These values are passed as the second argument for the `ch347_spi_config`, and the function signature for it already names it as the divisor: `ch347_spi_config(struct ch347_spi_data *ch347_data, uint8_t divisor)` https://review.coreboot.org/c/flashrom/+/82776/comment/08517c1e_5dbee440?us… : PS4, Line 72: 0x0 There isn't really a need to write the speeds in hexadecimal, so just drop the `0x` prefix https://review.coreboot.org/c/flashrom/+/82776/comment/cca817da_929a6b8a?us… : PS4, Line 287: 0x0 Just use decimal ```suggestion int spispeed = 0; /* defaulet 60M SPI */ ``` Also, in my experience it's quite difficult to get SPI flash chips working at 60 MHz, which is why I had hard coded a divisor of 2 (15 MHz) in the original code. It seems like flashrom only uses the standard JEDEC read (0x03) command, and many flash chips only support a maximum of 50 MHz or lower for standard reads. https://review.coreboot.org/c/flashrom/+/82776/comment/1f1059ee_9931a252?us… : PS4, Line 287: defaulet default https://review.coreboot.org/c/flashrom/+/82776/comment/a7f95cef_2355c2f9?us… : PS4, Line 365: defaul default https://review.coreboot.org/c/flashrom/+/82776/comment/e8e6089d_c45d23b9?us… : PS4, Line 365: M I would use MHz for more clarity instead of just M https://review.coreboot.org/c/flashrom/+/82776/comment/57551249_47459730?us… : PS4, Line 365: (60M clock spi) I don't think the parenthesis really add any value here; I would just drop them. -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 4 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: ZhiYuanNJ Gerrit-Comment-Date: Sun, 23 Jun 2024 14:43:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: ich_descriptor: Fix chipset_names index for Intel Meteor Lake
by Subrata Banik (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Hsuan Ting Chen. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83143?usp=email ) Change subject: ich_descriptor: Fix chipset_names index for Intel Meteor Lake ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > > Thank you for catching this! > > can you please help to submit in next 24 hr as per submission rule, I don't have submit access right for this project. (based on my contribution to Flashrom, i would love to get that) ping! can someone submit this CL please? -- To view, visit https://review.coreboot.org/c/flashrom/+/83143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic09cf0474c980369bcbf90924d45f697bc1b0a0d Gerrit-Change-Number: 83143 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 14:07:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add support for Panther Lake
by Subrata Banik (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email ) Change subject: ichspi: Add support for Panther Lake ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83144/comment/964194dc_93f995de?us… : PS2, Line 9: Panther Lake > Newbie question, how do I find the doc? :) I tried go to intel.com and search for doc number, no luck. I also tried to search by "panther lake". [Subrata] You need a premium account with Intel to access non-public datasheet (which is the case for Panther Lake, because Panther lake is 2027 SoC hence, currently this document is not in public domain). -- To view, visit https://review.coreboot.org/c/flashrom/+/83144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99cd8eb7cbb11381f8e8455b06cf90b9db77d8f0 Gerrit-Change-Number: 83144 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 14:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2024