June 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: Add Support for XMC XM25QH16C/XM25QH16D
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Add Support for XMC XM25QH16C/XM25QH16D Add initial support for the SPI flash chip XM25QH16C/XM25QH16D Datasheet link: https://www.xmcwh.com/uploads/798/XM25QH16C_Ver1.8.pdf Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/83182/1 diff --git a/flashchips.c b/flashchips.c index 10071fd..b667b46 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21899,6 +21899,44 @@ { .vendor = "XMC", + .name = "XM25QH16C/XM25QH16D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH16C, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 691ffc5..b59e759 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -853,6 +853,7 @@ #define XMC_XM25QH256C 0x4019 #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 +#define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QH16C/XM25QH16D
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/83181?usp=email ) Change subject: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/83181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ice38b2cfcf90ca2292302b227a3fc4796b9b34fb Gerrit-Change-Number: 83181 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QH16C/XM25QH16D
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83181?usp=email ) Change subject: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Add Support for XMC XM25QH16C/XM25QH16D Add initial support for the SPI flash chip XM25QH16C/XM25QH16D Datasheet link: https://www.xmcwh.com/uploads/798/XM25QH16C_Ver1.8.pdf Change-Id: Ice38b2cfcf90ca2292302b227a3fc4796b9b34fb Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/83181/1 diff --git a/flashchips.c b/flashchips.c index 6f3ea42..2b6100c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21937,6 +21937,44 @@ { .vendor = "XMC", + .name = "XM25QH16C/XM25QH16D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH16C, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index c3ceda0..62c6ce3 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -854,6 +854,7 @@ #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 #define XMC_XM25QU80B 0x5014 +#define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ice38b2cfcf90ca2292302b227a3fc4796b9b34fb Gerrit-Change-Number: 83181 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

[S] Change in flashrom[main]: Add Support for XMC XM25QU80B
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email ) Change subject: Add Support for XMC XM25QU80B ...................................................................... Add Support for XMC XM25QU80B Add initial support for the SPI flash chip XM25QU80B Datasheet link: https://www.xmcwh.com/uploads/520/XM25QU80B_Ver1.4.pdf Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5 Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/83180/1 diff --git a/flashchips.c b/flashchips.c index 10071fd..6f3ea42 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21899,6 +21899,44 @@ { .vendor = "XMC", + .name = "XM25QU80B", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QU80B, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256 } }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 691ffc5..c3ceda0 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -853,6 +853,7 @@ #define XMC_XM25QH256C 0x4019 #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 +#define XMC_XM25QU80B 0x5014 #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5 Gerrit-Change-Number: 83180 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

[L] Change in flashrom[main]: Add support for more XMC series
by Ssunk (Code Review) 23 Jun '24

23 Jun '24

Ssunk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/83089?usp=email ) Change subject: Add support for more XMC series ...................................................................... Abandoned Split commit -- To view, visit https://review.coreboot.org/c/flashrom/+/83089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4e4eec6553407466b4b84969a806f046f6bddcbf Gerrit-Change-Number: 83089 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB256E chip model
by Anastasia Klimchuk (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83140?usp=email ) Change subject: flashchips: add GD25LB256E chip model ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Gerrit-Change-Number: 83140 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:42:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB256E chip model
by Victor Lim (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83140?usp=email ) Change subject: flashchips: add GD25LB256E chip model ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83140/comment/7218858a_d944e298?us… : PS1, Line 12: > Could you please add here, in commit message, the operations that you tested? We usually add this in […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Gerrit-Change-Number: 83140 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 22 Jun 2024 02:01:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB256E chip model
by Victor Lim (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83140?usp=email ) Change subject: flashchips: add GD25LB256E chip model ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Added Tested read, write, erase, --wp-enable, --wp-disable, --wp-list and --wp-range (did not do erase by itself because it is already contained in the write operation) -- To view, visit https://review.coreboot.org/c/flashrom/+/83140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Gerrit-Change-Number: 83140 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 22 Jun 2024 02:00:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB256E chip model
by Victor Lim (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83140?usp=email to look at the new patch set (#2). Change subject: flashchips: add GD25LB256E chip model ...................................................................... flashchips: add GD25LB256E chip model adding GD25LB256E to the model GD25LR256E which share the same feature. The datasheet link https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Tested read, write, erase, --wp-enable, --wp-disable, --wp-list and --wp-range Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Signed-off-by: Victor Lim <vlim(a)gigadevice.com> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/83140/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f Gerrit-Change-Number: 83140 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[S] Change in flashrom[main]: ichspi: Add support for Panther Lake
by Subrata Banik (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email ) Change subject: ichspi: Add support for Panther Lake ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/83144/comment/01ee6570_67d88e9f?us… : PS2, Line 9: Panther Lake > > I am wondering, maybe there is a datasheet available? Asking for myself. […] Acknowledged File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83144/comment/1b306acd_b785525a?us… : PS2, Line 123: the chipset series with the '-c' parameter and one of the possible arguments > I think you need to add panther here too Acknowledged https://review.coreboot.org/c/flashrom/+/83144/comment/84ef6532_8abee7cb?us… : PS2, Line 251: else if (strcmp(csn, "panther") == 0) : cs = CHIPSET_PANTHER_LAKE; > I think the ich_descriptor_tool is run separately from flashrom. > Can you run it and add as one more test scenario? (and in a commit message too) > Thanks! Sure, I have submitted CB:83149 -- To view, visit https://review.coreboot.org/c/flashrom/+/83144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99cd8eb7cbb11381f8e8455b06cf90b9db77d8f0 Gerrit-Change-Number: 83144 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 15:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2024