Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email )
Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Kan, could you please rebase this patch on the latest main branch? […]
Hello, I've resolved the conflict, thanks
--
To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad
Gerrit-Change-Number: 83182
Gerrit-PatchSet: 3
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 13:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Ssunk, Stefan Reinauer.
Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/83182?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins)
Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
......................................................................
flashchips: Add Support for XMC XM25QH16C/XM25QH16D
Add initial support for the SPI flash chip XM25QH16C/XM25QH16D
Datasheet link: https://www.xmcwh.com/uploads/798/XM25QH16C_Ver1.8.pdf
Tested with ch341a programmer: probe, read, write, erase
Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad
Signed-off-by: Kan Sun <ssunkkan(a)gmail.com>
---
M flashchips.c
M include/flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/83182/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad
Gerrit-Change-Number: 83182
Gerrit-PatchSet: 3
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83227?usp=email )
Change subject: VERSION: Update version to 1.4.0-rc1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Note: finish and submit CB:83182 before this one
--
To view, visit https://review.coreboot.org/c/flashrom/+/83227?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I013a35de898cbd5c09d254baccb3d644c1def2a0
Gerrit-Change-Number: 83227
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Jun 2024 09:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No