June 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: how_to_add_new_chip: Add a section for feature bits and WRSR handling
by Hsuan-ting Chen (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Hsuan-ting Chen, Thomas Heijligen. Hello Anastasia Klimchuk, Hsuan Ting Chen, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/82908?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: how_to_add_new_chip: Add a section for feature bits and WRSR handling ...................................................................... how_to_add_new_chip: Add a section for feature bits and WRSR handling Feature bits are too complicated to understand if we only read the codes/datasheets. Add a new section in how_to_add_new_chip to add more details about each feature bits. Add the detailed explanation for WRSR handling first. If this new section looks good, I'll try to add some more sections in further commits. BUG=b:345154585 TEST=meson compile -C builddir and view the doc. Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M doc/contrib_howtos/how_to_add_new_chip.rst 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/82908/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/82908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Gerrit-Change-Number: 82908 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 28 Jun '24

28 Jun '24

Victor Lim has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... flashchips: Add chip models GD25LB256F/GD25LR256F GD25LB256F: 1.8V 256Mbit https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230926/DS-0… GD25LR256F: 1.8V 256Mbit with RPMC. https://www.gigadevice.com/message-board?cid=39&id=3171&file_type=Datasheet… Tested Erase, write, read, and protection. Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Signed-off-by: Victor <vlim(a)gigadevice.com> --- M flashchips.c 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83254/1 diff --git a/flashchips.c b/flashchips.c index aa16c50..b6110de 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6953,6 +6953,63 @@ }, { + .vendor = "GigaDevice", + .name = "GD25LB256F/GD25LR256F", + .bustype = BUS_SPI, + .manufacture_id = GIGADEVICE_ID, + .model_id = GIGADEVICE_GD25LQ255E, + .total_size = 32768, + .page_size = 256, + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR_EXT2 | FEATURE_4BA, + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_5C, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP4_SRWD, /* TODO: 2nd status reg (read with 0x35) */ + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1650, 2000}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .srl = {STATUS2, 0, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {STATUS1, 6, RW}, /* BP4 */ + .cmp = {STATUS2, 6, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, + }, + + { .vendor = "GigaDevice", .name = "GD25LR512ME", .bustype = BUS_SPI, -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc1
by Anastasia Klimchuk (Code Review) 28 Jun '24

28 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83227?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc1 ...................................................................... VERSION: Update version to 1.4.0-rc1 Change-Id: I013a35de898cbd5c09d254baccb3d644c1def2a0 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83227 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/VERSION b/VERSION index 90e4bc2..3280933 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.4.0-devel +1.4.0-rc1 -- To view, visit https://review.coreboot.org/c/flashrom/+/83227?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I013a35de898cbd5c09d254baccb3d644c1def2a0 Gerrit-Change-Number: 83227 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc1
by Peter Marheine (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83227?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83227?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I013a35de898cbd5c09d254baccb3d644c1def2a0 Gerrit-Change-Number: 83227 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 00:00:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc1
by Anastasia Klimchuk (Code Review) 27 Jun '24

27 Jun '24

Attention is currently required from: Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83227?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Note: finish and submit CB:83182 before this one Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83227?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I013a35de898cbd5c09d254baccb3d644c1def2a0 Gerrit-Change-Number: 83227 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 27 Jun 2024 23:19:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
by Anastasia Klimchuk (Code Review) 27 Jun '24

27 Jun '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... flashchips: Add Support for XMC XM25QH16C/XM25QH16D Add initial support for the SPI flash chip XM25QH16C/XM25QH16D Datasheet link: https://www.xmcwh.com/uploads/798/XM25QH16C_Ver1.8.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83182 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index aa16c50..1a7954c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21937,6 +21937,44 @@ { .vendor = "XMC", + .name = "XM25QH16C/XM25QH16D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH16C, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index d0c1aff..a43a0f9 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -848,6 +848,7 @@ #define XMC_XM25QH64C 0x4017 #define XMC_XM25QU64C 0x4117 #define XMC_XM25QU80B 0x5014 +#define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ #define XMC_XM25QH128A 0x7018 #define XMC_XM25QH128C 0x4018 #define XMC_XM25QU128C 0x4118 -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 4 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
by Anastasia Klimchuk (Code Review) 27 Jun '24

27 Jun '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad Gerrit-Change-Number: 83182 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 27 Jun 2024 21:16:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU512C/XM25QU512D
by Ssunk (Code Review) 27 Jun '24

27 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83243?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU512C/XM25QU512D ...................................................................... flashchips: Add Support for XMC XM25QU512C/XM25QU512D Add initial support for the SPI flash chip XM25QU512C/XM25QU512D Datasheet link: https://www.xmcwh.com/uploads/808/XM25QU512C_V1.6.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/83243/1 diff --git a/flashchips.c b/flashchips.c index 64677ca..499665f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22482,6 +22482,54 @@ }, { + .vendor = "XMC", + .name = "XM25QU512C/XM25QU512D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QU512C, + .total_size = 64*1024, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN + | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { .vendor = "XTX Technology Limited", .name = "XT25F02E", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index e4a9e28..678aa98 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -859,6 +859,7 @@ #define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 #define XMC_XM25QH512C 0x4020 /* Same as XM25QH512D */ +#define XMC_XM25QU512C 0x4120 /* Same as XM25QU512D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b Gerrit-Change-Number: 83243 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH512C/XM25QH512D
by Ssunk (Code Review) 27 Jun '24

27 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83242?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH512C/XM25QH512D ...................................................................... flashchips: Add Support for XMC XM25QH512C/XM25QH512D Add initial support for the SPI flash chip XM25QH512C/XM25QH512D Datasheet link: https://www.xmcwh.com/uploads/803/XM25QH512C_V1.6.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/83242/1 diff --git a/flashchips.c b/flashchips.c index 61c2127..64677ca 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22434,6 +22434,54 @@ }, { + .vendor = "XMC", + .name = "XM25QH512C/XM25QH512D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH512C, + .total_size = 64*1024, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN + | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { .vendor = "XTX Technology Limited", .name = "XT25F02E", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index 9b4b2f9..e4a9e28 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -858,6 +858,7 @@ #define XMC_XM25QH256C 0x4019 /* Same as XM25QH256D */ #define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 +#define XMC_XM25QH512C 0x4020 /* Same as XM25QH512D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83242?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f Gerrit-Change-Number: 83242 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU256D
by Ssunk (Code Review) 27 Jun '24

27 Jun '24

Ssunk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83241?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU256D ...................................................................... flashchips: Add Support for XMC XM25QU256D Add initial support for the SPI flash chip XM25QU256D (same as XM25QU256C) Datasheet link: https://www.xmcwh.com/uploads/224/XM25QU256C%20_%20Ver%202.0.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I504699160f804cfbacd189409596e105752d94eb Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/83241/1 diff --git a/flashchips.c b/flashchips.c index bfa6c4c..61c2127 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22351,7 +22351,7 @@ { .vendor = "XMC", - .name = "XM25QU256C", + .name = "XM25QU256C/XM25QU256D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QU256C, diff --git a/include/flashchips.h b/include/flashchips.h index f535e35..9b4b2f9 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -856,7 +856,7 @@ #define XMC_XM25QH128C 0x4018 /* Same as XM25QH128D */ #define XMC_XM25QU128C 0x4118 /* Same as XM25QU128D */ #define XMC_XM25QH256C 0x4019 /* Same as XM25QH256D */ -#define XMC_XM25QU256C 0x4119 +#define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 -- To view, visit https://review.coreboot.org/c/flashrom/+/83241?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I504699160f804cfbacd189409596e105752d94eb Gerrit-Change-Number: 83241 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2024