July 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: ni845x_spi: handle errors using goto during initialization
by Anastasia Klimchuk (Code Review) 19 Jul '23

19 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/72156?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ni845x_spi: handle errors using goto during initialization ...................................................................... ni845x_spi: handle errors using goto during initialization This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 Reviewed-on: https://review.coreboot.org/c/flashrom/+/72156 Reviewed-by: Miklós Márton <martonmiklosqdev(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M ni845x_spi.c 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved Miklós Márton: Looks good to me, approved diff --git a/ni845x_spi.c b/ni845x_spi.c index cb6b22e..58a8ef4 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -622,22 +622,24 @@ tmp = ni845xSpiConfigurationOpen(&configuration_handle); if (tmp != 0) { ni845x_report_error("ni845xSpiConfigurationOpen", tmp); - ni845x_spi_shutdown(NULL); - return 1; + goto err; } if (usb8452_spi_set_io_voltage(requested_io_voltage_mV, &io_voltage_in_mV, USE_LOWER, device_pid, device_handle) < 0) { - ni845x_spi_shutdown(NULL); - return 1; // no alert here usb8452_spi_set_io_voltage already printed that + // no alert here usb8452_spi_set_io_voltage already printed that + goto err; } if (ni845x_spi_set_speed(configuration_handle, spi_speed_KHz)) { msg_perr("Unable to set SPI speed\n"); - ni845x_spi_shutdown(NULL); - return 1; + goto err; } return register_spi_master(&spi_programmer_ni845x, NULL); + +err: + ni845x_spi_shutdown(NULL); + return 1; } const struct programmer_entry programmer_ni845x_spi = { -- To view, visit https://review.coreboot.org/c/flashrom/+/72156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Gerrit-Change-Number: 72156 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Anastasia Klimchuk (Code Review) 19 Jul '23

19 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ni845x_spi: pass global state through func params ...................................................................... ni845x_spi: pass global state through func params Instead of relying on global variables, pass and use their value or pointer to functions where possible. The usage of `io_voltage_in_mV` global var in `usb8452_spi_set_io_voltage` function is replaced with existing function argument `set_io_voltage_mV` since `set_io_voltage_mV` already contains the pointer to global var. This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 Reviewed-on: https://review.coreboot.org/c/flashrom/+/72154 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M ni845x_spi.c 1 file changed, 22 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/ni845x_spi.c b/ni845x_spi.c index 6e7bb76..cb6b22e 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -135,11 +135,11 @@ * @param opened_handle the opened handle from the ni845xOpen * @return the 0 on successful competition, negative error code on failure positive code on warning */ -static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle) +static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, enum USB845x_type pid) { // NI-845x driver loads the FPGA bitfile at the first time // which can take couple seconds - if (device_pid == USB8452) + if (pid == USB8452) msg_pwarn("Opening NI-8452, this might take a while for the first time\n"); int32 tmp = ni845xOpen(resource_handle, opened_handle); @@ -155,14 +155,14 @@ * @param serial a null terminated string containing the serial number of the specific device or NULL * @return the 0 on successful completion, negative error code on failure */ -static int ni845x_spi_open(const char *serial, uInt32 *return_handle) +static int ni845x_spi_open(const char *serial, uInt32 *return_handle, enum USB845x_type *pid) { char resource_name[256]; NiHandle device_find_handle; uInt32 found_devices_count = 0; int32 tmp = 0; - unsigned int vid, pid, usb_bus; + unsigned int vid, dev_pid, usb_bus; unsigned long int serial_as_number; int ret = -1; @@ -182,7 +182,7 @@ // and the DEADBEEF is the serial of the device if (sscanf(resource_name, "USB%u::0x%04X::0x%04X::%08lX::RAW", - &usb_bus, &vid, &pid, &serial_as_number) != 4) { + &usb_bus, &vid, &dev_pid, &serial_as_number) != 4) { // malformed resource string detected msg_pwarn("Warning: Unable to parse the %s NI-845x resource string.\n", resource_name); @@ -190,7 +190,7 @@ continue; } - device_pid = pid; + *pid = dev_pid; if (!serial || strtoul(serial, NULL, 16) == serial_as_number) break; @@ -205,7 +205,7 @@ } if (found_devices_count) - ret = ni845x_spi_open_resource(resource_name, return_handle); + ret = ni845x_spi_open_resource(resource_name, return_handle, *pid); _close_ret: tmp = ni845xCloseFindDeviceHandle(device_find_handle); @@ -227,14 +227,16 @@ */ static int usb8452_spi_set_io_voltage(uint16_t requested_io_voltage_mV, uint16_t *set_io_voltage_mV, - enum voltage_coerce_mode coerce_mode) + enum voltage_coerce_mode coerce_mode, + enum USB845x_type pid, + uInt32 device_handle) { unsigned int i = 0; uint8_t selected_voltage_100mV = 0; uint8_t requested_io_voltage_100mV = 0; - if (device_pid == USB8451) { - io_voltage_in_mV = 3300; + if (pid == USB8451) { + *set_io_voltage_mV = 3300; msg_pwarn("USB-8451 does not support the changing of the SPI IO voltage\n"); return 0; } @@ -307,7 +309,7 @@ * @param SCK_freq_in_KHz SCK speed in KHz * @return */ -static int ni845x_spi_set_speed(uint16_t SCK_freq_in_KHz) +static int ni845x_spi_set_speed(NiHandle configuration_handle, uint16_t SCK_freq_in_KHz) { int32 i = ni845xSpiConfigurationSetClockRate(configuration_handle, SCK_freq_in_KHz); uInt16 clock_freq_read_KHz; @@ -452,7 +454,9 @@ io_voltage_in_mV / 1000.0f); if (usb8452_spi_set_io_voltage(flash->chip->voltage.max, &io_voltage_in_mV, - USE_LOWER)) { + USE_LOWER, + device_pid, + device_handle)) { msg_perr("Unable to lower the IO voltage below " "the chip's maximum voltage\n"); return -1; @@ -475,7 +479,9 @@ io_voltage_in_mV / 1000.0f); if (usb8452_spi_set_io_voltage(flash->chip->voltage.min, &io_voltage_in_mV, - USE_HIGHER)) { + USE_HIGHER, + device_pid, + device_handle)) { msg_pwarn("Unable to raise the IO voltage above the chip's " "minimum voltage\n" "Flash operations might be unreliable.\n"); @@ -596,7 +602,7 @@ ignore_io_voltage_limits = true; } - if (ni845x_spi_open(serial_number, &device_handle)) { + if (ni845x_spi_open(serial_number, &device_handle, &device_pid)) { if (serial_number) { msg_pinfo("Could not find any connected NI USB-8451/8452 with serialnumber: %s!\n", serial_number); @@ -620,12 +626,12 @@ return 1; } - if (usb8452_spi_set_io_voltage(requested_io_voltage_mV, &io_voltage_in_mV, USE_LOWER) < 0) { + if (usb8452_spi_set_io_voltage(requested_io_voltage_mV, &io_voltage_in_mV, USE_LOWER, device_pid, device_handle) < 0) { ni845x_spi_shutdown(NULL); return 1; // no alert here usb8452_spi_set_io_voltage already printed that } - if (ni845x_spi_set_speed(spi_speed_KHz)) { + if (ni845x_spi_set_speed(configuration_handle, spi_speed_KHz)) { msg_perr("Unable to set SPI speed\n"); ni845x_spi_shutdown(NULL); return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/72154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: libflashrom: Add layout "exclude" API
by Edward O'Callaghan (Code Review) 18 Jul '23

18 Jul '23

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76005?usp=email ) Change subject: libflashrom: Add layout "exclude" API ...................................................................... libflashrom: Add layout "exclude" API Layouts can be expensive to derive (reading from flash), so we might want to reuse a layout for different purposes. Today, it's not possible to undo a flashrom_layout_include_region() operation (to, say, operate on a different region). Add such an API. Change-Id: I7ea3e0674f25e34bf2cfc8f464ae7ca1c1a3fbfd Signed-off-by: Brian Norris <briannorris(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76005 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nikolai Artemiev <nartemiev(a)google.com> --- M bindings/rust/libflashrom/src/lib.rs M include/libflashrom.h M layout.c M libflashrom.map M tests/layout.c 5 files changed, 58 insertions(+), 0 deletions(-) Approvals: Edward O'Callaghan: Looks good to me, approved Nikolai Artemiev: Looks good to me, approved build bot (Jenkins): Verified diff --git a/bindings/rust/libflashrom/src/lib.rs b/bindings/rust/libflashrom/src/lib.rs index 95fde56..3f3fbc0 100644 --- a/bindings/rust/libflashrom/src/lib.rs +++ b/bindings/rust/libflashrom/src/lib.rs @@ -879,6 +879,32 @@ } } + /// Exclude a region + /// + /// # Errors + /// + /// This function will return an error if the region is not a valid CString, + /// or if libflashrom returns an error. + pub fn exclude_region(&mut self, region: &str) -> std::result::Result<(), RegionError> { + let err = { + let region = CString::new(region)?; + unsafe { + libflashrom_sys::flashrom_layout_exclude_region( + self.layout.as_mut(), + region.as_ptr(), + ) + } + }; + if err != 0 { + Err(RegionError::ErrorCode(ErrorCode { + function: "flashrom_layout_exclude_region", + code: err, + })) + } else { + Ok(()) + } + } + /// Get the [`Range`] for the given region /// /// # Errors diff --git a/include/libflashrom.h b/include/libflashrom.h index 490ef03..e87776b 100644 --- a/include/libflashrom.h +++ b/include/libflashrom.h @@ -421,6 +421,16 @@ */ int flashrom_layout_include_region(struct flashrom_layout *layout, const char *name); /** + * @brief Mark given region as not included. + * + * @param layout The layout to alter. + * @param name The name of the region to exclude. + * + * @return 0 on success, + * 1 if the given name can't be found. + */ +int flashrom_layout_exclude_region(struct flashrom_layout *layout, const char *name); +/** * @brief Get given region's offset and length. * * @param[in] layout The existing layout. diff --git a/layout.c b/layout.c index cddd908..e46e61a 100644 --- a/layout.c +++ b/layout.c @@ -217,6 +217,17 @@ return 1; } +/* returns 0 to indicate success, 1 to indicate failure */ +static int exclude_region(struct flashrom_layout *const l, const char *name) +{ + struct romentry *const entry = _layout_entry_by_name(l, name); + if (entry) { + entry->included = false; + return 0; + } + return 1; +} + /* returns -1 if an entry is not found, 0 if found. */ static int romentry_exists(struct flashrom_layout *const l, char *name, char *file) { @@ -441,6 +452,11 @@ return include_region(layout, name, NULL); } +int flashrom_layout_exclude_region(struct flashrom_layout *const layout, const char *name) +{ + return exclude_region(layout, name); +} + int flashrom_layout_get_region_range(struct flashrom_layout *const l, const char *name, unsigned int *start, unsigned int *len) { diff --git a/libflashrom.map b/libflashrom.map index e3c7a76..77abf72 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -15,6 +15,7 @@ flashrom_image_write; flashrom_init; flashrom_layout_add_region; + flashrom_layout_exclude_region; flashrom_layout_get_region_range; flashrom_layout_include_region; flashrom_layout_new; diff --git a/tests/layout.c b/tests/layout.c index e71debf..917d77e 100644 --- a/tests/layout.c +++ b/tests/layout.c @@ -110,6 +110,8 @@ unsigned int region_start = 0x00021000; unsigned int region_end = 0x00031000; + unsigned int region2_start = 0x00041000; + unsigned int region2_end = 0x00051000; unsigned int start = 0; unsigned int len = 0; @@ -119,6 +121,9 @@ assert_int_equal(0, flashrom_layout_new(&layout)); assert_int_equal(0, flashrom_layout_add_region(layout, region_start, region_end, "region")); assert_int_equal(0, flashrom_layout_include_region(layout, "region")); + assert_int_equal(0, flashrom_layout_add_region(layout, region2_start, region2_end, "region2")); + assert_int_equal(0, flashrom_layout_include_region(layout, "region2")); + assert_int_equal(0, flashrom_layout_exclude_region(layout, "region2")); printf("done\n"); printf("Asserting region range... "); -- To view, visit https://review.coreboot.org/c/flashrom/+/76005?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ea3e0674f25e34bf2cfc8f464ae7ca1c1a3fbfd Gerrit-Change-Number: 76005 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Peter Marheine (Code Review) 17 Jul '23

17 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email ) Change subject: doc: Add new Development guidelines ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Jul 2023 01:31:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Peter Marheine (Code Review) 17 Jul '23

17 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Stefan Reinauer, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Seems fine, but I think we either need to get confirmation from the Coreboot arbitration team (listed in the linked doc) that they're willing to support Flashrom in that role, or nominate a Flashrom arbitration team and include their contact information in our doc. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 17 Jul 2023 01:31:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add XTX XT25F64B
by Anastasia Klimchuk (Code Review) 17 Jul '23

17 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58173?usp=email ) Change subject: flashchips: Add XTX XT25F64B ...................................................................... flashchips: Add XTX XT25F64B Datasheet: http://file2.dzsc.com/product/19/06/22/216185_132959081.pdf Tested probe, read, erase and write with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/58173 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index d1ce20d..4ca37a7 100644 --- a/flashchips.c +++ b/flashchips.c @@ -20967,6 +20967,46 @@ }, { + .vendor = "XTX Technology Limited", + .name = "XT25F64B", + .bustype = BUS_SPI, + .manufacture_id = XTX_ID, + .model_id = XTX_XT25F64B, + .total_size = 8 * 1024, + .page_size = 256, + /* Supports SFDP */ + /* OTP: 4 x 256 bytes */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP4_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { .vendor = "Zetta Device", .name = "ZD25D20", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index 3bbd573..9e2564c 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1041,6 +1041,9 @@ #define WINBOND_W49V002A 0xB0 #define WINBOND_W49V002FA 0x32 +#define XTX_ID 0x0B /* XTX Technology Limited */ +#define XTX_XT25F64B 0x4017 + #define ZETTADEVICE_ID 0xBA /* Zetta Device */ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 -- To view, visit https://review.coreboot.org/c/flashrom/+/58173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 Gerrit-Change-Number: 58173 Gerrit-PatchSet: 4 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: libflashrom: Add layout "exclude" API
by Nikolai Artemiev (Code Review) 17 Jul '23

17 Jul '23

Attention is currently required from: Brian Norris. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76005?usp=email ) Change subject: libflashrom: Add layout "exclude" API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > I don't seem to have Submit permissions. […] Edward or Anastasia can submit this -- To view, visit https://review.coreboot.org/c/flashrom/+/76005?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ea3e0674f25e34bf2cfc8f464ae7ca1c1a3fbfd Gerrit-Change-Number: 76005 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Jul 2023 00:23:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add Team page which describes Gerrit groups
by Stefan Reinauer (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76075?usp=email ) Change subject: doc: Add Team page which describes Gerrit groups ...................................................................... Patch Set 3: Code-Review+2 (16 comments) Patchset: PS3: Random thoughts and rephrases, feel free to ignore File doc/about_flashrom/team.rst: https://review.coreboot.org/c/flashrom/+/76075/comment/af381d7a_cee36e4a : PS3, Line 9: All contributors and users are expected to follow Development guidelines, : Code of Conduct and Friendliness guidelines. We kindly request all contributors and users to adhere to our Development guidelines, Code of Conduct, and Friendliness guidelines. https://review.coreboot.org/c/flashrom/+/76075/comment/1e39393c_89fda9bc : PS3, Line 12: . : https://review.coreboot.org/c/flashrom/+/76075/comment/b51580d1_85e6bbe8 : PS3, Line 16: : Members of the group can do full approval of patches (i.e. vote +2). : : In general, members of the group have some area of responsibility in the MAINTAINERS file, : and are automatically added as reviewers to patches when the patch touches this area. : : The responsibilities are the following. : : * React to patches when added as a reviewer. : : * Try to respond to technical questions on the mailing list if the topic is something you know about : and can provide a useful response. : : * Know development guidelines and check the patches you are reviewing align with the guidelines. This group is made up of individuals who hold the authority to fully approve patches, signified by a +2 vote. As a rule, members of this group often shoulder specific responsibilities noted in the MAINTAINERS file and are automatically included as reviewers for patches that touch upon their areas of responsibility. Here is a list of what's expected from a member of this group: * Engage with patches when marked as a reviewer. * If a technical question is within your area of expertise, strive to respond on the mailing list with a useful answer. * Be familiar with the development guidelines and ensure the patches under your review adhere to these standards. https://review.coreboot.org/c/flashrom/+/76075/comment/fe3f417d_534381c3 : PS3, Line 34: Members of the group can merge patches. : The responsibilities for the members of the group are described in more details below. Members of this group are authorized to merge patches. Below is a more detailed description of the group members' duties. https://review.coreboot.org/c/flashrom/+/76075/comment/4f41e920_983aff7e : PS3, Line 37: There is no expectation on how much time you spend on your duties, some non-zero amount of time, : whatever capacity you have. But in general, you stay around on flashrom. : We don't set any stringent demands on how much time you should devote to your duties. Any non-zero amount of time, as per your capacity, is appreciated. However, consistent engagement with flashrom and the community is expected. https://review.coreboot.org/c/flashrom/+/76075/comment/3446319f_c2fc04af : PS3, Line 40: If you disappear for some time (life happens), especially for a longer time, like several months, : especially without a warning: you implicitly agree that the others will handle the duties and make decisions if needed : (potentially without waiting for you to come back, if the decision is needed quickly). : If circumstances cause you to step away for a considerable length of time, particularly for several months and especially without notice, it is assumed that the remaining team members will take up your responsibilities and make necessary decisions (possibly without waiting for your return if a quick decision is required). https://review.coreboot.org/c/flashrom/+/76075/comment/4ac0b989_d9e869ef : PS3, Line 44: Merge all contributors's patches (when they are ready), not just your own. Merge all contributors' patches when they're ready, not just their own. https://review.coreboot.org/c/flashrom/+/76075/comment/00887a59_bb400483 : PS3, Line 44: * Members of this group are expected to: https://review.coreboot.org/c/flashrom/+/76075/comment/7b07270e_a89ba87d : PS3, Line 46: Be at least vaguely aware what development efforts are ongoing, this helps to make decisions : in what order the patches should be merged, and where could be merge conflicts. Maintain a basic awareness of ongoing development efforts to aid decision-making regarding the sequence of patch merging and possible merge conflicts. https://review.coreboot.org/c/flashrom/+/76075/comment/0d13c190_c52dea4e : PS3, Line 49: Know development guidelines, and educate other contributors if needed (e.g. give links). Understand the development guidelines and guide other contributors if necessary, for example by providing relevant links. https://review.coreboot.org/c/flashrom/+/76075/comment/962e9577_c0b206b1 : PS3, Line 51: * React to patches when added as a reviewer. Engage with patches when marked as a reviewer. https://review.coreboot.org/c/flashrom/+/76075/comment/d3c27f0c_d52d28cc : PS3, Line 53: * Try to respond to technical questions on the mailing list if the topic is something you know about : and can provide a useful response. : Attempt to respond to technical inquiries on the mailing list if the topic falls within your knowledge and you can provide a helpful response. https://review.coreboot.org/c/flashrom/+/76075/comment/932f4753_e95c8196 : PS3, Line 56: * From time to time show up in real-time channel(s) and/or dev meetings. Occasionally participate in real-time channels and/or developer meetings. https://review.coreboot.org/c/flashrom/+/76075/comment/033bdbf4_5205aced : PS3, Line 58: * Follow the Code of Conduct and Friendliness guidelines, be a good example for others. : : Adhere to the Code of Conduct and Friendliness guidelines, setting a positive example for others. https://review.coreboot.org/c/flashrom/+/76075/comment/39edaadb_ffe5fe73 : PS3, Line 60: * Bonus point: if you work in a [software] company, educate and help contributors from your company : with upstream culture and dev guidelines. : Bonus: If you're employed at a company that uses flashrom, please try to guide and educate your company's contributors about the upstream culture and development guidelines. -- To view, visit https://review.coreboot.org/c/flashrom/+/76075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3118b2b036eab93e901814447543b02c760c6a80 Gerrit-Change-Number: 76075 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 15 Jul 2023 18:46:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Alexander Goncharov (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email ) Change subject: doc: Add new Development guidelines ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Sat, 15 Jul 2023 13:18:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email ) Change subject: doc: Add new Development guidelines ...................................................................... Patch Set 7: (1 comment) File doc/dev_guide/development_guide.rst: https://review.coreboot.org/c/flashrom/+/75906/comment/69c37b9a_e63f4268 : PS6, Line 209: `git push upstream HEAD:refs/for/master%topic=example_topic` > missing `:code:` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 13:13:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023