July 2023 - flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Peter Marheine (Code Review) 14 Jul '23

14 Jul '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email ) Change subject: doc: Add new Development guidelines ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 13 Jul 2023 23:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add Team page which describes Gerrit groups
by Peter Marheine (Code Review) 14 Jul '23

14 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76075?usp=email ) Change subject: doc: Add Team page which describes Gerrit groups ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/76075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3118b2b036eab93e901814447543b02c760c6a80 Gerrit-Change-Number: 76075 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 13 Jul 2023 23:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for IS25WQ040
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Thomas Heijligen, Vasily Galkin, roman.stingler(a)gmail.com. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email ) Change subject: flashchips.c: Add support for IS25WQ040 ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: Vasily, I am so sorry your patch got lost and is waiting for so long! I hope you are still here. I have two small comments, and that should be it. Also, if you could rebase your patch that would be great. It is currently in "merge conflict" state because other stuff has been merged meanwhile. Thank you! File flashchips.c: https://review.coreboot.org/c/flashrom/+/58179/comment/5036ccc3_a339dee2 : PS5, Line 7792: 1024B Page 47 says OTP is 256Bytes ? Also are you sure about read and write? https://review.coreboot.org/c/flashrom/+/58179/comment/f654f473_8d74b449 : PS5, Line 7793: /* QPI enable 0x35, disable 0xF5 */ QPI is not in the datasheet? -- To view, visit https://review.coreboot.org/c/flashrom/+/58179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 5 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vasily Galkin Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 13 Jul 2023 13:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email ) Change subject: doc: Add new Development guidelines ...................................................................... Patch Set 6: (4 comments) File doc/dev_guide/development_guide.rst: https://review.coreboot.org/c/flashrom/+/75906/comment/da59936d_45acc7bf : PS5, Line 161: approproately > typo: appropriately Done https://review.coreboot.org/c/flashrom/+/75906/comment/cfa92148_48e072ff : PS5, Line 235: you > typo: your Done https://review.coreboot.org/c/flashrom/+/75906/comment/b718d54f_8474a520 : PS5, Line 235: -s > If the commit is already signed-off, will this add another signoff (probably not intended), or will […] I am using this command all the time without thinking (muscle memory) and it does not add second line of the same sign-off. It adds sign-off line at the end of commit message, and then if it exists already than does nothing. One caveat: if, after first time signing-off, you manually edit commit message to move sign-off line somewhere else, like in the middle of commit message (why would you even do it? :) ), then it adds the line one more time at the end. Because it always adds line at the end. File doc/dev_guide/development_guidelines.rst: https://review.coreboot.org/c/flashrom/+/75906/comment/5fae8f17_9990470d : PS2, Line 194: you can add Anastasia Klimchuk as a reviewer > Is anyone interested to put your name here too? ;) The question stays valid, but this patch is not blocked on it, so I am marking as resolved. -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 13 Jul 2023 11:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Hello Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75906?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+2 by Peter Marheine, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc: Add new Development guidelines ...................................................................... doc: Add new Development guidelines Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contact.rst A doc/dev_guide/development_guide.rst M doc/dev_guide/index.rst 3 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/75906/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Patrick Georgi (Code Review) 13 Jul '23

13 Jul '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75727?usp=email ) Change subject: doc: Add documentation license ...................................................................... doc: Add documentation license Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75727 Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A doc/documentation_license.rst M doc/index.rst 2 files changed, 297 insertions(+), 0 deletions(-) Approvals: Patrick Georgi: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/documentation_license.rst b/doc/documentation_license.rst new file mode 100644 index 0000000..ebadeb7 --- /dev/null +++ b/doc/documentation_license.rst @@ -0,0 +1,296 @@ +===================== +Documentation license +===================== + +Files under doc/ are licensed under CC-BY 4.0 terms, printed below. + +Attribution 4.0 International +============================= + +Creative Commons Corporation ("Creative Commons") is not a law firm and does not provide +legal services or legal advice. Distribution of Creative Commons public licenses does +not create a lawyer-client or other relationship. Creative Commons makes its licenses +and related information available on an "as-is" basis. Creative Commons gives no warranties +regarding its licenses, any material licensed under their terms and conditions, or any +related information. Creative Commons disclaims all liability for damages resulting from +their use to the fullest extent possible. + +Using Creative Commons Public Licenses +-------------------------------------- + +Creative Commons public licenses provide a standard set of terms and conditions that +creators and other rights holders may use to share original works of authorship and other +material subject to copyright and certain other rights specified in the public license below. +The following considerations are for informational purposes only, are not exhaustive, and do +not form part of our licenses. + +* **Considerations for licensors:** Our public licenses are intended for use by those + authorized to give the public permission to use material in ways otherwise restricted + by copyright and certain other rights. Our licenses are irrevocable. Licensors should + read and understand the terms and conditions of the license they choose before applying it. + Licensors should also secure all rights necessary before applying our licenses so that the + public can reuse the material as expected. Licensors should clearly mark any material not + subject to the license. This includes other CC-licensed material, or material used under an + exception or limitation to copyright. `More considerations for licensors <http://wiki.creativecommons.org/Considerations_for_licensors_and_licensees#…>`_ + +* **Considerations for the public:** By using one of our public licenses, a licensor grants + the public permission to use the licensed material under specified terms and conditions. If + the licensor's permission is not necessary for any reason - for example, because of any + applicable exception or limitation to copyright - then that use is not regulated by the + license. Our licenses grant only permissions under copyright and certain other rights that a + licensor has authority to grant. Use of the licensed material may still be restricted for + other reasons, including because others have copyright or other rights in the material. + A licensor may make special requests, such as asking that all changes be marked or described. + Although not required by our licenses, you are encouraged to respect those requests where + reasonable. `More considerations for the public <http://wiki.creativecommons.org/Considerations_for_licensors_and_licensees#…>`_ + +Creative Commons Attribution 4.0 International Public License +============================================================= + +By exercising the Licensed Rights (defined below), You accept and agree to be bound by the +terms and conditions of this Creative Commons Attribution 4.0 International Public License +("Public License"). To the extent this Public License may be interpreted as a contract, You +are granted the Licensed Rights in consideration of Your acceptance of these terms and +conditions, and the Licensor grants You such rights in consideration of benefits the Licensor +receives from making the Licensed Material available under these terms and conditions. + +Section 1 - Definitions. +------------------------ + +\a. **Adapted Material** means material subject to Copyright and Similar Rights that is +derived from or based upon the Licensed Material and in which the Licensed Material is +translated, altered, arranged, transformed, or otherwise modified in a manner requiring +permission under the Copyright and Similar Rights held by the Licensor. For purposes of +this Public License, where the Licensed Material is a musical work, performance, or sound +recording, Adapted Material is always produced where the Licensed Material is synched in +timed relation with a moving image. + +\b. **Adapter's License** means the license You apply to Your Copyright and Similar Rights +in Your contributions to Adapted Material in accordance with the terms and conditions of +this Public License. + +\c. **Copyright and Similar Rights** means copyright and/or similar rights closely related +to copyright including, without limitation, performance, broadcast, sound recording, and +Sui Generis Database Rights, without regard to how the rights are labeled or categorized. +For purposes of this Public License, the rights specified in Section 2(b)(1)-(2) are not +Copyright and Similar Rights. + +\d. **Effective Technological Measures** means those measures that, in the absence of proper +authority, may not be circumvented under laws fulfilling obligations under Article 11 of +the WIPO Copyright Treaty adopted on December 20, 1996, and/or similar international agreements. + +\e. **Exceptions and Limitations** means fair use, fair dealing, and/or any other exception or +limitation to Copyright and Similar Rights that applies to Your use of the Licensed Material. + +\f. **Licensed Material** means the artistic or literary work, database, or other material to +which the Licensor applied this Public License. + +\g. **Licensed Rights** means the rights granted to You subject to the terms and conditions of +this Public License, which are limited to all Copyright and Similar Rights that apply to Your +use of the Licensed Material and that the Licensor has authority to license. + +\h. **Licensor** means the individual(s) or entity(ies) granting rights under this Public License. + +\i. **Share** means to provide material to the public by any means or process that requires +permission under the Licensed Rights, such as reproduction, public display, public performance, +distribution, dissemination, communication, or importation, and to make material available to +the public including in ways that members of the public may access the material from a place +and at a time individually chosen by them. + +\j. **Sui Generis Database Rights** means rights other than copyright resulting from Directive 96/9/EC +of the European Parliament and of the Council of 11 March 1996 on the legal protection of databases, +as amended and/or succeeded, as well as other essentially equivalent rights anywhere in the world. + +\k. **You** means the individual or entity exercising the Licensed Rights under this Public License. +Your has a corresponding meaning. + +Section 2 - Scope. +------------------ + +\a. **License grant.** + + 1) Subject to the terms and conditions of this Public License, the Licensor hereby grants You a worldwide, + royalty-free, non-sublicensable, non-exclusive, irrevocable license to exercise the Licensed Rights in + the Licensed Material to: + + \A. reproduce and Share the Licensed Material, in whole or in part; and + + \B. produce, reproduce, and Share Adapted Material. + + 2) **Exceptions and Limitations.** For the avoidance of doubt, where Exceptions and Limitations apply + to Your use, this Public License does not apply, and You do not need to comply with its terms and conditions. + + 3) **Term.** The term of this Public License is specified in Section 6(a). + + 4) **Media and formats; technical modifications allowed.** The Licensor authorizes You to exercise + the Licensed Rights in all media and formats whether now known or hereafter created, and to make + technical modifications necessary to do so. The Licensor waives and/or agrees not to assert any right + or authority to forbid You from making technical modifications necessary to exercise the Licensed Rights, + including technical modifications necessary to circumvent Effective Technological Measures. For purposes + of this Public License, simply making modifications authorized by this Section 2(a)(4) never produces Adapted Material. + + 5) **Downstream recipients.** + + \A. **Offer from the Licensor - Licensed Material.** Every recipient of the Licensed Material + automatically receives an offer from the Licensor to exercise the Licensed Rights under the + terms and conditions of this Public License. + + \B. **No downstream restrictions.** You may not offer or impose any additional or different terms + or conditions on, or apply any Effective Technological Measures to, the Licensed Material if + doing so restricts exercise of the Licensed Rights by any recipient of the Licensed Material. + + 6) **No endorsement.** Nothing in this Public License constitutes or may be construed as permission + to assert or imply that You are, or that Your use of the Licensed Material is, connected with, or + sponsored, endorsed, or granted official status by, the Licensor or others designated to receive + attribution as provided in Section 3(a)(1)(A)(i). + +\b. **Other rights.** + + 1) Moral rights, such as the right of integrity, are not licensed under this Public License, nor are + publicity, privacy, and/or other similar personality rights; however, to the extent possible, the + Licensor waives and/or agrees not to assert any such rights held by the Licensor to the limited extent + necessary to allow You to exercise the Licensed Rights, but not otherwise. + + 2) Patent and trademark rights are not licensed under this Public License. + + 3) To the extent possible, the Licensor waives any right to collect royalties from You for the exercise + of the Licensed Rights, whether directly or through a collecting society under any voluntary or waivable + statutory or compulsory licensing scheme. In all other cases the Licensor expressly reserves any right + to collect such royalties. + +Section 3 - License Conditions. +------------------------------- + +Your exercise of the Licensed Rights is expressly made subject to the following conditions. + +\a. **Attribution.** + + 1) If You Share the Licensed Material (including in modified form), You must: + + \A. retain the following if it is supplied by the Licensor with the Licensed Material: + + \i. identification of the creator(s) of the Licensed Material and any others designated to receive + attribution, in any reasonable manner requested by the Licensor (including by pseudonym if designated); + + \ii. a copyright notice; + + \iii. a notice that refers to this Public License; + + \iv. a notice that refers to the disclaimer of warranties; + + \v. a URI or hyperlink to the Licensed Material to the extent reasonably practicable; + + \B. indicate if You modified the Licensed Material and retain an indication of any previous modifications; and + + \C. indicate the Licensed Material is licensed under this Public License, and include the text of, + or the URI or hyperlink to, this Public License. + + 2. You may satisfy the conditions in Section 3(a)(1) in any reasonable manner based on the medium, means, + and context in which You Share the Licensed Material. For example, it may be reasonable to satisfy the + conditions by providing a URI or hyperlink to a resource that includes the required information. + + 3. If requested by the Licensor, You must remove any of the information required by Section 3(a)(1)(A) to + the extent reasonably practicable. + + 4. If You Share Adapted Material You produce, the Adapter's License You apply must not prevent recipients + of the Adapted Material from complying with this Public License. + +Section 4 - Sui Generis Database Rights. +---------------------------------------- + +Where the Licensed Rights include Sui Generis Database Rights that apply to Your use of the Licensed Material: + +\a. for the avoidance of doubt, Section 2(a)(1) grants You the right to extract, reuse, reproduce, and Share +all or a substantial portion of the contents of the database; + +\b. if You include all or a substantial portion of the database contents in a database in which You have +Sui Generis Database Rights, then the database in which You have Sui Generis Database Rights (but not its +individual contents) is Adapted Material; and + +\c. You must comply with the conditions in Section 3(a) if You Share all or a substantial portion of the +contents of the database. + +For the avoidance of doubt, this Section 4 supplements and does not replace Your obligations under this +Public License where the Licensed Rights include other Copyright and Similar Rights. + +Section 5 - Disclaimer of Warranties and Limitation of Liability. +----------------------------------------------------------------- + +\a. **Unless otherwise separately undertaken by the Licensor, to the extent possible, the Licensor offers +the Licensed Material as-is and as-available, and makes no representations or warranties of any kind +oncerning the Licensed Material, whether express, implied, statutory, or other. This includes, without +limitation, warranties of title, merchantability, fitness for a particular purpose, non-infringement, +absence of latent or other defects, accuracy, or the presence or absence of errors, whether or not known +or discoverable. Where disclaimers of warranties are not allowed in full or in part, this disclaimer may +not apply to You.** + +\b. **To the extent possible, in no event will the Licensor be liable to You on any legal theory (including, +without limitation, negligence) or otherwise for any direct, special, indirect, incidental, consequential, +punitive, exemplary, or other losses, costs, expenses, or damages arising out of this Public License or use +of the Licensed Material, even if the Licensor has been advised of the possibility of such losses, costs, +expenses, or damages. Where a limitation of liability is not allowed in full or in part, this limitation +may not apply to You.** + +\c. The disclaimer of warranties and limitation of liability provided above shall be interpreted in a manner that, +to the extent possible, most closely approximates an absolute disclaimer and waiver of all liability. + +Section 6 - Term and Termination. +--------------------------------- + +\a. This Public License applies for the term of the Copyright and Similar Rights licensed here. However, if You +fail to comply with this Public License, then Your rights under this Public License terminate automatically. + +\b. Where Your right to use the Licensed Material has terminated under Section 6(a), it reinstates: + + 1) automatically as of the date the violation is cured, provided it is cured within 30 days of Your + discovery of the violation; or + + 2) upon express reinstatement by the Licensor. + + For the avoidance of doubt, this Section 6(b) does not affect any right the Licensor may have to seek + remedies for Your violations of this Public License. + +\c. For the avoidance of doubt, the Licensor may also offer the Licensed Material under separate terms or +conditions or stop distributing the Licensed Material at any time; however, doing so will not terminate this Public License. + +\d. Sections 1, 5, 6, 7, and 8 survive termination of this Public License. + +Section 7 - Other Terms and Conditions. +--------------------------------------- + +\a. The Licensor shall not be bound by any additional or different terms or conditions communicated by You +unless expressly agreed. + +\b. Any arrangements, understandings, or agreements regarding the Licensed Material not stated herein are +separate from and independent of the terms and conditions of this Public License. + +Section 8 - Interpretation. +--------------------------- + +\a. For the avoidance of doubt, this Public License does not, and shall not be interpreted to, reduce, limit, +restrict, or impose conditions on any use of the Licensed Material that could lawfully be made without +permission under this Public License. + +\b. To the extent possible, if any provision of this Public License is deemed unenforceable, it shall be +automatically reformed to the minimum extent necessary to make it enforceable. If the provision cannot +be reformed, it shall be severed from this Public License without affecting the enforceability of the +remaining terms and conditions. + +\c. No term or condition of this Public License will be waived and no failure to comply consented to unless +expressly agreed to by the Licensor. + +\d. Nothing in this Public License constitutes or may be interpreted as a limitation upon, or waiver of, any +privileges and immunities that apply to the Licensor or You, including from the legal processes of any +jurisdiction or authority. + + Creative Commons is not a party to its public licenses. Notwithstanding, Creative Commons may elect + to apply one of its public licenses to material it publishes and in those instances will be considered + the "Licensor". Except for the limited purpose of indicating that material is shared under a + Creative Commons public license or as otherwise permitted by the Creative Commons policies published at + `creativecommons.org/policies <http://creativecommons.org/policies>`_, Creative Commons does not authorize + the use of the trademark "Creative Commons" or any other trademark or logo of Creative Commons without + its prior written consent including, without limitation, in connection with any unauthorized modifications + to any of its public licenses or any other arrangements, understandings, or agreements concerning use of + licensed material. For the avoidance of doubt, this paragraph does not form part of the public licenses. + + Creative Commons may be contacted at creativecommons.org diff --git a/doc/index.rst b/doc/index.rst index f48a214..6a0f815 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -10,6 +10,7 @@ classic_cli_manpage contact how_to_add_docs + documentation_license .. include:: intro.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Patrick Georgi (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Stefan Reinauer, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75727?usp=email ) Change subject: doc: Add documentation license ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 13 Jul 2023 10:36:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Alexander Goncharov, Patrick Georgi, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75727?usp=email ) Change subject: doc: Add documentation license ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Patrick, or Stefan, if this page is all good, would you approve the patch? Thank you! File doc/documentation_license.rst: https://review.coreboot.org/c/flashrom/+/75727/comment/e88d2739_964c294f : PS3, Line 2: flashrom documentation license > My point is that we do not write "flashrom developers documentation" or "flashrom contact" because i […] Done, renamed to "Documentation license". More than one line in toctree is a good point! -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 13 Jul 2023 10:18:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Patrick Georgi, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Patrick Georgi, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75727?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Alexander Goncharov, Verified+1 by build bot (Jenkins) Change subject: doc: Add documentation license ...................................................................... doc: Add documentation license Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A doc/documentation_license.rst M doc/index.rst 2 files changed, 297 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/75727/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: meson: improve error message for unsupported systems
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75490?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: meson: improve error message for unsupported systems ...................................................................... meson: improve error message for unsupported systems This adds the current and supported system information to the error message when an unsupported programmer is requested, making it easier to tell what the incompatibility is. TEST=(in mingw-ucrt64) meson setup -Dprogrammer=ni845x_spi build, error message says the programmer needs `['windows']/['x86']` but the system is `windows/x86_64`. Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75490 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M meson.build 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/meson.build b/meson.build index 9428e08..77d941e 100644 --- a/meson.build +++ b/meson.build @@ -561,7 +561,13 @@ if selected_hard if not available - error(p_name + ' selected but not supported on this platform') + error('programmer @0@ was selected but is not supported on this platform (needs @1@/@2@, but system is @3@/@4@)'.format( + p_name, + p_data.get('systems'), + p_data.get('cpu_families'), + host_machine.system(), + host_machine.cpu_family() + )) elif not deps_found error(p_name + ' selected but dependency ' + not_found_dep +'not found') else -- To view, visit https://review.coreboot.org/c/flashrom/+/75490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c8a8b47505f7a239160d565463ce7262fe5d5d6 Gerrit-Change-Number: 75490 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023