July 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Alexander Goncharov (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Miklós Márton. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email ) Change subject: ni845x_spi: pass global state through func params ...................................................................... Patch Set 7: (2 comments) Patchset: PS2: > Great, thanks for compiling! That's very good news. […] Yes, I can confirm that it builds with/without NI-845x on Windows (MSYS2 MINGW32) via make/meson build systems, and without NI-845x on my host Linux just fine. Patchset: PS6: > Joursoir, could you please rebase because the other chain was merged and now this is in "merge confl […] Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/72154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sat, 15 Jul 2023 13:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add new Development guidelines
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen. Hello Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75906?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by Alexander Goncharov, Code-Review+2 by Peter Marheine, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc: Add new Development guidelines ...................................................................... doc: Add new Development guidelines Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contact.rst A doc/dev_guide/development_guide.rst M doc/dev_guide/index.rst 3 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/75906/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/75906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928 Gerrit-Change-Number: 75906 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ni845x_spi: introduce a separate func for cleaning up
by Alexander Goncharov (Code Review) 15 Jul '23

15 Jul '23

Alexander Goncharov has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72159?usp=email ) Change subject: ni845x_spi: introduce a separate func for cleaning up ...................................................................... Abandoned better solution found -- To view, visit https://review.coreboot.org/c/flashrom/+/72159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b32129b8d0dff9a7516973893fa4bf92f9e64db Gerrit-Change-Number: 72159 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) File doc/about_flashrom/code_of_conduct.rst: https://review.coreboot.org/c/flashrom/+/76455/comment/44a9a9ae_e3590a82 : PS1, Line 5: flashrom follows coreboot's `Code of Conduct <https://doc.coreboot.org/community/code_of_conduct.html>`_. > any reason not to just copy coreboot's document instead of pointing to it? But why copying if we can just link? There could be amendments to coreboot's doc, why would we spend an effort to maintain an exact copy, and copying all amendments? this would mean tracking all the patches and copying the same patches here? I can imagine in future, if there is a desire and energy to create a flashrom's CoC, then it could start from copying and then adding modifications. But for now we can share CoC I think. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 12:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Angel Pons, Peter Marheine, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76455?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Add code of conduct ...................................................................... doc: Add code of conduct For now link to coreboot's one, in the absence of our own. It is always possible to create our own later, if desired, but meanwhile we can share code of conduct with coreboot. We do have the same servers and infrastructure anyway. Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A doc/about_flashrom/code_of_conduct.rst M doc/about_flashrom/index.rst M doc/about_flashrom/team.rst 3 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/76455/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: change chip lock status funcs for Winbond chips
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email ) Change subject: flashchips: change chip lock status funcs for Winbond chips ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/75877/comment/7128be6d_2777334f : PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032 > I opened datasheets and looked up the function that allows to display all the data from the Status R […] I agree with renaming, these names are long already so long name is fine. But new name will be actually more useful (self-documenting!) The only thing I would change, is to have the order of registers in the order of how they are printed, which I think is: SRWD_SEC_TB_BP2_WELWIP -- To view, visit https://review.coreboot.org/c/flashrom/+/75877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49 Gerrit-Change-Number: 75877 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 10:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Miklós Márton. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160?usp=email ) Change subject: ni845x_spi: refactor singleton states into reentrant pattern ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/72160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Gerrit-Change-Number: 72160 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 10:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Miklós Márton. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email ) Change subject: ni845x_spi: pass global state through func params ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS2: > Thanks to the now available build instructions for NI-845x on Windows. […] Great, thanks for compiling! That's very good news. About testing on HW: Miklos hopefully will be able to test on HW in around a month, but not earlier. Meanwhile we can confirm that it builds with/without NI-845x , and if yes then the chain can be merged! I think you already confirmed it builds right? I am not sure about CB:72159 , is it still needed? If not, you can abandon it. Patchset: PS6: Joursoir, could you please rebase because the other chain was merged and now this is in "merge conflict" state? -- To view, visit https://review.coreboot.org/c/flashrom/+/72154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 10:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Alexander Goncharov, Miklós Márton. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160?usp=email ) Change subject: ni845x_spi: refactor singleton states into reentrant pattern ...................................................................... Patch Set 4: (1 comment) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/72160/comment/5eacfe88_3a1cfcf5 : PS3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV; > I've just dropped this line, because `io_voltage_in_mV` will be set in the `usb8452_spi_set_io_volta […] I agree with dropping the line: there was no "default" initialisation of `io_voltage_in_mV` before, it was initialised inside `usb8452_spi_set_io_voltage()` and the approach stays the same. -- To view, visit https://review.coreboot.org/c/flashrom/+/72160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Gerrit-Change-Number: 72160 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 15 Jul 2023 10:11:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: change chip lock status funcs for Winbond chips
by Alexander Goncharov (Code Review) 15 Jul '23

15 Jul '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email ) Change subject: flashchips: change chip lock status funcs for Winbond chips ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/75877/comment/e59640fd_32f67417 : PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032 > I agree, `AMIC_A25L032` doesn't seem like the right printlock function for a winbond chip. […] I opened datasheets and looked up the function that allows to display all the data from the Status Register. Functions with `PRETTYPRINT` prefix DO only print values from the Status Register-1, so an inappropriate function can only disguise a user. How about renaming to `SPI_PRETTYPRINT_STATUS_REGISTER_BP2_TB_SEC_SRWD`? Datasheets are available there: https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-fla… -- To view, visit https://review.coreboot.org/c/flashrom/+/75877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49 Gerrit-Change-Number: 75877 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 14 Jul 2023 23:46:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023