July 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: doc: Fix Contact link in README
by Anastasia Klimchuk (Code Review) 24 Jul '23

24 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76675?usp=email ) Change subject: doc: Fix Contact link in README ...................................................................... doc: Fix Contact link in README The link should be to another doc, that will work with any website configuration. Old link only worked for wiki. Change-Id: I6e2ec4f73494bebd5bd47bbeaa2051439d1d3bbd Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M README.rst 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/76675/1 diff --git a/README.rst b/README.rst index 428ae57..0a0ea08 100644 --- a/README.rst +++ b/README.rst @@ -55,6 +55,4 @@ https://www.flashrom.org/ -Available contact methods are - - https://www.flashrom.org/Contact +For available contact methods see :doc:`contact` -- To view, visit https://review.coreboot.org/c/flashrom/+/76675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e2ec4f73494bebd5bd47bbeaa2051439d1d3bbd Gerrit-Change-Number: 76675 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Fix the example Signed-off-by line to be displayed properly
by Peter Marheine (Code Review) 24 Jul '23

24 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76663?usp=email ) Change subject: doc: Fix the example Signed-off-by line to be displayed properly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0f26d6fb03d1491daefa4a362068f674230e94a6 Gerrit-Change-Number: 76663 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 24 Jul 2023 00:05:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flash: Update the comment for flashchip eraseblocks
by Aarya (Code Review) 23 Jul '23

23 Jul '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Thomas Heijligen. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75744?usp=email ) Change subject: flash: Update the comment for flashchip eraseblocks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28 Gerrit-Change-Number: 75744 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jul 2023 19:28:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Carl-Daniel Hailfinger (Code Review) 23 Jul '23

23 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I would like to suggest that the previous Friendliness etiquette has not worked very well in the past. That may be the case, but then again it worked with conflicts bigger than the one which caused explosions two months ago. > Particularly if I compare the coreboot project and the flashrom project, I have clear indication that there is value in adopting the coreboot Code of Conduct over the current "Friendliness" page. The developer base and community of both projects are fairly similar, with the coreboot project being significantly larger (and thus having more potential for conflict). I have gotten feedback that people generally prefer the coreboot Code of conduct implementation, and also the clarity of not trying to hide a Code of conduct behind the ambiguous term "Friendliness". Thank you for the feedback. I think there are significant overlaps betwen the two communities, but also quite some differences. For example, Anastasia seems to be only active in the flashrom gerrit and flashrom mailing list, but not on the coreboot side. Some other people who were previously very active in flashrom were only marginally active in coreboot. Is the feedback you got also available somewhere in public? I think it would be good to have this whole discussion on the mailing list. > So, there is both a need and an update already available. There may be a need for change, but even if we treat it as a source code patch, the submitter would have to list the bugs fixed by the new code. Wholesale replacements of source files rarely happen. A set of bylaws, rules or code of conduct shapes a whole community and has an impact far beyond a source code patch that can be easily reverted. Due to that, we should IMHO tread way more carefully here. The "update available" is something which may have worked for coreboot (I do not have enough info to make any assessment about that), but will it work for flashrom? > I would like to understand which parts of the coreboot code of conduct you oppose to with your -2, as there is a general expectation that -2 blocks give more actionable feedback than "I don't like change". Actionable feedback: 1. Acknowledge that rules already exist 2. Commit the existing rules to the repo of the new website 3. Propose changes with a justification (currently missing) 4. For wide-reaching changes like this, involve the community more than two lines in the meeting notes and a patch in gerrit, preferably with an (archivable) mailing list discussion 5. I think my personal concerns with the coreboot code of conduct were witten down as mailing list posts on the coreboot mailing list back when we had the coreboot code of conduct discussions. Some of them were addressed, some weren't. I can dig them up again if you want. My personal concerns with the coreboot code of conduct are independent of the process here, though. With the coreboot code of conduct, we had a proper mailing list discussion addressing actionable feedback items 1-4 from above. We also gave people enough time to respond and catch up. I do like change. I am also very much in favour of reviewing changes to make sure each part of the change is a net improvement instead of discard+rewrite. That is a hard lesson I learned from coreboot v3 and (besides feedback items 1-4) the reason I voted -2. > From the perspective of being legally responsible for running the infrastructure of this project, I also have a strong interest in unifying how the projects running on this infrastructure are generally managed. That is definitely a valid point, and we should address that. Maybe by working with SFC/SPI or a similar body? > That said, it is good to have you back, Carl-Daniel. Welcome to your first review in 3.5 years (and 5th review since flashrom switched to gerrit!) I am sure we will find a good solution that fits everybody's needs to some extent. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 22 Jul 2023 22:22:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Stefan Reinauer (Code Review) 22 Jul '23

22 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Carl-Daniel Hailfinger, Martin L Roth, Peter Marheine, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > We already have the equivalent of a code of conduct. […] I would like to suggest that the previous Friendliness etiquette has not worked very well in the past. Particularly if I compare the coreboot project and the flashrom project, I have clear indication that there is value in adopting the coreboot Code of Conduct over the current "Friendliness" page. The developer base and community of both projects are fairly similar, with the coreboot project being significantly larger (and thus having more potential for conflict). I have gotten feedback that people generally prefer the coreboot Code of conduct implementation, and also the clarity of not trying to hide a Code of conduct behind the ambiguous term "Friendliness". So, there is both a need and an update already available. I would like to understand which parts of the coreboot code of conduct you oppose to with your -2, as there is a general expectation that -2 blocks give more actionable feedback than "I don't like change". From the perspective of being legally responsible for running the infrastructure of this project, I also have a strong interest in unifying how the projects running on this infrastructure are generally managed. That said, it is good to have you back, Carl-Daniel. Welcome to your first review in 3.5 years (and 5th review since flashrom switched to gerrit!) I am sure we will find a good solution that fits everybody's needs to some extent. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 22 Jul 2023 21:22:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Carl-Daniel Hailfinger (Code Review) 22 Jul '23

22 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: As a side note, I think having this discussion on the mailing list would be better. The flashrom community does not consist purely of active developers, quite a few people contribute in other ways: - Helping users - Testing - Outreach (coreboot/flashrom booths at various events, talking to vendors, writing articles, spreading the word) - Reverse engineering - Documentation - Moderation of the mailing list - Moderation in chat Most of these people will not see the interaction here in Gerrit nor will they be able to participate here easily. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 22 Jul 2023 19:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Carl-Daniel Hailfinger (Code Review) 22 Jul '23

22 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: If desired, I can prepare a review request for migration of the old etiquette documentation. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 22 Jul 2023 19:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add code of conduct
by Carl-Daniel Hailfinger (Code Review) 22 Jul '23

22 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: We already have the equivalent of a code of conduct. https://wiki.flashrom.org/Friendliness If we want to migrate documentation, we should really migrate one and update it iff needed. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 22 Jul 2023 19:09:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix the example Signed-off-by line to be displayed properly
by Anastasia Klimchuk (Code Review) 21 Jul '23

21 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76663?usp=email ) Change subject: doc: Fix the example Signed-off-by line to be displayed properly ...................................................................... doc: Fix the example Signed-off-by line to be displayed properly It was not displayed, so needed to be fixed. Secondly, it is just one line and can be an inline code markup instead of a code-block (the latter was not displayed for some reasons). Change-Id: I0f26d6fb03d1491daefa4a362068f674230e94a6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/76663/1 diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index b4887ef..950fa91 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -87,9 +87,7 @@ <http://web.archive.org/web/20070306195036/http://osdlab.org/newsroom/press_…>`_ do. Add a note such as -.. code-block:: - - Signed-off-by: Random J Developer <random(a)developer.example.org> +:code:`Signed-off-by: Random J Developer <random(a)developer.example.org>` to your email/patch if you agree with the Developer's Certificate of Origin 1.1 printed below. Read `this post on the LKML -- To view, visit https://review.coreboot.org/c/flashrom/+/76663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0f26d6fb03d1491daefa4a362068f674230e94a6 Gerrit-Change-Number: 76663 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: flash: Update the comment for flashchip eraseblocks
by Anastasia Klimchuk (Code Review) 21 Jul '23

21 Jul '23

Attention is currently required from: Aarya, Edward O'Callaghan, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75744?usp=email ) Change subject: flash: Update the comment for flashchip eraseblocks ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hey guys, can anyone look at the patch? It is just updating the comment ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/75744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28 Gerrit-Change-Number: 75744 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Jul 2023 11:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023