July 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... Patch Set 2: (1 comment) File doc/index.rst: https://review.coreboot.org/c/flashrom/+/76772/comment/1702b5dc_fc0945b7 : PS1, Line 15: iki website > Do you want to point out that the wiki is no longer actively maintained? […] I was thinking about it, wasn't sure - but now you are thinking the same! so I will do it. I made it "Old wiki website" (and lost your approval :)) There are few pages on the wiki that are actually up-to-date, just need to be converted to rst format. So it's not entirely obsolete. Ideally we need to figure out how to put a banner to every wiki page, which says in red and bold "attention, this wiki is deprecated". -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 31 Jul 2023 07:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76772?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc: Add link to old wiki in the side menu ...................................................................... doc: Add link to old wiki in the side menu While the process of migrating pages is ongoing, wiki can be useful and is available in view-only mode. Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/76772/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: website/gh workflow: Resolve 404 links
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: website/gh workflow: Resolve 404 links ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/76821/comment/46e5f6ba_92dde760 : PS1, Line 6: : github workflow: Fix broken links to dev guide and contact page > move to body and just keep the short message short. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 07:46:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: website/gh workflow: Resolve 404 links
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons. Hello Angel Pons, Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76821?usp=email to look at the new patch set (#2). Change subject: website/gh workflow: Resolve 404 links ...................................................................... website/gh workflow: Resolve 404 links Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/76821/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: github workflow: Fix broken links to dev guide and contact page
by Edward O'Callaghan (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: github workflow: Fix broken links to dev guide and contact page ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/76821/comment/7c91d3af_721c3d30 : PS1, Line 6: : github workflow: Fix broken links to dev guide and contact page move to body and just keep the short message short. "website/gh workflow: Resolve 404 links" -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 31 Jul 2023 01:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Stefan Reinauer (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File doc/index.rst: https://review.coreboot.org/c/flashrom/+/76772/comment/f094c4e4_16fc4141 : PS1, Line 15: iki website Do you want to point out that the wiki is no longer actively maintained? e.g. Wiki (obsolete) -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 31 Jul 2023 00:39:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: github workflow: Fix broken links to dev guide and contact page
by Anastasia Klimchuk (Code Review) 29 Jul '23

29 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: github workflow: Fix broken links to dev guide and contact page ...................................................................... github workflow: Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/76821/1 diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml index 39b6548..f92e086 100644 --- a/.github/workflows/lockdown.yml +++ b/.github/workflows/lockdown.yml @@ -20,17 +20,17 @@ Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). pr-comment: > Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for BY25D40A
by Anastasia Klimchuk (Code Review) 29 Jul '23

29 Jul '23

Attention is currently required from: Giammarco. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76765?usp=email ) Change subject: flashchips.c: Add support for BY25D40A ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/76765/comment/a0b97175_6491452d : PS1, Line 14: You need to add testing info into commit message, which operations you ran on the chip. From the chip definition, looks like you did probing. Keep the rest of commit message, it's all fine. Just add testing info. It would be ideal if you share the logs from successful runs, can you upload logs to https://paste.flashrom.org/ ? and add the link in a comment? https://review.coreboot.org/c/flashrom/+/76765/comment/6176ea4e_a6e4464e : PS1, Line 16: Signed-off-by: Giammarco Marzano stich86(a)gmail.com Did you add this line manually? Because when you ask git to do this, it adds <> around email. You need to have: > Signed-off-by: Giammarco Marzano <stich86(a)gmail.com> You can either correct manually, or next time you amend your commit, ask git to sign-off `git commit --amend -s` If you ask git, it will add new line, and then you need to remove this current line. Patchset: PS1: Giammarco, thank you for the patch! I have just two comments. Also thanks for adding link to pull request, from it I discovered that the links in auto-response are broken. I will fix them, but I am glad you found guidelines anyway ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/76765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74a884549b24b1792e27c67ec65a1b185afc84e8 Gerrit-Change-Number: 76765 Gerrit-PatchSet: 1 Gerrit-Owner: Giammarco Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Giammarco Gerrit-Comment-Date: Sat, 29 Jul 2023 09:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 28 Jul '23

28 Jul '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Carl-Daniel Hailfinger, Martin L Roth, Patrick Georgi, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > > also added CB:75554 , it is already approved. […] This patch is not merged either. I looked into unresolved comments in CB:75554 , that's small re-wordings but no big changes. In any case, of course this patch will be updated with the final merged version of CB:75554. Let's keep this comment unresolved, until CB:75554 merged. I don't think it matters whether it is the strictest, or not the strictest. If it makes sense (I think it is), if it is relevant (I think it is), let's adopt it. But as I said above, after coreboot's patch merged. PS2: > What about option three? 3) Acknowledge that the friendliness document is a code of conduct? Even if you disagree with its scope, enforcement, and level of detail, it is a code of conduct. It is not, because there are 1-6 items that are missing. Friendliness document has a lot of potential, but it requires more work to get it migrated to the new website. It is less work if we keep it as a Friendliness page, and more work if we upgrade it to Code of Conduct. Either way, it is doable, but it needs effort. If it helps you, I was planning to migrate Friendliness myself, that was my first thought. But then when I started to inspect it closely I found that it's not straightforward. So in a case like this, when the end goal is far away, we can do it step by step. > How do you know that nothing happened? Speaking as past maintainer, I know that something happened because I had to handle such stuff in the past. Oh I was talking about recent times, not about stuff in the past. I fully believe you when you say you handled some stuff in the past, I am talking about the times I saw myself (approx last 3 years). > so the enforcement actions were not noticed publically It works with some people, and doesn't work with some other people. You never know. But it's good that you had a successful experience. When I said "tell me about it", it doesn't need to be public. But if you can share some useful experience and knowledge as a past maintainer, I would be interested to listen! -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 28 Jul 2023 13:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 28 Jul '23

28 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... doc: Add link to old wiki in the side menu While the process of migrating pages is ongoing, wiki can be useful and is available in view-only mode. Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/76772/1 diff --git a/doc/index.rst b/doc/index.rst index d308155..407c923 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -12,6 +12,7 @@ about_flashrom/index how_to_add_docs documentation_license + Wiki website <https://wiki.flashrom.org/> .. include:: intro.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023