July 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Sergii Dmytruk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76828?usp=email ) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... Patch Set 1: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/76828/comment/1f656142_5e454bc7 : PS1, Line 12: [development guide] I think you intended to drop the brackets. -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 31 Jul 2023 11:55:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76828?usp=email ) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... MAINTAINERS: Fix the link to dev guides and simplify the paragraph We can just say "follow the dev guide" here, the rest of information should be in the dev guide. Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M MAINTAINERS 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/76828/1 diff --git a/MAINTAINERS b/MAINTAINERS index e3aeef0..ecacaa2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9,11 +9,7 @@ it's often a good choice to look at the git history to see who worked on it last. -Please try to follow our [development guidelines]. This will make things -easier on the maintainers. Not all of these guidelines matter for every -trivial patch. So apply some common sense. - -[development guidelines]: https://www.flashrom.org/Development_Guidelines +Please follow our [development guide]: https://www.flashrom.org/dev_guide/development_guide.html Happy hacking! -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: flashchips: Add support for MXIC MX2525643G It is similar to the MX25...
by Name of user not set (Code Review) 31 Jul '23

31 Jul '23

Name of user not set #1005084 has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX2525643G It is similar to the MX2525635F and shares its RDID. ...................................................................... flashchips: Add support for MXIC MX2525643G It is similar to the MX2525635F and shares its RDID. Tested: read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/Lists/Datasheet/Attachments/8766/MX2525643G,%201.8V… Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/76853/1 diff --git a/flashchips.c b/flashchips.c index 4ca37a7..e87b3ba 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10085,6 +10085,56 @@ .voltage = {1650, 2000}, }, + + { + .vendor = "Macronix", + .name = "MX25U25643G", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25U25643G, + .total_size = 32768, + .page_size = 256, + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_4BA, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_5C, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + /* TODO: security register */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, /* Multi I/O supported */ + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1650, 2000}, + }, + { .vendor = "Macronix", .name = "MX25U25635F", diff --git a/include/flashchips.h b/include/flashchips.h index 9e2564c..aff77b7 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -527,6 +527,7 @@ #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ #define MACRONIX_MX25U6435E 0x2537 /* Same as MX25U6435F */ #define MACRONIX_MX25U12835E 0x2538 /* Same as MX25U12835F */ +#define MACRONIX_MX25U25643G 0x2539 #define MACRONIX_MX25U25635F 0x2539 #define MACRONIX_MX25U51245G 0x253a #define MACRONIX_MX25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... Patch Set 2: (1 comment) File doc/index.rst: https://review.coreboot.org/c/flashrom/+/76772/comment/1702b5dc_fc0945b7 : PS1, Line 15: iki website > Do you want to point out that the wiki is no longer actively maintained? […] I was thinking about it, wasn't sure - but now you are thinking the same! so I will do it. I made it "Old wiki website" (and lost your approval :)) There are few pages on the wiki that are actually up-to-date, just need to be converted to rst format. So it's not entirely obsolete. Ideally we need to figure out how to put a banner to every wiki page, which says in red and bold "attention, this wiki is deprecated". -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 31 Jul 2023 07:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76772?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc: Add link to old wiki in the side menu ...................................................................... doc: Add link to old wiki in the side menu While the process of migrating pages is ongoing, wiki can be useful and is available in view-only mode. Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/76772/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: website/gh workflow: Resolve 404 links
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: website/gh workflow: Resolve 404 links ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/76821/comment/46e5f6ba_92dde760 : PS1, Line 6: : github workflow: Fix broken links to dev guide and contact page > move to body and just keep the short message short. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 07:46:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: website/gh workflow: Resolve 404 links
by Anastasia Klimchuk (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons. Hello Angel Pons, Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76821?usp=email to look at the new patch set (#2). Change subject: website/gh workflow: Resolve 404 links ...................................................................... website/gh workflow: Resolve 404 links Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/76821/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: github workflow: Fix broken links to dev guide and contact page
by Edward O'Callaghan (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: github workflow: Fix broken links to dev guide and contact page ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/76821/comment/7c91d3af_721c3d30 : PS1, Line 6: : github workflow: Fix broken links to dev guide and contact page move to body and just keep the short message short. "website/gh workflow: Resolve 404 links" -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 31 Jul 2023 01:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Stefan Reinauer (Code Review) 31 Jul '23

31 Jul '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File doc/index.rst: https://review.coreboot.org/c/flashrom/+/76772/comment/f094c4e4_16fc4141 : PS1, Line 15: iki website Do you want to point out that the wiki is no longer actively maintained? e.g. Wiki (obsolete) -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 31 Jul 2023 00:39:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: github workflow: Fix broken links to dev guide and contact page
by Anastasia Klimchuk (Code Review) 29 Jul '23

29 Jul '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: github workflow: Fix broken links to dev guide and contact page ...................................................................... github workflow: Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/76821/1 diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml index 39b6548..f92e086 100644 --- a/.github/workflows/lockdown.yml +++ b/.github/workflows/lockdown.yml @@ -20,17 +20,17 @@ Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). pr-comment: > Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023