July 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: github workflow: Fix broken links to dev guide and contact page
by Anastasia Klimchuk (Code Review) July 29, 2023

July 29, 2023

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) Change subject: github workflow: Fix broken links to dev guide and contact page ...................................................................... github workflow: Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/76821/1 diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml index 39b6548..f92e086 100644 --- a/.github/workflows/lockdown.yml +++ b/.github/workflows/lockdown.yml @@ -20,17 +20,17 @@ Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). pr-comment: > Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for BY25D40A
by Anastasia Klimchuk (Code Review) July 29, 2023

July 29, 2023

Attention is currently required from: Giammarco. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76765?usp=email ) Change subject: flashchips.c: Add support for BY25D40A ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/76765/comment/a0b97175_6491452d : PS1, Line 14: You need to add testing info into commit message, which operations you ran on the chip. From the chip definition, looks like you did probing. Keep the rest of commit message, it's all fine. Just add testing info. It would be ideal if you share the logs from successful runs, can you upload logs to https://paste.flashrom.org/ ? and add the link in a comment? https://review.coreboot.org/c/flashrom/+/76765/comment/6176ea4e_a6e4464e : PS1, Line 16: Signed-off-by: Giammarco Marzano stich86(a)gmail.com Did you add this line manually? Because when you ask git to do this, it adds <> around email. You need to have: > Signed-off-by: Giammarco Marzano <stich86(a)gmail.com> You can either correct manually, or next time you amend your commit, ask git to sign-off `git commit --amend -s` If you ask git, it will add new line, and then you need to remove this current line. Patchset: PS1: Giammarco, thank you for the patch! I have just two comments. Also thanks for adding link to pull request, from it I discovered that the links in auto-response are broken. I will fix them, but I am glad you found guidelines anyway ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/76765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74a884549b24b1792e27c67ec65a1b185afc84e8 Gerrit-Change-Number: 76765 Gerrit-PatchSet: 1 Gerrit-Owner: Giammarco Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Giammarco Gerrit-Comment-Date: Sat, 29 Jul 2023 09:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) July 28, 2023

July 28, 2023

Attention is currently required from: Alexander Goncharov, Angel Pons, Carl-Daniel Hailfinger, Martin L Roth, Patrick Georgi, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > > also added CB:75554 , it is already approved. […] This patch is not merged either. I looked into unresolved comments in CB:75554 , that's small re-wordings but no big changes. In any case, of course this patch will be updated with the final merged version of CB:75554. Let's keep this comment unresolved, until CB:75554 merged. I don't think it matters whether it is the strictest, or not the strictest. If it makes sense (I think it is), if it is relevant (I think it is), let's adopt it. But as I said above, after coreboot's patch merged. PS2: > What about option three? 3) Acknowledge that the friendliness document is a code of conduct? Even if you disagree with its scope, enforcement, and level of detail, it is a code of conduct. It is not, because there are 1-6 items that are missing. Friendliness document has a lot of potential, but it requires more work to get it migrated to the new website. It is less work if we keep it as a Friendliness page, and more work if we upgrade it to Code of Conduct. Either way, it is doable, but it needs effort. If it helps you, I was planning to migrate Friendliness myself, that was my first thought. But then when I started to inspect it closely I found that it's not straightforward. So in a case like this, when the end goal is far away, we can do it step by step. > How do you know that nothing happened? Speaking as past maintainer, I know that something happened because I had to handle such stuff in the past. Oh I was talking about recent times, not about stuff in the past. I fully believe you when you say you handled some stuff in the past, I am talking about the times I saw myself (approx last 3 years). > so the enforcement actions were not noticed publically It works with some people, and doesn't work with some other people. You never know. But it's good that you had a successful experience. When I said "tell me about it", it doesn't need to be public. But if you can share some useful experience and knowledge as a past maintainer, I would be interested to listen! -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 28 Jul 2023 13:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) July 28, 2023

July 28, 2023

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... doc: Add link to old wiki in the side menu While the process of migrating pages is ongoing, wiki can be useful and is available in view-only mode. Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/76772/1 diff --git a/doc/index.rst b/doc/index.rst index d308155..407c923 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -12,6 +12,7 @@ about_flashrom/index how_to_add_docs documentation_license + Wiki website <https://wiki.flashrom.org/> .. include:: intro.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add link to flashrom patches to dev guide
by Anastasia Klimchuk (Code Review) July 28, 2023

July 28, 2023

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76771?usp=email ) Change subject: doc: Add link to flashrom patches to dev guide ...................................................................... doc: Add link to flashrom patches to dev guide People might be interested in what's currently ongoing in development, and even more practically, have a look at examples before creating their own patch. In fact, the latter is a good idea to do. Giving the link in the intro of dev guide will encourage that. Viewing the patches does not require an account, so can be done at the very beginning. Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/76771/1 diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 950fa91..35cd927 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -13,6 +13,7 @@ adjusted and you avoid frustration if there is some disagreement about the design. +You can look at the latest flashrom development efforts `here <https://review.coreboot.org/q/project:flashrom>`_. Set up the git repository and dev environment ============================================= -- To view, visit https://review.coreboot.org/c/flashrom/+/76771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Gerrit-Change-Number: 76771 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Fix Contact link in README
by Anastasia Klimchuk (Code Review) July 28, 2023

July 28, 2023

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76675?usp=email ) Change subject: doc: Fix Contact link in README ...................................................................... doc: Fix Contact link in README The link should be to another doc, that will work with any website configuration. Old link only worked for wiki. Change-Id: I6e2ec4f73494bebd5bd47bbeaa2051439d1d3bbd Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76675 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M README.rst 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/README.rst b/README.rst index 428ae57..0a0ea08 100644 --- a/README.rst +++ b/README.rst @@ -55,6 +55,4 @@ https://www.flashrom.org/ -Available contact methods are - - https://www.flashrom.org/Contact +For available contact methods see :doc:`contact` -- To view, visit https://review.coreboot.org/c/flashrom/+/76675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e2ec4f73494bebd5bd47bbeaa2051439d1d3bbd Gerrit-Change-Number: 76675 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for BY25D40A
by Giammarco (Code Review) July 27, 2023

July 27, 2023

Giammarco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76765?usp=email ) Change subject: flashchips.c: Add support for BY25D40A ...................................................................... flashchips.c: Add support for BY25D40A Based on https://github.com/flashrom/flashrom/pull/303 Add BY25D40A, is 512KB SPI Device ID is 0x4013 Datasheet avaliable there: https://datasheet.lcsc.com/lcsc/1912111437_BOYAMICRO-BY25D40ASTIG-T_C384591… Change-Id: I74a884549b24b1792e27c67ec65a1b185afc84e8 Signed-off-by: Giammarco Marzano stich86(a)gmail.com --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/76765/1 diff --git a/flashchips.c b/flashchips.c index 4ca37a7..45238a0 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3567,6 +3567,44 @@ .voltage = {2700, 3600}, }, + { + .vendor = "Boya/BoHong Microelectronics", + .name = "B.25D40A", + .bustype = BUS_SPI, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B__25D40A, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 512, 256} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 512, 32} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 512, 16} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {1 * 512 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {1 * 512 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP2_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP2_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + { .vendor = "Boya/BoHong Microelectronics", .name = "B.25D80A", diff --git a/include/flashchips.h b/include/flashchips.h index 9e2564c..222ae38 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -211,6 +211,7 @@ /* Boya/BoHong Microelectronics Inc. */ #define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B__25D40A 0x4013 #define BOYA_BOHONG_B__25D80A 0x4014 #define BOYA_BOHONG_B_25D16A 0x4015 #define BOYA_BOHONG_B_25Q128AS 0x4018 -- To view, visit https://review.coreboot.org/c/flashrom/+/76765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74a884549b24b1792e27c67ec65a1b185afc84e8 Gerrit-Change-Number: 76765 Gerrit-PatchSet: 1 Gerrit-Owner: Giammarco Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Fix the example Signed-off-by line to be displayed properly
by Anastasia Klimchuk (Code Review) July 27, 2023

July 27, 2023

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76663?usp=email ) Change subject: doc: Fix the example Signed-off-by line to be displayed properly ...................................................................... doc: Fix the example Signed-off-by line to be displayed properly It was not displayed, so needed to be fixed. Secondly, it is just one line and can be an inline code markup instead of a code-block (the latter was not displayed for some reasons). Change-Id: I0f26d6fb03d1491daefa4a362068f674230e94a6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76663 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index b4887ef..950fa91 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -87,9 +87,7 @@ <http://web.archive.org/web/20070306195036/http://osdlab.org/newsroom/press_…>`_ do. Add a note such as -.. code-block:: - - Signed-off-by: Random J Developer <random(a)developer.example.org> +:code:`Signed-off-by: Random J Developer <random(a)developer.example.org>` to your email/patch if you agree with the Developer's Certificate of Origin 1.1 printed below. Read `this post on the LKML -- To view, visit https://review.coreboot.org/c/flashrom/+/76663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0f26d6fb03d1491daefa4a362068f674230e94a6 Gerrit-Change-Number: 76663 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: flash: Update the comment for flashchip eraseblocks
by Anastasia Klimchuk (Code Review) July 27, 2023

July 27, 2023

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75744?usp=email ) Change subject: flash: Update the comment for flashchip eraseblocks ...................................................................... flash: Update the comment for flashchip eraseblocks Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75744 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Aarya <aarya.chaumal(a)gmail.com> --- M include/flash.h 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Aarya: Looks good to me, approved build bot (Jenkins): Verified diff --git a/include/flash.h b/include/flash.h index 0eace15..4c08549 100644 --- a/include/flash.h +++ b/include/flash.h @@ -449,9 +449,7 @@ /* * Erase blocks and associated erase function. Any chip erase function * is stored as chip-sized virtual block together with said function. - * The first one that fits will be chosen. There is currently no way to - * influence that behaviour. For testing just comment out the other - * elements or set the function pointer to NULL. + * The logic for how to optimally select erase functions is in erasure_layout.c */ struct block_eraser { struct eraseblock { -- To view, visit https://review.coreboot.org/c/flashrom/+/75744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28 Gerrit-Change-Number: 75744 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: doc: Add code of conduct
by Carl-Daniel Hailfinger (Code Review) July 26, 2023

July 26, 2023

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Patrick Georgi, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > It seems the main misunderstanding comes from "Acknowledge that rules already exist". > Maybe some rules exist, but code of conduct does not exist. The project needs one. Right. If the name is important, we can just rename the existing rules to "code of conduct". Then we have one. And the wikipedia definition of "code of conduct" also matches the old rules. (No, I didn't edit wikipedia to agree with me.) > I see two options: > > 1) This patch adds code of conduct copied from coreboot as a starting point. We start discussions/reviews of a Friendliness page with the goal to rename and promote it to code of conduct. Once this is done, the new page replaces this initial version. > > 2) This patch adds code of conduct copied from coreboot as a starting point. We start discussions/reviews of a Friendliness page as an independent page, and then once it is done we have two pages: code of conduct and friendliness. > > There are few reasons why Friendliness cannot be migrated to the new format straight away, see below. Otherwise I would migrate it already. > > 1) Some parts are out-dated (we don't do code reviews on mailing list anymore) > 2) Some parts unfinished (todo in the middle) > 3) Some parts belong to dev guidelines > 4) Some info better be on the Contacts page > 5) Missing: clear definition of unacceptable behavior > 6) Missing: clear statement that this rules are enforced (and how), clear explanation of consequences of 5) What about option three? 3) Acknowledge that the friendliness document is a code of conduct? Even if you disagree with its scope, enforcement, and level of detail, it is a code of conduct. > I am more than happy to also add these as comments to the friendliness patch, once it is out for review. > > The very important property of code of conduct is that one can't violate it. That was missing from Friendliness: it was violated multiple times over the recent years and nothing happened. How do you know that nothing happened? Speaking as past maintainer, I know that something happened because I had to handle such stuff in the past. However, I do believe in not shaming people in public, so the enforcement actions were not noticed publically. > As a side note: I am really interested to hear the story about "conflicts bigger than the one which caused explosions two months ago"! Seriously, tell me about it, I haven't heard about it! The involved parties know, and I don't want to shame people in public regardless of how long ago this happened. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 26 Jul 2023 01:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-MessageType: comment

1 0