Attention is currently required from: Anastasia Klimchuk, Ao Zhong.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email )
Change subject: flashchips.c: Add voltage data to chips without that
......................................................................
Patch Set 3:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/63596/comment/3f06a7e8_84204964 :
PS3, Line 8196: {3000, 3600},
> https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html […]
Updated to apply on top of https://review.coreboot.org/c/flashrom/+/64259
--
To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e
Gerrit-Change-Number: 63596
Gerrit-PatchSet: 3
Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 01 Jul 2023 01:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Chinmay Lonkar.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email )
Change subject: flashchips: Add voltage data for several chips
......................................................................
Patch Set 4:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/64259/comment/9fdb16d6_81442d32 :
PS4, Line 8451: {2700, 3300},
> https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html […]
Will update in follow-on patch.
https://review.coreboot.org/c/flashrom/+/64259/comment/8ba06fab_65fd7bf0 :
PS4, Line 8480: .voltage = {2700, 3600},
For this, we probably just want to use 5v for external programmers so we can use the same voltage for read, write, and erase.
https://www.datasheetq.com/28F400BV-doc-Intel
5V or 12V Program/Erase
2.7V, 3.3V or 5V Read Operation
Will update in follow-on patch
https://review.coreboot.org/c/flashrom/+/64259/comment/81b00109_e13aaaa0 :
PS4, Line 8509: .voltage = {2700, 3600},
I think this version should probably be 5V as well:
https://www.datasheetq.com/28F400CV-T-doc-Intel
5V or 12V Program/Erase
2.7V, 3.3V or 5V Read Operation
Will update in follow-on patch.
--
To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13
Gerrit-Change-Number: 64259
Gerrit-PatchSet: 4
Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Chinmay Lonkar <chinmay20220(a)gmail.com>
Gerrit-Comment-Date: Sat, 01 Jul 2023 01:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Ao Zhong.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email )
Change subject: flashchips.c: Add voltage data to chips without that
......................................................................
Patch Set 3:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/63596/comment/34f3434d_d414232a :
PS3, Line 8196: {3000, 3600},
https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html
• FlexibleSmartVoltageTechnology
— 2.7V–3.6VRead/Program/Erase
Shouldn't this be 2700,3600?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e
Gerrit-Change-Number: 63596
Gerrit-PatchSet: 3
Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 01 Jul 2023 01:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Chinmay Lonkar.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email )
Change subject: flashchips: Add voltage data for several chips
......................................................................
Patch Set 4:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/64259/comment/9480b06f_fe339e80 :
PS4, Line 8451: {2700, 3300},
https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html
• FlexibleSmartVoltageTechnology
— 2.7V–3.6VRead/Program/Erase
Shouldn't this be 2700,3600?
--
To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13
Gerrit-Change-Number: 64259
Gerrit-PatchSet: 4
Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Chinmay Lonkar <chinmay20220(a)gmail.com>
Gerrit-Comment-Date: Sat, 01 Jul 2023 01:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk.
Martin L Roth has uploaded a new patch set (#4) to the change originally created by Chinmay Lonkar. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: Add voltage data for several chips
......................................................................
flashchips: Add voltage data for several chips
The following flashchips are missing voltage data. Thus, add them.
* Intel 28F002BC/BL/BV/BX-T
* Intel 28F004B5/BE/BV/BX-B
* Intel 28F004B5/BE/BV/BX-T
* Intel 28F008S3/S5/SC
* Intel 28F400BV/BX/CE/CV-B
* Intel 28F400BV/BX/CE/CV-T
* Micron/Numonyx/ST M25P40-old
* SyncMOS/MoselVitelic {F,S,V}29C51002T
* Winbond W29C010(M)/W29C011A/W29EE011/W29EE012
* Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old
Signed-off-by: ChinmayLonkar <chinmay20220(a)gmail.com>
Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13
---
M flashchips.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/64259/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13
Gerrit-Change-Number: 64259
Gerrit-PatchSet: 4
Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset