flashrom-gerrit July 2023

flashrom-gerrit@flashrom.org

1 participants
139 discussions

[S] Change in flashrom[master]: flashchips: Add voltage data for several chips
by Anastasia Klimchuk (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Chinmay Lonkar, Martin L Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email ) Change subject: flashchips: Add voltage data for several chips ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Martin thank you so much! The contributor who is initial author of this patch left mid-last year, so you can just take over the patch. File flashchips.c: https://review.coreboot.org/c/flashrom/+/64259/comment/dd600956_4a5b0fec : PS4, Line 8451: {2700, 3300}, > Will update in follow-on patch. I also commented on follow-on patch that maybe remove these lines from here? -- To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 Gerrit-Change-Number: 64259 Gerrit-PatchSet: 4 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 11:18:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add voltage data to chips without that
by Anastasia Klimchuk (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Ao Zhong, Martin L Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email ) Change subject: flashchips.c: Add voltage data to chips without that ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: Thank you so much for doing these voltage patches! File flashchips.c: https://review.coreboot.org/c/flashrom/+/63596/comment/2dadd040_2ff9a008 : PS4, Line 17628: .voltage = {4500, 5500} Removing voltage, is this intentional? https://review.coreboot.org/c/flashrom/+/63596/comment/2b51f80d_0601e637 : PS4, Line 8452: .voltage = {2700, 3600}, Maybe it's safer to add voltage data at once, and correct values? (vs adding in one patch and immediately changing in the next one). I am thinking, maybe remove these lines from previous patch, and add here. So that both patches only add lines. What do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e Gerrit-Change-Number: 63596 Gerrit-PatchSet: 4 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 11:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Anastasia Klimchuk (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 8: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/f15c2923_db833be5 : PS6, Line 11: https://www.gigadevice.com/datasheet/gd25lr512me/ > Updated to archive. […] Thanks! I don't know whether it's my local issue, but I downloaded both pdf documents, and none of them can be opened :\ Do the docs open for you? (after downloading?) https://review.coreboot.org/c/flashrom/+/58025/comment/10f88931_5226397d : PS6, Line 17: sudo dut-control cold_reset:on fw_wp_en:off spi2_buf_en:on spi2_buf_on_flex_en:on spi2_vref:pp1800 spi_hold:off : sudo flashrom -V -p raiden_debug_spi -w <test_binary> : sudo dut-control spi2_buf_en:off spi2_buf_on_flex_en:off spi2_vref:off spi_hold:off cold_reset:off > I only have access to the gd25lr512me chip and flashed with a dediprog. […] Yes, maybe it's not that critical to see the exact command, but I am for example interested which programmers are used (and tested, as a side-effect). We do have PREWB to indicate that write-protect is tested for the chip (I assume this is the locking functionality you mentioned, which we usually call write-protect). Because both letters W and P were taken already, it got letter B for block-protect. I can mark this as resolved it seems. Thank you! Patchset: PS8: just one thing I wanted to double-check about the datasheets -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 09:41:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add voltage data to chips without that
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Anastasia Klimchuk, Ao Zhong. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email ) Change subject: flashchips.c: Add voltage data to chips without that ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/63596/comment/3f06a7e8_84204964 : PS3, Line 8196: {3000, 3600}, > https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html […] Updated to apply on top of https://review.coreboot.org/c/flashrom/+/64259 -- To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e Gerrit-Change-Number: 63596 Gerrit-PatchSet: 3 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Jul 2023 01:28:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add voltage data to chips without that
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Anastasia Klimchuk, Ao Zhong. Martin L Roth has uploaded a new patch set (#4) to the change originally created by Ao Zhong. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips.c: Add voltage data to chips without that ...................................................................... flashchips.c: Add voltage data to chips without that Eon EN25Q128 Datasheet: https://www.netcheif.com/Reviews/DSL-7850U/pdf/EN25Q128.pdf Intel 28F002BC/BL/BV/BX-T Datasheet: https://datasheet.octopart.com/E28F002BC-T80-Intel-datasheet-111286.pdf Intel 28F004B5/BE/BV/BX-B Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F200B5_IntelCorporation.pdf Intel 28F004B5/BE/BV/BX-T Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F200B5_IntelCorporation.pdf Intel 28F008S3/S5/SC Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F004S3_IntelCorporation.pdf Datasheet: https://www.digchip.com/datasheets/download_datasheet.php?id=38424&part-num… Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F004SC_IntelCorporation.pdf Intel 28F400BV/BX/CE/CV-B Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F400BX-TB_IntelCorporation.p… Intel 28F400BV/BX/CE/CV-T Datasheet: https://cdn.datasheetspdf.com/pdf-down/2/8/F/28F400BV-TB_IntelCorporation.p… Micron/Numonyx/ST M25P40-old Datasheet: https://www.farnell.com/datasheets/40267.pdf SyncMOS/MoselVitelic {F,S,V}29C51002B Datasheet: https://cdn.datasheetspdf.com/pdf-down/F/2/9/F29C51002T_SyncMOS.pdf SyncMOS/MoselVitelic {F,S,V}29C51002T Datasheet: https://cdn.datasheetspdf.com/pdf-down/F/2/9/F29C51002T_SyncMOS.pdf Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 Datasheet: https://tz.micro-semiconductor.hk/datasheet/fb-W29EE011P90Z.pdf Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old Datasheet: http://www.romservice.ru/datashee/W29C010.PDF Signed-off-by: Ao Zhong <hacc1225(a)gmail.com> Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e --- M flashchips.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/63596/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e Gerrit-Change-Number: 63596 Gerrit-PatchSet: 4 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: Add voltage data for several chips
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Anastasia Klimchuk, Chinmay Lonkar. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email ) Change subject: flashchips: Add voltage data for several chips ...................................................................... Patch Set 4: (3 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/64259/comment/9fdb16d6_81442d32 : PS4, Line 8451: {2700, 3300}, > https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html […] Will update in follow-on patch. https://review.coreboot.org/c/flashrom/+/64259/comment/8ba06fab_65fd7bf0 : PS4, Line 8480: .voltage = {2700, 3600}, For this, we probably just want to use 5v for external programmers so we can use the same voltage for read, write, and erase. https://www.datasheetq.com/28F400BV-doc-Intel 5V or 12V Program/Erase 2.7V, 3.3V or 5V Read Operation Will update in follow-on patch https://review.coreboot.org/c/flashrom/+/64259/comment/81b00109_e13aaaa0 : PS4, Line 8509: .voltage = {2700, 3600}, I think this version should probably be 5V as well: https://www.datasheetq.com/28F400CV-T-doc-Intel 5V or 12V Program/Erase 2.7V, 3.3V or 5V Read Operation Will update in follow-on patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 Gerrit-Change-Number: 64259 Gerrit-PatchSet: 4 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 01:22:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add voltage data to chips without that
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Anastasia Klimchuk, Ao Zhong. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email ) Change subject: flashchips.c: Add voltage data to chips without that ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/63596/comment/34f3434d_d414232a : PS3, Line 8196: {3000, 3600}, https://html.datasheetq.com/pdf-html/123108/Intel/31page/28F008S3.html • FlexibleSmartVoltageTechnology — 2.7V–3.6VRead/Program/Erase Shouldn't this be 2700,3600? -- To view, visit https://review.coreboot.org/c/flashrom/+/63596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aa2e71cf327ad5a5025a411689d77c6f6546a2e Gerrit-Change-Number: 63596 Gerrit-PatchSet: 3 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Jul 2023 01:07:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add voltage data for several chips
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

1 0

[S] Change in flashrom[master]: flashchips: Add voltage data for several chips
by Martin L Roth (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Anastasia Klimchuk. Martin L Roth has uploaded a new patch set (#4) to the change originally created by Chinmay Lonkar. ( https://review.coreboot.org/c/flashrom/+/64259?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add voltage data for several chips ...................................................................... flashchips: Add voltage data for several chips The following flashchips are missing voltage data. Thus, add them. * Intel 28F002BC/BL/BV/BX-T * Intel 28F004B5/BE/BV/BX-B * Intel 28F004B5/BE/BV/BX-T * Intel 28F008S3/S5/SC * Intel 28F400BV/BX/CE/CV-B * Intel 28F400BV/BX/CE/CV-T * Micron/Numonyx/ST M25P40-old * SyncMOS/MoselVitelic {F,S,V}29C51002T * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old Signed-off-by: ChinmayLonkar <chinmay20220(a)gmail.com> Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 --- M flashchips.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/64259/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/64259?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I796a0933570adbbd18e3e7852c420fee82666b13 Gerrit-Change-Number: 64259 Gerrit-PatchSet: 4 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023