July 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... doc: Add build instructions for NI-845x on Windows Because this patch adds a new footprint level, Sphinx incorrectly interprets the 3 asterisks (***) as the start of a bold block, rather than a footnote marker. To work around this, use sphinx built-in footprints. Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75270 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/dev_guide/building_from_source.rst M doc/dev_guide/building_with_make.rst 2 files changed, 25 insertions(+), 8 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/dev_guide/building_from_source.rst b/doc/dev_guide/building_from_source.rst index 7503e9e..64250dd 100644 --- a/doc/dev_guide/building_from_source.rst +++ b/doc/dev_guide/building_from_source.rst @@ -13,15 +13,17 @@ And the following dependencies: -* cmocka* -* linux-headers** -* libpci** -* libusb1** -* libftdi1** -* libjaylink** +* cmocka [#b1]_ +* linux-headers [#b2]_ +* libpci [#b2]_ +* libusb1 [#b2]_ +* libftdi1 [#b2]_ +* libjaylink [#b2]_ +* NI-845x driver & library package [#b3]_ -| \* optional, for building unit testing -| \** optional, depending on the selected programmer +.. [#b1] | optional, for building unit testing +.. [#b2] | optional, depending on the selected programmer +.. [#b3] | optional, proprietary and Windows only. (See Windows build instructions) If you are cross compiling, install the dependencies for your target. @@ -34,6 +36,8 @@ meson install -C builddir +.. _installing-dependencies: + Installing dependencies ----------------------- @@ -85,6 +89,9 @@ Install `MSYS2 <https://www.msys2.org/>`_ and ensure it is `fully updated <https://www.msys2.org/docs/updating/>`_. * ``libpci`` is not available through the package manager and pci based programmer are not supported on Windows. + * ``ni845x_spi`` is only available with the proprietary library from National Instruments. Download and install the driver + from `ni.com <https://www.ni.com/en-us/support/downloads/drivers/download.ni-845x-driver-…>`_ and build flashrom + for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. In the MINGW64 shell run:: diff --git a/doc/dev_guide/building_with_make.rst b/doc/dev_guide/building_with_make.rst index 90a3e46..710aad3 100644 --- a/doc/dev_guide/building_with_make.rst +++ b/doc/dev_guide/building_with_make.rst @@ -21,6 +21,7 @@ * libusb (if you want FT2232, Dediprog or USB-Blaster support) * libftdi (if you want FT2232 or USB-Blaster support) * libjaylink (if you want support for SEGGER J-Link and compatible devices) + * NI-845x driver & library package (if you want support for NI-845x devices; uses a proprietary driver) **Linux et al:** @@ -63,6 +64,15 @@ Install DirectHW from coresystems GmbH. DirectHW is available at https://www.coreboot.org/DirectHW . +**To compile on Windows:** + +Install MSYS tools (and the NI-845x drivers if desired) as described in +:ref:`installing-dependencies`. + +To build with support for NI-845x:: + + make HAS_LIB_NI845X=yes CONFIG_NI845X_SPI=yes + **To cross-compile on Linux for DOS:** Get packages of the DJGPP cross compiler and install them: -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... meson: Add support for ni845x_spi on Windows TEST=On MSYS32 MINGW32 with ni845x library installed: meson setup -Dprogrammer=ni845x_spi build meson compile -C build ./build/flashrom.exe lists the ni845x_spi as choice. Without ni845x library installed but ni845x_spi disabled, build succeeds on all platforms. Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75236 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M meson.build M meson_options.txt M ni845x_spi.c 3 files changed, 44 insertions(+), 1 deletion(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/meson.build b/meson.build index 18359db..9428e08 100644 --- a/meson.build +++ b/meson.build @@ -12,6 +12,8 @@ ], ) +fs = import('fs') + if get_option('classic_cli').enabled() and get_option('default_library') == 'shared' error(''' Cannot build cli_classic with shared libflashrom. Use \'-Dclassic_cli=disabled\' to disable the cli, @@ -149,6 +151,30 @@ libftdi1 = dependency('libftdi1', required : group_ftdi) libjaylink = dependency('libjaylink', required : group_jlink, version : '>=0.3.0') +if host_machine.system() == 'windows' + # Specifying an include_path that doesn't exist is an error, + # but we only use this if the library is found in the same directory. + ni845x_search_path = get_option('ni845x_search_path') + if fs.is_dir(ni845x_search_path) + ni845x_include_path = [ni845x_search_path] + else + ni845x_include_path = [] + endif + + libni845x = declare_dependency( + dependencies : [ + cc.find_library( + 'ni845x', + dirs : get_option('ni845x_search_path'), + required : get_option('programmer').contains('ni845x_spi') + ), + ], + include_directories : ni845x_include_path, + ) +else + libni845x = dependency('', required : false) +endif + subdir('platform') if systems_hwaccess.contains(host_machine.system()) @@ -369,6 +395,14 @@ 'flags' : [ '-DCONFIG_MSTARDDC_SPI=1' ], 'default' : false }, + 'ni845x_spi' : { + 'systems' : [ 'windows' ], + 'cpu_families' : [ 'x86' ], # The required ni845x library is 32-bit only + 'deps' : [ libni845x ], + 'srcs' : files('ni845x_spi.c'), + 'flags' : [ '-DCONFIG_NI845X_SPI=1' ], + 'default' : false, + }, 'nic3com' : { 'systems' : systems_hwaccess, 'cpu_families' : cpus_port_io, diff --git a/meson_options.txt b/meson_options.txt index 732d8d52..e62deb6 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -13,10 +13,12 @@ 'asm106x', 'atahpt', 'atapromise', 'atavia', 'buspirate_spi', 'ch341a_spi', 'ch347_spi','dediprog', 'developerbox_spi', 'digilent_spi', 'dirtyjtag_spi', 'drkaiser', 'dummy', 'ft2232_spi', 'gfxnvidia', 'internal', 'it8212', 'jlink_spi', 'linux_mtd', 'linux_spi', 'mediatek_i2c_spi', - 'mstarddc_spi', 'nic3com', 'nicintel', 'nicintel_eeprom', 'nicintel_spi', 'nicnatsemi', + 'mstarddc_spi', 'ni845x_spi', 'nic3com', 'nicintel', 'nicintel_eeprom', 'nicintel_spi', 'nicnatsemi', 'nicrealtek', 'ogp_spi', 'parade_lspcon', 'pickit2_spi', 'pony_spi', 'raiden_debug_spi', 'rayer_spi', 'realtek_mst_i2c_spi', 'satamv', 'satasii', 'serprog', 'stlinkv3_spi', 'usbblaster_spi', ], description: 'Active programmers') option('llvm_cov', type : 'feature', value : 'disabled', description : 'build for llvm code coverage') option('man-pages', type : 'feature', value : 'auto', description : 'build the man-page for classic_cli') option('documentation', type : 'feature', value : 'auto', description : 'build the html documentation') +option('ni845x_search_path', type : 'string', value : 'C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C', + description : 'Path to search for the proprietary ni845x library and header (32-bit Windows only)') diff --git a/ni845x_spi.c b/ni845x_spi.c index d4ae294..6e7bb76 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -15,6 +15,13 @@ * */ +/* The ni845x header does need the WIN32 symbol to be defined and meson does not do it. + * Define it just here, since this driver will only work on 32-bit Windows. + */ +#ifndef WIN32 +#define WIN32 +#endif + #include <ctype.h> #include <inttypes.h> #include <string.h> -- To view, visit https://review.coreboot.org/c/flashrom/+/75236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: tests/io_mock.h: add missing includes
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75235?usp=email ) Change subject: tests/io_mock.h: add missing includes ...................................................................... tests/io_mock.h: add missing includes When libusb is not around for the tests struct timeval and mode_t are not defined on mingw. Add both missing header to compile the tests under MSYS2 MINGW32/64 without libusb. Change-Id: Ic76653c8f3b5d7043ab6080d4e2e1748590ad070 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75235 Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M tests/io_mock.h 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Alexander Goncharov: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/tests/io_mock.h b/tests/io_mock.h index 9798066..04b0ef5 100644 --- a/tests/io_mock.h +++ b/tests/io_mock.h @@ -38,6 +38,10 @@ #include <stdint.h> +/* Required for struct timeval and mode_t */ +#include <sys/types.h> +#include <sys/time.h> + #include "usb_unittests.h" /* Address value needs fit into uint8_t. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/75235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic76653c8f3b5d7043ab6080d4e2e1748590ad070 Gerrit-Change-Number: 75235 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: Makefile: Simplify the NI-845X detection
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75234?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile: Simplify the NI-845X detection ...................................................................... Makefile: Simplify the NI-845X detection The current auto detection is kind of broken. Since the NI-845X driver package is likely not changing, hardcode `C:\Program Files (x86)\National Instuments\NI-845x\MS Visual C` as default path to search for the library and header. This can be overridden by setting `CONFIG_NI845X_LIBRARY_PATH` to the custom path. TEST=Run make HAS_LIB_NI845X=yes CONFIG_NI845X=yes successfully on MSYS2 MINGW32 Change-Id: I2115c30d0884e35eb549a31beef04d966ba4f491 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75234 Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile 1 file changed, 3 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Miklós Márton: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Alexander Goncharov: Looks good to me, but someone else must approve Stefan Reinauer: Looks good to me, approved diff --git a/Makefile b/Makefile index 5827cab..bc3eecb 100644 --- a/Makefile +++ b/Makefile @@ -211,19 +211,9 @@ CONFIG_LIBFTDI1_CFLAGS := $(call dependency_cflags, libftdi1) CONFIG_LIBFTDI1_LDFLAGS := $(call dependency_ldflags, libftdi1) -# Hack to keep legacy auto detection of Program Files (x86), Only active if none of the CONFIG_ variables for ni845x are set. -ifeq ($(CONFIG_NI845X_LIBRARY_PATH)$(CONFIG_LIB_NI845X_CFLAGS)$(CONFIG_LIB_NI845X_LDFLAGS),) -PROGRAMFILES_X86 = $(shell env | sed -n "s/^PROGRAMFILES(X86)=//p") -ifneq ($(PROGRAMFILES_X86DIR),) -ifneq ($(PROGRAMFILES_X86DIR), ${PROGRAMFILES}) -NI854_X86_LIBRARY_PATH := '${PROGRAMFILES_X86}\National Instruments\NI-845x\MS Visual C' -endif -endif -endif - -CONFIG_NI845X_LIBRARY_PATH := '${PROGRAMFILES}\National Instruments\NI-845x\MS Visual C' -CONFIG_LIB_NI845X_CFLAGS := -I$(CONFIG_NI845X_LIBRARY_PATH) $(if NI854_X86_LIBRARY_PATH, -I${NI854_X86_LIBRARY_PATH}) -CONFIG_LIB_NI845X_LDFLAGS := -L$(CONFIG_NI845X_LIBRARY_PATH) $(if NI854_X86_LIBRARY_PATH, -L${NI854_X86_LIBRARY_PATH}) -lni845x +CONFIG_NI845X_LIBRARY_PATH := 'C:\Program Files (x86)\National Instruments\NI-845x\MS Visual C' +CONFIG_LIB_NI845X_CFLAGS := -I$(CONFIG_NI845X_LIBRARY_PATH) +CONFIG_LIB_NI845X_LDFLAGS := -L$(CONFIG_NI845X_LIBRARY_PATH) -lni845x CONFIG_LIBJAYLINK_VERSION := $(call dependency_version, libjaylink) CONFIG_LIBJAYLINK_CFLAGS := $(call dependency_cflags, libjaylink) -- To view, visit https://review.coreboot.org/c/flashrom/+/75234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2115c30d0884e35eb549a31beef04d966ba4f491 Gerrit-Change-Number: 75234 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Anastasia Klimchuk (Code Review) 13 Jul '23

13 Jul '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75189?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... doc: Add Windows MSYS2 build instructions Change-Id: I847428535547242ff32af92c4fe8477241826814 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75189 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> --- M doc/dev_guide/building_from_source.rst 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Alexander Goncharov: Looks good to me, approved build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved Stefan Reinauer: Looks good to me, approved diff --git a/doc/dev_guide/building_from_source.rst b/doc/dev_guide/building_from_source.rst index 9c2959e..7503e9e 100644 --- a/doc/dev_guide/building_from_source.rst +++ b/doc/dev_guide/building_from_source.rst @@ -81,7 +81,22 @@ cmocka-dev pciutils-dev libusb-dev libjaylink-dev * Windows - .. todo:: Add build instructions to build under MSYS2, CYGWIN or cross compiling from Linux + * MSYS2 + Install `MSYS2 <https://www.msys2.org/>`_ and ensure it is `fully updated <https://www.msys2.org/docs/updating/>`_. + + * ``libpci`` is not available through the package manager and pci based programmer are not supported on Windows. + + In the MINGW64 shell run:: + + pacman -Sy \ + mingw-w64-x86_64-gcc mingw-w64-x86_64-meson mingw-w64-x86_64-ninja mingw-w64-x86_64-pkg-config mingw-w64-x86_64-python-sphinx \ + mingw-w64-x86_64-cmocka mingw-w64-x86_64-libusb mingw-w64-x86_64-libftdi mingw-w64-x86_64-libjaylink-git + + For building flashrom as 32-bit application, use the MSYS2 MINGW32 shell and run:: + + pacman -Sy \ + mingw-w64-i686-gcc mingw-w64-i686-meson mingw-w64-i686-ninja mingw-w64-i686-pkg-config mingw-w64-i686-python-sphinx \ + mingw-w64-i686-cmocka mingw-w64-i686-libusb mingw-w64-i686-libftdi mingw-w64-i686-libjaylink-git * MacOS * Homebrew -- To view, visit https://review.coreboot.org/c/flashrom/+/75189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: ni845x_spi: support building with Meson
by Peter Marheine (Code Review) 13 Jul '23

13 Jul '23

Peter Marheine has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/74963?usp=email ) Change subject: ni845x_spi: support building with Meson ...................................................................... Abandoned https://review.coreboot.org/c/flashrom/+/75236 -- To view, visit https://review.coreboot.org/c/flashrom/+/74963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I90e85c424f97898b47bf0a3d78672d6c25af12b0 Gerrit-Change-Number: 74963 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: flashchips: Add XTX XT25F64B
by Peter Marheine (Code Review) 13 Jul '23

13 Jul '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Thomas Heijligen, WereCatf. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58173?usp=email ) Change subject: flashchips: Add XTX XT25F64B ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 Gerrit-Change-Number: 58173 Gerrit-PatchSet: 3 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-Comment-Date: Thu, 13 Jul 2023 01:23:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: libflashrom: Add layout "exclude" API
by Brian Norris (Code Review) 12 Jul '23

12 Jul '23

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76005?usp=email ) Change subject: libflashrom: Add layout "exclude" API ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping for review -- To view, visit https://review.coreboot.org/c/flashrom/+/76005?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ea3e0674f25e34bf2cfc8f464ae7ca1c1a3fbfd Gerrit-Change-Number: 76005 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 12 Jul 2023 22:41:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: only perform WP unlock for write/erase operations
by Brian Norris (Code Review) 12 Jul '23

12 Jul '23

Attention is currently required from: Nikolai Artemiev. Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only perform WP unlock for write/erase operations ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 12 Jul 2023 22:41:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add XTX XT25F64B
by Anastasia Klimchuk (Code Review) 12 Jul '23

12 Jul '23

Attention is currently required from: Angel Pons, Thomas Heijligen, WereCatf. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58173?usp=email ) Change subject: flashchips: Add XTX XT25F64B ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Hello WereCatf, I am sorry that your patches got lost :( I mean this one and CB:58134. […] Okay, looks like you are busy or left, I updated the patchset and replaced func pointers with enums, also rebased. -- To view, visit https://review.coreboot.org/c/flashrom/+/58173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 Gerrit-Change-Number: 58173 Gerrit-PatchSet: 3 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-Comment-Date: Wed, 12 Jul 2023 13:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2023