November 2022 - flashrom-gerrit

[S] Change in flashrom[master]: ichspi: Fix number of bytes for HW seq operations
by Edward O'Callaghan (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Nikolai Artemiev, Subrata Banik, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69789 ) Change subject: ichspi: Fix number of bytes for HW seq operations ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5b911655649c693e576497520687d7810bbd3c54 Gerrit-Change-Number: 69789 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Iman Bingi, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69714 to look at the new patch set (#10). Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... flashrom/gui: Add GUI to Flashrom Flashrom Graphical User Interface Depends on: * gtk+ >=4 * adwaita >=1 Shortcomings: * Untested TODO: * Test on as many hardware/platforms as possible Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- A gflashrom/Makefile A gflashrom/board_info.ui.xml A gflashrom/chartable.c A gflashrom/chartable.h A gflashrom/chipset_info.ui.xml A gflashrom/common_macros.h A gflashrom/common_ui.c A gflashrom/common_ui.h A gflashrom/config.h A gflashrom/configuration.c A gflashrom/configuration.h A gflashrom/context_menu.ui.xml A gflashrom/converter.c A gflashrom/converter.h A gflashrom/coreboot.Gflashrom.gschema.xml A gflashrom/data_buffer.c A gflashrom/data_buffer.h A gflashrom/device_info.c A gflashrom/device_info.h A gflashrom/find_dialog.ui.xml A gflashrom/find_options.ui.xml A gflashrom/findreplace.c A gflashrom/findreplace.h A gflashrom/flashchip_info.ui.xml A gflashrom/flashrom.c A gflashrom/gflashrom.c A gflashrom/gflashrom.css A gflashrom/gflashrom.gresource.xml A gflashrom/gflashrom.h A gflashrom/gflashrom_app_win.c A gflashrom/gflashrom_app_win.h A gflashrom/gflashrom_app_win.ui.xml A gflashrom/gflashrom_layout_manager.c A gflashrom/gflashrom_layout_manager.h A gflashrom/gflashrom_paste_data.c A gflashrom/gflashrom_paste_data.h A gflashrom/gflashrom_resources.c A gflashrom/help_overlay.ui.xml A gflashrom/hex_dialog.c A gflashrom/hex_dialog.h A gflashrom/hex_document.c A gflashrom/hex_document.h A gflashrom/hex_statusbar.c A gflashrom/hex_statusbar.h A gflashrom/jump_dialog.ui.xml A gflashrom/main.c A gflashrom/objects.c A gflashrom/objects.h A gflashrom/paste_special.c A gflashrom/paste_special.h A gflashrom/paste_special.ui.xml A gflashrom/preferences.c A gflashrom/preferences.h A gflashrom/preferences.ui.xml A gflashrom/print.c A gflashrom/print.h A gflashrom/replace_dialog.ui.xml 57 files changed, 17,913 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 10 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Felix Singer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 3: Code-Review+1 (10 comments) Patchset: PS3: In the meantime we have replaced some function pointers with enums. This needs to be fixed in your patch. Otherwise looks good to me. File flashchips.c: https://review.coreboot.org/c/flashrom/+/68295/comment/4c04b7ad_45b45559 PS3, Line 7487: probe_spi_rdid PROBE_SPI_RDID https://review.coreboot.org/c/flashrom/+/68295/comment/1e0aa3f4_fb442d95 PS3, Line 7493: spi_block_erase_20 SPI_BLOCK_ERASE_20 https://review.coreboot.org/c/flashrom/+/68295/comment/9f866217_2574998e PS3, Line 7496: spi_block_erase_d7 SPI_BLOCK_ERASE_D7 https://review.coreboot.org/c/flashrom/+/68295/comment/a3edc858_411151b8 PS3, Line 7499: spi_block_erase_52 SPI_BLOCK_ERASE_52 https://review.coreboot.org/c/flashrom/+/68295/comment/6332c96b_8f32089e PS3, Line 7502: spi_block_erase_d8 SPI_BLOCK_ERASE_D8 https://review.coreboot.org/c/flashrom/+/68295/comment/2ccc021d_c02964cc PS3, Line 7505: spi_block_erase_60 SPI_BLOCK_ERASE_60 https://review.coreboot.org/c/flashrom/+/68295/comment/a07b7d04_e5e4cb5f PS3, Line 7508: spi_block_erase_c7 SPI_BLOCK_ERASE_C7 https://review.coreboot.org/c/flashrom/+/68295/comment/d5d840bc_2e7e0a9d PS3, Line 7512: spi_chip_write_256 SPI_CHIP_WRITE256 https://review.coreboot.org/c/flashrom/+/68295/comment/7c2bfef7_6b6f773f PS3, Line 7513: spi_chip_read SPI_CHIP_READ -- To view, visit https://review.coreboot.org/c/flashrom/+/68295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Mon, 21 Nov 2022 05:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Drop redundant chip read validation in verify_range()
by Edward O'Callaghan (Code Review) 21 Nov '22

21 Nov '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/69471 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashrom.c: Drop redundant chip read validation in verify_range() ...................................................................... flashrom.c: Drop redundant chip read validation in verify_range() The 'chip_safety_check()' already validates the chip structure within 'prepare_flash_access()' before all subsequent chip operations such as 'verify_range()' and therefore the chip structure is guaranteed to be valid in the domain of those operations. BUG=none BRANCH=none TEST=builds Change-Id: Ifc57dd89715115e03d013691352463a8b3c0dc52 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69471 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashrom.c 1 file changed, 23 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index 5483af3..51a6b64 100644 --- a/flashrom.c +++ b/flashrom.c @@ -511,11 +511,6 @@ return -1; } - if (!lookup_read_func_ptr(flash->chip)) { - msg_cerr("ERROR: flashrom has no read function for this flash chip.\n"); - return -1; - } - uint8_t *readbuf = malloc(len); if (!readbuf) { msg_gerr("Could not allocate memory!\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/69471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifc57dd89715115e03d013691352463a8b3c0dc52 Gerrit-Change-Number: 69471 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: opaque_master: Mark Opaque chip as tested for WP
by Edward O'Callaghan (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69842 ) Change subject: opaque_master: Mark Opaque chip as tested for WP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ae4cb49eb0abc6ab26cfe2f3359e4e50dd4fd4f Gerrit-Change-Number: 69842 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 04:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: opaque_master: Mark Opaque chip as tested for WP
by Anastasia Klimchuk (Code Review) 21 Nov '22

21 Nov '22

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69842 ) Change subject: opaque_master: Mark Opaque chip as tested for WP ...................................................................... opaque_master: Mark Opaque chip as tested for WP Opaque masters by design are populating information about a flashchip on the runtime inside their probe function. For the user the chip is visible as "Opaque flash chip". Without this patch, any operation on opaque flash chip displays a message to the user: "This flash part has status UNTESTED for operations: WP" and advises to report on the mailing list. However, this is not very useful in the case of Opaque chip. For all the other operations (read, write, erase) opaque masters always mark them as tested. So it seems in line with opaque design to mark WP as tested too. BUG=b:258755442 TEST=the following does not display untested message: 1) flashrom -p dummy:size=8388608,emulate=VARIABLE_SIZE 2) flashrom -p internal (on Intel device) Change-Id: I5ae4cb49eb0abc6ab26cfe2f3359e4e50dd4fd4f Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M dummyflasher.c M ichspi.c M nicintel_eeprom.c 3 files changed, 31 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/69842/1 diff --git a/dummyflasher.c b/dummyflasher.c index 110a88c..35cdfef 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -145,7 +145,7 @@ msg_cdbg("%s: set flash->total_size to %dK bytes.\n", __func__, flash->chip->total_size); - flash->chip->tested = TEST_OK_PREW; + flash->chip->tested = TEST_OK_PREWB; if (emu_data->erase_to_zero) flash->chip->feature_bits |= FEATURE_ERASED_ZERO; diff --git a/ichspi.c b/ichspi.c index 4e982f0..cd330e3 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1485,7 +1485,7 @@ msg_cdbg("In that range are %d erase blocks with %d B each.\n", size_high / erase_size_high, erase_size_high); } - flash->chip->tested = TEST_OK_PREW; + flash->chip->tested = TEST_OK_PREWB; return 1; } diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index ff2c3ce..4d5ab6b 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -115,7 +115,7 @@ /* Emulated eeprom has a fixed size of 4 KB */ flash->chip->total_size = 4; flash->chip->page_size = flash->chip->total_size * 1024; - flash->chip->tested = TEST_OK_PREW; + flash->chip->tested = TEST_OK_PREWB; flash->chip->gran = write_gran_1byte_implicit_erase; flash->chip->block_erasers->eraseblocks[0].size = flash->chip->page_size; flash->chip->block_erasers->eraseblocks[0].count = 1; @@ -146,7 +146,7 @@ } flash->chip->page_size = EE_PAGE_MASK + 1; - flash->chip->tested = TEST_OK_PREW; + flash->chip->tested = TEST_OK_PREWB; flash->chip->gran = write_gran_1byte_implicit_erase; flash->chip->block_erasers->eraseblocks[0].size = (EE_PAGE_MASK + 1); flash->chip->block_erasers->eraseblocks[0].count = (flash->chip->total_size * 1024) / (EE_PAGE_MASK + 1); -- To view, visit https://review.coreboot.org/c/flashrom/+/69842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ae4cb49eb0abc6ab26cfe2f3359e4e50dd4fd4f Gerrit-Change-Number: 69842 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: bindings: Add FLASHROM_WP_ERR_UNSUPPORTED_STATE
by Evan Benn (Code Review) 21 Nov '22

21 Nov '22

Evan Benn has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69864 ) Change subject: bindings: Add FLASHROM_WP_ERR_UNSUPPORTED_STATE ...................................................................... bindings: Add FLASHROM_WP_ERR_UNSUPPORTED_STATE Add support for new write protect error. BUG=None BRANCH=None TEST=cargo test Change-Id: I2adaad6552a601147e779c85a2a51d2e39b91c28 --- M bindings/rust/libflashrom/src/lib.rs 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/69864/1 diff --git a/bindings/rust/libflashrom/src/lib.rs b/bindings/rust/libflashrom/src/lib.rs index 39e76ac..95fde56 100644 --- a/bindings/rust/libflashrom/src/lib.rs +++ b/bindings/rust/libflashrom/src/lib.rs @@ -312,6 +312,7 @@ WpErrRangeUnsupported, WpErrModeUnsupported, WpErrRangeListUnavailable, + WpErrUnsupportedState, WpErrUnknown(libflashrom_sys::flashrom_wp_result), } @@ -341,6 +342,9 @@ libflashrom_sys::flashrom_wp_result::FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE => { WPError::WpErrRangeListUnavailable } + libflashrom_sys::flashrom_wp_result::FLASHROM_WP_ERR_UNSUPPORTED_STATE => { + WPError::WpErrUnsupportedState + } _ => WPError::WpErrUnknown(e), // this could also be a panic } } -- To view, visit https://review.coreboot.org/c/flashrom/+/69864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2adaad6552a601147e779c85a2a51d2e39b91c28 Gerrit-Change-Number: 69864 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: linux_mtd: Mark Opaque chip as tested for WP
by Anastasia Klimchuk (Code Review) 21 Nov '22

21 Nov '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/69518 ) Change subject: linux_mtd: Mark Opaque chip as tested for WP ...................................................................... linux_mtd: Mark Opaque chip as tested for WP Since linux_mtd supports write-protect, its probe function needs to mark Opaque chip as tested for WP. Programmers which are opaque masters are responsible for populating flashchip#tested struct in probe function. Without the patch, any operation running via linux_mtd displays a message "This flash part has status UNTESTED for operations: WP". With the patch, the message is not displayed anymore. BUG=b:258755442 BRANCH=none TEST=flashrom -p host on ARM dut Found Programmer flash chip "Opaque flash chip" (8192 kB, Programmer-specific) on host. No operations were specified. Change-Id: Icc0521c28555a93f26ce66bdbeaa68590f10c358 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69518 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M linux_mtd.c 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sergii Dmytruk: Looks good to me, but someone else must approve diff --git a/linux_mtd.c b/linux_mtd.c index b8aee06..495db9a 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -179,7 +179,7 @@ if (data->no_erase) flash->chip->feature_bits |= FEATURE_NO_ERASE; - flash->chip->tested = TEST_OK_PREW; + flash->chip->tested = TEST_OK_PREWB; flash->chip->total_size = data->total_size / 1024; /* bytes -> kB */ flash->chip->block_erasers[0].eraseblocks[0].size = data->erasesize; flash->chip->block_erasers[0].eraseblocks[0].count = -- To view, visit https://review.coreboot.org/c/flashrom/+/69518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc0521c28555a93f26ce66bdbeaa68590f10c358 Gerrit-Change-Number: 69518 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: cli_classic.c: Be consistent with pointer types
by Anastasia Klimchuk (Code Review) 21 Nov '22

21 Nov '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/69451 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cli_classic.c: Be consistent with pointer types ...................................................................... cli_classic.c: Be consistent with pointer types With `i586-pc-msdosdjgpp-gcc (GCC) 12.2.0`, `uint32_t` is defined as `long unsigned int`, which is not the same as `unsigned int`. As the `flashrom_layout_get_region_range()` function is part of libflashrom API, adjust `cli_classic.c` instead to avoid type mismatches. Change-Id: Ie8f5bc0d9296f7c6b8f8a351b53052f5fe86b09d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69451 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Evan Benn <evanbenn(a)google.com> Reviewed-by: Nikolai Artemiev <nartemiev(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M cli_classic.c 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Nikolai Artemiev: Looks good to me, but someone else must approve Evan Benn: Looks good to me, but someone else must approve diff --git a/cli_classic.c b/cli_classic.c index bd98a07..fe50cf4 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -127,7 +127,7 @@ return true; } -static int parse_wp_range(uint32_t *start, uint32_t *len) +static int parse_wp_range(unsigned int *start, unsigned int *len) { char *endptr = NULL, *token = NULL; @@ -571,7 +571,7 @@ int namelen, opt, i, j; int startchip = -1, chipcount = 0, option_index = 0; int operation_specified = 0; - uint32_t wp_start = 0, wp_len = 0; + unsigned int wp_start = 0, wp_len = 0; bool force = false, ifd = false, fmap = false; #if CONFIG_PRINT_WIKI == 1 bool list_supported_wiki = false; -- To view, visit https://review.coreboot.org/c/flashrom/+/69451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie8f5bc0d9296f7c6b8f8a351b53052f5fe86b09d Gerrit-Change-Number: 69451 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68295/comment/f93c53a3_a4605b6a PS1, Line 7: flashchips.c > just "flashchips" Done https://review.coreboot.org/c/flashrom/+/68295/comment/01da1934_71dac8b2 PS1, Line 10: Everything > Alternatively, list what has been tested and add "No issues found so far" or similar. To me current version looks fine ("Reading, erasing and writing works"). I am marking as resolved, but if you (Felix, Angel) disagree please tell! Patchset: PS2: Mario, I discovered that you have fixed the comments in your latest patchset, just haven't marked them as done :) When you are working on a patch, and uploading new patchset, you usually reply to the comments from your reviewers: either reply Done (if done) or ask for clarification if the comment is unclear, or you are not sure what to do with it. Otherwise I can be confusing, because patch has unresolved and unreplied comments - and reviewers might think that you are still working on it and it's not ready for next round of reviews. Thank you! For this patch: it needs rebasing, and also probably Felix and Angel would like to have another look after comments are resolved. File flashchips.c: https://review.coreboot.org/c/flashrom/+/68295/comment/4d26d611_2e6af0d5 PS1, Line 7381: > We use tabs to align the equals signs Done -- To view, visit https://review.coreboot.org/c/flashrom/+/68295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sun, 20 Nov 2022 21:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022