November 2022 - flashrom-gerrit

[M] Change in flashrom[master]: util/pkgbuilds: Add musl PKGBUILDs
by Felix Singer (Code Review) 19 Nov '22

19 Nov '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69781 to look at the new patch set (#6). Change subject: util/pkgbuilds: Add musl PKGBUILDs ...................................................................... util/pkgbuilds: Add musl PKGBUILDs WIP Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I28f524a53897685ab763c48f8be5370b8f6488b6 --- A util/pkgbuilds/aarch64-linux-musl-gcc-wrapper/PKGBUILD A util/pkgbuilds/arm-linux-musl-gcc-wrapper/PKGBUILD A util/pkgbuilds/libusb/PKGBUILD A util/pkgbuilds/riscv64-linux-musl-gcc-wrapper/PKGBUILD 4 files changed, 187 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/69781/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/69781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f524a53897685ab763c48f8be5370b8f6488b6 Gerrit-Change-Number: 69781 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom_tester: Fix unit test error
by Angel Pons (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Edward O'Callaghan, Evan Benn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69765 ) Change subject: flashrom_tester: Fix unit test error ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/69765/comment/d19bc0fb_ff67a17b PS1, Line 9: 065366d Commit 065366d (flashrom_tester: Change timestamp to UTC microsecond) -- To view, visit https://review.coreboot.org/c/flashrom/+/69765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba42a9026b41ddb61bb704aa1c26783cd251d787 Gerrit-Change-Number: 69765 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Sat, 19 Nov 2022 01:07:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libpayload: Fix compiling bugs
by Angel Pons (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69831 ) Change subject: libpayload: Fix compiling bugs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Gerrit-Change-Number: 69831 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 01:00:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libpayload: Fix compiling bugs
by Thomas Heijligen (Code Review) 19 Nov '22

19 Nov '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69831 ) Change subject: libpayload: Fix compiling bugs ...................................................................... libpayload: Fix compiling bugs Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M hwaccess_physmap.c M hwaccess_x86_io.c 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/69831/1 diff --git a/hwaccess_physmap.c b/hwaccess_physmap.c index 81adf18..f95b5f6 100644 --- a/hwaccess_physmap.c +++ b/hwaccess_physmap.c @@ -121,7 +121,7 @@ #define MEM_DEV "" -void *sys_physmap(uintptr_t phys_addr, size_t len) +static void *sys_physmap(uintptr_t phys_addr, size_t len) { return (void *)phys_to_virt(phys_addr); } diff --git a/hwaccess_x86_io.c b/hwaccess_x86_io.c index c3ad313..a883ed4 100644 --- a/hwaccess_x86_io.c +++ b/hwaccess_x86_io.c @@ -134,6 +134,8 @@ #endif #if defined(__LIBPAYLOAD__) +#include <arch/io.h> + #define IO_PORT_PERMISSION USE_DUMMY #define IO_PORT_FUNCTION USE_LIBC_TARGET_LAST #endif -- To view, visit https://review.coreboot.org/c/flashrom/+/69831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Gerrit-Change-Number: 69831 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69714 to look at the new patch set (#6). Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... flashrom/gui: Add GUI to Flashrom Flashrom Graphical User Interface Depends on: * gtk+ >=4 * adwaita >=1 Shortcomings: * Untested TODO: * Test on as many hardware/platforms as possible Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- A gflashrom/Makefile A gflashrom/chartable.c A gflashrom/chartable.h A gflashrom/common_macros.h A gflashrom/common_ui.c A gflashrom/common_ui.h A gflashrom/config.h A gflashrom/configuration.c A gflashrom/configuration.h A gflashrom/context_menu.ui.xml A gflashrom/converter.c A gflashrom/converter.h A gflashrom/coreboot.Gflashrom.gschema.xml A gflashrom/data_buffer.c A gflashrom/data_buffer.h A gflashrom/find_dialog.ui.xml A gflashrom/find_options.ui.xml A gflashrom/findreplace.c A gflashrom/findreplace.h A gflashrom/flashrom.c A gflashrom/gflashrom.c A gflashrom/gflashrom.css A gflashrom/gflashrom.gresource.xml A gflashrom/gflashrom.h A gflashrom/gflashrom_app_win.c A gflashrom/gflashrom_app_win.h A gflashrom/gflashrom_app_win.ui.xml A gflashrom/gflashrom_layout_manager.c A gflashrom/gflashrom_layout_manager.h A gflashrom/gflashrom_paste_data.c A gflashrom/gflashrom_paste_data.h A gflashrom/gflashrom_resources.c A gflashrom/help_overlay.ui.xml A gflashrom/hex_dialog.c A gflashrom/hex_dialog.h A gflashrom/hex_document.c A gflashrom/hex_document.h A gflashrom/hex_statusbar.c A gflashrom/hex_statusbar.h A gflashrom/jump_dialog.ui.xml A gflashrom/main.c A gflashrom/objects.c A gflashrom/objects.h A gflashrom/paste_special.c A gflashrom/paste_special.h A gflashrom/paste_special.ui.xml A gflashrom/preferences.c A gflashrom/preferences.h A gflashrom/preferences.ui.xml A gflashrom/print.c A gflashrom/print.h A gflashrom/replace_dialog.ui.xml 52 files changed, 17,022 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 6 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: ichspi: Clear Fast SPI HSFC register before HW seq operation
by Subrata Banik (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69788 ) Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation ...................................................................... Patch Set 2: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/69788/comment/a69f4750_bcb8eb3d PS1, Line 1360: /* make sure HSFC register is cleared before initiate any operation */ : REGWRITE16(ICH9_REG_HSFC, 0); : : /* Set up transaction parameters. */ : hsfc = REGREAD16(ICH9_REG_HSFC); > > Couldn't this be simplified? > > Something like this ? > > uint16_t hsfc = 0; > > hsfc |= hsfc_cycle; > hsfc |= HSFC_FDBC_VAL(len - 1); > hsfc |= HSFC_FGO; /* start */ > prettyprint_ich9_reg_hsfc(hsfc, ich_generation); > REGWRITE16(ICH9_REG_HSFC, hsfc); Please refer to the latest patchset. Thanks for the suggestion. -- To view, visit https://review.coreboot.org/c/flashrom/+/69788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 Gerrit-Change-Number: 69788 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Nov 2022 18:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi: Clear Fast SPI HSFC register before HW seq operation
by Subrata Banik (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69788 to look at the new patch set (#2). Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation ...................................................................... ichspi: Clear Fast SPI HSFC register before HW seq operation This patch fixes a regression introduced with commit 7ed1337309d3fe74f5af09520970f0f1d417399a (ichspi: Factor out common hwseq_xfer logic into helpers). The reason for the regression is ignoring the fact that the Fast SPI controller MMIO register HSFC (0x06) might not hold the default zero value before initiating the HW sequencing operation. Having a `1b` value in the HSFC.FDBC (bits 24-29) field would represent a byte that needs to be transfered. While debugging the regression, we have observed that the default value in the FDBC (prior to initiate any operation) is 0x3f (instead of zero) which represents 64-byte transfer. localhost ~ # iotools mmio_read32 0x92d16006 0x3f00 <Fast SPI MMIO BAR: 0x92d16000 and HSFC offset: 0x06> FDBC offset during `--wp-disable` operation represents higher numbers of bytes than the actual and eventually results in the error. Additionally, dropped unused variable (struct hwseq_data *hwseq_data). BUG=b:258280679 TEST=Able to build flashrom and perform below operations on Google, Rex and Google, Kano/Taeko. Without this patch: HSFC register value inside ich_start_hwseq_xfer() before initiating the HW seq operations: 0x3f00 HSFC register value inside ich_start_hwseq_xfer() during the HW seq operations (Read Status): 0x3f11 With this patch: HSFC register value inside ich_start_hwseq_xfer() before initiating the HW seq operations: 0x0 HSFC register value inside ich_start_hwseq_xfer() during the HW seq operations (Read Status): 0x11 Additionally, verified other HW sequencing operations (like read, write, erase, read status, write status, read ID) working fine without any error. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 --- M ichspi.c 1 file changed, 59 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/69788/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 Gerrit-Change-Number: 69788 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: ichspi: Clear Fast SPI HSFC register before HW seq operation
by Subrata Banik (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69788 ) Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation ...................................................................... Patch Set 1: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/69788/comment/2b0e49d3_2b418b05 PS1, Line 1360: /* make sure HSFC register is cleared before initiate any operation */ : REGWRITE16(ICH9_REG_HSFC, 0); : : /* Set up transaction parameters. */ : hsfc = REGREAD16(ICH9_REG_HSFC); > Couldn't this be simplified? Something like this ? uint16_t hsfc = 0; hsfc |= hsfc_cycle; hsfc |= HSFC_FDBC_VAL(len - 1); hsfc |= HSFC_FGO; /* start */ prettyprint_ich9_reg_hsfc(hsfc, ich_generation); REGWRITE16(ICH9_REG_HSFC, hsfc); -- To view, visit https://review.coreboot.org/c/flashrom/+/69788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 Gerrit-Change-Number: 69788 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Nov 2022 18:03:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi: Clear Fast SPI HSFC register before HW seq operation
by Angel Pons (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nikolai Artemiev, Subrata Banik, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69788 ) Change subject: ichspi: Clear Fast SPI HSFC register before HW seq operation ...................................................................... Patch Set 1: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/69788/comment/b474e4db_44764a61 PS1, Line 1360: /* make sure HSFC register is cleared before initiate any operation */ : REGWRITE16(ICH9_REG_HSFC, 0); : : /* Set up transaction parameters. */ : hsfc = REGREAD16(ICH9_REG_HSFC); Couldn't this be simplified? -- To view, visit https://review.coreboot.org/c/flashrom/+/69788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4cc3f24f880d1d621f1f48a6e6b276449fa46f98 Gerrit-Change-Number: 69788 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Nov 2022 17:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi: Fix number of bytes for HW seq operations
by Angel Pons (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nikolai Artemiev, Subrata Banik, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69789 ) Change subject: ichspi: Fix number of bytes for HW seq operations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5b911655649c693e576497520687d7810bbd3c54 Gerrit-Change-Number: 69789 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Nov 2022 17:26:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022