flashrom-gerrit November 2022

flashrom-gerrit@flashrom.org

1 participants
864 discussions

[XL] Change in flashrom[master]: tree/: Convert flashchip read func ptr to enumerate
by Felix Singer (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66788 ) Change subject: tree/: Convert flashchip read func ptr to enumerate ...................................................................... Patch Set 15: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66788/comment/82d26f1c_7eaf7bf5 PS15, Line 14: Squash in, : flashchips.c: convert edi_chip_read() : flashchips.c: convert spi_chip_read() : flashchips.c: convert read_opaque() : flashchips.c: convert read_memmapped() : flashchips.c: convert spi_read_at45db_e8() : flashchips.c: convert spi_read_at45db() : flashchips.c: convert NULL cases Not needed anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/66788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Gerrit-Change-Number: 66788 Gerrit-PatchSet: 15 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate
by Felix Singer (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 ) Change subject: tree/: Convert flashchip write func ptr to enumerate ...................................................................... Patch Set 14: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66782/comment/07a991a6_2215a2e1 PS14, Line 14: Squash in, : flashchips.c: convert spi_chip_write_256() : flashchips.c: convert write_jedec_1() : flashchips.c: convert write_jedec() : flashchips.c: convert write_opaque() : flashchips.c: convert spi_chip_write_1() : flashchips.c: convert spi_aai_write() : flashchips.c: convert edi_chip_write() : flashchips.c: convert write_en29lv640b() : flashchips.c: convert write_82802ab() : flashchips.c: convert spi_write_at45db() : flashchips.c: convert write_28sf040() : flashchips.c: convert NULL write Not needed anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/66782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Gerrit-Change-Number: 66782 Gerrit-PatchSet: 14 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate
by Felix Singer (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 ) Change subject: tree/: Convert flashchip probe func ptr to enumerate ...................................................................... Patch Set 13: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/66781/comment/00f7682b_d7737eb1 PS3, Line 759: static probe_func_t lookup_probe_func_ptr(const struct flashchip *chip) > Seems reasonable, just took a quick look though. I think this is resolved :) Marking as done. -- To view, visit https://review.coreboot.org/c/flashrom/+/66781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Gerrit-Change-Number: 66781 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate
by Felix Singer (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Edward O'Callaghan, Arthur Heymans, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 ) Change subject: tree/: Convert flashchip probe func ptr to enumerate ...................................................................... Patch Set 13: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66781/comment/95fc0642_04d2d16c PS13, Line 14: squash in, : : flashchip.c: probe_jedec_29gl : flashchip.c: probe_82802ab : flashchip.c: probe_opaque : flashchip.c: probe_jedec : flashchip.c: probe_spi_res2 : flashchip.c: probe_spi_res1 : flashchip.c: probe_spi_rems : flashchip.c: probe_spi_at25f : flashchip.c: probe_spi_at45db : flashchip.c: probe_spi_st95 : flashchip.c: probe_spi_sfdp : flashchip.c: probe_spi_rdid{4} : flashchip.c: probe_w29ee011 : flashchip.c: probe_en29lv640b : flashchip.c: edi_probe_kb9012 : flashchip.c: probe_spi_big_spansion I guess this is not needed anymore ;) Patchset: PS13: Thanks for keeping this up for so long Edward! Just one small thing is left 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/66781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396 Gerrit-Change-Number: 66781 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:17:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022