November 2022 - flashrom-gerrit

[M] Change in flashrom[master]: flashrom_tester: Change String types to PathBuf where appropriate
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Evan Benn. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69064 ) Change subject: flashrom_tester: Change String types to PathBuf where appropriate ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/69064/comment/b2bc64b9_83d70e7c PS1, Line 7: String `str` not `String`, a `String` is a heap … [View More]

1 0

[M] Change in flashrom[master]: flashrom_tester: Change String types to PathBuf where appropriate
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Evan Benn. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69064 ) Change subject: flashrom_tester: Change String types to PathBuf where appropriate ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/… [View More]

1 0

[M] Change in flashrom[master]: flashrom_tester: Move layout_file to TestEnv
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Evan Benn. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69063 ) Change subject: flashrom_tester: Move layout_file to TestEnv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: … [View More]

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip erase_block func ptr to enumerate
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Felix Singer, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67240 ) Change subject: tree/: Convert flashchip erase_block func ptr to enumerate ...................................................................... Patch Set 14: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/67240/comment/c429ab8d_29fea4db PS5, Line 307: // TODO rename to &… [View More]

1 0

[S] Change in flashrom[master]: chipdrivers: Rename s/erase_sector_jedec/jedec_sector_erase
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69051 ) Change subject: chipdrivers: Rename s/erase_sector_jedec/jedec_sector_erase ...................................................................... chipdrivers: Rename s/erase_sector_jedec/jedec_sector_erase Change-Id: Id21d514d6a8701a058287d9dabf9be7b62cfd95f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/chipdrivers.h M jedec.c 3 files … [View More]changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/69051/1 diff --git a/flashrom.c b/flashrom.c index c0a9f9d..cad95c8 100644 --- a/flashrom.c +++ b/flashrom.c @@ -358,7 +358,7 @@ case SPI_BLOCK_ERASE_DC: return &spi_block_erase_dc; case S25FL_BLOCK_ERASE: return &s25fl_block_erase; case S25FS_BLOCK_ERASE_D8: return &s25fs_block_erase_d8; - case JEDEC_SECTOR_ERASE: return &erase_sector_jedec; // TODO rename to &jedec_sector_erase; + case JEDEC_SECTOR_ERASE: return &jedec_sector_erase; case JEDEC_BLOCK_ERASE: return &jedec_block_erase; case JEDEC_CHIP_BLOCK_ERASE: return &jedec_chip_block_erase; case OPAQUE_ERASE: return &opqaue_erase; diff --git a/include/chipdrivers.h b/include/chipdrivers.h index 93368bb..005cc5b 100644 --- a/include/chipdrivers.h +++ b/include/chipdrivers.h @@ -146,7 +146,7 @@ int probe_jedec_29gl(struct flashctx *flash); int write_jedec(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int write_jedec_1(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); -int erase_sector_jedec(struct flashctx *flash, unsigned int page, unsigned int pagesize); +int jedec_sector_erase(struct flashctx *flash, unsigned int page, unsigned int pagesize); int jedec_block_erase(struct flashctx *flash, unsigned int page, unsigned int blocksize); int jedec_chip_block_erase(struct flashctx *flash, unsigned int page, unsigned int blocksize); diff --git a/jedec.c b/jedec.c index b31d6c5..70cc16b 100644 --- a/jedec.c +++ b/jedec.c @@ -281,7 +281,7 @@ return 1; } -static int erase_sector_jedec_common(struct flashctx *flash, unsigned int page, +static int jedec_sector_erase_common(struct flashctx *flash, unsigned int page, unsigned int pagesize, unsigned int mask) { chipaddr bios = flash->virtual_memory; @@ -537,13 +537,13 @@ return probe_jedec_common(flash, mask); } -int erase_sector_jedec(struct flashctx *flash, unsigned int page, +int jedec_sector_erase(struct flashctx *flash, unsigned int page, unsigned int size) { unsigned int mask; mask = getaddrmask(flash->chip); - return erase_sector_jedec_common(flash, page, size, mask); + return jedec_sector_erase_common(flash, page, size, mask); } int jedec_block_erase(struct flashctx *flash, unsigned int page, -- To view, visit https://review.coreboot.org/c/flashrom/+/69051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id21d514d6a8701a058287d9dabf9be7b62cfd95f Gerrit-Change-Number: 69051 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[S] Change in flashrom[master]: chipdrivers: Rename s/erase_block_jedec/jedec_block_erase
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69050 ) Change subject: chipdrivers: Rename s/erase_block_jedec/jedec_block_erase ...................................................................... chipdrivers: Rename s/erase_block_jedec/jedec_block_erase Change-Id: I8e7b51f6e78fc5a4c88a1b8dcb24ef82b1f657b8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/chipdrivers.h M jedec.c 3 files changed, … [View More]15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/69050/1 diff --git a/flashrom.c b/flashrom.c index 6c9dbd0..c0a9f9d 100644 --- a/flashrom.c +++ b/flashrom.c @@ -359,7 +359,7 @@ case S25FL_BLOCK_ERASE: return &s25fl_block_erase; case S25FS_BLOCK_ERASE_D8: return &s25fs_block_erase_d8; case JEDEC_SECTOR_ERASE: return &erase_sector_jedec; // TODO rename to &jedec_sector_erase; - case JEDEC_BLOCK_ERASE: return &erase_block_jedec; // TODO rename to &jedec_block_erase; + case JEDEC_BLOCK_ERASE: return &jedec_block_erase; case JEDEC_CHIP_BLOCK_ERASE: return &jedec_chip_block_erase; case OPAQUE_ERASE: return &opqaue_erase; case SPI_ERASE_AT45CS_SECTOR: return &spi_erase_at45cs_sector; diff --git a/include/chipdrivers.h b/include/chipdrivers.h index 6c27cb3..93368bb 100644 --- a/include/chipdrivers.h +++ b/include/chipdrivers.h @@ -147,7 +147,7 @@ int write_jedec(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int write_jedec_1(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int erase_sector_jedec(struct flashctx *flash, unsigned int page, unsigned int pagesize); -int erase_block_jedec(struct flashctx *flash, unsigned int page, unsigned int blocksize); +int jedec_block_erase(struct flashctx *flash, unsigned int page, unsigned int blocksize); int jedec_chip_block_erase(struct flashctx *flash, unsigned int page, unsigned int blocksize); int unlock_regspace2_uniform_32k(struct flashctx *flash); diff --git a/jedec.c b/jedec.c index 5cba398..b31d6c5 100644 --- a/jedec.c +++ b/jedec.c @@ -313,7 +313,7 @@ return 0; } -static int erase_block_jedec_common(struct flashctx *flash, unsigned int block, +static int jedec_block_erase_common(struct flashctx *flash, unsigned int block, unsigned int blocksize, unsigned int mask) { chipaddr bios = flash->virtual_memory; @@ -546,13 +546,13 @@ return erase_sector_jedec_common(flash, page, size, mask); } -int erase_block_jedec(struct flashctx *flash, unsigned int page, +int jedec_block_erase(struct flashctx *flash, unsigned int page, unsigned int size) { unsigned int mask; mask = getaddrmask(flash->chip); - return erase_block_jedec_common(flash, page, size, mask); + return jedec_block_erase_common(flash, page, size, mask); } struct unlockblock { -- To view, visit https://review.coreboot.org/c/flashrom/+/69050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8e7b51f6e78fc5a4c88a1b8dcb24ef82b1f657b8 Gerrit-Change-Number: 69050 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[S] Change in flashrom[master]: chipdrivers: Rename s/erase_chip_block_jedec/jedec_chip_block_erase
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69049 ) Change subject: chipdrivers: Rename s/erase_chip_block_jedec/jedec_chip_block_erase ...................................................................... chipdrivers: Rename s/erase_chip_block_jedec/jedec_chip_block_erase Change-Id: I3a2d370ec8d997689fdc921f1d3d7191b7c6cd1d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/chipdrivers.h M jedec.… [View More]c 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/69049/1 diff --git a/flashrom.c b/flashrom.c index a05dac0..6c9dbd0 100644 --- a/flashrom.c +++ b/flashrom.c @@ -360,7 +360,7 @@ case S25FS_BLOCK_ERASE_D8: return &s25fs_block_erase_d8; case JEDEC_SECTOR_ERASE: return &erase_sector_jedec; // TODO rename to &jedec_sector_erase; case JEDEC_BLOCK_ERASE: return &erase_block_jedec; // TODO rename to &jedec_block_erase; - case JEDEC_CHIP_BLOCK_ERASE: return &erase_chip_block_jedec; // TODO rename to &jedec_chip_block_erase; + case JEDEC_CHIP_BLOCK_ERASE: return &jedec_chip_block_erase; case OPAQUE_ERASE: return &opqaue_erase; case SPI_ERASE_AT45CS_SECTOR: return &spi_erase_at45cs_sector; case SPI_ERASE_AT45DB_BLOCK: return &spi_erase_at45db_block; diff --git a/include/chipdrivers.h b/include/chipdrivers.h index 657c902..6c27cb3 100644 --- a/include/chipdrivers.h +++ b/include/chipdrivers.h @@ -148,7 +148,7 @@ int write_jedec_1(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int erase_sector_jedec(struct flashctx *flash, unsigned int page, unsigned int pagesize); int erase_block_jedec(struct flashctx *flash, unsigned int page, unsigned int blocksize); -int erase_chip_block_jedec(struct flashctx *flash, unsigned int page, unsigned int blocksize); +int jedec_chip_block_erase(struct flashctx *flash, unsigned int page, unsigned int blocksize); int unlock_regspace2_uniform_32k(struct flashctx *flash); int unlock_regspace2_uniform_64k(struct flashctx *flash); diff --git a/jedec.c b/jedec.c index c4ee0c7..5cba398 100644 --- a/jedec.c +++ b/jedec.c @@ -515,7 +515,7 @@ } /* erase chip with block_erase() prototype */ -int erase_chip_block_jedec(struct flashctx *flash, unsigned int addr, +int jedec_chip_block_erase(struct flashctx *flash, unsigned int addr, unsigned int blocksize) { unsigned int mask; -- To view, visit https://review.coreboot.org/c/flashrom/+/69049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3a2d370ec8d997689fdc921f1d3d7191b7c6cd1d Gerrit-Change-Number: 69049 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[S] Change in flashrom[master]: chipdrivers: Rename s/erase_opaque/opqaue_erase
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69048 ) Change subject: chipdrivers: Rename s/erase_opaque/opqaue_erase ...................................................................... chipdrivers: Rename s/erase_opaque/opqaue_erase Change-Id: Icac7a3d2dfa1b00a12a1e151ea7a730cd25110a3 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/chipdrivers.h M opaque.c 3 files changed, 13 insertions(+), 3 … [View More]deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/69048/1 diff --git a/flashrom.c b/flashrom.c index 0f10ad4..a05dac0 100644 --- a/flashrom.c +++ b/flashrom.c @@ -361,7 +361,7 @@ case JEDEC_SECTOR_ERASE: return &erase_sector_jedec; // TODO rename to &jedec_sector_erase; case JEDEC_BLOCK_ERASE: return &erase_block_jedec; // TODO rename to &jedec_block_erase; case JEDEC_CHIP_BLOCK_ERASE: return &erase_chip_block_jedec; // TODO rename to &jedec_chip_block_erase; - case OPAQUE_ERASE: return &erase_opaque; // TODO rename to &opqaue_erase; + case OPAQUE_ERASE: return &opqaue_erase; case SPI_ERASE_AT45CS_SECTOR: return &spi_erase_at45cs_sector; case SPI_ERASE_AT45DB_BLOCK: return &spi_erase_at45db_block; case SPI_ERASE_AT45DB_CHIP: return &spi_erase_at45db_chip; diff --git a/include/chipdrivers.h b/include/chipdrivers.h index 9d1db76..657c902 100644 --- a/include/chipdrivers.h +++ b/include/chipdrivers.h @@ -114,7 +114,7 @@ int probe_opaque(struct flashctx *flash); int read_opaque(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int write_opaque(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); -int erase_opaque(struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); +int opqaue_erase(struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); /* at45db.c */ int probe_spi_at45db(struct flashctx *flash); diff --git a/opaque.c b/opaque.c index 7704ec7..e794035 100644 --- a/opaque.c +++ b/opaque.c @@ -41,7 +41,7 @@ return flash->mst->opaque.write(flash, buf, start, len); } -int erase_opaque(struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen) +int opqaue_erase(struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen) { return flash->mst->opaque.erase(flash, blockaddr, blocklen); } -- To view, visit https://review.coreboot.org/c/flashrom/+/69048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icac7a3d2dfa1b00a12a1e151ea7a730cd25110a3 Gerrit-Change-Number: 69048 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[S] Change in flashrom[master]: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69047 ) Change subject: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase ...................................................................... chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase Change-Id: Ia916b5782abf04499ab46a540820acbe4a171068 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/chipdrivers.h M stm50.c 3 files … [View More]changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/69047/1 diff --git a/flashrom.c b/flashrom.c index ec4ddbc..0f10ad4 100644 --- a/flashrom.c +++ b/flashrom.c @@ -371,7 +371,7 @@ case ERASE_SECTOR_28SF040: return &erase_sector_28sf040; case ERASE_BLOCK_82802AB: return &erase_block_82802ab; case ERASE_SECTOR_49LFXXXC: return &erase_sector_49lfxxxc; - case STM50_SECTOR_ERASE: return &erase_sector_stm50; // TODO rename to &stm50_sector_erase; + case STM50_SECTOR_ERASE: return &stm50_sector_erase; case EDI_CHIP_BLOCK_ERASE: return &edi_chip_block_erase; case TEST_ERASE_INJECTOR: return g_test_erase_injector; /* default: total function, 0 indicates no erase function set. diff --git a/include/chipdrivers.h b/include/chipdrivers.h index 3b07afe..9d1db76 100644 --- a/include/chipdrivers.h +++ b/include/chipdrivers.h @@ -198,7 +198,7 @@ bool w29ee011_can_override(const char *const chip_name, const char *const override_chip); /* stm50.c */ -int erase_sector_stm50(struct flashctx *flash, unsigned int block, unsigned int blocksize); +int stm50_sector_erase(struct flashctx *flash, unsigned int block, unsigned int blocksize); /* en29lv640b.c */ int probe_en29lv640b(struct flashctx *flash); diff --git a/stm50.c b/stm50.c index d495e09..9092a0f 100644 --- a/stm50.c +++ b/stm50.c @@ -47,7 +47,7 @@ * the block erase function instead. FIXME: This duplicates the behavior of the remaining erasers for blocks and * might be fixed when flashrom supports multiple functions per eraser or erasers that do erase parts of the * chip only. */ -int erase_sector_stm50(struct flashctx *flash, unsigned int addr, unsigned int len) +int stm50_sector_erase(struct flashctx *flash, unsigned int addr, unsigned int len) { if (len == 4096) return stm50_erase_sector(flash, addr); -- To view, visit https://review.coreboot.org/c/flashrom/+/69047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia916b5782abf04499ab46a540820acbe4a171068 Gerrit-Change-Number: 69047 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[M] Change in flashrom[master]: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
by Anastasia Klimchuk (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 ) Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash() ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/… [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022