Attention is currently required from: Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69846 )
Change subject: writeprotect.c: move wp_bits -> register values/masks conversion into func
......................................................................
Patch Set 1:
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/69846/comment/0949b3d6_59b80525
PS1, Line 170: bit_masks, write_masks
Swapped arguments. Maybe change order of parameters of `get_wp_bits_reg_values()` instead to match `set_reg_bit()`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I604478ecbb70392c5584bf5d87c76b6f20f882b1
Gerrit-Change-Number: 69846
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 16:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons.
Name of user not set #1004656 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309 )
Change subject: Add support for XMC XM25QH128A. Read/write tested.
......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69309/comment/92566da4_1bc179b6
PS1, Line 7: Add support for XMC XM25QH128A. Read/write tested.
> flashchips: Add support for XMC XM25QH128A
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/bb1be76e_e6db2c50
PS1, Line 8:
> Mention here what you have tested, a link to the datasheet and also information about the revision o […]
Has been read/write/erase tested. Is that sufficient and if not what other info should I provide?
I can link to Google cache of the datasheet on XMC's website, they took it offline recently. There's PDFs floating around as well but none hosted by the manufacturer anymore AFAICT.
Cheers
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/69309/comment/0b4935c6_2a329118
PS1, Line 19720: probe_spi_rdid
> PROBE_SPI_RDID
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/54a9be8d_79608693
PS1, Line 19743: spi_chip_write_256
> SPI_CHIP_WRITE256
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/13fc9934_dc2ac4e8
PS1, Line 19744: spi_chip_read
> SPI_CHIP_READ
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/11f1d55b_8ef5a0ae
PS1, Line 19755: decode_range_spi25
> DECODE_RANGE_SPI25
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/7671d5a5_d9e8c9b1
PS1, Line 19758:
> Remove one line
Ack
--
To view, visit https://review.coreboot.org/c/flashrom/+/69309
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Gerrit-Change-Number: 69309
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1004656
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 11:09:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/69831
to look at the new patch set (#2).
Change subject: libpayload: Fix compiling bugs
......................................................................
libpayload: Fix compiling bugs
hwaccess_physmap.c: make `void *sys_physmap(()` static
hwaccess_x86_io.c: Add missing include
Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M hwaccess_physmap.c
M hwaccess_x86_io.c
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/69831/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/69831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f
Gerrit-Change-Number: 69831
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69846 )
Change subject: writeprotect.c: move wp_bits -> register values/masks conversion into func
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69846/comment/c5c998d3_c817216c
PS1, Line 7: move wp_bits -> register values/masks conversion into func
"Split out reg mask/val calculations into pure func"
https://review.coreboot.org/c/flashrom/+/69846/comment/68c11620_8f1642e7
PS1, Line 11: .
"This avoids monadic transformer stacks where unit-testing cannot penetrate well to give suitable coverage, therefore keep the pure bit logic in a separate function without side-effects."
https://review.coreboot.org/c/flashrom/+/69846/comment/77efe15d_280ea5ff
PS1, Line 13: TEST=ninja test
`BUG=b:259013033`
--
To view, visit https://review.coreboot.org/c/flashrom/+/69846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I604478ecbb70392c5584bf5d87c76b6f20f882b1
Gerrit-Change-Number: 69846
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 10:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69844 )
Change subject: tree/: Convert flashchips db to use indirection for printlock
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69844/comment/4c295f6e_eca749a4
PS1, Line 9: un
s/un/print/
--
To view, visit https://review.coreboot.org/c/flashrom/+/69844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icff868d9454e9b0a059a736457bb562430436033
Gerrit-Change-Number: 69844
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment