October 2021 - flashrom-gerrit

Change in flashrom[master]: Add support for GD25LQ256D
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Drew Fustini, Thomas Heijligen, Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 ) Change subject: Add support for GD25LQ256D ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/51113/comment/1bc74d41_4410b4f8 PS1, Line 7: Add support for GD25LQ256D Add `flashchips.c: ` before that -- To view, visit https://review.coreboot.org/c/flashrom/+/51113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1b745cac070d8deb96ce65137fd9060b148b965 Gerrit-Change-Number: 51113 Gerrit-PatchSet: 1 Gerrit-Owner: Drew Fustini <drew(a)beagleboard.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Drew Fustini <drew(a)beagleboard.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 21:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: add Macronix MX25L3255E
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Thomas Heijligen, Joseph C. Lehner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410 ) Change subject: flashchips: add Macronix MX25L3255E ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57410/comment/84e68318_34c47603 PS1, Line 7: flashchips: add Macronix MX25L3255E How did you test it? Which programmer did you use? https://review.coreboot.org/c/flashrom/+/57410/comment/f0ecb332_5cbbede5 PS1, Line 8: Please add a link to the datasheet. File flashchips.h: https://review.coreboot.org/c/flashrom/+/57410/comment/31928eb7_433a86dc PS1, Line 508: #define MACRONIX_MX25L3255E 0x9e16 Please put it after MACRONIX_MX25L6495F. -- To view, visit https://review.coreboot.org/c/flashrom/+/57410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9 Gerrit-Change-Number: 57410 Gerrit-PatchSet: 1 Gerrit-Owner: Joseph C. Lehner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Joseph C. Lehner Gerrit-Comment-Date: Wed, 06 Oct 2021 21:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Ravishankar Sarawadi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 ) Change subject: flashchips: Add support for GigaDevice GD25LR256E ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/54dc99de_f345fdaf PS1, Line 9: Tested using Servo: reading and writing works. > Please add a link to the datasheet. Also, mention how you tested it. -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 21:13:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Angel Pons, Hanno Heinrichs. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/51048/comment/7212f5de_0f12ada5 PS4, Line 10: Please add a link to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 4 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Comment-Date: Wed, 06 Oct 2021 21:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Ravishankar Sarawadi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 ) Change subject: flashchips: Add support for GigaDevice GD25LR256E ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/644430a7_c8590fed PS1, Line 9: Tested using Servo: reading and writing works. Please add a link to the datasheet. File flashchips.h: https://review.coreboot.org/c/flashrom/+/58025/comment/0ed07a45_b19386a2 PS1, Line 403: #define GIGADEVICE_GD25LR256E 0x6719 Please keep the ordering and move it down one more line. -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 21:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25D21H
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: WereCatf. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25D21H ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58134/comment/c59459ed_2f2f6000 PS1, Line 8: Please add a link to the datasheet and explain how you tested it. -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 1 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 20:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E
by Sukumar Ghorai (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Ravishankar Sarawadi. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 ) Change subject: flashchips: Add support for GigaDevice GD25LR256E ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Verified. -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 19:14:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util: Add Nix shell file
by Thomas Heijligen (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58012 ) Change subject: util: Add Nix shell file ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50 Gerrit-Change-Number: 58012 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 06 Oct 2021 18:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add TGP-H IDs
by Tim Crawford (Code Review) 06 Oct '21

06 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57533 to look at the new patch set (#3). Change subject: chipset_enable.c: Add TGP-H IDs ...................................................................... chipset_enable.c: Add TGP-H IDs Add IDs for: H510, B560, H570, Q570, Z590, W580, HM570, QM570, WM590 Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M chipset_enable.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/57533/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/57533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Gerrit-Change-Number: 57533 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add Puya P25D21H
by WereCatf (Code Review) 06 Oct '21

06 Oct '21

WereCatf has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25D21H ...................................................................... flashchips: Add Puya P25D21H Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/58134/1 diff --git a/flashchips.c b/flashchips.c index 434c46d..8ca540b 100644 --- a/flashchips.c +++ b/flashchips.c @@ -13131,6 +13131,43 @@ }, { + .vendor = "PUYA", + .name = "P25D21H", + .bustype = BUS_SPI, + .manufacture_id = PUYA_ID, + .model_id = PUYA_P25D21H, + .total_size = 256, + .page_size = 256, + /* supports SFDP */ + /* OTP: 3 x 256 bytes */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 8} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256, 1024} }, + .block_erase = spi_block_erase_81, + } + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { .vendor = "SST", .name = "SST25LF020A", .bustype = BUS_SPI, diff --git a/flashchips.h b/flashchips.h index e190dca..5ec26ab 100644 --- a/flashchips.h +++ b/flashchips.h @@ -621,6 +621,9 @@ #define PMC_PM49FL002 0x6D #define PMC_PM49FL004 0x6E +#define PUYA_ID 0x85 +#define PUYA_P25D21H 0x4012 + /* * The Sanyo chip found so far uses SPI, first byte is manufacturer code, * second byte is the device code, -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 1 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021