Attention is currently required from: Angel Pons, Hanno Heinrichs.
Hello Felix Singer, build bot (Jenkins), Paul Menzel, Angel Pons, Nikolai Artemiev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/51048
to look at the new patch set (#5).
Change subject: flashchips: Add AT25DF011
......................................................................
flashchips: Add AT25DF011
Tested read/write/erase/probe operations with a ch341a_spi programmer.
Datasheet is available at https://www.mouser.de/datasheet/2/590/DS-AT25DF011_032-1098683.pdf
Signed-off-by: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de>
Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131
---
M flashchips.c
M flashchips.h
2 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/51048/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/51048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131
Gerrit-Change-Number: 51048
Gerrit-PatchSet: 5
Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Bartley, Thomas Heijligen, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 )
Change subject: flashchips: add support for Winbond W25Q01JV
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54968/comment/1a1675fd_67228042
PS4, Line 7: flashchips: add support for Winbond W25Q01JV
Which programmer did you use? What was tested?
https://review.coreboot.org/c/flashrom/+/54968/comment/bd5d7247_821cadca
PS4, Line 8:
Please add a link to the datasheet.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If369409419332070c1fed96ce0e96b7cfe42c169
Gerrit-Change-Number: 54968
Gerrit-PatchSet: 4
Gerrit-Owner: David Bartley <andareed(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: David Bartley <andareed(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 22:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Thomas Walker, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 )
Change subject: flashchips: Add Spansion/Cypress S25FL256L
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52310/comment/d2ce870e_045e2c20
PS6, Line 11:
Please add a link to the datasheet.
--
To view, visit https://review.coreboot.org/c/flashrom/+/52310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4e8cba554d0590c94dac92aa91e9ab400efca281
Gerrit-Change-Number: 52310
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Walker <thh.walker(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Thomas Walker <thh.walker(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 22:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Hendricks, Thomas Heijligen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/22567 )
Change subject: flashchips: add W25Q128JV.M
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/22567/comment/b8b71f26_f30c7c67
PS1, Line 7: flashchips: add W25Q128JV.M
Which programmer did you use?
https://review.coreboot.org/c/flashrom/+/22567/comment/ac104976_f43bdce8
PS1, Line 8:
Please add a link to the datasheet.
--
To view, visit https://review.coreboot.org/c/flashrom/+/22567
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Wed, 06 Oct 2021 22:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Neil Armstrong.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263 )
Change subject: flashchips: add definition of the XT25F02E SPI NOR flash
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/50263/comment/97d49972_f33f5628
PS4, Line 7: flashchips: add definition of the XT25F02E SPI NOR flash
Which programmer did you use?
https://review.coreboot.org/c/flashrom/+/50263/comment/409129de_bb00285f
PS4, Line 8:
Please add a link to the datasheet.
--
To view, visit https://review.coreboot.org/c/flashrom/+/50263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54
Gerrit-Change-Number: 50263
Gerrit-PatchSet: 4
Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 22:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Drew Fustini, Thomas Heijligen, Nikolai Artemiev.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 )
Change subject: Add support for GD25LQ256D
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51113/comment/1bc74d41_4410b4f8
PS1, Line 7: Add support for GD25LQ256D
Add `flashchips.c: ` before that
--
To view, visit https://review.coreboot.org/c/flashrom/+/51113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1b745cac070d8deb96ce65137fd9060b148b965
Gerrit-Change-Number: 51113
Gerrit-PatchSet: 1
Gerrit-Owner: Drew Fustini <drew(a)beagleboard.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Drew Fustini <drew(a)beagleboard.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 21:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Joseph C. Lehner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410 )
Change subject: flashchips: add Macronix MX25L3255E
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57410/comment/84e68318_34c47603
PS1, Line 7: flashchips: add Macronix MX25L3255E
How did you test it? Which programmer did you use?
https://review.coreboot.org/c/flashrom/+/57410/comment/f0ecb332_5cbbede5
PS1, Line 8:
Please add a link to the datasheet.
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/57410/comment/31928eb7_433a86dc
PS1, Line 508: #define MACRONIX_MX25L3255E 0x9e16
Please put it after MACRONIX_MX25L6495F.
--
To view, visit https://review.coreboot.org/c/flashrom/+/57410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Gerrit-Change-Number: 57410
Gerrit-PatchSet: 1
Gerrit-Owner: Joseph C. Lehner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Joseph C. Lehner
Gerrit-Comment-Date: Wed, 06 Oct 2021 21:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravishankar Sarawadi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 )
Change subject: flashchips: Add support for GigaDevice GD25LR256E
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/54dc99de_f345fdaf
PS1, Line 9: Tested using Servo: reading and writing works.
> Please add a link to the datasheet.
Also, mention how you tested it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0
Gerrit-Change-Number: 58025
Gerrit-PatchSet: 1
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 21:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment