October 2021 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer. WereCatf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25Q21H ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58134/comment/2d3f4227_06fbe44f PS1, Line 8: > Please add a link to the datasheet and explain how you tested it. Done Patchset: PS2: The chip is apparently actually called P25Q21H, despite the markings on it saying P25D21H, so I changed that. Also, I did add the requested changes to the commit-message. -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 2 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 07 Oct 2021 08:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Hanno Heinrichs (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Angel Pons, Nikolai Artemiev. Hanno Heinrichs has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/51048/comment/d8d48962_50aa366b PS4, Line 10: > Please add a link to the datasheet. Ack Patchset: PS5: Thank you all for your feedback. I think I have taken care of all points. File flashchips.c: https://review.coreboot.org/c/flashrom/+/51048/comment/d8a904ac_cdf26e23 PS2, Line 1495: TEST_OK_PREW > Maybe add some details to the commit message about how you tested the chip. Ack https://review.coreboot.org/c/flashrom/+/51048/comment/24aab1d4_2524c730 PS2, Line 1521: /* 2.3-3.6V & 2.7-3.6V models available */ > The DS-25DF011–032F–5/2017 datasheet states that the range is 1.65v-3.6v. Ack, Thank you for your feedback and please excuse the delay! -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 5 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 08:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: WereCatf. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58134 to look at the new patch set (#2). Change subject: flashchips: Add Puya P25Q21H ...................................................................... flashchips: Add Puya P25Q21H Datasheet: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf Tested read, write and probe with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/58134/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 2 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Hanno Heinrichs (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Angel Pons, Hanno Heinrichs. Hello Felix Singer, build bot (Jenkins), Paul Menzel, Angel Pons, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/51048 to look at the new patch set (#5). Change subject: flashchips: Add AT25DF011 ...................................................................... flashchips: Add AT25DF011 Tested read/write/erase/probe operations with a ch341a_spi programmer. Datasheet is available at https://www.mouser.de/datasheet/2/590/DS-AT25DF011_032-1098683.pdf Signed-off-by: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/51048/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 5 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

WereCatf has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/58159 ) Change subject: flashchips: Add Puya P25Q21H ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/58159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3039dbfd6def29bbab8dfb5b40d8db85fe160485 Gerrit-Change-Number: 58159 Gerrit-PatchSet: 1 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

WereCatf has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58159 ) Change subject: flashchips: Add Puya P25Q21H ...................................................................... flashchips: Add Puya P25Q21H Datasheet: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf Tested reading, writing and probing with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: I3039dbfd6def29bbab8dfb5b40d8db85fe160485 --- M flashchips.c M flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/58159/1 diff --git a/flashchips.c b/flashchips.c index 8ca540b..65c5928 100644 --- a/flashchips.c +++ b/flashchips.c @@ -13132,10 +13132,10 @@ { .vendor = "PUYA", - .name = "P25D21H", + .name = "P25Q21H", .bustype = BUS_SPI, .manufacture_id = PUYA_ID, - .model_id = PUYA_P25D21H, + .model_id = PUYA_P25Q21H, .total_size = 256, .page_size = 256, /* supports SFDP */ diff --git a/flashchips.h b/flashchips.h index 5ec26ab..96fdddd 100644 --- a/flashchips.h +++ b/flashchips.h @@ -622,7 +622,7 @@ #define PMC_PM49FL004 0x6E #define PUYA_ID 0x85 -#define PUYA_P25D21H 0x4012 +#define PUYA_P25Q21H 0x4012 /* * The Sanyo chip found so far uses SPI, first byte is manufacturer code, -- To view, visit https://review.coreboot.org/c/flashrom/+/58159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3039dbfd6def29bbab8dfb5b40d8db85fe160485 Gerrit-Change-Number: 58159 Gerrit-PatchSet: 1 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: add support for Winbond W25Q01JV
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: David Bartley, Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 ) Change subject: flashchips: add support for Winbond W25Q01JV ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/54968/comment/1a1675fd_67228042 PS4, Line 7: flashchips: add support for Winbond W25Q01JV Which programmer did you use? What was tested? https://review.coreboot.org/c/flashrom/+/54968/comment/bd5d7247_821cadca PS4, Line 8: Please add a link to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/54968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If369409419332070c1fed96ce0e96b7cfe42c169 Gerrit-Change-Number: 54968 Gerrit-PatchSet: 4 Gerrit-Owner: David Bartley <andareed(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: David Bartley <andareed(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 22:05:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Spansion/Cypress S25FL256L
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Thomas Heijligen, Thomas Walker, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 ) Change subject: flashchips: Add Spansion/Cypress S25FL256L ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52310/comment/d2ce870e_045e2c20 PS6, Line 11: Please add a link to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/52310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4e8cba554d0590c94dac92aa91e9ab400efca281 Gerrit-Change-Number: 52310 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Walker <thh.walker(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Walker <thh.walker(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 22:03:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: add W25Q128JV.M
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: David Hendricks, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/22567 ) Change subject: flashchips: add W25Q128JV.M ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/22567/comment/b8b71f26_f30c7c67 PS1, Line 7: flashchips: add W25Q128JV.M Which programmer did you use? https://review.coreboot.org/c/flashrom/+/22567/comment/ac104976_f43bdce8 PS1, Line 8: Please add a link to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/22567 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Gerrit-Change-Number: 22567 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 06 Oct 2021 22:02:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Felix Singer (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Thomas Heijligen, Neil Armstrong. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263 ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/50263/comment/97d49972_f33f5628 PS4, Line 7: flashchips: add definition of the XT25F02E SPI NOR flash Which programmer did you use? https://review.coreboot.org/c/flashrom/+/50263/comment/409129de_bb00285f PS4, Line 8: Please add a link to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/50263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 4 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 22:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021