October 2021 - flashrom-gerrit

Change in flashrom[master]: raiden_debug_spi: Link spi_master struct to spi data
by Anastasia Klimchuk (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57972 ) Change subject: raiden_debug_spi: Link spi_master struct to spi data ...................................................................... Patch Set 2: (1 comment) File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/57972/comment/6c2b902d_10046ced PS2, Line 1404: free(ctx_data); : free(spi_config); Something I just thought right now: do I need to swap these two lines? (same for another branch in this function, and same for init function). I thought yes, and then I thought no it's not needed: spi_config is independent pointer and it won't disappear after free(ctx_data)? Just wanted to check that it is indeed not needed? -- To view, visit https://review.coreboot.org/c/flashrom/+/57972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1 Gerrit-Change-Number: 57972 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 05 Oct 2021 00:25:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: raiden_debug_spi: Use spi data in configure_protocol
by Anastasia Klimchuk (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57973 to look at the new patch set (#2). Change subject: raiden_debug_spi: Use spi data in configure_protocol ...................................................................... raiden_debug_spi: Use spi data in configure_protocol Spi data for this programmer now contains pointer to spi_master struct, and can be used in configure_protocol. This patch is making init code of raiden_debug_spi a bit more consistent with other programmers, for example it allows to remove data assignment `spi_config->data = data` from init function. This assignment was only needed for configure_protocol function, and now it is not needed anymore. BUG=b:185191942 TEST=test in CB:57918 Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/57973/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270 Gerrit-Change-Number: 57973 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: raiden_debug_spi: Link spi_master struct to spi data
by Anastasia Klimchuk (Code Review) 04 Oct '21

04 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57972 ) Change subject: raiden_debug_spi: Link spi_master struct to spi data ...................................................................... Patch Set 1: (1 comment) File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/57972/comment/57ec6028_76f437b5 PS1, Line 444: spi_config > Could we just call the field `spi_master` too? I think that would make […] I did a search for spi_config in this file, this string is also used as a part of some enum values in `packet_id_type` enum, also there is a function `get_spi_config_v2`. But the function is working with spi data actually, read/write count fields. So renaming makes sense, in a separate patch, yes. And function name and enum values should stay the same, I think. -- To view, visit https://review.coreboot.org/c/flashrom/+/57972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1 Gerrit-Change-Number: 57972 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 04 Oct 2021 23:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nicintel_spi.c: Cache FLA register value
by Angel Pons (Code Review) 04 Oct '21

04 Oct '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55720 ) Change subject: nicintel_spi.c: Cache FLA register value ...................................................................... Patch Set 2: (1 comment) File nicintel_spi.c: https://review.coreboot.org/c/flashrom/+/55720/comment/0b96d0db_1b4bc71a PS2, Line 122: pci_mmio_readl > If somebody else is still in charge, could the register value still […] Good question, I'd have to read the datasheet. To be safe, I think keeping the last value read is the right thing to do. -- To view, visit https://review.coreboot.org/c/flashrom/+/55720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4013a71ec498be977f62fe2531ac8770bfffadcd Gerrit-Change-Number: 55720 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 04 Oct 2021 14:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: reintroduce generic GPIOL control
by Nico Huber (Code Review) 04 Oct '21

04 Oct '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/57810 ) Change subject: ft2232_spi: reintroduce generic GPIOL control ...................................................................... ft2232_spi: reintroduce generic GPIOL control This reintroduces a reworked version of the GPIOL pin control first introduced in commit 3207844 (CB:49637), which was reverted in commit 6518cf3 (CB:55692) due to breakage. This change introduces a new argument `gpiolX` to allow use of the four GPIOL pins either as generic gpios or as additional CS# signal(s). `X` specifies the GPIOL pin (0-3) to be set to one of [HLC] with the following meaning: * H - set the pin as output high * L - set the pin as output low * C - use the pin as additional CS# signal The third value, `C`, aims to replace the parameter `csgpiol`, that is now marked as deprecated and can be removed at some point in the future. `gpiol` and `csgpiol` are mutually exclusive and use of both results in an error. Multiple pins may be set by specifying the parameter multiple times. Documentation was updated/added accordingly. Test: All pin levels/modes have been verified to behave correctly with a logic analyzer. Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Signed-off-by: Alan Green <avg(a)google.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/57810 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.8.tmpl M ft2232_spi.c 2 files changed, 109 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index de93453..989d677 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -883,12 +883,42 @@ syntax. .sp Using the parameter -.B csgpiol +.B csgpiol (DEPRECATED - use gpiol instead) an additional CS# pin can be chosen, where the value can be a number between 0 and 3, denoting GPIOL0-GPIOL3 correspondingly. Example: .sp .B " flashrom \-p ft2232_spi:csgpiol=3" .sp +The parameter +.B gpiolX=[HLC] +allows use of the GPIOL pins either as generic gpios with a fixed value during flashing or as addtional CS# +signal, where +.B X +can be a number between 0 and 3, denoting GPIOL0-GPIOL3 correspondingly. The parameter may be specified +multiple times, one time per GPIOL pin. +Valid values are +.B H +, +.B L +and +.B C +: +.br +.B " H " +- Set GPIOL output high +.br +.B " L " +- Set GPIOL output low +.br +.B " C " +- Use GPIOL as additional CS# output +.sp +.B Example: +.sp +.B " flashrom \-p ft2232_spi:gpiol0=H" +.sp +.B Note +that not all GPIOL pins are freely usable with all programmers as some have special functionality. .SS .BR "serprog " programmer .IP diff --git a/ft2232_spi.c b/ft2232_spi.c index 110bdec..65326f9 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -91,9 +91,10 @@ * to high and will be toggled during SPI transactions. All other * output pins will be kept low all the time. For some programmers, * some reserved GPIOL* pins are used as outputs. Free GPIOL* pins - * are configured as inputs, while it's possible to use one of them - * as additional CS# signal through the parameter `csgpiol`. On exit, - * all pins will be reconfigured as inputs. + * are configured as inputs, while it's possible to use them either + * as generic gpios or as additional CS# signal(s) through the + * parameter(s) `gpiolX`. On exit, all pins will be reconfigured + * as inputs. * * The pin offsets are as follows: * TCK/SK is bit 0. @@ -112,6 +113,7 @@ */ struct ft2232_data { uint8_t cs_bits; + uint8_t aux_bits; uint8_t pindir; struct ftdi_context ftdic_context; }; @@ -233,7 +235,8 @@ msg_pspew("Assert CS#\n"); buf[i++] = SET_BITS_LOW; - buf[i++] = 0; /* assert CS# pins, all other output pins stay low */ + /* assert CS# pins, keep aux_bits, all other output pins stay low */ + buf[i++] = spi_data->aux_bits; buf[i++] = spi_data->pindir; /* WREN, OP(PROGRAM, ERASE), ADDR, DATA */ @@ -255,7 +258,7 @@ /* Add final de-assert CS# */ msg_pspew("De-assert CS#\n"); buf[i++] = SET_BITS_LOW; - buf[i++] = spi_data->cs_bits; + buf[i++] = spi_data->cs_bits | spi_data->aux_bits; buf[i++] = spi_data->pindir; /* continue if there is no read-cmd and further cmds exist */ @@ -325,6 +328,7 @@ double mpsse_clk; uint8_t cs_bits = 0x08; + uint8_t aux_bits = 0x00; uint8_t pindir = 0x0b; struct ftdi_context ftdic; struct ft2232_data *spi_data; @@ -470,8 +474,13 @@ } free(arg); + bool csgpiol_set = false; arg = extract_programmer_param("csgpiol"); if (arg) { + csgpiol_set = true; + msg_pwarn("Deprecation warning: `csgpiol` is deprectated and will be removed " + "in the future.\nUse `gpiolX=C` instead.\n"); + char *endptr; unsigned int temp = strtoul(arg, &endptr, 10); if (*endptr || endptr == arg || temp > 3) { @@ -480,8 +489,8 @@ free(arg); return -2; } - unsigned int pin = temp + 4; + unsigned int pin = temp + 4; if (rsv_bits & 1 << pin) { msg_perr("Error: Invalid GPIOL specified: \"%s\".\n" "The pin is reserved on this programmer.\n", @@ -491,10 +500,70 @@ } cs_bits |= 1 << pin; - pindir |= 1 << pin; + pindir |= 1 << pin; } free(arg); + /* gpiolX */ + for (int pin = 0; pin < 4; pin++) { + char gpiol_param[7]; + snprintf(gpiol_param, sizeof(gpiol_param), "gpiol%d", pin); + arg = extract_programmer_param(gpiol_param); + + if (!arg) + continue; + + if (csgpiol_set) { + msg_perr("Error: `csgpiol` and `gpiolX` are mutually exclusive.\n" + "Since `csgpiol` is deprecated and will be removed in the " + "future, use of `gpiolX=C` is recommended.\n"); + free(arg); + return -2; + } + + uint8_t bit = 1 << (pin + 4); + if (rsv_bits & bit) { + msg_perr("Error: Invalid GPIOL specified: \"gpiol%d=%s\".\n" + "Pin GPIOL%i is reserved on this programmer.\n", + pin, arg, pin); + free(arg); + return -2; + } + + if (strlen(arg) != 1) + goto format_error; + + switch (toupper(arg[0])) { + case 'H': + aux_bits |= bit; + pindir |= bit; + break; + case 'L': + pindir |= bit; + break; + case 'C': + cs_bits |= bit; + pindir |= bit; + break; + default: + goto format_error; + } + + free(arg); + continue; + +format_error: + msg_perr("Error: Invalid GPIOL specified: \"gpiol%d=%s\".\n" + "Valid values are H, L and C.\n" + " H - Set GPIOL output high\n" + " L - Set GPIOL output low\n" + " C - Use GPIOL as additional CS# output\n", + pin, arg); + + free(arg); + return -2; + } + msg_pdbg("Using device type %s %s ", get_ft2232_vendorname(ft2232_vid, ft2232_type), get_ft2232_devicename(ft2232_vid, ft2232_type)); @@ -577,7 +646,7 @@ msg_pdbg("Set data bits\n"); buf[0] = SET_BITS_LOW; - buf[1] = cs_bits; + buf[1] = cs_bits | aux_bits; buf[2] = pindir; if (send_buf(&ftdic, buf, 3)) { ret = -8; @@ -590,6 +659,7 @@ return SPI_GENERIC_ERROR; } spi_data->cs_bits = cs_bits; + spi_data->aux_bits = aux_bits; spi_data->pindir = pindir; spi_data->ftdic_context = ftdic; -- To view, visit https://review.coreboot.org/c/flashrom/+/57810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Gerrit-Change-Number: 57810 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ich_descriptors: Add explicit checks for all chipsets
by David Hendricks (Code Review) 02 Oct '21

02 Oct '21

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 ) Change subject: ich_descriptors: Add explicit checks for all chipsets ...................................................................... Patch Set 5: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57793/comment/d7bd35fd_b7d2447b PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n"); > > Regardless, this is not worth splitting hairs so I've reverted back to using msg_pwarn() since you […] The codepaths aren't really "normalized" in this case, but Angel helpfully explained the rationale for leaving this snippet alone. Thanks, Angel. -- To view, visit https://review.coreboot.org/c/flashrom/+/57793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Gerrit-Change-Number: 57793 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 02 Oct 2021 02:27:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by David Hendricks (Code Review) 02 Oct '21

02 Oct '21

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Abandoned No longer needed -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by David Hendricks (Code Review) 02 Oct '21

02 Oct '21

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/57633 ) Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... Abandoned Superseded by CB:57793 -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: util/ich_descriptors_tool: Use GNU-style printf in MinGW
by David Hendricks (Code Review) 01 Oct '21

01 Oct '21

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43052 ) Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW ...................................................................... util/ich_descriptors_tool: Use GNU-style printf in MinGW This allows MinGW targets to use certain printf formatting identifiers such as "%v" by adding -D__USE_MINGW_ANSI_STDIO=1 to the CFLAGS. This is also done in flashrom's top-level Makefile. Reported on https://github.com/flashrom/flashrom/issues/149 Change-Id: I644be8b5b607cc77b4be2121c443f0d41d8da687 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M util/ich_descriptors_tool/Makefile 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/43052/1 diff --git a/util/ich_descriptors_tool/Makefile b/util/ich_descriptors_tool/Makefile index c32e30b..8962431 100644 --- a/util/ich_descriptors_tool/Makefile +++ b/util/ich_descriptors_tool/Makefile @@ -41,6 +41,10 @@ CFLAGS += -Wno-format endif +ifeq ($(TARGET_OS), MinGW) +CFLAGS += -D__USE_MINGW_ANSI_STDIO=1 +endif + ifeq ($(WARNERROR), yes) CFLAGS += -Werror endif -- To view, visit https://review.coreboot.org/c/flashrom/+/43052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I644be8b5b607cc77b4be2121c443f0d41d8da687 Gerrit-Change-Number: 43052 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

4 5

Change in flashrom[master]: ft2232_spi: reintroduce generic GPIOL control
by Michael Niewöhner (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 ) Change subject: ft2232_spi: reintroduce generic GPIOL control ...................................................................... Patch Set 18: (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57810/comment/4502095c_b2c232d7 PS16, Line 513: arg_gpiol[3] = extract_programmer_param("gpiol3"); > > > Also just noticed: In the current form, any premature `return` inside […] ack, indeed -- To view, visit https://review.coreboot.org/c/flashrom/+/57810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Gerrit-Change-Number: 57810 Gerrit-PatchSet: 18 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 12:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021