Change in flashrom[master]: util/ich_descriptors_tool: Use GNU-style printf in MinGW

[David Hendricks (Code Review)]

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

util/ich_descriptors_tool: Use GNU-style printf in MinGW

This allows MinGW targets to use certain printf formatting
identifiers such as "%v" by adding  -D__USE_MINGW_ANSI_STDIO=1 to
the CFLAGS. This is also done in flashrom's top-level Makefile.

Reported on https://github.com/flashrom/flashrom/issues/149

Change-Id: I644be8b5b607cc77b4be2121c443f0d41d8da687
Signed-off-by: David Hendricks 
---
M util/ich_descriptors_tool/Makefile
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/43052/1

diff --git a/util/ich_descriptors_tool/Makefile b/util/ich_descriptors_tool/Makefile
index c32e30b..8962431 100644
--- a/util/ich_descriptors_tool/Makefile
+++ b/util/ich_descriptors_tool/Makefile
@@ -41,6 +41,10 @@
 CFLAGS += -Wno-format
 endif

+ifeq ($(TARGET_OS), MinGW)
+CFLAGS += -D__USE_MINGW_ANSI_STDIO=1
+endif
+
 ifeq ($(WARNERROR), yes)
 CFLAGS += -Werror
 endif

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

Patch Set 1:

Tested by running `make CC=i686-w64-mingw32-gcc CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no` on an Ubuntu 20 host with MinGW installed.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Attention is currently required from: David Hendricks.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

Patch Set 2: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

util/ich_descriptors_tool: Use GNU-style printf in MinGW

This allows MinGW targets to use certain printf formatting
identifiers such as "%v" by adding  -D__USE_MINGW_ANSI_STDIO=1 to
the CFLAGS. This is also done in flashrom's top-level Makefile.

Reported on https://github.com/flashrom/flashrom/issues/149

Change-Id: I644be8b5b607cc77b4be2121c443f0d41d8da687
Signed-off-by: David Hendricks 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/43052
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M util/ich_descriptors_tool/Makefile
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/util/ich_descriptors_tool/Makefile b/util/ich_descriptors_tool/Makefile
index c32e30b..8962431 100644
--- a/util/ich_descriptors_tool/Makefile
+++ b/util/ich_descriptors_tool/Makefile
@@ -41,6 +41,10 @@
 CFLAGS += -Wno-format
 endif

+ifeq ($(TARGET_OS), MinGW)
+CFLAGS += -D__USE_MINGW_ANSI_STDIO=1
+endif
+
 ifeq ($(WARNERROR), yes)
 CFLAGS += -Werror
 endif

[Miklós Márton (Code Review)]

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43052 )

Change subject: util/ich_descriptors_tool: Use GNU-style printf in MinGW
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

Patchset:

PS3: 
Ship it!