October 2021 - flashrom-gerrit

Change in flashrom[master]: Add support for IS25WQ040
by Felix Singer (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Vasily Galkin, Thomas Heijligen, roman.stingler(a)gmail.com. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179 ) Change subject: Add support for IS25WQ040 ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58179/comment/348d3a10_d5d632f4 PS1, Line 7: Add support for IS25WQ040 Add `flashchips.c: ` before that https://review.coreboot.org/c/flashrom/+/58179/comment/78782ed9_00e4dfe9 PS1, Line 10: Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Put the Sign-offs after the line with the Change-Id. This one should come first. https://review.coreboot.org/c/flashrom/+/58179/comment/c533e841_6842ed9f PS1, Line 11: Add a link to the datasheet. https://review.coreboot.org/c/flashrom/+/58179/comment/769020a9_1f3f5322 PS1, Line 12: Did you test it? How? Which programmer did you use? -- To view, visit https://review.coreboot.org/c/flashrom/+/58179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: Vasily Galkin Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 07 Oct 2021 17:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util: Add Nix shell file
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58012 ) Change subject: util: Add Nix shell file ...................................................................... Patch Set 3: (2 comments) File util/shell.nix: https://review.coreboot.org/c/flashrom/+/58012/comment/148e3305_16b9b018 PS3, Line 3: stdenv What does this imply? I was wondering why we need `meson` but not `gcc`, `make` etc. Is it always Linux? if so, are kernel headers always available? https://review.coreboot.org/c/flashrom/+/58012/comment/ad93be1e_0b114c04 PS3, Line 9: libusb1 Is there a libjaylink package? -- To view, visit https://review.coreboot.org/c/flashrom/+/58012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50 Gerrit-Change-Number: 58012 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 07 Oct 2021 16:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for IS25WQ040
by Vasily Galkin (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: roman.stingler(a)gmail.com. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179 ) Change subject: Add support for IS25WQ040 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: (just notifying Roman that his change with fixes is included in this review) -- To view, visit https://review.coreboot.org/c/flashrom/+/58179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Comment-Date: Thu, 07 Oct 2021 16:20:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for IS25WQ040
by Vasily Galkin (Code Review) 07 Oct '21

07 Oct '21

Vasily Galkin has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58179 ) Change subject: Add support for IS25WQ040 ...................................................................... Add support for IS25WQ040 Based on https://github.com/flashrom/flashrom/pull/204 Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Squashed with fixes of IS25WQ040 size: it is 4Mbits, not 4MBytes. Fixes were tested on a real chip with ft2232_spi programmer. Signed-off-by: Vasily Galkin <galkin-vv(a)ya.ru> Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/58179/1 diff --git a/flashchips.c b/flashchips.c index 434c46d..57cc3c4 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7611,6 +7611,48 @@ { .vendor = "ISSI", + .name = "IS25WQ040", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WQ040, + .total_size = 512, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, diff --git a/flashchips.h b/flashchips.h index e190dca..2bce460 100644 --- a/flashchips.h +++ b/flashchips.h @@ -479,6 +479,7 @@ #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 #define ISSI_IS25WP256 0x7019 +#define ISSI_IS25WQ040 0x1253 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 -- To view, visit https://review.coreboot.org/c/flashrom/+/58179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Tim Crawford (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Michał Żygowski. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: Michał can you rebase this to resolve the conflict? -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 15:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add wrap for libusb_init and use it in dediprog test
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57917 ) Change subject: tests: Add wrap for libusb_init and use it in dediprog test ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57917/comment/bc15f1b8_4ea6a029 PS3, Line 15: real libusb_init Do we ever want to call real libusb functions? If not, I guess, we shouldn't link the test executable with libusb. This would result in most visible link-time errors in case we forget to implement something. -- To view, visit https://review.coreboot.org/c/flashrom/+/57917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I51c9cb96db1afb3298f4d098df96509d3cb3c046 Gerrit-Change-Number: 57917 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 07 Oct 2021 14:24:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add XTX XT25F64B
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

WereCatf has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58173 ) Change subject: flashchips: Add XTX XT25F64B ...................................................................... flashchips: Add XTX XT25F64B Datasheet: http://file2.dzsc.com/product/19/06/22/216185_132959081.pdf Tested probe, read, erase and write with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/58173/1 diff --git a/flashchips.c b/flashchips.c index 434c46d..eb5c0d2 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19394,6 +19394,46 @@ }, { + .vendor = "XTX Technology Limited", + .name = "XT25F64B", + .bustype = BUS_SPI, + .manufacture_id = XTX_ID, + .model_id = XTX_XT25F64B, + .total_size = 8192, + .page_size = 256, + /* Supports SFDP */ + /* OTP: 4 x 256 bytes */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8192 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8192 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp4_srwd, + .unlock = spi_disable_blockprotect_bp4_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { .vendor = "Zetta Device", .name = "ZD25D20", .bustype = BUS_SPI, diff --git a/flashchips.h b/flashchips.h index e190dca..ab392ac 100644 --- a/flashchips.h +++ b/flashchips.h @@ -1025,6 +1025,9 @@ #define WINBOND_W49V002A 0xB0 #define WINBOND_W49V002FA 0x32 +#define XTX_ID 0x0B /* XTX Technology Limited */ +#define XTX_XT25F64B 0x4017 + #define ZETTADEVICE_ID 0xBA /* Zetta Device */ #define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 -- To view, visit https://review.coreboot.org/c/flashrom/+/58173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I369db9ccfd5319d28424d10f77aab49ec73a8836 Gerrit-Change-Number: 58173 Gerrit-PatchSet: 1 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Felix Singer (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Angel Pons, Nikolai Artemiev, Hanno Heinrichs. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 5 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Comment-Date: Thu, 07 Oct 2021 12:02:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H/11H/06H
by Felix Singer (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Angel Pons, WereCatf. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25Q21H/11H/06H ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 4 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 12:00:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 ) Change subject: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Yes, I was also thinking about whether io_mock is the right header ... so probably it's not. > include/test.h gets LOG_ME further in this chain anyway CB:57914, so I can move non zero and not null there as well. > But I would need include/tests.c for not_null() implementation, is that correct? You mean to put not_null() into `tests/tests.c`? > > Another thing I wanted to ask before I start changing everything: I am using io_mock.c later in this chain for current_io CB:57915 is that correct approach? If yes, I think I can remove io_mock.c from this patch and delay its creation until CB:57915. Sounds good. -- To view, visit https://review.coreboot.org/c/flashrom/+/57269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48 Gerrit-Change-Number: 57269 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 07 Oct 2021 11:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021