October 2021 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Puya P25Q21H/11H/06H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58134 to look at the new patch set (#4). Change subject: flashchips: Add Puya P25Q21H/11H/06H ...................................................................... flashchips: Add Puya P25Q21H/11H/06H Datasheet: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf Tested P25Q21H read, write and probe with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 --- M flashchips.c M flashchips.h 2 files changed, 134 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/58134/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 4 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H/11H/06H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. WereCatf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25Q21H/11H/06H ...................................................................... Patch Set 3: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58134/comment/749dae56_fbfa9f8b PS2, Line 10: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf > While we're at it, I'd greatly appreciate if you could add support for the P25Q11H and P25Q06H as we […] Done Patchset: PS3: Requested changes made. File flashchips.c: https://review.coreboot.org/c/flashrom/+/58134/comment/d56bd9b9_f640bc0b PS2, Line 13158: }, { > Missing entries for the full chip erase commands: […] Done https://review.coreboot.org/c/flashrom/+/58134/comment/cc69cdb7_829d2966 PS2, Line 13158: : .eraseblocks = { {256, 1024} }, : .block_erase = spi_block_erase_81 > Block eraser entries should be sorted in ascending block size (the pair of numbers is `{ block size, […] Done https://review.coreboot.org/c/flashrom/+/58134/comment/44b2bd1d_216d4e58 PS2, Line 13163: spi_prettyprint_status_register_plain > spi_prettyprint_status_register_bp4_srwd Done https://review.coreboot.org/c/flashrom/+/58134/comment/f3c102e1_6fcbe5d0 PS2, Line 13164: spi_disable_blockprotect > spi_disable_blockprotect_bp4_srwd Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 3 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H/11H/06H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, WereCatf. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58134 to look at the new patch set (#3). Change subject: flashchips: Add Puya P25Q21H/11H/06H ...................................................................... flashchips: Add Puya P25Q21H/11H/06H Datasheet: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf Tested read, write and probe with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 --- M flashchips.c M flashchips.h 2 files changed, 134 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/58134/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 3 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: raiden_debug_spi: Use new API to register shutdown function
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57975 ) Change subject: raiden_debug_spi: Use new API to register shutdown function ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57975/comment/d87d95d0_c146eada PS2, Line 17: TRY TO TEST ME ON HW I guess this is why I didn't give a +2 yet. Any plans to do this before we merge these patches? -- To view, visit https://review.coreboot.org/c/flashrom/+/57975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8927224779f24d1fda088991337e54d7272775a6 Gerrit-Change-Number: 57975 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: raiden_debug_spi: Use spi data in configure_protocol
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57973 ) Change subject: raiden_debug_spi: Use spi data in configure_protocol ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270 Gerrit-Change-Number: 57973 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: raiden_debug_spi: Link spi_master struct to spi data
by Nico Huber (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57972 ) Change subject: raiden_debug_spi: Link spi_master struct to spi data ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/57972/comment/70665b41_e9717435 PS2, Line 1404: free(ctx_data); : free(spi_config); > spi_config is independent pointer and it won't disappear after free(ctx_data)? That's it. Both pointers live on the stack. -- To view, visit https://review.coreboot.org/c/flashrom/+/57972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1 Gerrit-Change-Number: 57972 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by Angel Pons (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, WereCatf. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25Q21H ...................................................................... Patch Set 2: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58134/comment/5de4d4c9_f171e66c PS2, Line 10: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf While we're at it, I'd greatly appreciate if you could add support for the P25Q11H and P25Q06H as well, as they only differ in size (`total_size` and `block_erasers` need adjustment). Also, they should be marked as `TEST_UNTESTED` for now. File flashchips.c: https://review.coreboot.org/c/flashrom/+/58134/comment/afce1fd9_dc732ce9 PS2, Line 13158: }, { Missing entries for the full chip erase commands: }, { .eraseblocks = { {256 * 1024, 1} }, .block_erase = spi_block_erase_60, }, { .eraseblocks = { {256 * 1024, 1} }, .block_erase = spi_block_erase_c7, }, These two entries should be the last, below the other entries. https://review.coreboot.org/c/flashrom/+/58134/comment/61ccc19b_f8bd1e02 PS2, Line 13158: : .eraseblocks = { {256, 1024} }, : .block_erase = spi_block_erase_81 Block eraser entries should be sorted in ascending block size (the pair of numbers is `{ block size, number of blocks }`). So, this one should be the first, above the other entries. I expect this change to slow down erasing/rewriting. If the performance impact is unacceptable (e.g. full erase time goes from several seconds to some minutes), please let me know. https://review.coreboot.org/c/flashrom/+/58134/comment/aeb31eda_819dad41 PS2, Line 13163: spi_prettyprint_status_register_plain spi_prettyprint_status_register_bp4_srwd https://review.coreboot.org/c/flashrom/+/58134/comment/65130650_1bc05f2d PS2, Line 13164: spi_disable_blockprotect spi_disable_blockprotect_bp4_srwd -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 2 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer. WereCatf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 ) Change subject: flashchips: Add Puya P25Q21H ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58134/comment/2d3f4227_06fbe44f PS1, Line 8: > Please add a link to the datasheet and explain how you tested it. Done Patchset: PS2: The chip is apparently actually called P25Q21H, despite the markings on it saying P25D21H, so I changed that. Also, I did add the requested changes to the commit-message. -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 2 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 07 Oct 2021 08:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Hanno Heinrichs (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Felix Singer, Angel Pons, Nikolai Artemiev. Hanno Heinrichs has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/51048/comment/d8d48962_50aa366b PS4, Line 10: > Please add a link to the datasheet. Ack Patchset: PS5: Thank you all for your feedback. I think I have taken care of all points. File flashchips.c: https://review.coreboot.org/c/flashrom/+/51048/comment/d8a904ac_cdf26e23 PS2, Line 1495: TEST_OK_PREW > Maybe add some details to the commit message about how you tested the chip. Ack https://review.coreboot.org/c/flashrom/+/51048/comment/24aab1d4_2524c730 PS2, Line 1521: /* 2.3-3.6V & 2.7-3.6V models available */ > The DS-25DF011–032F–5/2017 datasheet states that the range is 1.65v-3.6v. Ack, Thank you for your feedback and please excuse the delay! -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 5 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 08:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Puya P25Q21H
by WereCatf (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: WereCatf. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58134 to look at the new patch set (#2). Change subject: flashchips: Add Puya P25Q21H ...................................................................... flashchips: Add Puya P25Q21H Datasheet: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf Tested read, write and probe with CH341a. Signed-off-by: Nita Vesa <werecatf(a)outlook.com> Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/58134/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9 Gerrit-Change-Number: 58134 Gerrit-PatchSet: 2 Gerrit-Owner: WereCatf <werecatf(a)outlook.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: WereCatf <werecatf(a)outlook.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021