Attention is currently required from: Thomas Heijligen, Joseph C. Lehner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410 )
Change subject: flashchips: add Macronix MX25L3255E ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57410/comment/84e68318_34c47603 PS1, Line 7: flashchips: add Macronix MX25L3255E How did you test it? Which programmer did you use?
https://review.coreboot.org/c/flashrom/+/57410/comment/f0ecb332_5cbbede5 PS1, Line 8: Please add a link to the datasheet.
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/57410/comment/31928eb7_433a86dc PS1, Line 508: #define MACRONIX_MX25L3255E 0x9e16 Please put it after MACRONIX_MX25L6495F.
-
Felix Singer (Code Review)