January 2021 - flashrom-gerrit

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49262 to look at the new patch set (#8). Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... bitbang_spi.c: fix bitbang_spi_send_command … [View More]

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49255 to look at the new patch set (#13). Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... bitbang-spi.c: support clock polarity and phase SPI has four modes,… [View More]

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Edward O'Callaghan (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 ) Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... Patch Set 12: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/49255/comment/7e077dbe_04cd0187 PS12, Line 12: . Also state the previous … [View More]

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Edward O'Callaghan (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49262 To unsubscribe, or for help writing mail filters, visit … [View More]

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49255 to look at the new patch set (#12). Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... bitbang-spi.c: support clock polarity and phase SPI has … [View More]

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49255 to look at the new patch set (#11). Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... bitbang-spi.c: support clock polarity and phase SPI has … [View More]

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49262/comment/dfa1c8b9_3600361a PS3, Line 7: bitbang_spi.c: fix … [View More]

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49262 to look at the new patch set (#5). Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... bitbang_spi.c: fix bitbang_spi_send_command … [View More]

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 ) Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... Patch Set 10: (2 comments) File bitbang_spi.c: https://review.coreboot.org/c/flashrom/+/49255/comment/bc863fec_34e1ce19 PS9, Line 77: } > sorry, I mean the `\n` deletion … [View More]

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49262 to look at the new patch set (#4). Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... bitbang_spi.c: fix bitbang_spi_send_command … [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2021