Miklós Márton has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43900 )
Change subject: [stlinkv3_spi]Added missing line ends, and added a note about the first version of the updater which contains the necessary V3 bridge feature.
......................................................................
[stlinkv3_spi]Added missing line ends, and added a note about the
first version of the updater which contains the necessary V3 bridge
feature.
Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com>
---
M stlinkv3_spi.c
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/43900/1
diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c
index ae865be..c75f7db 100644
--- a/stlinkv3_spi.c
+++ b/stlinkv3_spi.c
@@ -253,21 +253,22 @@
enum fw_version_check_result fw_check_result;
if (stlinkv3_check_version(&fw_check_result)) {
- msg_perr("Failed to query FW version");
+ msg_perr("Failed to query FW version\n");
return -1;
}
if (fw_check_result != FW_VERSION_OK) {
msg_pinfo("Your STLink V3 has too old version of the bridge interface\n"
- "Please update the firmware with the STSW-LINK007 which can be downloaded from here:\n"
- "https://www.st.com/en/development-tools/stsw-link007.html");
+ "Please update the firmware with version 2.33.25 or newer of the STSW-LINK007\n"
+ "which can be downloaded from here:\n"
+ "https://www.st.com/en/development-tools/stsw-link007.html\n");
return -1;
}
if (stlinkv3_spi_calc_prescaler(reqested_freq_in_kHz,
&prescaler,
&SCK_freq_in_kHz)) {
- msg_perr("Failed to calculate SPI clock prescaler");
+ msg_perr("Failed to calculate SPI clock prescaler\n");
return -1;
}
msg_pinfo("SCK frequency set to %d kHz\n", SCK_freq_in_kHz);
--
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-MessageType: newchange
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................
Patch Set 14:
Just a try to show what effect the change has:
To do one PageProgram the Flash needs the following cmds/information (PROG=PageProgramCmd):
Flash-Cmds: JEDEC_WREN + PROG + ADDR + DATA
As flashrom communicates with the FTDI, there are additional FTDI-cmds necessary, of course.
This gives the following calls:
ft2232_spi_send_command(XX, XX, ['JEDEC_WREN'], XX)
before: -> send_buf(XX, [FTDI-CMD + 'JEDEC_WREN' + FTDI-CMD], 10)
now: -> save i and buf as they are static, no further function call; buf = [FTDI-CMD + 'JEDEC_WREN' + FTDI-CMD]
ft2232_spi_send_command(XX, XX, ['PROG', 'ADDR', 'DATA'], XX)
before: -> send_buf(XX, [FTDI-CMD + 'PROG' + 'ADDR' + 'DATA' + FTDI-CMD], 270)
now: -> send_buf(XX, [FTDI-CMD + 'JEDEC_WREN' + FTDI-CMD + FTDI-CMD + 'PROG' + 'ADDR' + 'DATA' + FTDI-CMD], 280)
=> saves one send_buf/ftdi_write_data call every page-program or erase action.
--
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 14
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 27 Jul 2020 14:16:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43895 )
Change subject: ichspi.c: Take chromiums flash desc sec override msg
......................................................................
ichspi.c: Take chromiums flash desc sec override msg
Line wrapped and a little more descriptive.
Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M ichspi.c
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/43895/1
diff --git a/ichspi.c b/ichspi.c
index 1cc1cd7..d9f13ef 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1849,9 +1849,11 @@
if (tmp2 & HSFS_FDV)
desc_valid = 1;
if (!(tmp2 & HSFS_FDOPSS) && desc_valid)
- msg_pinfo("The Flash Descriptor Override Strap-Pin is set. Restrictions implied by\n"
- "the Master Section of the flash descriptor are NOT in effect. Please note\n"
- "that Protected Range (PR) restrictions still apply.\n");
+ msg_pinfo("The Flash Descriptor Security Override "
+ "Strap-Pin is set. Restrictions implied\n"
+ "by the FRAP and FREG registers are NOT in "
+ "effect. Please note that Protected\n"
+ "Range (PR) restrictions still apply.\n");
ich_init_opcodes(ich_gen);
if (desc_valid) {
--
To view, visit https://review.coreboot.org/c/flashrom/+/43895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6
Gerrit-Change-Number: 43895
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43599 )
Change subject: meson: fix compilation under uClibc-ng
......................................................................
meson: fix compilation under uClibc-ng
fileno requires _POSIX_C_SOURCE to only be defined.
nanosleep requires _POSIX_C_SOURCE to be defined to 199309L.
strndup requires _POSIX_C_SOURCE to be defined to 200809L.
Change-Id: Idb80937bb78e173eb03f2a0c0cdd8925fcd7bfa1
Signed-off-by: Rosen Penev <rosenp(a)gmail.com>
---
M meson.build
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/43599/1
diff --git a/meson.build b/meson.build
index 5374e87..ef7ac2c 100644
--- a/meson.build
+++ b/meson.build
@@ -25,7 +25,7 @@
cc = meson.get_compiler('c')
add_project_arguments(cc.get_supported_arguments(warning_flags), language : 'c')
add_project_arguments('-D_DEFAULT_SOURCE', language : 'c')
-add_project_arguments('-D_POSIX_C_SOURCE', language : 'c') # required for fileno
+add_project_arguments('-D_POSIX_C_SOURCE=200809L', language : 'c') # required for fileno, nanosleep, and strndup
add_project_arguments('-D_BSD_SOURCE', language : 'c') # required for glibc < v2.19
add_project_arguments('-DFLASHROM_VERSION="' + meson.project_version() + '"', language : 'c')
--
To view, visit https://review.coreboot.org/c/flashrom/+/43599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idb80937bb78e173eb03f2a0c0cdd8925fcd7bfa1
Gerrit-Change-Number: 43599
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: newchange
David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43598 )
Change subject: endiantest: Fix #if expression
......................................................................
endiantest: Fix #if expression
Without this, `gcc -E endiantest.c` can fail and return the incorrect
endiannes as well as exiting with non-zero. Here is the actual error
shown in the output:
endiantest.c:2:31: error: #if with no expression
#if __FLASHROM_LITTLE_ENDIAN__
I was able to reproduce this using gcc-6.3.0 and clang-4.0.1, but
newer compilers didn't have this issue.
Change-Id: Iba2febd861471ec821a494336e800c2564984332
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M endiantest.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/43598/1
diff --git a/endiantest.c b/endiantest.c
index de44ec5..9766061 100644
--- a/endiantest.c
+++ b/endiantest.c
@@ -1,5 +1,5 @@
#include "platform.h"
-#if __FLASHROM_LITTLE_ENDIAN__
+#if defined __FLASHROM_LITTLE_ENDIAN__
little
#else
big
--
To view, visit https://review.coreboot.org/c/flashrom/+/43598
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba2febd861471ec821a494336e800c2564984332
Gerrit-Change-Number: 43598
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: newchange