Change in flashrom[master]: ichspi.c: Take chromiums flash desc sec override msg
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43895 ) Change subject: ichspi.c: Take chromiums flash desc sec override msg ...................................................................... ichspi.c: Take chromiums flash desc sec override msg Line wrapped and a little more descriptive. Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Signed-off-by: Edward O'Callaghan <quasisec@google.com> --- M ichspi.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/43895/1 diff --git a/ichspi.c b/ichspi.c index 1cc1cd7..d9f13ef 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1849,9 +1849,11 @@ if (tmp2 & HSFS_FDV) desc_valid = 1; if (!(tmp2 & HSFS_FDOPSS) && desc_valid) - msg_pinfo("The Flash Descriptor Override Strap-Pin is set. Restrictions implied by\n" - "the Master Section of the flash descriptor are NOT in effect. Please note\n" - "that Protected Range (PR) restrictions still apply.\n"); + msg_pinfo("The Flash Descriptor Security Override " + "Strap-Pin is set. Restrictions implied\n" + "by the FRAP and FREG registers are NOT in " + "effect. Please note that Protected\n" + "Range (PR) restrictions still apply.\n"); ich_init_opcodes(ich_gen); if (desc_valid) { -- To view, visit https://review.coreboot.org/c/flashrom/+/43895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: newchange
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43895 ) Change subject: ichspi.c: Take chromiums flash desc sec override msg ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c File ichspi.c: https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c@1854 PS1, Line 1854: FRAP and FREG registers These names are only correct for ICH9 and similar. IBX and onwards use FLMSTRx -- To view, visit https://review.coreboot.org/c/flashrom/+/43895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 26 Jul 2020 08:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43895 ) Change subject: ichspi.c: Take chromiums flash desc sec override msg ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c File ichspi.c: https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c@1854 PS1, Line 1854: FRAP and FREG registers
These names are only correct for ICH9 and similar. […] See commit d7d423bb as to why this message was changed. This commit is effectively undoing part of it.
-- To view, visit https://review.coreboot.org/c/flashrom/+/43895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 26 Jul 2020 08:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43895 ) Change subject: ichspi.c: Take chromiums flash desc sec override msg ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c File ichspi.c: https://review.coreboot.org/c/flashrom/+/43895/1/ichspi.c@1854 PS1, Line 1854: FRAP and FREG registers
See commit d7d423bb as to why this message was changed. […] Ah thanks for pointing this out!
-- To view, visit https://review.coreboot.org/c/flashrom/+/43895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 26 Jul 2020 11:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/43895 ) Change subject: ichspi.c: Take chromiums flash desc sec override msg ...................................................................... Abandoned incorrect cros/upstream resync direction. -- To view, visit https://review.coreboot.org/c/flashrom/+/43895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1043bed042f5507788ed2b417bd44d0fe3dc0aa6 Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: abandon
participants (2)
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)