Change in flashrom[master]: ich_descriptors.h: Upstream PCH100+ region comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43896 )


Change subject: ich_descriptors.h: Upstream PCH100+ region comment
......................................................................

ich_descriptors.h: Upstream PCH100+ region comment

Useful information we should extract out of the
chromium fork of flashrom and ingest into upstream.

Change-Id: I246c56aa86bb44f27c5934ab5883f555a8307784
Signed-off-by: Edward O'Callaghan <[e-mail]>
---
M ich_descriptors.h
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/43896/1

diff --git a/ich_descriptors.h b/ich_descriptors.h
index c6bf5d8..98535e1 100644
--- a/ich_descriptors.h
+++ b/ich_descriptors.h
@@ -234,6 +234,14 @@
 						:3;
 		};
 		/* From Skylake on */
+		/*
+		 * Flash Descriptor Master Access settings for PCH100+
+		 *
+		 * [31:20] Master Region Write Access (regions 11:0)
+		 * [19:8] Master Region Read Access (regions 11:0)
+		 * [7:4] Extended Region Write Access (regions 15:12)
+		 * [3:0] Extended Region Read access (regions 15:12)
+		 */
 		struct {
 			uint32_t ext_read	:4,
 				 ext_write	:4,

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I246c56aa86bb44f27c5934ab5883f555a8307784
Gerrit-Change-Number: 43896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43896 )

Change subject: ich_descriptors.h: Upstream PCH100+ region comment
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/43896/1/ich_descriptors.h 
File ich_descriptors.h:

https://review.coreboot.org/c/flashrom/+/43896/1/ich_descriptors.h@238 
PS1, Line 238: PCH100
I can't see that on SPT (Sunrise Point, 100-series PCH), though



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I246c56aa86bb44f27c5934ab5883f555a8307784
Gerrit-Change-Number: 43896
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Sun, 26 Jul 2020 09:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43896 )

Change subject: ich_descriptors.h: Upstream PCH100+ region comment
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/43896/1/ich_descriptors.h 
File ich_descriptors.h:

https://review.coreboot.org/c/flashrom/+/43896/1/ich_descriptors.h@238 
PS1, Line 238: PCH100
> I can't see that on SPT (Sunrise Point, 100-series PCH), though
> This is all I have from downstream.