Change in flashrom[master]: [stlinkv3_spi]Added missing line ends, and added a note about the fir...

[Miklós Márton (Code Review)]

Miklós Márton has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43900 )


Change subject: [stlinkv3_spi]Added missing line ends, and added a note about the first version of the updater which contains the necessary V3 bridge feature.
......................................................................

[stlinkv3_spi]Added missing line ends, and added a note about the
first version of the updater which contains the necessary V3 bridge
feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <[e-mail]>
---
M stlinkv3_spi.c
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/43900/1

diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c
index ae865be..c75f7db 100644
--- a/stlinkv3_spi.c
+++ b/stlinkv3_spi.c
@@ -253,21 +253,22 @@
 	enum fw_version_check_result fw_check_result;
 
 	if (stlinkv3_check_version(&fw_check_result)) {
-		msg_perr("Failed to query FW version");
+		msg_perr("Failed to query FW version\n");
 		return -1;
 	}
 
 	if (fw_check_result != FW_VERSION_OK) {
 		msg_pinfo("Your STLink V3 has too old version of the bridge interface\n"
-			  "Please update the firmware with the STSW-LINK007 which can be downloaded from here:\n"
-			  "https://www.st.com/en/development-tools/stsw-link007.html");
+			  "Please update the firmware with version 2.33.25 or newer of the STSW-LINK007\n"
+			  "which can be downloaded from here:\n"
+			  "https://www.st.com/en/development-tools/stsw-link007.html\n");
 		return -1;
 	}
 
 	if (stlinkv3_spi_calc_prescaler(reqested_freq_in_kHz,
 					&prescaler,
 					&SCK_freq_in_kHz)) {
-		msg_perr("Failed to calculate SPI clock prescaler");
+		msg_perr("Failed to calculate SPI clock prescaler\n");
 		return -1;
 	}
 	msg_pinfo("SCK frequency set to %d kHz\n", SCK_freq_in_kHz);

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-MessageType: newchange

Change in flashrom[master]: [stlinkv3_spi]Added missing line ends in command line output. Added a...

[Miklós Márton (Code Review)]

Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/flashrom/+/43900

to look at the new patch set (#2).

Change subject: [stlinkv3_spi]Added missing line ends in command line output. Added a note about the first version of the updater which contains the necessary V3 bridge feature.
......................................................................

[stlinkv3_spi]Added missing line ends in command line output.
Added a note about the first version of the updater
which contains the necessary V3 bridge feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <[e-mail]>
---
M stlinkv3_spi.c
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/43900/2
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 2
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

Change in flashrom[master]: [stlinkv3_spi]Added missing line ends in command line output. Added a...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: [stlinkv3_spi]Added missing line ends in command line output. Added a note about the first version of the updater which contains the necessary V3 bridge feature.
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/c/flashrom/+/43900/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/43900/2//COMMIT_MSG@7 
PS2, Line 7: [stlinkv3_spi]Added missing line ends in command line output.
           : Added a note about the first version of the updater
           : which contains the necessary V3 bridge feature.
stlinkv3_spi.c: Improve printed messages

Add missing line ends, and add a note about the first version of the updater which contains the necessary V3 bridge feature.


https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c 
File stlinkv3_spi.c:

https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c@261 
PS2, Line 261: has too
has *a* too


https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c@262 
PS2, Line 262: with
to



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 2
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 26 Jul 2020 09:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Miklós Márton (Code Review)]

Hello build bot (Jenkins), Angel Pons, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/flashrom/+/43900

to look at the new patch set (#3).

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................

stlinkv3_spi.c: Improve printed messages

Add missing line ends, and add a note about the first version of the updater which contains the necessary V3 bridge feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <[e-mail]>
---
M stlinkv3_spi.c
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/43900/3
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 3
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Miklós Márton (Code Review)]

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/c/flashrom/+/43900/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/43900/2//COMMIT_MSG@7 
PS2, Line 7: [stlinkv3_spi]Added missing line ends in command line output.
           : Added a note about the first version of the updater
           : which contains the necessary V3 bridge feature.
> stlinkv3_spi.c: Improve printed messages […]
> Done

https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c 
File stlinkv3_spi.c:

https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c@261 
PS2, Line 261: has too
> has *a* too
> Done

https://review.coreboot.org/c/flashrom/+/43900/2/stlinkv3_spi.c@262 
PS2, Line 262: with
> to
> Done

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/flashrom/+/43900/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/43900/3//COMMIT_MSG@9 
PS3, Line 9: updater which contains the necessary V3 bridge feature.
Put this on the next line



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 3
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 26 Jul 2020 09:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Miklós Márton (Code Review)]

Hello build bot (Jenkins), Angel Pons, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/flashrom/+/43900

to look at the new patch set (#4).

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................

stlinkv3_spi.c: Improve printed messages

Add missing line ends, and add a note about the first version of the
updater which contains the necessary V3 bridge feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <[e-mail]>
---
M stlinkv3_spi.c
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/43900/4
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 4
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Miklós Márton (Code Review)]

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/c/flashrom/+/43900/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/43900/3//COMMIT_MSG@9 
PS3, Line 9: updater which contains the necessary V3 bridge feature.
> Put this on the next line
> Done

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 4
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 26 Jul 2020 14:28:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in flashrom[master]: stlinkv3_spi.c: Improve printed messages

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/43900 )

Change subject: stlinkv3_spi.c: Improve printed messages
......................................................................

stlinkv3_spi.c: Improve printed messages

Add missing line ends, and add a note about the first version of the
updater which contains the necessary V3 bridge feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/43900
Reviewed-by: Angel Pons <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M stlinkv3_spi.c
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved



diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c
index ae865be..7e8336e 100644
--- a/stlinkv3_spi.c
+++ b/stlinkv3_spi.c
@@ -253,21 +253,22 @@
 	enum fw_version_check_result fw_check_result;
 
 	if (stlinkv3_check_version(&fw_check_result)) {
-		msg_perr("Failed to query FW version");
+		msg_perr("Failed to query FW version\n");
 		return -1;
 	}
 
 	if (fw_check_result != FW_VERSION_OK) {
-		msg_pinfo("Your STLink V3 has too old version of the bridge interface\n"
-			  "Please update the firmware with the STSW-LINK007 which can be downloaded from here:\n"
-			  "https://www.st.com/en/development-tools/stsw-link007.html");
+		msg_pinfo("Your STLink V3 has a too old version of the bridge interface\n"
+			  "Please update the firmware to version 2.33.25 or newer of the STSW-LINK007\n"
+			  "which can be downloaded from here:\n"
+			  "https://www.st.com/en/development-tools/stsw-link007.html\n");
 		return -1;
 	}
 
 	if (stlinkv3_spi_calc_prescaler(reqested_freq_in_kHz,
 					&prescaler,
 					&SCK_freq_in_kHz)) {
-		msg_perr("Failed to calculate SPI clock prescaler");
+		msg_perr("Failed to calculate SPI clock prescaler\n");
 		return -1;
 	}
 	msg_pinfo("SCK frequency set to %d kHz\n", SCK_freq_in_kHz);

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/43900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 5
Gerrit-Owner: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged