October 2019 - flashrom-gerrit

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Hello Edward O'Callaghan, Angel Pons, Jacob Garber, Paul Menzel, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30411 to look at the new patch set (#9). Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Makefile,meson.build: Enable/assume -Wextra Enable all -Wextra warnings but -Wunused-parameter. Nobody seems to miss warnings about unused parameters and we have a lot unavoidable occurrences in flashrom because of common interfaces. Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M meson.build 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/30411/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Limonciello <superm1(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: board_enable: Work around -Wtype-limits issue
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Hello Jacob Garber, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/35801 to review the following change. Change subject: board_enable: Work around -Wtype-limits issue ...................................................................... board_enable: Work around -Wtype-limits issue In case of an empty `board_matches` list (i.e. on non-x86), we checked if the `unsigned i` is smaller 0. Shuffling the computation avoids that problem. Change-Id: I636d73c920a7b7e7507eafe444bab8236d7acb67 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M board_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/35801/1 diff --git a/board_enable.c b/board_enable.c index 98d6fd0..a5980eb 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2493,7 +2493,7 @@ int ret = 0; unsigned int i; - for (i = 0; i < ARRAY_SIZE(board_matches) - 1; i++) { + for (i = 0; i + 1 < ARRAY_SIZE(board_matches); i++) { const struct board_match *b = &board_matches[i]; if (b->vendor_name == NULL || b->board_name == NULL) { msg_gerr("ERROR: Board enable #%d does not define a vendor and board name.\n" -- To view, visit https://review.coreboot.org/c/flashrom/+/35801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I636d73c920a7b7e7507eafe444bab8236d7acb67 Gerrit-Change-Number: 35801 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: Fix two sign-compare issues that sneaked in
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35800 ) Change subject: Fix two sign-compare issues that sneaked in ...................................................................... Fix two sign-compare issues that sneaked in Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M ich_descriptors.c M libflashrom.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/35800/1 diff --git a/ich_descriptors.c b/ich_descriptors.c index 6d7b020..120d3fe 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -421,7 +421,7 @@ for (i = 0; i < nm; i++) { size_t j; msg_pdbg2("%-4s", master_names[i]); - for (j = 0; j < min(num_regions, 12); j++) + for (j = 0; j < (size_t)min(num_regions, 12); j++) msg_pdbg2(" %c%c ", desc->master.mstr[i].read & (1 << j) ? 'r' : ' ', desc->master.mstr[i].write & (1 << j) ? 'w' : ' '); diff --git a/libflashrom.c b/libflashrom.c index dbc5129..1d8a9ae 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -139,7 +139,7 @@ */ struct flashrom_flashchip_info *flashrom_supported_flash_chips(void) { - int i = 0; + unsigned int i = 0; struct flashrom_flashchip_info *supported_flashchips = malloc(flashchips_size * sizeof(*supported_flashchips)); -- To view, visit https://review.coreboot.org/c/flashrom/+/35800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5 Gerrit-Change-Number: 35800 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

3 7

Change in flashrom[master]: meson: Correct license to GPL-2.0
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35584 ) Change subject: meson: Correct license to GPL-2.0 ...................................................................... meson: Correct license to GPL-2.0 Parts of flashrom are 2.0+ but some are not. As Meson's purpose is to link these together, it should advertise only GPL-2.0 for the whole. Change-Id: Iab99c74f5f9d54dac56085ecc7475b14be00a310 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/35584/1 diff --git a/meson.build b/meson.build index b475f64..4be68e2 100644 --- a/meson.build +++ b/meson.build @@ -1,6 +1,6 @@ project('flashromutils', 'c', version : run_command('util/getversion.sh', '-v').stdout().strip(), - license : 'GPL-2.0+', + license : 'GPL-2.0', meson_version : '>=0.47.0', default_options : ['warning_level=2', 'c_std=c99'], ) -- To view, visit https://review.coreboot.org/c/flashrom/+/35584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iab99c74f5f9d54dac56085ecc7475b14be00a310 Gerrit-Change-Number: 35584 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

4 5

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Miklós Márton (Code Review) 05 Oct '19

05 Oct '19

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 26: (4 comments) https://review.coreboot.org/c/flashrom/+/25683/25/ni845x_spi.c File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/25683/25/ni845x_spi.c@253 PS25, Line 253: if (io_voltage_100mV < usb8452_io_voltages_in_100mV[0]) { > Nit, if called with `use_smaller = false` we might not want to take this path? […] Ack https://review.coreboot.org/c/flashrom/+/25683/25/ni845x_spi.c@443 PS25, Line 443: if (device_pid == USB8451) { > Nit, taking this path will result in no warning printed, even if […] Ack https://review.coreboot.org/c/flashrom/+/25683/25/ni845x_spi.c@504 PS25, Line 504: return -1; > This path is a little troubling. What if the user has a voltage translator […] Ack https://review.coreboot.org/c/flashrom/+/25683/25/ni845x_spi.c@542 PS25, Line 542: } > Might look nicer with the whole `if` block in a separate fucntion. Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 26 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Sat, 05 Oct 2019 20:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Miklós Márton (Code Review) 05 Oct '19

05 Oct '19

Miklós Márton has uploaded a new patch set (#26) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 784 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/26 -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 26 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: Add spi95.c to fix the build
by David Hendricks (Code Review) 05 Oct '19

05 Oct '19

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35819 ) Change subject: meson: Add spi95.c to fix the build ...................................................................... meson: Add spi95.c to fix the build Reported in issue #105 on github. Change-Id: Ibe484b4ef60533135fa1e96eb203bb55985d1f8e Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M meson.build 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/35819/1 diff --git a/meson.build b/meson.build index d778d71..0696ce4 100644 --- a/meson.build +++ b/meson.build @@ -321,6 +321,7 @@ srcs += 'sfdp.c' srcs += 'spi25.c' srcs += 'spi25_statusreg.c' +srcs += 'spi95.c' srcs += 'spi.c' srcs += 'sst28sf040.c' srcs += 'sst49lfxxxc.c' -- To view, visit https://review.coreboot.org/c/flashrom/+/35819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibe484b4ef60533135fa1e96eb203bb55985d1f8e Gerrit-Change-Number: 35819 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

2 2

Change in flashrom[master]: cli_classic: Add convenient '--flash-name' cli opt
by Edward O'Callaghan (Code Review) 04 Oct '19

04 Oct '19

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35591 ) Change subject: cli_classic: Add convenient '--flash-name' cli opt ...................................................................... cli_classic: Add convenient '--flash-name' cli opt We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption. Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M cli_classic.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/1 diff --git a/cli_classic.c b/cli_classic.c index b4112fd..4604043 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -101,6 +101,7 @@ #if CONFIG_PRINT_WIKI == 1 int list_supported_wiki = 0; #endif + int flash_name = 0; int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; int dont_verify_it = 0, dont_verify_all = 0, list_supported = 0, operation_specified = 0; struct flashrom_layout *layout = NULL; @@ -110,6 +111,7 @@ OPTION_FMAP, OPTION_FMAP_FILE, OPTION_FLASH_CONTENTS, + OPTION_FLASH_NAME, }; int ret = 0; @@ -130,6 +132,7 @@ {"fmap-file", 1, NULL, OPTION_FMAP_FILE}, {"image", 1, NULL, 'i'}, {"flash-contents", 1, NULL, OPTION_FLASH_CONTENTS}, + {"flash-name", 0, NULL, OPTION_FLASH_NAME}, {"list-supported", 0, NULL, 'L'}, {"list-supported-wiki", 0, NULL, 'z'}, {"programmer", 1, NULL, 'p'}, @@ -296,6 +299,9 @@ case OPTION_FLASH_CONTENTS: referencefile = strdup(optarg); break; + case OPTION_FLASH_NAME: + flash_name = 1; + break; case 'L': if (++operation_specified > 1) { fprintf(stderr, "More than one operation " @@ -602,11 +608,23 @@ goto out_shutdown; } - if (!(read_it | write_it | verify_it | erase_it)) { + if (!(read_it | write_it | verify_it | erase_it | flash_name)) { msg_ginfo("No operations were specified.\n"); goto out_shutdown; } + if (flash_name) { + if (fill_flash->chip->vendor && fill_flash->chip->name) { + msg_ginfo("vendor\"%s\" name=\"%s\"\n", + fill_flash->chip->vendor, + fill_flash->chip->name); + goto out_shutdown; + } else { + ret = -1; + goto out_shutdown; + } + } + if (layoutfile) { layout = get_global_layout(); } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || -- To view, visit https://review.coreboot.org/c/flashrom/+/35591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Gerrit-Change-Number: 35591 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

8 25

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Jacob Garber (Code Review) 04 Oct '19

04 Oct '19

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30411 ) Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Patch Set 8: Code-Review+2 > Patch Set 8: > > manibuilder says go! (at least there are no regressions, > only x86 and mipsel build cleanly atm) Let's do it! -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Limonciello <superm1(a)gmail.com> Gerrit-Comment-Date: Fri, 04 Oct 2019 19:32:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson.build: Sanitize the version string
by Nico Huber (Code Review) 04 Oct '19

04 Oct '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/flashrom/+/35566/2/meson.build File meson.build: https://review.coreboot.org/c/flashrom/+/35566/2/meson.build@360 PS2, Line 360: #strip dirty version info > pkgconfig wants numbers and doesn't really get happy with version strings with letters. yes, I get that. but is there really a use case for dirty packages? I mean, if a dirty tree hurts, don't build from a dirty tree, or what do I miss? -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Oct 2019 19:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mario Limonciello <superm1(a)gmail.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2019