October 2019 - flashrom-gerrit

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Miklós Márton (Code Review) Oct. 22, 2019

Oct. 22, 2019

Miklós Márton has uploaded a new patch set (#27) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 790 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/27 -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 27 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: cli_classic.c: Tidy up some repeated handling patterns into funcs
by Edward O'Callaghan (Code Review) Oct. 17, 2019

Oct. 17, 2019

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35611 ) Change subject: cli_classic.c: Tidy up some repeated handling patterns into funcs ...................................................................... cli_classic.c: Tidy up some repeated handling patterns into funcs Introduce cli_classic_single_operation() to consolidate the repeating pattern of multiple CLI operations at once. Also modify cli_classic_abort_usage() to take an optional error abort string and print it to stderr, this allows for trimming a few more lines off the cli implementation. Change-Id: I54598efdaee2b95cb278b0f2aac05f48bbd95bef Signed-off-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M cli_classic.c 1 file changed, 47 insertions(+), 98 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/35611/1 diff --git a/cli_classic.c b/cli_classic.c index 6f362f1..7fd0495 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -71,12 +71,21 @@ "If no operation is specified, flashrom will only probe for flash chips.\n"); } -static void cli_classic_abort_usage(void) +static void cli_classic_abort_usage(const char *msg) { printf("Please run \"flashrom --help\" for usage info.\n"); + if (msg) + fprintf(stderr, "%s", msg); exit(1); } +static void cli_classic_single_operation(int operation_specified) +{ + if (++operation_specified > 1) { + cli_classic_abort_usage("More than one operation specified. Aborting.\n"); + } +} + static int check_filename(char *filename, char *type) { if (!filename || (filename[0] == '\0')) { @@ -171,41 +180,27 @@ long_options, &option_index)) != EOF) { switch (opt) { case 'r': - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); filename = strdup(optarg); read_it = 1; break; case 'w': - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); filename = strdup(optarg); write_it = 1; break; case 'v': //FIXME: gracefully handle superfluous -v - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); if (dont_verify_it) { - fprintf(stderr, "--verify and --noverify are mutually exclusive. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("--verify and --noverify are mutually exclusive. Aborting.\n"); } filename = strdup(optarg); verify_it = 1; break; case 'n': if (verify_it) { - fprintf(stderr, "--verify and --noverify are mutually exclusive. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("--verify and --noverify are mutually exclusive. Aborting.\n"); } dont_verify_it = 1; break; @@ -221,11 +216,7 @@ verbose_logfile = verbose_screen; break; case 'E': - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); erase_it = 1; break; case 'f': @@ -233,61 +224,49 @@ break; case 'l': if (layoutfile) { - fprintf(stderr, "Error: --layout specified " - "more than once. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --layout specified more than once. Aborting.\n"); } if (ifd) { - fprintf(stderr, "Error: --layout and --ifd both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --layout and --ifd both specified. Aborting.\n"); } if (fmap) { - fprintf(stderr, "Error: --layout and --fmap-file both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --layout and --fmap-file both specified. Aborting.\n"); } layoutfile = strdup(optarg); break; case OPTION_IFD: if (layoutfile) { - fprintf(stderr, "Error: --layout and --ifd both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --layout and --ifd both specified. Aborting.\n"); } if (fmap) { - fprintf(stderr, "Error: --fmap-file and --ifd both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --fmap-file and --ifd both specified. Aborting.\n"); } ifd = 1; break; case OPTION_FMAP_FILE: if (fmap) { - fprintf(stderr, "Error: --fmap or --fmap-file specified " + cli_classic_abort_usage("Error: --fmap or --fmap-file specified " "more than once. Aborting.\n"); - cli_classic_abort_usage(); } if (ifd) { - fprintf(stderr, "Error: --fmap-file and --ifd both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --fmap-file and --ifd both specified. Aborting.\n"); } if (layoutfile) { - fprintf(stderr, "Error: --fmap-file and --layout both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --fmap-file and --layout both specified. Aborting.\n"); } fmapfile = strdup(optarg); fmap = 1; break; case OPTION_FMAP: if (fmap) { - fprintf(stderr, "Error: --fmap or --fmap-file specified " + cli_classic_abort_usage("Error: --fmap or --fmap-file specified " "more than once. Aborting.\n"); - cli_classic_abort_usage(); } if (ifd) { - fprintf(stderr, "Error: --fmap and --ifd both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --fmap and --ifd both specified. Aborting.\n"); } if (layoutfile) { - fprintf(stderr, "Error: --layout and --fmap both specified. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: --layout and --fmap both specified. Aborting.\n"); } fmap = 1; break; @@ -295,58 +274,40 @@ tempstr = strdup(optarg); if (register_include_arg(&include_args, tempstr)) { free(tempstr); - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } break; case OPTION_FLASH_CONTENTS: referencefile = strdup(optarg); break; case OPTION_FLASH_NAME: - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); flash_name = 1; break; case OPTION_GET_SIZE: - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); get_size = 1; break; case 'L': - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); list_supported = 1; break; case 'z': #if CONFIG_PRINT_WIKI == 1 - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); list_supported_wiki = 1; #else - fprintf(stderr, "Error: Wiki output was not compiled " + cli_classic_abort_usage("Error: Wiki output was not compiled " "in. Aborting.\n"); - cli_classic_abort_usage(); #endif break; case 'p': if (prog != PROGRAMMER_INVALID) { - fprintf(stderr, "Error: --programmer specified " + cli_classic_abort_usage("Error: --programmer specified " "more than once. You can separate " "multiple\nparameters for a programmer " "with \",\". Please see the man page " "for details.\n"); - cli_classic_abort_usage(); } for (prog = 0; prog < PROGRAMMER_INVALID; prog++) { name = programmer_table[prog].name; @@ -378,31 +339,22 @@ optarg); list_programmers_linebreak(0, 80, 0); msg_ginfo(".\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } break; case 'R': /* print_version() is always called during startup. */ - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); exit(0); break; case 'h': - if (++operation_specified > 1) { - fprintf(stderr, "More than one operation " - "specified. Aborting.\n"); - cli_classic_abort_usage(); - } + cli_classic_single_operation(operation_specified); cli_classic_usage(argv[0]); exit(0); break; case 'o': #ifdef STANDALONE - fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Log file not supported in standalone mode. Aborting.\n"); #else /* STANDALONE */ if (logfile) { fprintf(stderr, "Warning: -o/--output specified multiple times.\n"); @@ -411,40 +363,37 @@ logfile = strdup(optarg); if (logfile[0] == '\0') { - fprintf(stderr, "No log filename specified.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("No log filename specified.\n"); } #endif /* STANDALONE */ break; default: - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); break; } } if (optind < argc) { - fprintf(stderr, "Error: Extra parameter found.\n"); - cli_classic_abort_usage(); + cli_classic_abort_usage("Error: Extra parameter found.\n"); } - if ((read_it | write_it | verify_it) && check_filename(filename, "image")) { - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } if (layoutfile && check_filename(layoutfile, "layout")) { - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } if (fmapfile && check_filename(fmapfile, "fmap")) { - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } if (referencefile && check_filename(referencefile, "reference")) { - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); } #ifndef STANDALONE if (logfile && check_filename(logfile, "log")) - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); if (logfile && open_logfile(logfile)) - cli_classic_abort_usage(); + cli_classic_abort_usage(NULL); #endif /* !STANDALONE */ #if CONFIG_PRINT_WIKI == 1 -- To view, visit https://review.coreboot.org/c/flashrom/+/35611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I54598efdaee2b95cb278b0f2aac05f48bbd95bef Gerrit-Change-Number: 35611 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

7 20

Change in flashrom[master]: cli_classic: Fix first line of --help to match manpage
by Edward O'Callaghan (Code Review) Oct. 17, 2019

Oct. 17, 2019

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35793 ) Change subject: cli_classic: Fix first line of --help to match manpage ...................................................................... cli_classic: Fix first line of --help to match manpage Make the first line of --help in usage to align with the format of the man page, including fixing any missing options. Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf Signed-off-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M cli_classic.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/35793/1 diff --git a/cli_classic.c b/cli_classic.c index 6c3c9da..1c289a7 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -35,9 +35,12 @@ #if CONFIG_PRINT_WIKI == 1 "-z|" #endif - "-p <programmername>[:<parameters>] [-c <chipname>]\n" - "[-E|(-r|-w|-v) <file>] [(-l <layoutfile>|--ifd) [-i <imagename>]...] [-n] [-N] [-f]]\n" - "[-V[V[V]]] [-o <logfile>]\n\n", name); + "\n\t-p <programmername>[:<parameters>] [-c <chipname>]\n" + "\t\t(--flash-name|--flash-size|\n" + "\t\t[-E|(-r|-w|-v) <file>]\n" + "\t\t[(-l <layoutfile>|--ifd| --fmap|--fmap-file <file>) [-i <imagename>]...]\n" + "\t\t[-n] [-N] [-f])]\n" + "\t[-V[V[V]]] [-o <logfile>]\n\n", name); printf(" -h | --help print this help text\n" " -R | --version print version (release)\n" -- To view, visit https://review.coreboot.org/c/flashrom/+/35793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf Gerrit-Change-Number: 35793 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

3 5

Change in flashrom[master]: Correct the pkgconfig generated file naming
by Mario Limonciello (Code Review) Oct. 16, 2019

Oct. 16, 2019

Mario Limonciello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/36069 ) Change subject: Correct the pkgconfig generated file naming ...................................................................... Correct the pkgconfig generated file naming The typical convention is to not use the `lib` prefix (ie `libfoo`) but instead to just use foo. Change-Id: I5ab46418e2a1708d5c11970f1e56250f2adb7d70 Signed-off-by: Mario Limonciello <mario.limonciello(a)dell.com> --- M meson.build 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/36069/1 diff --git a/meson.build b/meson.build index f63e7bf..b63875e 100644 --- a/meson.build +++ b/meson.build @@ -362,9 +362,9 @@ pkgg.generate( libraries : flashrom, version : version, - name : 'libflashrom', - filebase : 'libflashrom', - description : 'libflashrom', + name : 'flashrom', + filebase : 'flashrom', + description : 'library to interact with flashrom', ) flashrom_dep = declare_dependency( -- To view, visit https://review.coreboot.org/c/flashrom/+/36069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ab46418e2a1708d5c11970f1e56250f2adb7d70 Gerrit-Change-Number: 36069 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-MessageType: newchange

4 3

Change in flashrom[master]: meson.build: Sanitize the version string
by Nico Huber (Code Review) Oct. 16, 2019

Oct. 16, 2019

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... meson.build: Sanitize the version string Match strictly the library version, and remove all starting letters. Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Signed-off-by: Mario Limonciello <mario.limonciello(a)dell.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/35566 Tested-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Richard Hughes <richard(a)hughsie.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M meson.build 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Nico Huber: Verified; Looks good to me, approved Richard Hughes: Looks good to me, but someone else must approve diff --git a/meson.build b/meson.build index ca52ccf..bda6b08 100644 --- a/meson.build +++ b/meson.build @@ -349,10 +349,19 @@ link_depends : mapfile, ) +version = meson.project_version() +#strip leading characters +if version.startswith('v') + version = version.split('v')[1] +endif +if version.startswith('p') + version = version.split('p')[1] +endif + pkgg = import('pkgconfig') pkgg.generate( libraries : flashrom, - version : meson.project_version(), + version : version, name : 'libflashrom', filebase : 'libflashrom', description : 'libflashrom', -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 7 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: meson.build: Sanitize the version string
by Nico Huber (Code Review) Oct. 16, 2019

Oct. 16, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... Patch Set 6: Verified+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 6 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 21:46:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson.build: Sanitize the version string
by Mario Limonciello (Code Review) Oct. 16, 2019

Oct. 16, 2019

Hello Jacob Garber, Richard Hughes, David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/35566 to look at the new patch set (#6). Change subject: meson.build: Sanitize the version string ...................................................................... meson.build: Sanitize the version string Match strictly the library version, and remove all starting letters. Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Signed-off-by: Mario Limonciello <mario.limonciello(a)dell.com> --- M meson.build 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/35566/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 6 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: linux_spi: add missing include
by David Hendricks (Code Review) Oct. 16, 2019

Oct. 16, 2019

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35830 ) Change subject: linux_spi: add missing include ...................................................................... linux_spi: add missing include Some defines (e.g. _IOC_SIZEBITS) are defined in linux/ioctl.h, so it must be included before it is used, by SPI_IOC_MESSAGE from linux/spi/spidev.h Fixes build errors with the musl C library, as seen in these Buildroot autobuilder failures: http://autobuild.buildroot.org/results/2a3/2a3744007c630c267575a638ebcd83a4… http://autobuild.buildroot.org/results/3de/3de936d9be79e151e66af15193084d82… Signed-off-by: "Yann E. MORIN" <yann.morin.1998(a)free.fr> [Retrieved from: https: //git.buildroot.net/buildroot/tree/package/flashrom/0001-spi.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Change-Id: Ieab60f59bc63aca0dc4867f31699dab4167da05b --- M linux_spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/35830/1 diff --git a/linux_spi.c b/linux_spi.c index de09e60..30b6288 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -26,6 +26,7 @@ #include <unistd.h> #include <sys/ioctl.h> #include <linux/types.h> +#include <linux/ioctl.h> #include <linux/spi/spidev.h> #include <linux/ioctl.h> #include "flash.h" -- To view, visit https://review.coreboot.org/c/flashrom/+/35830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieab60f59bc63aca0dc4867f31699dab4167da05b Gerrit-Change-Number: 35830 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

2 7

Change in flashrom[master]: meson.build: Sanitize the version string
by Nico Huber (Code Review) Oct. 16, 2019

Oct. 16, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/flashrom/+/35566/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/35566/5//COMMIT_MSG@10 PS5, Line 10: after dashes. Just realized, this needs an update. -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 19:22:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson.build: Sanitize the version string
by Nico Huber (Code Review) Oct. 16, 2019

Oct. 16, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... Patch Set 5: Code-Review+2 > I guess it's slightly odd just to not post-release bump the version, but looks good to me. What would be the benefit compared to automatically bumping it when tagging a release? -- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 19:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0